[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284, FLINK-12637][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-06-25 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r297494125 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284, FLINK-12637][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-06-25 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r297493392 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284, FLINK-12637][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-06-25 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r297491959 ## File path:

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297465153 ## File path:

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297491370 ## File path:

[GitHub] [flink] Aitozi commented on a change in pull request #8455: [FLINK-12284, FLINK-12637][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-06-25 Thread GitBox
Aitozi commented on a change in pull request #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r297491110 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284, FLINK-12637][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-06-25 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r297491040 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284, FLINK-12637][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-06-25 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r297491040 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284, FLINK-12637][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-06-25 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r297490492 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8455: [FLINK-12284, FLINK-12637][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-06-25 Thread GitBox
zhijiangW commented on a change in pull request #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#discussion_r297490427 ## File path:

[jira] [Comment Edited] (FLINK-12889) Job keeps in FAILING state

2019-06-25 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872933#comment-16872933 ] zhijiang edited comment on FLINK-12889 at 6/26/19 5:33 AM: --- My previous

[jira] [Comment Edited] (FLINK-12889) Job keeps in FAILING state

2019-06-25 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872933#comment-16872933 ] zhijiang edited comment on FLINK-12889 at 6/26/19 5:32 AM: --- My previous

[jira] [Updated] (FLINK-12889) Job keeps in FAILING state

2019-06-25 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-12889: - Priority: Minor (was: Blocker) > Job keeps in FAILING state > -- > >

[GitHub] [flink] dianfu commented on issue #8847: [FLINK-12609][python] Align the Python data types with Java

2019-06-25 Thread GitBox
dianfu commented on issue #8847: [FLINK-12609][python] Align the Python data types with Java URL: https://github.com/apache/flink/pull/8847#issuecomment-505724940 Hi @sunjincheng121, makes sense to me. I have created #8892 and #8893 for the hotfix changes.

[jira] [Updated] (FLINK-12889) Job keeps in FAILING state

2019-06-25 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-12889: - Affects Version/s: (was: 1.7.2) > Job keeps in FAILING state > -- > >

[jira] [Commented] (FLINK-12889) Job keeps in FAILING state

2019-06-25 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872933#comment-16872933 ] zhijiang commented on FLINK-12889: -- My previous analysis in ML was as follows:   Actually all the five

[jira] [Updated] (FLINK-12889) Job keeps in FAILING state

2019-06-25 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhijiang updated FLINK-12889: - Component/s: (was: API / DataStream) Runtime / Coordination > Job keeps in FAILING

[GitHub] [flink] lirui-apache commented on issue #8875: [FLINK-12970][hive] Support writing Hive complex types

2019-06-25 Thread GitBox
lirui-apache commented on issue #8875: [FLINK-12970][hive] Support writing Hive complex types URL: https://github.com/apache/flink/pull/8875#issuecomment-505721128 Thanks @bowenli86 for the review. Please take another look.

[GitHub] [flink] xuefuz commented on a change in pull request #8882: [FLINK-12965][table][hive] unify catalog view implementations

2019-06-25 Thread GitBox
xuefuz commented on a change in pull request #8882: [FLINK-12965][table][hive] unify catalog view implementations URL: https://github.com/apache/flink/pull/8882#discussion_r297481016 ## File path:

[GitHub] [flink] flinkbot commented on issue #8893: [hotfix][python] Align the signature of type utility methods with Java

2019-06-25 Thread GitBox
flinkbot commented on issue #8893: [hotfix][python] Align the signature of type utility methods with Java URL: https://github.com/apache/flink/pull/8893#issuecomment-505713502 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] dianfu opened a new pull request #8893: [hotfix][python] Align the signature of type utility methods with Java

2019-06-25 Thread GitBox
dianfu opened a new pull request #8893: [hotfix][python] Align the signature of type utility methods with Java URL: https://github.com/apache/flink/pull/8893 ## What is the purpose of the change *Currently, the python method `DataTypes.VARCHAR(length)` assumes default value `1` for

[GitHub] [flink] flinkbot commented on issue #8892: [FLINK-FLINK-12990][python] Date type doesn't consider the local TimeZone

2019-06-25 Thread GitBox
flinkbot commented on issue #8892: [FLINK-FLINK-12990][python] Date type doesn't consider the local TimeZone URL: https://github.com/apache/flink/pull/8892#issuecomment-505711190 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[jira] [Updated] (FLINK-12990) Date type doesn't consider the local TimeZone

2019-06-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12990: --- Labels: pull-request-available (was: ) > Date type doesn't consider the local TimeZone >

[GitHub] [flink] dianfu opened a new pull request #8892: [FLINK-FLINK-12990][python] Date type doesn't consider the local TimeZone

2019-06-25 Thread GitBox
dianfu opened a new pull request #8892: [FLINK-FLINK-12990][python] Date type doesn't consider the local TimeZone URL: https://github.com/apache/flink/pull/8892 ## What is the purpose of the change *Currently, the python DateType is converted by an `int` which indicates the days

[GitHub] [flink] flinkbot commented on issue #8891: [hotfix][util] Use OneTimeLeaderListenerFuture in LeaderRetrievalUtils

2019-06-25 Thread GitBox
flinkbot commented on issue #8891: [hotfix][util] Use OneTimeLeaderListenerFuture in LeaderRetrievalUtils URL: https://github.com/apache/flink/pull/8891#issuecomment-505709075 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] TisonKun opened a new pull request #8891: [hotfix][util] Use OneTimeLeaderListenerFuture in LeaderRetrievalUtils

2019-06-25 Thread GitBox
TisonKun opened a new pull request #8891: [hotfix][util] Use OneTimeLeaderListenerFuture in LeaderRetrievalUtils URL: https://github.com/apache/flink/pull/8891 ## What is the purpose of the change Refactor LeaderRetrievalUtils by removing redundant codes. ## Brief change log

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297475345 ## File path:

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297476171 ## File path:

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297475345 ## File path:

[jira] [Comment Edited] (FLINK-12976) Bump Kafka client version to 2.3.0 for universal Kafka connector

2019-06-25 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872883#comment-16872883 ] vinoyang edited comment on FLINK-12976 at 6/26/19 3:53 AM: --- I can make sure

[GitHub] [flink] xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool

2019-06-25 Thread GitBox
xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool URL: https://github.com/apache/flink/pull/8841#discussion_r297465087 ## File path:

[GitHub] [flink] xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool

2019-06-25 Thread GitBox
xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool URL: https://github.com/apache/flink/pull/8841#discussion_r297465713 ## File path:

[jira] [Created] (FLINK-12990) Date type doesn't consider the local TimeZone

2019-06-25 Thread Dian Fu (JIRA)
Dian Fu created FLINK-12990: --- Summary: Date type doesn't consider the local TimeZone Key: FLINK-12990 URL: https://issues.apache.org/jira/browse/FLINK-12990 Project: Flink Issue Type: Bug

[jira] [Resolved] (FLINK-12957) Fix thrift and protobuf dependency examples in documentation

2019-06-25 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-12957. - Resolution: Fixed Fix Version/s: 1.9.0 Merged for 1.9.0:

[GitHub] [flink] xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool

2019-06-25 Thread GitBox
xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool URL: https://github.com/apache/flink/pull/8841#discussion_r297472482 ## File path:

[GitHub] [flink] xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool

2019-06-25 Thread GitBox
xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool URL: https://github.com/apache/flink/pull/8841#discussion_r297471061 ## File path:

[GitHub] [flink] xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool

2019-06-25 Thread GitBox
xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool URL: https://github.com/apache/flink/pull/8841#discussion_r297470517 ## File path:

[jira] [Resolved] (FLINK-12732) Add savepoint reader for consuming partitioned operator state

2019-06-25 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-12732. - Resolution: Fixed Fix Version/s: 1.9.0 Thanks for the contribution Seth!

[jira] [Resolved] (FLINK-12729) Add savepoint reader for consuming non-partitioned operator state

2019-06-25 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-12729. - Resolution: Fixed Fix Version/s: 1.9.0 Merged for 1.9.0:

[GitHub] [flink] asfgit closed pull request #8709: [hotfix][docs]Fix the typos in process_function.md and process_function.zh.md.

2019-06-25 Thread GitBox
asfgit closed pull request #8709: [hotfix][docs]Fix the typos in process_function.md and process_function.zh.md. URL: https://github.com/apache/flink/pull/8709 This is an automated message from the Apache Git Service. To

[GitHub] [flink] asfgit closed pull request #8849: [hotfix][connectors] fix shadowed NPE in elasticsearch sink connector

2019-06-25 Thread GitBox
asfgit closed pull request #8849: [hotfix][connectors] fix shadowed NPE in elasticsearch sink connector URL: https://github.com/apache/flink/pull/8849 This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] asfgit closed pull request #8797: [Docks] Checkpoints: fix typo

2019-06-25 Thread GitBox
asfgit closed pull request #8797: [Docks] Checkpoints: fix typo URL: https://github.com/apache/flink/pull/8797 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] asfgit closed pull request #8640: [FLINK-12741][docs] Update Kafka producer fault tolerance guarantees

2019-06-25 Thread GitBox
asfgit closed pull request #8640: [FLINK-12741][docs] Update Kafka producer fault tolerance guarantees URL: https://github.com/apache/flink/pull/8640 This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] asfgit closed pull request #8806: [FLINK-12870][doc] Add missing warnings to schema evolution documentation

2019-06-25 Thread GitBox
asfgit closed pull request #8806: [FLINK-12870][doc] Add missing warnings to schema evolution documentation URL: https://github.com/apache/flink/pull/8806 This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] asfgit closed pull request #8848: [FLINK-12957][docs] fix thrift and protobuf dependency examples

2019-06-25 Thread GitBox
asfgit closed pull request #8848: [FLINK-12957][docs] fix thrift and protobuf dependency examples URL: https://github.com/apache/flink/pull/8848 This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (FLINK-12870) Improve documentation of keys schema evolution

2019-06-25 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-12870. - Resolution: Fixed Fix Version/s: 1.9.0 Merged for 1.9.0:

[GitHub] [flink] asfgit closed pull request #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state

2019-06-25 Thread GitBox
asfgit closed pull request #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state URL: https://github.com/apache/flink/pull/8618 This is an automated message from the Apache

[GitHub] [flink] asfgit closed pull request #8174: [FLINK-12190] Fix IllegalArgumentException thrown by FlinkKinesisConsumerMigrationTest#writeSnapshot

2019-06-25 Thread GitBox
asfgit closed pull request #8174: [FLINK-12190] Fix IllegalArgumentException thrown by FlinkKinesisConsumerMigrationTest#writeSnapshot URL: https://github.com/apache/flink/pull/8174 This is an automated message from the

[GitHub] [flink] xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool

2019-06-25 Thread GitBox
xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool URL: https://github.com/apache/flink/pull/8841#discussion_r297467266 ## File path:

[GitHub] [flink] xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool

2019-06-25 Thread GitBox
xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool URL: https://github.com/apache/flink/pull/8841#discussion_r297472941 ## File path:

[jira] [Resolved] (FLINK-12190) Fix IllegalArgumentException thrown by FlinkKinesisConsumerMigrationTest#writeSnapshot

2019-06-25 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-12190. - Resolution: Fixed Fix Version/s: 1.9.0 Merged for 1.9.0:

[GitHub] [flink] asfgit closed pull request #8615: [FLINK-12729][state-processor-api] Add state reader for consuming non-partitioned operator state

2019-06-25 Thread GitBox
asfgit closed pull request #8615: [FLINK-12729][state-processor-api] Add state reader for consuming non-partitioned operator state URL: https://github.com/apache/flink/pull/8615 This is an automated message from the Apache

[jira] [Resolved] (FLINK-12741) Update docs about Kafka producer fault tolerance guarantees

2019-06-25 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-12741. - Resolution: Fixed Fix Version/s: 1.9.0 Merged for 1.9.0:

[jira] [Updated] (FLINK-12729) Add savepoint reader for consuming non-partitioned operator state

2019-06-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12729: --- Labels: pull-request-available (was: ) > Add savepoint reader for consuming

[jira] [Comment Edited] (FLINK-12976) Bump Kafka client version to 2.3.0 for universal Kafka connector

2019-06-25 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872883#comment-16872883 ] vinoyang edited comment on FLINK-12976 at 6/26/19 3:32 AM: --- I can make sure

[GitHub] [flink] tzulitai commented on issue #8174: [FLINK-12190] Fix IllegalArgumentException thrown by FlinkKinesisConsumerMigrationTest#writeSnapshot

2019-06-25 Thread GitBox
tzulitai commented on issue #8174: [FLINK-12190] Fix IllegalArgumentException thrown by FlinkKinesisConsumerMigrationTest#writeSnapshot URL: https://github.com/apache/flink/pull/8174#issuecomment-505703526 Merging ... This

[jira] [Commented] (FLINK-12976) Bump Kafka client version to 2.3.0 for universal Kafka connector

2019-06-25 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872883#comment-16872883 ] vinoyang commented on FLINK-12976: -- I can make sure that there are compatibility issues when bumping

[GitHub] [flink] zjuwangg commented on issue #8890: Xuefu1

2019-06-25 Thread GitBox
zjuwangg commented on issue #8890: Xuefu1 URL: https://github.com/apache/flink/pull/8890#issuecomment-505702146 better to rename the pr title This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297466824 ## File path:

[GitHub] [flink] tzulitai commented on issue #8640: [FLINK-12741][docs] Update Kafka producer fault tolerance guarantees

2019-06-25 Thread GitBox
tzulitai commented on issue #8640: [FLINK-12741][docs] Update Kafka producer fault tolerance guarantees URL: https://github.com/apache/flink/pull/8640#issuecomment-505701524 Thanks for the fix and reviews. Merging .. This

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297470182 ## File path:

[GitHub] [flink] tzulitai commented on issue #8709: [hotfix][docs]Fix the typos in process_function.md and process_function.zh.md.

2019-06-25 Thread GitBox
tzulitai commented on issue #8709: [hotfix][docs]Fix the typos in process_function.md and process_function.zh.md. URL: https://github.com/apache/flink/pull/8709#issuecomment-505701130 Merging ... This is an automated message

[GitHub] [flink] tzulitai commented on issue #8797: [Docks] Checkpoints: fix typo

2019-06-25 Thread GitBox
tzulitai commented on issue #8797: [Docks] Checkpoints: fix typo URL: https://github.com/apache/flink/pull/8797#issuecomment-505700499 Thanks for the fix and reviews, merging .. This is an automated message from the Apache

[GitHub] [flink] tzulitai commented on issue #8806: [FLINK-12870][doc] Add missing warnings to schema evolution documentation

2019-06-25 Thread GitBox
tzulitai commented on issue #8806: [FLINK-12870][doc] Add missing warnings to schema evolution documentation URL: https://github.com/apache/flink/pull/8806#issuecomment-505700140 I think the extra warnings is already an improvement to the current state of this page. +1, will merge this

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297465424 ## File path:

[GitHub] [flink] sunjincheng121 commented on issue #8847: [FLINK-12609][python] Align the Python data types with Java

2019-06-25 Thread GitBox
sunjincheng121 commented on issue #8847: [FLINK-12609][python] Align the Python data types with Java URL: https://github.com/apache/flink/pull/8847#issuecomment-505700051 Thanks for the PR @dianfu ! I appreciate if you can open the independent PR for the hotfix change,What do you

[jira] [Issue Comment Deleted] (FLINK-12976) Bump Kafka client version to 2.3.0 for universal Kafka connector

2019-06-25 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-12976: - Comment: was deleted (was: It seems the public maven repository has not updated for the newest

[GitHub] [flink] tzulitai commented on issue #8848: [FLINK-12957][docs] fix thrift and protobuf dependency examples

2019-06-25 Thread GitBox
tzulitai commented on issue #8848: [FLINK-12957][docs] fix thrift and protobuf dependency examples URL: https://github.com/apache/flink/pull/8848#issuecomment-505699571 Thanks for the contribution @NicoK! The changes look good, will merge this ..

[GitHub] [flink] xuefuz edited a comment on issue #8890: Xuefu1

2019-06-25 Thread GitBox
xuefuz edited a comment on issue #8890: Xuefu1 URL: https://github.com/apache/flink/pull/8890#issuecomment-505680111 Please note that this PR included the changes in PR #8883. cc: @bowenli86 @lirui-apache This is an

[GitHub] [flink] flinkbot edited a comment on issue #8849: [hotfix][connectors] fix shadowed NPE in elasticsearch sink connector

2019-06-25 Thread GitBox
flinkbot edited a comment on issue #8849: [hotfix][connectors] fix shadowed NPE in elasticsearch sink connector URL: https://github.com/apache/flink/pull/8849#issuecomment-504907532 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] tzulitai commented on issue #8849: [hotfix][connectors] fix shadowed NPE in elasticsearch sink connector

2019-06-25 Thread GitBox
tzulitai commented on issue #8849: [hotfix][connectors] fix shadowed NPE in elasticsearch sink connector URL: https://github.com/apache/flink/pull/8849#issuecomment-505698528 @flinkbot approve all This is an automated

[GitHub] [flink] tzulitai commented on issue #8849: [hotfix][connectors] fix shadowed NPE in elasticsearch sink connector

2019-06-25 Thread GitBox
tzulitai commented on issue #8849: [hotfix][connectors] fix shadowed NPE in elasticsearch sink connector URL: https://github.com/apache/flink/pull/8849#issuecomment-505698475 Thanks for this fix, merging .. This is an

[GitHub] [flink] flinkbot edited a comment on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state

2019-06-25 Thread GitBox
flinkbot edited a comment on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state URL: https://github.com/apache/flink/pull/8618#issuecomment-498777998 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] tzulitai commented on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state

2019-06-25 Thread GitBox
tzulitai commented on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state URL: https://github.com/apache/flink/pull/8618#issuecomment-505697948 Merging ... This is

[GitHub] [flink] tzulitai commented on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state

2019-06-25 Thread GitBox
tzulitai commented on issue #8618: [FLINK-12732][state-processor-api] Add savepoint reader for consuming partitioned operator state URL: https://github.com/apache/flink/pull/8618#issuecomment-505697913 @flinkbot approve architecture @flinkbot approve quality

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297466824 ## File path:

[GitHub] [flink] lirui-apache commented on issue #8859: [FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner

2019-06-25 Thread GitBox
lirui-apache commented on issue #8859: [FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner URL: https://github.com/apache/flink/pull/8859#issuecomment-505697061 For Hive to access (non-generic) views created by Flink, we need to 1) remove the catalog part from the

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297466312 ## File path:

[jira] [Closed] (FLINK-12972) Ensure calling open/close in join condition of generated functions for blink

2019-06-25 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12972. -- Resolution: Fixed Fix Version/s: 1.9.0 merged in 1.9.0:

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297466134 ## File path:

[GitHub] [flink] KurtYoung merged pull request #8868: [FLINK-12972][table-planner-blink] Ensure calling open/close in join condition of generated functions for blink

2019-06-25 Thread GitBox
KurtYoung merged pull request #8868: [FLINK-12972][table-planner-blink] Ensure calling open/close in join condition of generated functions for blink URL: https://github.com/apache/flink/pull/8868 This is an automated

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297465694 ## File path:

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297465424 ## File path:

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297465153 ## File path:

[GitHub] [flink] zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler

2019-06-25 Thread GitBox
zhuzhurk commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8851#discussion_r297463953 ## File path:

[GitHub] [flink] godfreyhe commented on issue #8878: [FLINK-12971][table-planner-blink] Remove the constraint that lookup join needs a primary key or index key

2019-06-25 Thread GitBox
godfreyhe commented on issue #8878: [FLINK-12971][table-planner-blink] Remove the constraint that lookup join needs a primary key or index key URL: https://github.com/apache/flink/pull/8878#issuecomment-505693275 thanks for this refactoring @wuchong , LGTM now

[GitHub] [flink] zhijiangW commented on issue #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager

2019-06-25 Thread GitBox
zhijiangW commented on issue #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager URL: https://github.com/apache/flink/pull/8646#issuecomment-505692836 Thanks for further reviews @azagrebin ! I have rebased the codes and addressed the new

[jira] [Commented] (FLINK-12070) Make blocking result partitions consumable multiple times

2019-06-25 Thread Yingjie Cao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872870#comment-16872870 ] Yingjie Cao commented on FLINK-12070: - [~StephanEwen] Though, theoretically, two read buffers is

[GitHub] [flink] godfreyhe commented on a change in pull request #8878: [FLINK-12971][table-planner-blink] Remove the constraint that lookup join needs a primary key or index key

2019-06-25 Thread GitBox
godfreyhe commented on a change in pull request #8878: [FLINK-12971][table-planner-blink] Remove the constraint that lookup join needs a primary key or index key URL: https://github.com/apache/flink/pull/8878#discussion_r297461744 ## File path:

[GitHub] [flink] becketqin commented on issue #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord

2019-06-25 Thread GitBox
becketqin commented on issue #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord URL: https://github.com/apache/flink/pull/8535#issuecomment-505687127 @aljoscha Yes, you are right. We are not able to change the partition once the `ProducerRecrod` is there. We will

[GitHub] [flink] flinkbot commented on issue #8890: Xuefu1

2019-06-25 Thread GitBox
flinkbot commented on issue #8890: Xuefu1 URL: https://github.com/apache/flink/pull/8890#issuecomment-505680303 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] xuefuz commented on issue #8890: Xuefu1

2019-06-25 Thread GitBox
xuefuz commented on issue #8890: Xuefu1 URL: https://github.com/apache/flink/pull/8890#issuecomment-505680111 Please note that this PR included the changes in PR #8883. cc: @bowenli86 This is an automated message from the

[GitHub] [flink] xuefuz opened a new pull request #8890: Xuefu1

2019-06-25 Thread GitBox
xuefuz opened a new pull request #8890: Xuefu1 URL: https://github.com/apache/flink/pull/8890 ## What is the purpose of the change Add the generation of HiveTableSink from from a Hive table ## Brief change log *(for example:)* - Added the logic of

[GitHub] [flink] godfreyhe commented on a change in pull request #8868: [FLINK-12972][table-planner-blink] Ensure calling open/close in join condition of generated functions for blink

2019-06-25 Thread GitBox
godfreyhe commented on a change in pull request #8868: [FLINK-12972][table-planner-blink] Ensure calling open/close in join condition of generated functions for blink URL: https://github.com/apache/flink/pull/8868#discussion_r297452220 ## File path:

[jira] [Updated] (FLINK-12989) Generate HiveTableSink from from a Hive table

2019-06-25 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuefu Zhang updated FLINK-12989: Summary: Generate HiveTableSink from from a Hive table (was: Add implementation of converting

[jira] [Created] (FLINK-12989) Add implementation of converting Hive catalog table to Hive table sink

2019-06-25 Thread Xuefu Zhang (JIRA)
Xuefu Zhang created FLINK-12989: --- Summary: Add implementation of converting Hive catalog table to Hive table sink Key: FLINK-12989 URL: https://issues.apache.org/jira/browse/FLINK-12989 Project: Flink

[GitHub] [flink] flinkbot commented on issue #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service

2019-06-25 Thread GitBox
flinkbot commented on issue #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service URL: https://github.com/apache/flink/pull/8889#issuecomment-505662827 Thanks a lot for your contribution to the Apache Flink project. I'm

[jira] [Updated] (FLINK-12934) add additional dependencies for flink-connector-hive to connect to remote hive metastore service

2019-06-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12934: --- Labels: pull-request-available (was: ) > add additional dependencies for

[GitHub] [flink] bowenli86 opened a new pull request #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service

2019-06-25 Thread GitBox
bowenli86 opened a new pull request #8889: [FLINK-12934][hive] add additional dependencies for flink-connector-hive to connect to remote hive metastore service URL: https://github.com/apache/flink/pull/8889 ## What is the purpose of the change This PR adds a few more dependencies

[jira] [Updated] (FLINK-12934) add additional dependencies for flink-connector-hive to connect to remote hive metastore service

2019-06-25 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12934: - Summary: add additional dependencies for flink-connector-hive to connect to remote hive metastore

  1   2   3   4   5   6   >