flinkbot edited a comment on pull request #11837:
URL: https://github.com/apache/flink/pull/11837#issuecomment-616956896
## CI report:
* 9a4391b7c7248cdca1d2536f402891a6b64335b7 Travis:
[FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161760513) Azure:
flinkbot edited a comment on pull request #11892:
URL: https://github.com/apache/flink/pull/11892#issuecomment-618766534
## CI report:
* 84b468105ad7674897ed1df0f126d5f078944225 Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161749793) Azure:
flinkbot edited a comment on pull request #11897:
URL: https://github.com/apache/flink/pull/11897#issuecomment-618812841
## CI report:
* 7969f07cca4581f4ae7cbef7bd06787b3e90d248 Travis:
[PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161766709) Azure:
flinkbot edited a comment on pull request #11893:
URL: https://github.com/apache/flink/pull/11893#issuecomment-618771008
## CI report:
* b6a842dcaf10cca2b72a0155c1be580c5d9a3448 Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161751204) Azure:
danny0405 commented on a change in pull request #11791:
URL: https://github.com/apache/flink/pull/11791#discussion_r414314520
##
File path: flink-table/flink-sql-parser/pom.xml
##
@@ -298,6 +348,23 @@ under the License.
danny0405 commented on a change in pull request #11791:
URL: https://github.com/apache/flink/pull/11791#discussion_r414313942
##
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/hive/HiveDDLUtils.java
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed
GJL commented on a change in pull request #11857:
URL: https://github.com/apache/flink/pull/11857#discussion_r414313732
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/RestartPipelinedRegionFailoverStrategy.java
##
@@ -84,34
KarmaGYZ commented on a change in pull request #11854:
URL: https://github.com/apache/flink/pull/11854#discussion_r414313708
##
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/externalresource/ExternalResourceUtilsTest.java
##
@@ -85,4 +88,20 @@ public void
KarmaGYZ commented on a change in pull request #11854:
URL: https://github.com/apache/flink/pull/11854#discussion_r414312301
##
File path:
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/runtime/SavepointEnvironment.java
##
@@ -198,6
KarmaGYZ commented on a change in pull request #11854:
URL: https://github.com/apache/flink/pull/11854#discussion_r414312301
##
File path:
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/runtime/SavepointEnvironment.java
##
@@ -198,6
flinkbot commented on pull request #11897:
URL: https://github.com/apache/flink/pull/11897#issuecomment-618812841
## CI report:
* 7969f07cca4581f4ae7cbef7bd06787b3e90d248 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot
danny0405 commented on a change in pull request #11791:
URL: https://github.com/apache/flink/pull/11791#discussion_r414308065
##
File path: flink-table/flink-sql-parser/src/main/codegen-hive/data/Parser.tdd
##
@@ -0,0 +1,547 @@
+# Licensed to the Apache Software Foundation
flinkbot edited a comment on pull request #11893:
URL: https://github.com/apache/flink/pull/11893#issuecomment-618771008
## CI report:
* b6a842dcaf10cca2b72a0155c1be580c5d9a3448 Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161751204) Azure:
flinkbot edited a comment on pull request #11837:
URL: https://github.com/apache/flink/pull/11837#issuecomment-616956896
## CI report:
* 9a4391b7c7248cdca1d2536f402891a6b64335b7 Travis:
[FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161760513) Azure:
flinkbot edited a comment on pull request #11687:
URL: https://github.com/apache/flink/pull/11687#issuecomment-611445542
## CI report:
* 5bad018f00f85a7359345187a12d7938aa510d25 UNKNOWN
* d51ce7f47381d99b843278cd701dcff223761a0b UNKNOWN
*
flinkbot edited a comment on pull request #11896:
URL: https://github.com/apache/flink/pull/11896#issuecomment-618808279
## CI report:
* 6c5110c57efcb28693fa1bb15f59dbfc9850e58f Travis:
[PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161765118) Azure:
flinkbot edited a comment on pull request #11838:
URL: https://github.com/apache/flink/pull/11838#issuecomment-616983944
## CI report:
* cd4f2390481d8edcea676f07a6db2eafe0a4025c UNKNOWN
* b961c6a03d184e9a091b1513cb82f7aaa3956cf3 Travis:
KarmaGYZ commented on a change in pull request #11854:
URL: https://github.com/apache/flink/pull/11854#discussion_r414305550
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/DistributedRuntimeUDFContext.java
##
@@ -41,10 +44,14 @@
public
danny0405 commented on a change in pull request #11791:
URL: https://github.com/apache/flink/pull/11791#discussion_r414305379
##
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##
@@ -1403,4 +1446,29 @@
danny0405 commented on a change in pull request #11791:
URL: https://github.com/apache/flink/pull/11791#discussion_r414269563
##
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##
@@ -247,7 +253,10 @@ public
flinkbot commented on pull request #11897:
URL: https://github.com/apache/flink/pull/11897#issuecomment-618810155
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
[
https://issues.apache.org/jira/browse/FLINK-17344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhijiang reassigned FLINK-17344:
Assignee: Wenlong Lyu (was: Wenlong Li)
> RecordWriterTest.testIdleTime possibly deadlocks on
[
https://issues.apache.org/jira/browse/FLINK-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-16104:
---
Labels: pull-request-available (was: )
> Translate "Streaming Aggregation" page of "Table
[
https://issues.apache.org/jira/browse/FLINK-17344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhijiang reassigned FLINK-17344:
Assignee: Wenlong Li
> RecordWriterTest.testIdleTime possibly deadlocks on Travis
>
chaojianok opened a new pull request #11897:
URL: https://github.com/apache/flink/pull/11897
[FLINK-16104] Translate "Streaming Aggregation" page of "Table API & SQL"
into Chinese.
This is an automated message from the
KurtYoung commented on a change in pull request #11874:
URL: https://github.com/apache/flink/pull/11874#discussion_r414302741
##
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/NonDeterministicTests.scala
##
@@ -23,71
flinkbot edited a comment on pull request #11895:
URL: https://github.com/apache/flink/pull/11895#issuecomment-618799215
## CI report:
* 191da9e8a608bde3657193779bc9f0a48350f36d Travis:
[PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161760585) Azure:
flinkbot edited a comment on pull request #11892:
URL: https://github.com/apache/flink/pull/11892#issuecomment-618766534
## CI report:
* 84b468105ad7674897ed1df0f126d5f078944225 Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161749793) Azure:
flinkbot commented on pull request #11896:
URL: https://github.com/apache/flink/pull/11896#issuecomment-618808279
## CI report:
* 6c5110c57efcb28693fa1bb15f59dbfc9850e58f UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot
flinkbot edited a comment on pull request #11687:
URL: https://github.com/apache/flink/pull/11687#issuecomment-611445542
## CI report:
* 5bad018f00f85a7359345187a12d7938aa510d25 UNKNOWN
* d51ce7f47381d99b843278cd701dcff223761a0b UNKNOWN
*
flinkbot edited a comment on pull request #11797:
URL: https://github.com/apache/flink/pull/11797#issuecomment-615294694
## CI report:
* 85f40e3041783b1dbda1eb3b812f23e77936f7b3 UNKNOWN
* b8122fd40266de44eea61cd65e0b61cecea8 Travis:
KarmaGYZ commented on a change in pull request #11854:
URL: https://github.com/apache/flink/pull/11854#discussion_r414300630
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/externalresource/ExternalResourceUtils.java
##
@@ -117,4 +138,17 @@
zjffdu commented on pull request #11895:
URL: https://github.com/apache/flink/pull/11895#issuecomment-618806981
@flinkbot run azure
This is an automated message from the Apache Git Service.
To respond to the message, please
flinkbot commented on pull request #11896:
URL: https://github.com/apache/flink/pull/11896#issuecomment-618801326
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
[
https://issues.apache.org/jira/browse/FLINK-14356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-14356:
---
Labels: pull-request-available (was: )
> Introduce "single-field" format to (de)serialize
hackergin opened a new pull request #11896:
URL: https://github.com/apache/flink/pull/11896
## What is the purpose of the change
This pull request introduct single-value format to (de)serialize message to
a single field
## Brief change log
- add
flinkbot edited a comment on pull request #11837:
URL: https://github.com/apache/flink/pull/11837#issuecomment-616956896
## CI report:
* 38df357bc5c54d93159c2d460833cf80c42b5e0c Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161413766) Azure:
flinkbot commented on pull request #11895:
URL: https://github.com/apache/flink/pull/11895#issuecomment-618799215
## CI report:
* 191da9e8a608bde3657193779bc9f0a48350f36d UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot
flinkbot edited a comment on pull request #11838:
URL: https://github.com/apache/flink/pull/11838#issuecomment-616983944
## CI report:
* cd4f2390481d8edcea676f07a6db2eafe0a4025c UNKNOWN
* b961c6a03d184e9a091b1513cb82f7aaa3956cf3 Travis:
flinkbot edited a comment on pull request #11853:
URL: https://github.com/apache/flink/pull/11853#issuecomment-617586421
## CI report:
* 99b58fba1e22bdbba0896f0aba181eafc6a28e7f Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161461206) Azure:
flinkbot edited a comment on pull request #11796:
URL: https://github.com/apache/flink/pull/11796#issuecomment-615254717
## CI report:
* 90fa0d286fbdae57d834d527a8843a8a493d5a0d Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160733394) Azure:
Lu Niu created FLINK-17364:
--
Summary: Support StreamingFileSink in PrestoS3FileSystem
Key: FLINK-17364
URL: https://issues.apache.org/jira/browse/FLINK-17364
Project: Flink
Issue Type: Improvement
Ruan-Xin commented on pull request #11876:
URL: https://github.com/apache/flink/pull/11876#issuecomment-618795529
> ObjectInspectorFactory.ObjectInspectorOptions.JAVA)
I got it, You're right, I can get the correct result with this method.
flinkbot edited a comment on pull request #11853:
URL: https://github.com/apache/flink/pull/11853#issuecomment-617586421
## CI report:
* 99b58fba1e22bdbba0896f0aba181eafc6a28e7f Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161461206) Azure:
flinkbot edited a comment on pull request #11837:
URL: https://github.com/apache/flink/pull/11837#issuecomment-616956896
## CI report:
* 38df357bc5c54d93159c2d460833cf80c42b5e0c Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161413766) Azure:
flinkbot edited a comment on pull request #11797:
URL: https://github.com/apache/flink/pull/11797#issuecomment-615294694
## CI report:
* 85f40e3041783b1dbda1eb3b812f23e77936f7b3 UNKNOWN
* b8122fd40266de44eea61cd65e0b61cecea8 Travis:
flinkbot edited a comment on pull request #11796:
URL: https://github.com/apache/flink/pull/11796#issuecomment-615254717
## CI report:
* 90fa0d286fbdae57d834d527a8843a8a493d5a0d Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160733394) Azure:
flinkbot edited a comment on pull request #11774:
URL: https://github.com/apache/flink/pull/11774#issuecomment-614576955
## CI report:
* 1f72fb850f69449f4ef886ec0cad8a0644bab93d Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161169787) Azure:
[
https://issues.apache.org/jira/browse/FLINK-17273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091156#comment-17091156
]
Canbin Zheng commented on FLINK-17273:
--
Thanks a lot for the input [~trohrmann] [~xintongsong]. I
[
https://issues.apache.org/jira/browse/FLINK-16662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091155#comment-17091155
]
chenxyz commented on FLINK-16662:
-
[~jark] thx, you're right, end-to-end test is a better way for
xintongsong commented on a change in pull request #11323:
URL: https://github.com/apache/flink/pull/11323#discussion_r414277526
##
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManager.java
##
@@ -320,5 +333,16 @@ private void
flinkbot commented on pull request #11895:
URL: https://github.com/apache/flink/pull/11895#issuecomment-618789667
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
flinkbot edited a comment on pull request #11774:
URL: https://github.com/apache/flink/pull/11774#issuecomment-614576955
## CI report:
* 1f72fb850f69449f4ef886ec0cad8a0644bab93d Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161169787) Azure:
zjffdu opened a new pull request #11895:
URL: https://github.com/apache/flink/pull/11895
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way we avoid re-transferring them on
lirui-apache commented on pull request #11876:
URL: https://github.com/apache/flink/pull/11876#issuecomment-618788643
@Ruan-Xin I meant you can change `HiveSimpleUDF::getHiveResultType` to
something like this:
```
@Override
public DataType getHiveResultType(Object[]
robert created FLINK-17363:
--
Summary: Asynchronous association dimension table timeout
Key: FLINK-17363
URL: https://issues.apache.org/jira/browse/FLINK-17363
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-17308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091144#comment-17091144
]
sunjincheng commented on FLINK-17308:
-
Reset the fix version as 1.9.3 was released.
>
zhuzhurk commented on a change in pull request #11857:
URL: https://github.com/apache/flink/pull/11857#discussion_r414264754
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/RestartPipelinedRegionFailoverStrategy.java
##
@@
[
https://issues.apache.org/jira/browse/FLINK-17308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sunjincheng updated FLINK-17308:
Fix Version/s: (was: 1.9.3)
1.9.4
> ExecutionGraphCache
flinkbot commented on pull request #11894:
URL: https://github.com/apache/flink/pull/11894#issuecomment-618785514
## CI report:
* 191da9e8a608bde3657193779bc9f0a48350f36d UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot
zhuzhurk commented on a change in pull request #11857:
URL: https://github.com/apache/flink/pull/11857#discussion_r414264754
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/RestartPipelinedRegionFailoverStrategy.java
##
@@
flinkbot edited a comment on pull request #11791:
URL: https://github.com/apache/flink/pull/11791#issuecomment-615162346
## CI report:
* a6642cdfead306f1192f73c861e7201af9d38c56 Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160705250) Azure:
zhuzhurk commented on a change in pull request #11774:
URL: https://github.com/apache/flink/pull/11774#discussion_r414269826
##
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
##
@@ -898,6 +825,116 @@
zhuzhurk commented on a change in pull request #11774:
URL: https://github.com/apache/flink/pull/11774#discussion_r414270078
##
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
##
@@ -898,6 +825,116 @@
[
https://issues.apache.org/jira/browse/FLINK-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091141#comment-17091141
]
xin.ruan commented on FLINK-17334:
--
Hi all, I want to support array and map types, but I found that I
[
https://issues.apache.org/jira/browse/FLINK-17086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091140#comment-17091140
]
Rui Li commented on FLINK-17086:
Hi [~leiwangouc], FLINK-16802 has been fixed and you can try whether
[
https://issues.apache.org/jira/browse/FLINK-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xin.ruan updated FLINK-17334:
-
Attachment: screenshot-1.png
> Flink does not support HIVE UDFs with primitive return types
>
[
https://issues.apache.org/jira/browse/FLINK-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xin.ruan updated FLINK-17334:
-
Description:
We are currently migrating Hive UDF to Flink. While testing compatibility, we
found that
[
https://issues.apache.org/jira/browse/FLINK-14543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee updated FLINK-14543:
-
Fix Version/s: 1.11.0
> Support partition for temporary table
>
[
https://issues.apache.org/jira/browse/FLINK-14543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee closed FLINK-14543.
Resolution: Fixed
master: 6976e50e68f64d133fbf223a56db4a8b09e079cb
> Support partition for
[
https://issues.apache.org/jira/browse/FLINK-15901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee closed FLINK-15901.
Resolution: Fixed
master: 3a30886e300835e158177944f734a47453a4beab
> Support partitioned generic
flinkbot commented on pull request #11894:
URL: https://github.com/apache/flink/pull/11894#issuecomment-618783169
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
[
https://issues.apache.org/jira/browse/FLINK-14356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu updated FLINK-14356:
Fix Version/s: 1.11.0
> Introduce "single-field" format to (de)serialize message to a single field
>
[
https://issues.apache.org/jira/browse/FLINK-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xin.ruan updated FLINK-17334:
-
Description:
We are currently migrating Hive UDF to Flink. While testing compatibility, we
found that
[
https://issues.apache.org/jira/browse/FLINK-10911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-10911:
---
Labels: pull-request-available (was: )
> Flink's flink-scala-shell is not working with
zjffdu opened a new pull request #11894:
URL: https://github.com/apache/flink/pull/11894
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way we avoid re-transferring them on
[
https://issues.apache.org/jira/browse/FLINK-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee closed FLINK-16803.
> Need to make sure partition inherit table spec when writing to Hive tables
>
[
https://issues.apache.org/jira/browse/FLINK-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee updated FLINK-16803:
-
Affects Version/s: 1.10.0
> Need to make sure partition inherit table spec when writing to Hive
[
https://issues.apache.org/jira/browse/FLINK-16802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee closed FLINK-16802.
Fix Version/s: 1.11.0
Assignee: Rui Li
Resolution: Fixed
master:
[
https://issues.apache.org/jira/browse/FLINK-16802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee updated FLINK-16802:
-
Affects Version/s: 1.10.0
> Set schema info in JobConf for Hive readers
>
JingsongLi commented on pull request #11791:
URL: https://github.com/apache/flink/pull/11791#issuecomment-618782334
CC: @danny0405
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/FLINK-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingsong Lee reassigned FLINK-16803:
Assignee: Rui Li
> Need to make sure partition inherit table spec when writing to Hive
flinkbot edited a comment on pull request #11884:
URL: https://github.com/apache/flink/pull/11884#issuecomment-618376627
## CI report:
* 570f7e22326fc2f2d9f7dff4066192b604e7c479 Travis:
[CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/161749776) Azure:
zhuzhurk commented on a change in pull request #11857:
URL: https://github.com/apache/flink/pull/11857#discussion_r414264754
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/RestartPipelinedRegionFailoverStrategy.java
##
@@
flinkbot edited a comment on pull request #11791:
URL: https://github.com/apache/flink/pull/11791#issuecomment-615162346
## CI report:
* a6642cdfead306f1192f73c861e7201af9d38c56 Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160705250) Azure:
flinkbot edited a comment on pull request #11687:
URL: https://github.com/apache/flink/pull/11687#issuecomment-611445542
## CI report:
* 5bad018f00f85a7359345187a12d7938aa510d25 UNKNOWN
* d51ce7f47381d99b843278cd701dcff223761a0b UNKNOWN
*
zhuzhurk commented on a change in pull request #11857:
URL: https://github.com/apache/flink/pull/11857#discussion_r414264754
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/RestartPipelinedRegionFailoverStrategy.java
##
@@
[
https://issues.apache.org/jira/browse/FLINK-16662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091129#comment-17091129
]
Jark Wu commented on FLINK-16662:
-
Btw, your approach is very similar to an end-to-end test.
> Blink
[
https://issues.apache.org/jira/browse/FLINK-16662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091128#comment-17091128
]
Jark Wu commented on FLINK-16662:
-
Hi [~chenxyz], I think a better test is to add a real user case in
zhuzhurk commented on pull request #11855:
URL: https://github.com/apache/flink/pull/11855#issuecomment-618779582
Seems there was something wrong with Flink travis.
Would you rebase the change and trigger the travis again?
wuchong commented on a change in pull request #11874:
URL: https://github.com/apache/flink/pull/11874#discussion_r414251140
##
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/DecimalTypeTest.scala
##
@@ -129,23 +130,6
flinkbot edited a comment on pull request #11884:
URL: https://github.com/apache/flink/pull/11884#issuecomment-618376627
## CI report:
* ecd663181bfe20940c7c2ff311100f9007316392 Travis:
[SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161626047) Azure:
flinkbot edited a comment on pull request #11893:
URL: https://github.com/apache/flink/pull/11893#issuecomment-618771008
## CI report:
* b6a842dcaf10cca2b72a0155c1be580c5d9a3448 Travis:
[PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161751204) Azure:
flinkbot edited a comment on pull request #11687:
URL: https://github.com/apache/flink/pull/11687#issuecomment-611445542
## CI report:
* 5bad018f00f85a7359345187a12d7938aa510d25 UNKNOWN
* d51ce7f47381d99b843278cd701dcff223761a0b UNKNOWN
*
KarmaGYZ commented on a change in pull request #11854:
URL: https://github.com/apache/flink/pull/11854#discussion_r414256108
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/externalresource/ExternalResourceUtils.java
##
@@ -76,4 +78,43 @@
WeiZhong94 commented on pull request #11884:
URL: https://github.com/apache/flink/pull/11884#issuecomment-618773790
@dianfu Thanks for your review! I have addressed you comments in the latest
commit.
This is an automated
wuchong commented on a change in pull request #11837:
URL: https://github.com/apache/flink/pull/11837#discussion_r414255501
##
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/TableSourceTest.scala
##
@@ -130,6
WeiZhong94 commented on a change in pull request #11884:
URL: https://github.com/apache/flink/pull/11884#discussion_r414255081
##
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java
##
@@ -194,22 +194,32 @@ public void
WeiZhong94 commented on a change in pull request #11884:
URL: https://github.com/apache/flink/pull/11884#discussion_r414254201
##
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogFunctionImpl.java
##
@@ -67,6 +67,9 @@ public
docete commented on a change in pull request #11837:
URL: https://github.com/apache/flink/pull/11837#discussion_r414254173
##
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/TableSourceTest.scala
##
@@ -130,6
1 - 100 of 598 matches
Mail list logo