[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-18 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r578870795 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManager.java ## @@ -600,61 +603,69 @@

[GitHub] [flink] flinkbot edited a comment on pull request #14868: [FLINK-21326][runtime] Optimize building topology when initializing ExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14868: URL: https://github.com/apache/flink/pull/14868#issuecomment-773192044 ## CI report: * 85af2bb6354ce46e90d607ee0f784a91266b80b1 Azure:

[jira] [Commented] (FLINK-21319) hadoop-mapreduce jars are not loaded into classpath when submiting flink on yarn jobs.

2021-02-18 Thread Tang Yan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286807#comment-17286807 ] Tang Yan commented on FLINK-21319: -- Thanks for your reply. [~trohrmann] Could you check my code in

[GitHub] [flink] flinkbot edited a comment on pull request #14868: [FLINK-21326][runtime] Optimize building topology when initializing ExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14868: URL: https://github.com/apache/flink/pull/14868#issuecomment-773192044 ## CI report: * 85af2bb6354ce46e90d607ee0f784a91266b80b1 Azure:

[jira] [Created] (FLINK-21411) The components on which Flink depends may contain vulnerabilities. If yes, fix them.

2021-02-18 Thread dgbro (Jira)
dgbro created FLINK-21411: - Summary: The components on which Flink depends may contain vulnerabilities. If yes, fix them. Key: FLINK-21411 URL: https://issues.apache.org/jira/browse/FLINK-21411 Project:

[jira] [Closed] (FLINK-17061) Unset process/flink memory size from configuration once dynamic worker resource is activated.

2021-02-18 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-17061. Fix Version/s: 1.13.0 Resolution: Fixed Fixed via: * master (1.13):

[GitHub] [flink] xintongsong closed pull request #14954: [FLINK-17061][runtime] Unset TM total process/flink memory size for fine-grained resource management

2021-02-18 Thread GitBox
xintongsong closed pull request #14954: URL: https://github.com/apache/flink/pull/14954 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] flinkbot edited a comment on pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14964: URL: https://github.com/apache/flink/pull/14964#issuecomment-781637879 ## CI report: * ed1dc2c2399cd7a9a0e8c5c68f4b39470e7ec10e Azure:

[jira] [Comment Edited] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-18 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286380#comment-17286380 ] Jiangjie Qin edited comment on FLINK-21133 at 2/19/21, 12:41 AM: - It

[GitHub] [flink] flinkbot edited a comment on pull request #14951: [FLINK-21380][coordination] Hide terminal ExecutionGraph in StateWithExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14951: URL: https://github.com/apache/flink/pull/14951#issuecomment-780579743 ## CI report: * 75d0067ce378ce84d7e8edbe1810cf85bdcab9fb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14798: URL: https://github.com/apache/flink/pull/14798#issuecomment-769223911 ## CI report: * af8de65a4905ae47ab704a75acfcd1b2e897d915 UNKNOWN * 772e076ed9d773e16713236c942f4e30b659d6eb UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #14928: [FLINK-21360][coordination] Make resource timeout configurable

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14928: URL: https://github.com/apache/flink/pull/14928#issuecomment-14828 ## CI report: * 20915f746d6fd359f00a6f7a77aa3b7c349a94fb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14798: URL: https://github.com/apache/flink/pull/14798#issuecomment-769223911 ## CI report: * af8de65a4905ae47ab704a75acfcd1b2e897d915 UNKNOWN * 772e076ed9d773e16713236c942f4e30b659d6eb UNKNOWN *

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-18 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r578805957 ## File path: flink-end-to-end-tests/test-scripts/test_glue_schema_registry.sh ## @@ -0,0 +1,72 @@ +#!/usr/bin/env bash Review comment:

[GitHub] [flink] zentol commented on a change in pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
zentol commented on a change in pull request #14950: URL: https://github.com/apache/flink/pull/14950#discussion_r578794106 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/MockExecutionGraphBase.java ## @@ -0,0 +1,424 @@ +/* + * Licensed to

[GitHub] [flink] zentol commented on a change in pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-18 Thread GitBox
zentol commented on a change in pull request #14963: URL: https://github.com/apache/flink/pull/14963#discussion_r578791931 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/declarative/RestartingTest.java ## @@ -209,6 +210,7 @@ public void close()

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r578787023 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,33 @@ public void cancel() {

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r578786368 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,33 @@ public void cancel() {

[GitHub] [flink] dannycranmer commented on pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-18 Thread GitBox
dannycranmer commented on pull request #14737: URL: https://github.com/apache/flink/pull/14737#issuecomment-781667422 As a follow up we should add support for SQL client and Table API by: - Adding a shaded module for SQL client, similar to

[GitHub] [flink] flinkbot edited a comment on pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14964: URL: https://github.com/apache/flink/pull/14964#issuecomment-781637879 ## CI report: * ed1dc2c2399cd7a9a0e8c5c68f4b39470e7ec10e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14847: URL: https://github.com/apache/flink/pull/14847#issuecomment-772387941 ## CI report: * 9a2ea20ce0803e48edfc3ab7bcc02078b7410fbf UNKNOWN * 4aecfae5f4889de59c7f1d71d39647b6ee6f9ad8 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14964: URL: https://github.com/apache/flink/pull/14964#issuecomment-781637879 ## CI report: * ed1dc2c2399cd7a9a0e8c5c68f4b39470e7ec10e Azure:

[GitHub] [flink] flinkbot commented on pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
flinkbot commented on pull request #14964: URL: https://github.com/apache/flink/pull/14964#issuecomment-781637879 ## CI report: * ed1dc2c2399cd7a9a0e8c5c68f4b39470e7ec10e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
flinkbot commented on pull request #14964: URL: https://github.com/apache/flink/pull/14964#issuecomment-781635100 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-21410) Document checkpoint interval trade-offs

2021-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21410: --- Labels: pull-request-available (was: ) > Document checkpoint interval trade-offs >

[GitHub] [flink] sjwiesman opened a new pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
sjwiesman opened a new pull request #14964: URL: https://github.com/apache/flink/pull/14964 ## What is the purpose of the change Document the trade-offs of setting different checkpoint interval values and provide guidance on how to determine the appropriate interval for a given job.

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r578737299 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,33 @@ public void cancel() {

[GitHub] [flink] flinkbot edited a comment on pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14963: URL: https://github.com/apache/flink/pull/14963#issuecomment-781452668 ## CI report: * 80874c3472c2d74de07c651d56c728e210e9db6d UNKNOWN * d6bbdeabce59f5556c0d1be6e88e098df84d7f98 Azure:

[jira] [Assigned] (FLINK-21410) Document checkpoint interval trade-offs

2021-02-18 Thread Seth Wiesman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman reassigned FLINK-21410: Assignee: Seth Wiesman > Document checkpoint interval trade-offs >

[GitHub] [flink] rkhachatryan commented on a change in pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-18 Thread GitBox
rkhachatryan commented on a change in pull request #14740: URL: https://github.com/apache/flink/pull/14740#discussion_r578709529 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java ## @@ -651,39 +681,52 @@ private void

[GitHub] [flink] rkhachatryan commented on a change in pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-18 Thread GitBox
rkhachatryan commented on a change in pull request #14740: URL: https://github.com/apache/flink/pull/14740#discussion_r578709529 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java ## @@ -651,39 +681,52 @@ private void

[jira] [Created] (FLINK-21410) Document checkpoint interval trade-offs

2021-02-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21410: Summary: Document checkpoint interval trade-offs Key: FLINK-21410 URL: https://issues.apache.org/jira/browse/FLINK-21410 Project: Flink Issue Type:

[jira] [Closed] (FLINK-16947) ArtifactResolutionException: Could not transfer artifact. Entry [...] has not been leased from this pool

2021-02-18 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger closed FLINK-16947. -- Fix Version/s: 1.13.0 Resolution: Fixed Maybe a fix, merged to master only for now:

[GitHub] [flink] rmetzger merged pull request #14959: [FLINK-16947][Azure] Attempt to fix maven network issues

2021-02-18 Thread GitBox
rmetzger merged pull request #14959: URL: https://github.com/apache/flink/pull/14959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] rmetzger commented on pull request #14959: [FLINK-16947][Azure] Attempt to fix maven network issues

2021-02-18 Thread GitBox
rmetzger commented on pull request #14959: URL: https://github.com/apache/flink/pull/14959#issuecomment-781587879 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] flinkbot edited a comment on pull request #14951: [FLINK-21380][coordination] Hide terminal ExecutionGraph in StateWithExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14951: URL: https://github.com/apache/flink/pull/14951#issuecomment-780579743 ## CI report: * 0ce7b0c76e548703b5aaa367785bb19634c37072 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14928: [FLINK-21360][coordination] Make resource timeout configurable

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14928: URL: https://github.com/apache/flink/pull/14928#issuecomment-14828 ## CI report: * 6be910fe164322d9862bad9c0d80f8ff4ee5fe62 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14951: [FLINK-21380][coordination] Hide terminal ExecutionGraph in StateWithExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14951: URL: https://github.com/apache/flink/pull/14951#issuecomment-780579743 ## CI report: * 0ce7b0c76e548703b5aaa367785bb19634c37072 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14928: [FLINK-21360][coordination] Make resource timeout configurable

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14928: URL: https://github.com/apache/flink/pull/14928#issuecomment-14828 ## CI report: * 6be910fe164322d9862bad9c0d80f8ff4ee5fe62 Azure:

[jira] [Created] (FLINK-21409) Add Avro to DataTypes & Serialization docs

2021-02-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21409: Summary: Add Avro to DataTypes & Serialization docs Key: FLINK-21409 URL: https://issues.apache.org/jira/browse/FLINK-21409 Project: Flink Issue

[jira] [Created] (FLINK-21408) Clarify which DataStream sources support Batch execution

2021-02-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21408: Summary: Clarify which DataStream sources support Batch execution Key: FLINK-21408 URL: https://issues.apache.org/jira/browse/FLINK-21408 Project: Flink

[jira] [Created] (FLINK-21407) Clarify which sources and APIs support which formats

2021-02-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21407: Summary: Clarify which sources and APIs support which formats Key: FLINK-21407 URL: https://issues.apache.org/jira/browse/FLINK-21407 Project: Flink

[jira] [Created] (FLINK-21406) Add AvroParquetFileRecordFormat

2021-02-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21406: Summary: Add AvroParquetFileRecordFormat Key: FLINK-21406 URL: https://issues.apache.org/jira/browse/FLINK-21406 Project: Flink Issue Type: New

[GitHub] [flink] zentol commented on a change in pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-18 Thread GitBox
zentol commented on a change in pull request #14963: URL: https://github.com/apache/flink/pull/14963#discussion_r578652262 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/declarative/WaitingForResourcesTest.java ## @@ -57,10 +57,15 @@ public void

[jira] [Closed] (FLINK-21381) Kubernetes HA documentation does not state required service account and role

2021-02-18 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-21381. - Fix Version/s: (was: 1.12.2) 1.12.3 Resolution: Fixed Fixed via

[GitHub] [flink] tillrohrmann closed pull request #14947: [BP-1.12][FLINK-21381][docs] Add information about service account permissions to K8s HA service documentation

2021-02-18 Thread GitBox
tillrohrmann closed pull request #14947: URL: https://github.com/apache/flink/pull/14947 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] tillrohrmann commented on pull request #14947: [BP-1.12][FLINK-21381][docs] Add information about service account permissions to K8s HA service documentation

2021-02-18 Thread GitBox
tillrohrmann commented on pull request #14947: URL: https://github.com/apache/flink/pull/14947#issuecomment-781547092 Manually merged via 3bbfb73908b239f957169805bf591c69ce949ccb This is an automated message from the Apache

[jira] [Created] (FLINK-21405) SchedulerNGFactoryFactoryTest fails if DeclarativeScheduler is enabled via property

2021-02-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21405: Summary: SchedulerNGFactoryFactoryTest fails if DeclarativeScheduler is enabled via property Key: FLINK-21405 URL: https://issues.apache.org/jira/browse/FLINK-21405

[jira] [Created] (FLINK-21404) YARNITCase runs indefinitely

2021-02-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21404: Summary: YARNITCase runs indefinitely Key: FLINK-21404 URL: https://issues.apache.org/jira/browse/FLINK-21404 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-21403) Some tests expect to fail if parallelism cannot be met

2021-02-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21403: Summary: Some tests expect to fail if parallelism cannot be met Key: FLINK-21403 URL: https://issues.apache.org/jira/browse/FLINK-21403 Project: Flink

[jira] [Created] (FLINK-21402) Consolidate Scheduler/SlotPool factories

2021-02-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21402: Summary: Consolidate Scheduler/SlotPool factories Key: FLINK-21402 URL: https://issues.apache.org/jira/browse/FLINK-21402 Project: Flink Issue Type:

[GitHub] [flink] tillrohrmann commented on pull request #14946: [FLINK-21381][docs] Add information about service account permissions to K8s HA service documentation

2021-02-18 Thread GitBox
tillrohrmann commented on pull request #14946: URL: https://github.com/apache/flink/pull/14946#issuecomment-781536646 Thanks for the review. Merging this PR now. This is an automated message from the Apache Git Service. To

[jira] [Created] (FLINK-21401) Tests that manually build a JobGraph cannot use DeclarativeScheduler

2021-02-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21401: Summary: Tests that manually build a JobGraph cannot use DeclarativeScheduler Key: FLINK-21401 URL: https://issues.apache.org/jira/browse/FLINK-21401

[GitHub] [flink] tillrohrmann closed pull request #14946: [FLINK-21381][docs] Add information about service account permissions to K8s HA service documentation

2021-02-18 Thread GitBox
tillrohrmann closed pull request #14946: URL: https://github.com/apache/flink/pull/14946 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (FLINK-21400) Attempt numbers are not maintained across restarts

2021-02-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21400: Summary: Attempt numbers are not maintained across restarts Key: FLINK-21400 URL: https://issues.apache.org/jira/browse/FLINK-21400 Project: Flink

[jira] [Closed] (FLINK-20580) Missing null value handling for SerializedValue's getByteArray()

2021-02-18 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-20580. - Fix Version/s: (was: 1.11.4) Resolution: Fixed Fixed via 1.13.0:

[jira] [Created] (FLINK-21399) Adjust JobMasterTest#testRequestNextInputSplitWith*Failover

2021-02-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21399: Summary: Adjust JobMasterTest#testRequestNextInputSplitWith*Failover Key: FLINK-21399 URL: https://issues.apache.org/jira/browse/FLINK-21399 Project: Flink

[GitHub] [flink] flinkbot edited a comment on pull request #14944: [FLINK-21297] Support 'LOAD/UNLOAD MODULE' syntax

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14944: URL: https://github.com/apache/flink/pull/14944#issuecomment-779315396 ## CI report: * 2ee9ac64332d3547bf934d7cd17f73ee5404c8b1 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14943: URL: https://github.com/apache/flink/pull/14943#issuecomment-779315285 ## CI report: * f80b97c479ec82663e971553c54c8a6cda3122ff UNKNOWN * c9be932fec6390ffb103c000550cbc85747c266e Azure:

[jira] [Created] (FLINK-21398) Adjsut JobMasterTest#testRestoring[...]FromSavepoint

2021-02-18 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-21398: Summary: Adjsut JobMasterTest#testRestoring[...]FromSavepoint Key: FLINK-21398 URL: https://issues.apache.org/jira/browse/FLINK-21398 Project: Flink

[jira] [Updated] (FLINK-21398) Adjust JobMasterTest#testRestoring[...]FromSavepoint

2021-02-18 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-21398: - Summary: Adjust JobMasterTest#testRestoring[...]FromSavepoint (was: Adjsut

[GitHub] [flink] tillrohrmann closed pull request #14936: [FLINK-20580][core] Don't support nullable value for SerializedValue

2021-02-18 Thread GitBox
tillrohrmann closed pull request #14936: URL: https://github.com/apache/flink/pull/14936 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (FLINK-20580) Missing null value handling for SerializedValue's getByteArray()

2021-02-18 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-20580: -- Fix Version/s: 1.12.3 1.13.0 1.11.4 > Missing null

[GitHub] [flink] HuangZhenQiu commented on pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-02-18 Thread GitBox
HuangZhenQiu commented on pull request #14961: URL: https://github.com/apache/flink/pull/14961#issuecomment-781519693 @JingsongLi Would you please review this PR? This is an automated message from the Apache Git Service.

[GitHub] [flink] tillrohrmann commented on a change in pull request #14936: [FLINK-20580][core] Don't support nullable value for SerializedValue

2021-02-18 Thread GitBox
tillrohrmann commented on a change in pull request #14936: URL: https://github.com/apache/flink/pull/14936#discussion_r578618616 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcSerializedValue.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to the

[GitHub] [flink] flinkbot edited a comment on pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14847: URL: https://github.com/apache/flink/pull/14847#issuecomment-772387941 ## CI report: * 9a2ea20ce0803e48edfc3ab7bcc02078b7410fbf UNKNOWN * 4aecfae5f4889de59c7f1d71d39647b6ee6f9ad8 UNKNOWN *

[jira] [Commented] (FLINK-16444) Count the read/write/seek/next latency of RocksDB as metrics

2021-02-18 Thread Yu Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286615#comment-17286615 ] Yu Li commented on FLINK-16444: --- [~yunta] Besides these metrics, let's also check and confirm whether more

[GitHub] [flink] XComp commented on pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
XComp commented on pull request #14847: URL: https://github.com/apache/flink/pull/14847#issuecomment-781491052 The following state diagram reflect the most recent code changes to support the code review.

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578584522 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointContext.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578584067 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/StopWithSavepointContextTest.java ## @@ -0,0 +1,249 @@ +/* + * Licensed to

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578582587 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/StopWithSavepointContextTest.java ## @@ -0,0 +1,249 @@ +/* + * Licensed to

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578581744 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointOperations.java ## @@ -0,0 +1,54 @@ +/* + * Licensed to the

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578580800 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointContext.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578581053 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/StopWithSavepointContext.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the

[jira] [Resolved] (FLINK-19503) Add StateChangelog interface and its in-memory implementation

2021-02-18 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan resolved FLINK-19503. --- Resolution: Fixed > Add StateChangelog interface and its in-memory implementation >

[GitHub] [flink] rkhachatryan merged pull request #14838: [FLINK-19503][state] Add StateChangelog API

2021-02-18 Thread GitBox
rkhachatryan merged pull request #14838: URL: https://github.com/apache/flink/pull/14838 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] rkhachatryan commented on pull request #14838: [FLINK-19503][state] Add StateChangelog API

2021-02-18 Thread GitBox
rkhachatryan commented on pull request #14838: URL: https://github.com/apache/flink/pull/14838#issuecomment-781481465 Test failure unrelated (FLINK-21277), merging. This is an automated message from the Apache Git Service.

[GitHub] [flink] flinkbot edited a comment on pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14963: URL: https://github.com/apache/flink/pull/14963#issuecomment-781452668 ## CI report: * 80874c3472c2d74de07c651d56c728e210e9db6d UNKNOWN * d6bbdeabce59f5556c0d1be6e88e098df84d7f98 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14847: URL: https://github.com/apache/flink/pull/14847#issuecomment-772387941 ## CI report: * 9a2ea20ce0803e48edfc3ab7bcc02078b7410fbf UNKNOWN * 4aecfae5f4889de59c7f1d71d39647b6ee6f9ad8 UNKNOWN *

[GitHub] [flink] wuchong commented on a change in pull request #14944: [FLINK-21297] Support 'LOAD/UNLOAD MODULE' syntax

2021-02-18 Thread GitBox
wuchong commented on a change in pull request #14944: URL: https://github.com/apache/flink/pull/14944#discussion_r578568850 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala ## @@ -546,13 +555,16 @@ class

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578568213 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -908,49 +909,38 @@ public void

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578567820 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -817,6 +818,126 @@ public void

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578567121 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java ## @@ -817,6 +818,126 @@ public void

[GitHub] [flink] XComp commented on a change in pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14847: URL: https://github.com/apache/flink/pull/14847#discussion_r578561800 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -835,8 +837,15 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14963: URL: https://github.com/apache/flink/pull/14963#issuecomment-781452668 ## CI report: * 80874c3472c2d74de07c651d56c728e210e9db6d UNKNOWN * d6bbdeabce59f5556c0d1be6e88e098df84d7f98 UNKNOWN Bot commands The

[GitHub] [flink] shmyer commented on pull request #14084: [FLINK-15867][table-planner-blink] Support time-related types for FIRST_VALUE and LAST_VALUE aggregate functions

2021-02-18 Thread GitBox
shmyer commented on pull request #14084: URL: https://github.com/apache/flink/pull/14084#issuecomment-781454473 @leonardBang Sorry for the late response, I kind of lost sight of this PR :( I can't seem to find the test comment you mentioned, where would I find that?

[GitHub] [flink] flinkbot commented on pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-18 Thread GitBox
flinkbot commented on pull request #14963: URL: https://github.com/apache/flink/pull/14963#issuecomment-781452668 ## CI report: * 80874c3472c2d74de07c651d56c728e210e9db6d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #14954: [FLINK-17061][runtime] Unset TM total process/flink memory size for fine-grained resource management

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14954: URL: https://github.com/apache/flink/pull/14954#issuecomment-781063841 ## CI report: * 709ba9478b5c13b183bf66d73294d8133438a8f5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14961: URL: https://github.com/apache/flink/pull/14961#issuecomment-781278553 ## CI report: * a35e534ab18f7d4c80a8ee52d7dd70b7e3a0f2a0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14960: fix scrolling issue in Firefox

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14960: URL: https://github.com/apache/flink/pull/14960#issuecomment-781267077 ## CI report: * c195cee17a3fa141bcf497f137495a54e55041f7 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14953: [FLINK-21351][checkpointing] Don't subsume last checkpoint

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14953: URL: https://github.com/apache/flink/pull/14953#issuecomment-780752668 ## CI report: * 941374ecdd03b5ceb9245e4d8a8370671b691a34 UNKNOWN * 07d008483dd496a4b89fe34e799511e3e2670fb8 Azure:

[jira] [Commented] (FLINK-21359) CompatibilityResult issues with Flink 1.9.0

2021-02-18 Thread Siva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286558#comment-17286558 ] Siva commented on FLINK-21359: -- It is working fine with Flink 1.7.0 and emr 5.21.0 we are using 

[jira] [Issue Comment Deleted] (FLINK-21359) CompatibilityResult issues with Flink 1.9.0

2021-02-18 Thread Siva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siva updated FLINK-21359: - Comment: was deleted (was: BytesDeserializerSchema cannot be cast to

[jira] [Assigned] (FLINK-21101) Set up cron job to run CI with declarative scheduler

2021-02-18 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-21101: -- Assignee: Robert Metzger > Set up cron job to run CI with declarative scheduler >

[GitHub] [flink] flinkbot commented on pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-18 Thread GitBox
flinkbot commented on pull request #14963: URL: https://github.com/apache/flink/pull/14963#issuecomment-781429547 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-21362) Remove State#onEnter

2021-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21362: --- Labels: pull-request-available (was: ) > Remove State#onEnter > > >

[GitHub] [flink] rmetzger opened a new pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-18 Thread GitBox
rmetzger opened a new pull request #14963: URL: https://github.com/apache/flink/pull/14963 ## What is the purpose of the change Increase robustness by moving the onEnter into the constructor of the states.

[jira] [Commented] (FLINK-18634) FlinkKafkaProducerITCase.testRecoverCommittedTransaction failed with "Timeout expired after 60000milliseconds while awaiting InitProducerId"

2021-02-18 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286534#comment-17286534 ] Dong Lin commented on FLINK-18634: -- Sounds good. I will try to upgrade Kafka dependency to 2.5.1. >

[GitHub] [flink] flinkbot edited a comment on pull request #14962: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14962: URL: https://github.com/apache/flink/pull/14962#issuecomment-781306516 ## CI report: * fda5571674ea74fb5c104180e3790d45c600fbea Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14950: URL: https://github.com/apache/flink/pull/14950#issuecomment-780431068 ## CI report: * 1b43a411d22af19f12f14a79c1094c8dc5cfeb42 UNKNOWN * a8191e6800961467c726695c8ef7575d157a Azure:

<    1   2   3   4   5   >