[GitHub] [flink] kezhuw commented on a change in pull request #14936: [FLINK-20580][core] Don't support nullable value for SerializedValue

2021-02-18 Thread GitBox
kezhuw commented on a change in pull request #14936: URL: https://github.com/apache/flink/pull/14936#discussion_r578501942 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcSerializedValue.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to the

[GitHub] [flink] flinkbot edited a comment on pull request #14959: [FLINK-16947][Azure] Attempt to fix maven network issues

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14959: URL: https://github.com/apache/flink/pull/14959#issuecomment-781241815 ## CI report: * 3e3889ee5cc45f7d8dd654b9c5296a80ab6e88e0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14916: [FLINK-21345][Table SQL / Planner] Fix BUG of Union All join Temporal…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14916: URL: https://github.com/apache/flink/pull/14916#issuecomment-776614443 ## CI report: * 13b22ab740f81a326927caa4f344bbafab336a54 Azure:

[GitHub] [flink] kezhuw commented on pull request #14936: [FLINK-20580][core] Don't support nullable value for SerializedValue

2021-02-18 Thread GitBox
kezhuw commented on pull request #14936: URL: https://github.com/apache/flink/pull/14936#issuecomment-781410232 @tillrohrmann Thanks for reviewing, the comments make sense to me. Then I will give up rebasing to you. This is

[jira] [Commented] (FLINK-21382) Standalone K8s documentation does not explain usage of standby JobManagers

2021-02-18 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286514#comment-17286514 ] Yang Wang commented on FLINK-21382: --- Make sense. I used to leave a similar solution

[GitHub] [flink] tillrohrmann commented on a change in pull request #14936: [FLINK-20580][core] Don't support nullable value for SerializedValue

2021-02-18 Thread GitBox
tillrohrmann commented on a change in pull request #14936: URL: https://github.com/apache/flink/pull/14936#discussion_r578464596 ## File path: flink-core/src/test/java/org/apache/flink/util/SerializedValueTest.java ## @@ -47,26 +50,47 @@ public void testSimpleValue() {

[GitHub] [flink] rmetzger commented on a change in pull request #14923: [DRAFT] Remove State#onEnter

2021-02-18 Thread GitBox
rmetzger commented on a change in pull request #14923: URL: https://github.com/apache/flink/pull/14923#discussion_r578386398 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/declarative/DeclarativeScheduler.java ## @@ -887,19 +897,22 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #14928: [FLINK-21360][coordination] Make resource timeout configurable

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14928: URL: https://github.com/apache/flink/pull/14928#issuecomment-14828 ## CI report: * 6be910fe164322d9862bad9c0d80f8ff4ee5fe62 Azure:

[GitHub] [flink] tillrohrmann commented on a change in pull request #14951: [FLINK-21380][coordination] Hide terminal ExecutionGraph in StateWithExecutionGraph

2021-02-18 Thread GitBox
tillrohrmann commented on a change in pull request #14951: URL: https://github.com/apache/flink/pull/14951#discussion_r578441952 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionGraph.java ## @@ -335,9 +352,16 @@ public static

[GitHub] [flink] rkhachatryan commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
rkhachatryan commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578434972 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorageLoader.java ## @@ -162,14 +163,19 @@ public static

[GitHub] [flink] rkhachatryan commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
rkhachatryan commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578414166 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/delegate/DelegatedStateBackend.java ## @@ -0,0 +1,29 @@ +/* + * Licensed

[GitHub] [flink] flinkbot edited a comment on pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14950: URL: https://github.com/apache/flink/pull/14950#issuecomment-780431068 ## CI report: * 1b43a411d22af19f12f14a79c1094c8dc5cfeb42 UNKNOWN * e6aae42cf093d4f44b93b79a78bdc64538df8725 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14943: URL: https://github.com/apache/flink/pull/14943#issuecomment-779315285 ## CI report: * f80b97c479ec82663e971553c54c8a6cda3122ff UNKNOWN * 3e1cf6d7f7f645e991c0b788f653bab7b1baa797 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14838: [FLINK-19503][state] Add StateChangelog API

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14838: URL: https://github.com/apache/flink/pull/14838#issuecomment-772060058 ## CI report: * f560722ab6bbf452340228a2c88e025ecc797274 UNKNOWN * 000fa3e28def66c51ebf7b5975d8b6106988 Azure:

[GitHub] [flink] lllkkklll commented on pull request #13353: [FLINK-17104] Support registering custom JobStatusListeners from config

2021-02-18 Thread GitBox
lllkkklll commented on pull request #13353: URL: https://github.com/apache/flink/pull/13353#issuecomment-781356093 why not merge? better idea? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] tillrohrmann commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
tillrohrmann commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r578407995 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java ## @@ -153,7 +152,7 @@ private LogicalSlot

[GitHub] [flink] flinkbot edited a comment on pull request #14946: [FLINK-21381][docs] Add information about service account permissions to K8s HA service documentation

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14946: URL: https://github.com/apache/flink/pull/14946#issuecomment-779866080 ## CI report: * eacbdcd5b9a6d60747e81f91208b102b53a5cafa Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14943: URL: https://github.com/apache/flink/pull/14943#issuecomment-779315285 ## CI report: * f80b97c479ec82663e971553c54c8a6cda3122ff UNKNOWN * 3e1cf6d7f7f645e991c0b788f653bab7b1baa797 Azure:

[jira] [Closed] (FLINK-14869) Force an extended resource to be null if it's value is 0

2021-02-18 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-14869. Fix Version/s: 1.13.0 Resolution: Fixed Fixed via * master (1.13):

[GitHub] [flink] xintongsong closed pull request #14955: [FLINK-14869][core] Discard zero-valued extended resources in ResourceSpec/ResourceProfile

2021-02-18 Thread GitBox
xintongsong closed pull request #14955: URL: https://github.com/apache/flink/pull/14955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] flinkbot edited a comment on pull request #14955: [FLINK-14869][core] Discard zero-valued extended resources in ResourceSpec/ResourceProfile

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14955: URL: https://github.com/apache/flink/pull/14955#issuecomment-781090588 ## CI report: * a4330f962aafed35041166c9a718e95fe5fcc214 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14944: [FLINK-21297] Support 'LOAD/UNLOAD MODULE' syntax

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14944: URL: https://github.com/apache/flink/pull/14944#issuecomment-779315396 ## CI report: * e265855ee20db57e62a53be0f80486ff2feaef29 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14958: [FLINK-18550][sql-client] use TableResult#collect to get select result for sql client

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14958: URL: https://github.com/apache/flink/pull/14958#issuecomment-781106758 ## CI report: * 15a2ba54d452e3f88ca92ed2820b8e58285a7058 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14944: [FLINK-21297] Support 'LOAD/UNLOAD MODULE' syntax

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14944: URL: https://github.com/apache/flink/pull/14944#issuecomment-779315396 ## CI report: * e265855ee20db57e62a53be0f80486ff2feaef29 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-766340750 ## CI report: * c7e6b28b249f85cf52740d5201a769e0982a60aa UNKNOWN * bebd298009b12a9d5ac6518902f5534f8e00ff32 UNKNOWN *

[jira] [Commented] (FLINK-21393) Implement ParquetAvroInputFormat

2021-02-18 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-21393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286461#comment-17286461 ] Dominik Wosiński commented on FLINK-21393: -- Happy to add that. > Implement

[GitHub] [flink] echauchot commented on pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-02-18 Thread GitBox
echauchot commented on pull request #14961: URL: https://github.com/apache/flink/pull/14961#issuecomment-781322363 @fhueske as you merged the previous related PR, can you please review this one ? Thanks. This is an

[GitHub] [flink] echauchot edited a comment on pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-02-18 Thread GitBox
echauchot edited a comment on pull request #14961: URL: https://github.com/apache/flink/pull/14961#issuecomment-781272437 @HuangZhenQiu FYI as discussed This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (FLINK-21351) Incremental checkpoint data would be lost once a non-stop savepoint completed

2021-02-18 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286454#comment-17286454 ] Till Rohrmann commented on FLINK-21351: --- I think that this should work a bit better at the cost of

[jira] [Commented] (FLINK-21351) Incremental checkpoint data would be lost once a non-stop savepoint completed

2021-02-18 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286455#comment-17286455 ] Till Rohrmann commented on FLINK-21351: --- [~pnowojski] can you help with the review? > Incremental

[GitHub] [flink] rmetzger commented on a change in pull request #14923: [DRAFT] Remove State#onEnter

2021-02-18 Thread GitBox
rmetzger commented on a change in pull request #14923: URL: https://github.com/apache/flink/pull/14923#discussion_r578386398 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/declarative/DeclarativeScheduler.java ## @@ -887,19 +897,22 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #14962: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14962: URL: https://github.com/apache/flink/pull/14962#issuecomment-781306516 ## CI report: * fda5571674ea74fb5c104180e3790d45c600fbea Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14822: [FLINK-21005][table-api] Introduce new provider for unified Sink API and implement in planner

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14822: URL: https://github.com/apache/flink/pull/14822#issuecomment-770394744 ## CI report: * 4b0b591d6cc06d0eacc83f9277147d55af6ddf78 Azure:

[jira] [Commented] (FLINK-20427) Remove CheckpointConfig.setPreferCheckpointForRecovery because it can lead to data loss

2021-02-18 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286453#comment-17286453 ] Till Rohrmann commented on FLINK-20427: --- [~rex-remind], the sources are not affected by this

[jira] [Closed] (FLINK-21082) Document how to start multiple JobManagers in HA mode for Kubernetes deployment

2021-02-18 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-21082. - Resolution: Duplicate > Document how to start multiple JobManagers in HA mode for Kubernetes >

[jira] [Commented] (FLINK-21382) Standalone K8s documentation does not explain usage of standby JobManagers

2021-02-18 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286452#comment-17286452 ] Till Rohrmann commented on FLINK-21382: --- That's very good [~fly_in_gis]. I've actually overlooked

[jira] [Closed] (FLINK-18171) Do not take client side config options to cluster

2021-02-18 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-18171. - Resolution: Later > Do not take client side config options to cluster >

[jira] [Commented] (FLINK-21383) Docker image does not play well together with ConfigMap based flink-conf.yamls

2021-02-18 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286450#comment-17286450 ] Till Rohrmann commented on FLINK-21383: --- The failure messages are unfortunately not very

[jira] [Commented] (FLINK-18171) Do not take client side config options to cluster

2021-02-18 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286451#comment-17286451 ] Till Rohrmann commented on FLINK-18171: --- Alright, then I will close this issue and mark it as

[GitHub] [flink] flinkbot commented on pull request #14962: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client

2021-02-18 Thread GitBox
flinkbot commented on pull request #14962: URL: https://github.com/apache/flink/pull/14962#issuecomment-781306516 ## CI report: * fda5571674ea74fb5c104180e3790d45c600fbea UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14943: URL: https://github.com/apache/flink/pull/14943#issuecomment-779315285 ## CI report: * f80b97c479ec82663e971553c54c8a6cda3122ff UNKNOWN * 3e1cf6d7f7f645e991c0b788f653bab7b1baa797 Azure:

[GitHub] [flink] flinkbot commented on pull request #14962: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client

2021-02-18 Thread GitBox
flinkbot commented on pull request #14962: URL: https://github.com/apache/flink/pull/14962#issuecomment-781302347 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] fsk119 opened a new pull request #14962: [FLINK-18789][sql-client] Use TableEnvironment#executeSql method to execute insert statement in sql client

2021-02-18 Thread GitBox
fsk119 opened a new pull request #14962: URL: https://github.com/apache/flink/pull/14962 ## What is the purpose of the change *sql client has a lot of logic to execute an insert job, which can be simplified through executeSql method. This pr aims to do the improvement*

[GitHub] [flink] flinkbot edited a comment on pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14961: URL: https://github.com/apache/flink/pull/14961#issuecomment-781278553 ## CI report: * a35e534ab18f7d4c80a8ee52d7dd70b7e3a0f2a0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14954: [FLINK-17061][runtime] Unset TM total process/flink memory size for fine-grained resource management

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14954: URL: https://github.com/apache/flink/pull/14954#issuecomment-781063841 ## CI report: * de5409c4a93a18d7c664e6483036222985e673c4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14943: URL: https://github.com/apache/flink/pull/14943#issuecomment-779315285 ## CI report: * f80b97c479ec82663e971553c54c8a6cda3122ff UNKNOWN * fb2643d0aa19f9a4ea3106061c1f9c113abbd5d8 Azure:

[GitHub] [flink] dianfu closed pull request #14957: [FLINK-20534] Add Flink 1.12 MigrationVersion and add Flink 1.12 snapshots for TypeSerializer upgrade tests

2021-02-18 Thread GitBox
dianfu closed pull request #14957: URL: https://github.com/apache/flink/pull/14957 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] dianfu commented on pull request #14957: [FLINK-20534] Add Flink 1.12 MigrationVersion and add Flink 1.12 snapshots for TypeSerializer upgrade tests

2021-02-18 Thread GitBox
dianfu commented on pull request #14957: URL: https://github.com/apache/flink/pull/14957#issuecomment-781291040 Closed via 570e40c21560f5f2a2e270739f507708abeafb17 and 68e82653ce21a291ea61edccd0557ddfc5f91c05 This is an

[jira] [Closed] (FLINK-20534) Add Flink 1.12 MigrationVersion

2021-02-18 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-20534. --- Fix Version/s: (was: 1.12.0) 1.12.3 1.13.0 Resolution:

[jira] [Created] (FLINK-21397) BufferUnderflowException when read parquet

2021-02-18 Thread lihe ma (Jira)
lihe ma created FLINK-21397: --- Summary: BufferUnderflowException when read parquet Key: FLINK-21397 URL: https://issues.apache.org/jira/browse/FLINK-21397 Project: Flink Issue Type: Bug

[GitHub] [flink] dianfu closed pull request #14956: [FLINK-20534] Add Flink 1.12 MigrationVersion and add Flink 1.12 snapshots for TypeSerializer upgrade tests

2021-02-18 Thread GitBox
dianfu closed pull request #14956: URL: https://github.com/apache/flink/pull/14956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (FLINK-21108) Flink runtime rest server and history server webmonitor do not require authentication.

2021-02-18 Thread Xiaoguang Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286428#comment-17286428 ] Xiaoguang Sun commented on FLINK-21108: --- Hi [~trohrmann] I have done some work to make rest

[GitHub] [flink] tillrohrmann commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-18 Thread GitBox
tillrohrmann commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r578344017 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManager.java ## @@ -600,61 +603,69 @@

[GitHub] [flink] flinkbot commented on pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-02-18 Thread GitBox
flinkbot commented on pull request #14961: URL: https://github.com/apache/flink/pull/14961#issuecomment-781278553 ## CI report: * a35e534ab18f7d4c80a8ee52d7dd70b7e3a0f2a0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #14960: fix scrolling issue in Firefox

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14960: URL: https://github.com/apache/flink/pull/14960#issuecomment-781267077 ## CI report: * c195cee17a3fa141bcf497f137495a54e55041f7 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14957: [FLINK-20534] Add Flink 1.12 MigrationVersion and add Flink 1.12 snapshots for TypeSerializer upgrade tests

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14957: URL: https://github.com/apache/flink/pull/14957#issuecomment-781106649 ## CI report: * dc2f8d2db78483a1d21a376ac0ff36da497f977d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14956: [FLINK-20534] Add Flink 1.12 MigrationVersion and add Flink 1.12 snapshots for TypeSerializer upgrade tests

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14956: URL: https://github.com/apache/flink/pull/14956#issuecomment-781106539 ## CI report: * a05e0c6456256e78658fbfceb4a9dfcb72fe2728 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14954: [FLINK-17061][runtime] Unset TM total process/flink memory size for fine-grained resource management

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14954: URL: https://github.com/apache/flink/pull/14954#issuecomment-781063841 ## CI report: * 6746ea0922384476c2f9f4ad4fcae1273811201f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14953: [FLINK-21351][checkpointing] Don't subsume last checkpoint

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14953: URL: https://github.com/apache/flink/pull/14953#issuecomment-780752668 ## CI report: * 941374ecdd03b5ceb9245e4d8a8370671b691a34 UNKNOWN * b495b70cd52846372f8e14cd08facd234235f984 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14946: [FLINK-21381][docs] Add information about service account permissions to K8s HA service documentation

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14946: URL: https://github.com/apache/flink/pull/14946#issuecomment-779866080 ## CI report: * 3acf861c7e288f9ce7c3b0fec5bc513c75ea8f18 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14897: URL: https://github.com/apache/flink/pull/14897#issuecomment-775050448 ## CI report: * 35644082e06622b2182b6fb68d9a30df167d5c11 Azure:

[GitHub] [flink] flinkbot commented on pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-02-18 Thread GitBox
flinkbot commented on pull request #14961: URL: https://github.com/apache/flink/pull/14961#issuecomment-781272978 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] echauchot commented on pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-02-18 Thread GitBox
echauchot commented on pull request #14961: URL: https://github.com/apache/flink/pull/14961#issuecomment-781272437 @HuangZhenQiu can you ping a committer as you proposed to review this PR ? Thanks This is an automated

[jira] [Updated] (FLINK-21388) Parquet DECIMAL logical type is not properly supported in ParquetSchemaConverter

2021-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21388: --- Labels: pull-request-available (was: ) > Parquet DECIMAL logical type is not properly

[GitHub] [flink] echauchot opened a new pull request #14961: [FLINK-21388] [flink-parquet] support DECIMAL parquet logical type when parquet primitive type is INT32

2021-02-18 Thread GitBox
echauchot opened a new pull request #14961: URL: https://github.com/apache/flink/pull/14961 ## What is the purpose of the change support DECIMAL parquet logical type when parquet primitive type is INT32 ## Brief change log The support for INT64 was already done

[jira] [Created] (FLINK-21396) Update the Catalog APIs

2021-02-18 Thread Timo Walther (Jira)
Timo Walther created FLINK-21396: Summary: Update the Catalog APIs Key: FLINK-21396 URL: https://issues.apache.org/jira/browse/FLINK-21396 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-21395) Implement Schema, ResolvedSchema, SchemaResolver

2021-02-18 Thread Timo Walther (Jira)
Timo Walther created FLINK-21395: Summary: Implement Schema, ResolvedSchema, SchemaResolver Key: FLINK-21395 URL: https://issues.apache.org/jira/browse/FLINK-21395 Project: Flink Issue Type:

[jira] [Created] (FLINK-21394) FLIP-164: Improve Schema Handling in Catalogs

2021-02-18 Thread Timo Walther (Jira)
Timo Walther created FLINK-21394: Summary: FLIP-164: Improve Schema Handling in Catalogs Key: FLINK-21394 URL: https://issues.apache.org/jira/browse/FLINK-21394 Project: Flink Issue Type:

[GitHub] [flink] flinkbot commented on pull request #14960: fix scrolling issue in Firefox

2021-02-18 Thread GitBox
flinkbot commented on pull request #14960: URL: https://github.com/apache/flink/pull/14960#issuecomment-781267077 ## CI report: * c195cee17a3fa141bcf497f137495a54e55041f7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #14955: [FLINK-14869][core] Discard zero-valued extended resources in ResourceSpec/ResourceProfile

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14955: URL: https://github.com/apache/flink/pull/14955#issuecomment-781090588 ## CI report: * 216d83acae21669fd504d4562524a7e9276062a8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14950: URL: https://github.com/apache/flink/pull/14950#issuecomment-780431068 ## CI report: * bee61356ebeb5f99c96ce3193b3bd8205e61e44d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14946: [FLINK-21381][docs] Add information about service account permissions to K8s HA service documentation

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14946: URL: https://github.com/apache/flink/pull/14946#issuecomment-779866080 ## CI report: * 3acf861c7e288f9ce7c3b0fec5bc513c75ea8f18 Azure:

[GitHub] [flink] curcur commented on a change in pull request #14799: [FLINK-21354][WIP] Wrapped StateBackend to forward state changes to StateChangleLog

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14799: URL: https://github.com/apache/flink/pull/14799#discussion_r578323771 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimeServiceManagerImpl.java ## @@ -99,23 +101,30 @@

[GitHub] [flink] curcur commented on a change in pull request #14799: [FLINK-21354][WIP] Wrapped StateBackend to forward state changes to StateChangleLog

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14799: URL: https://github.com/apache/flink/pull/14799#discussion_r578323324 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorageLoader.java ## @@ -162,14 +163,19 @@ public static

[GitHub] [flink] flinkbot edited a comment on pull request #14959: [FLINK-16947][Azure] Attempt to fix maven network issues

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14959: URL: https://github.com/apache/flink/pull/14959#issuecomment-781241815 ## CI report: * 3e3889ee5cc45f7d8dd654b9c5296a80ab6e88e0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14950: URL: https://github.com/apache/flink/pull/14950#issuecomment-780431068 ## CI report: * bee61356ebeb5f99c96ce3193b3bd8205e61e44d Azure:

[GitHub] [flink] tillrohrmann commented on pull request #14946: [FLINK-21381][docs] Add information about service account permissions to K8s HA service documentation

2021-02-18 Thread GitBox
tillrohrmann commented on pull request #14946: URL: https://github.com/apache/flink/pull/14946#issuecomment-781252287 Thanks for the review @XComp and @wangyang0918. I have updated the documentation. Please take another look whether it is now clearer.

[GitHub] [flink] flinkbot edited a comment on pull request #14953: [FLINK-21351][checkpointing] Don't subsume last checkpoint

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14953: URL: https://github.com/apache/flink/pull/14953#issuecomment-780752668 ## CI report: * 941374ecdd03b5ceb9245e4d8a8370671b691a34 UNKNOWN * b495b70cd52846372f8e14cd08facd234235f984 Azure:

[GitHub] [flink] lovelock commented on pull request #14848: [FLINK-21268]Fix scrolling issue in Firefox

2021-02-18 Thread GitBox
lovelock commented on pull request #14848: URL: https://github.com/apache/flink/pull/14848#issuecomment-781251547 @vthinkxie please see this https://github.com/apache/flink/pull/14960 This is an automated message from the

[GitHub] [flink] lovelock closed pull request #14848: [FLINK-21268]Fix scrolling issue in Firefox

2021-02-18 Thread GitBox
lovelock closed pull request #14848: URL: https://github.com/apache/flink/pull/14848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] flinkbot commented on pull request #14960: fix scrolling issue in Firefox

2021-02-18 Thread GitBox
flinkbot commented on pull request #14960: URL: https://github.com/apache/flink/pull/14960#issuecomment-781251002 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] lovelock opened a new pull request #14960: fix scrolling issue in Firefox

2021-02-18 Thread GitBox
lovelock opened a new pull request #14960: URL: https://github.com/apache/flink/pull/14960 ## What is the purpose of the change 1. Fix scrolling bug in Firefox. Logs view both in TaskManager and JobManager can't scroll with mouse in Firefox because of the bug in

[jira] [Commented] (FLINK-21362) Remove State#onEnter

2021-02-18 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286405#comment-17286405 ] Robert Metzger commented on FLINK-21362: Draft PR: https://github.com/apache/flink/pull/14923

[GitHub] [flink] rmetzger commented on pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
rmetzger commented on pull request #14950: URL: https://github.com/apache/flink/pull/14950#issuecomment-781246489 Rebased onto DeclScheduler merge on master This is an automated message from the Apache Git Service. To

[GitHub] [flink] flinkbot commented on pull request #14959: [FLINK-16947][Azure] Attempt to fix maven network issues

2021-02-18 Thread GitBox
flinkbot commented on pull request #14959: URL: https://github.com/apache/flink/pull/14959#issuecomment-781241815 ## CI report: * 3e3889ee5cc45f7d8dd654b9c5296a80ab6e88e0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #14916: [FLINK-21345][Table SQL / Planner] Fix BUG of Union All join Temporal…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14916: URL: https://github.com/apache/flink/pull/14916#issuecomment-776614443 ## CI report: * bf763e66a66853764f8bb39c07db8d86c98916aa Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14838: [FLINK-19503][state] Add StateChangelog API

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14838: URL: https://github.com/apache/flink/pull/14838#issuecomment-772060058 ## CI report: * f560722ab6bbf452340228a2c88e025ecc797274 UNKNOWN * 42dd6bd7e4e64b3ff0ecf5156cae0f860226d629 Azure:

[GitHub] [flink] tillrohrmann commented on a change in pull request #14946: [FLINK-21381][docs] Add information about service account permissions to K8s HA service documentation

2021-02-18 Thread GitBox
tillrohrmann commented on a change in pull request #14946: URL: https://github.com/apache/flink/pull/14946#discussion_r578292069 ## File path: docs/content.zh/docs/deployment/ha/kubernetes_ha.md ## @@ -31,6 +31,14 @@ Flink's Kubernetes HA services use

[GitHub] [flink] lovelock commented on pull request #14848: [FLINK-21268]Fix scrolling issue in Firefox

2021-02-18 Thread GitBox
lovelock commented on pull request #14848: URL: https://github.com/apache/flink/pull/14848#issuecomment-781235336 > Hi @lovelock > `@ant-design/icons-angular` is the dependency of ng-zorro-antd, which should be installed automatically. > can you check your npm version via run `npm

[GitHub] [flink] lovelock commented on pull request #14848: [FLINK-21268]Fix scrolling issue in Firefox

2021-02-18 Thread GitBox
lovelock commented on pull request #14848: URL: https://github.com/apache/flink/pull/14848#issuecomment-781232691 I've hidden 3 abused comments by myself because all the errors I run into are because network problem. However `git-commit-id-plugin` would cause OOM error because of network

[GitHub] [flink] flinkbot edited a comment on pull request #14954: [FLINK-17061][runtime] Unset TM total process/flink memory size for fine-grained resource management

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14954: URL: https://github.com/apache/flink/pull/14954#issuecomment-781063841 ## CI report: * 6746ea0922384476c2f9f4ad4fcae1273811201f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14928: [FLINK-21360][coordination] Make resource timeout configurable

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14928: URL: https://github.com/apache/flink/pull/14928#issuecomment-14828 ## CI report: * fa4a474ab1addab8caafd64686a1a9d029843556 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14950: URL: https://github.com/apache/flink/pull/14950#issuecomment-780431068 ## CI report: * bee61356ebeb5f99c96ce3193b3bd8205e61e44d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14916: [FLINK-21345][Table SQL / Planner] Fix BUG of Union All join Temporal…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14916: URL: https://github.com/apache/flink/pull/14916#issuecomment-776614443 ## CI report: * bf763e66a66853764f8bb39c07db8d86c98916aa Azure:

[jira] [Commented] (FLINK-21319) hadoop-mapreduce jars are not loaded into classpath when submiting flink on yarn jobs.

2021-02-18 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286398#comment-17286398 ] Till Rohrmann commented on FLINK-21319: --- I don't know what kind of job you are running but Flink

[GitHub] [flink] flinkbot edited a comment on pull request #14838: [FLINK-19503][state] Add StateChangelog API

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14838: URL: https://github.com/apache/flink/pull/14838#issuecomment-772060058 ## CI report: * f560722ab6bbf452340228a2c88e025ecc797274 UNKNOWN * 42dd6bd7e4e64b3ff0ecf5156cae0f860226d629 Azure:

[GitHub] [flink] flinkbot commented on pull request #14959: [FLINK-16947][Azure] Attempt to fix maven network issues

2021-02-18 Thread GitBox
flinkbot commented on pull request #14959: URL: https://github.com/apache/flink/pull/14959#issuecomment-781217170 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] syucream commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2021-02-18 Thread GitBox
syucream commented on pull request #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-781216459 Any progress? This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (FLINK-16947) ArtifactResolutionException: Could not transfer artifact. Entry [...] has not been leased from this pool

2021-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-16947: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] rmetzger opened a new pull request #14959: [FLINK-16947][Azure] Attempt to fix maven network issues

2021-02-18 Thread GitBox
rmetzger opened a new pull request #14959: URL: https://github.com/apache/flink/pull/14959 This updates the base docker image to use a modified maven version with a fixed http wagon version. Diff on the Dockerfile: ```diff diff --git a/Dockerfile b/Dockerfile index

<    1   2   3   4   5   >