[GitHub] [flink] rkhachatryan commented on a change in pull request #15046: [hotfix][state] Remove hardcoded backend class name check

2021-02-28 Thread GitBox
rkhachatryan commented on a change in pull request #15046: URL: https://github.com/apache/flink/pull/15046#discussion_r584506052 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java ## @@ -349,7 +349,12 @@ public int

[GitHub] [flink] XComp commented on a change in pull request #15049: [FLINK-21190][runtime-web] Expose exception history

2021-02-28 Thread GitBox
XComp commented on a change in pull request #15049: URL: https://github.com/apache/flink/pull/15049#discussion_r584503804 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobExceptionsInfo.java ## @@ -100,6 +121,11 @@ public boolean

[GitHub] [flink] rkhachatryan commented on a change in pull request #14943: [FLINK-21354] Introduce ChangelogStateBackend to delegate state access

2021-02-28 Thread GitBox
rkhachatryan commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r584503879 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/util/StateConfigUtil.java ## @@ -46,19 +46,24 @@

[GitHub] [flink] XComp commented on a change in pull request #15049: [FLINK-21190][runtime-web] Expose exception history

2021-02-28 Thread GitBox
XComp commented on a change in pull request #15049: URL: https://github.com/apache/flink/pull/15049#discussion_r584503804 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobExceptionsInfo.java ## @@ -100,6 +121,11 @@ public boolean

[GitHub] [flink] flinkbot commented on pull request #15050: [FLINK-21531][table-planner-blink][table-api-java][hive] Introduce pluggable Parser

2021-02-28 Thread GitBox
flinkbot commented on pull request #15050: URL: https://github.com/apache/flink/pull/15050#issuecomment-787736322 ## CI report: * e096dadbeef7c6c2e6c3f79edd9b090a1374616f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #15047: [FLINK-21502][coordination] Reduce frequency of global re-allocate re…

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #15047: URL: https://github.com/apache/flink/pull/15047#issuecomment-787603325 ## CI report: * ec740e36bf9c727139ed108ac44c9aca0f7c6838 UNKNOWN * a9f91f45d9db4c5382311313f17116f4ee5c6f51 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15049: [FLINK-21190][runtime-web] Expose exception history

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #15049: URL: https://github.com/apache/flink/pull/15049#issuecomment-787719691 ## CI report: * 2cbffce55c35f7e163739d07f88e480870a0fc37 UNKNOWN * 062b00b1d7630ebec00e4892195a0ac94824884b UNKNOWN Bot commands The

[GitHub] [flink] flinkbot edited a comment on pull request #15027: [FLINK-21509][python] Add 'withProcessingTime()' method call when creating proctime slide window assigner in 'StreamExecPythonGroupWi

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #15027: URL: https://github.com/apache/flink/pull/15027#issuecomment-786485028 ## CI report: * 9524d19b147288bf7151479926cb4d8909b37fb0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14840: [FLINK-21231][sql-client] add "SHOW VIEWS" to SQL client

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #14840: URL: https://github.com/apache/flink/pull/14840#issuecomment-772110005 ## CI report: * 7ae1c97a2632e96538cd117a251ae91344576706 Azure:

[GitHub] [flink] Myasuka commented on a change in pull request #15046: [hotfix][state] Remove hardcoded backend class name check

2021-02-28 Thread GitBox
Myasuka commented on a change in pull request #15046: URL: https://github.com/apache/flink/pull/15046#discussion_r584502814 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java ## @@ -349,7 +349,12 @@ public int

[GitHub] [flink] Myasuka removed a comment on pull request #15046: [hotfix][state] Remove hardcoded backend class name check

2021-02-28 Thread GitBox
Myasuka removed a comment on pull request #15046: URL: https://github.com/apache/flink/pull/15046#issuecomment-787734053 LGTM, +1 to merge. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] Myasuka commented on pull request #15046: [hotfix][state] Remove hardcoded backend class name check

2021-02-28 Thread GitBox
Myasuka commented on pull request #15046: URL: https://github.com/apache/flink/pull/15046#issuecomment-787734053 LGTM, +1 to merge. This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (FLINK-21532) Make CatalogTableImpl#toProperties and CatalogTableImpl#fromProperties case sensitive

2021-02-28 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292693#comment-17292693 ] Timo Walther commented on FLINK-21532: -- Maybe [~jark] has some more insights how users define their

[jira] [Updated] (FLINK-21511) Flink connector elasticsearch 6.x has a bug about BulkProcessor hangs for threads deadlocked

2021-02-28 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-21511: - Affects Version/s: (was: 1.11.2) (was: 1.11.1)

[GitHub] [flink] flinkbot commented on pull request #15050: [FLINK-21531][table-planner-blink][table-api-java][hive] Introduce pluggable Parser

2021-02-28 Thread GitBox
flinkbot commented on pull request #15050: URL: https://github.com/apache/flink/pull/15050#issuecomment-787732798 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Comment Edited] (FLINK-21532) Make CatalogTableImpl#toProperties and CatalogTableImpl#fromProperties case sensitive

2021-02-28 Thread Lsw_aka_laplace (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292688#comment-17292688 ] Lsw_aka_laplace edited comment on FLINK-21532 at 3/1/21, 7:45 AM: --

[jira] [Commented] (FLINK-21532) Make CatalogTableImpl#toProperties and CatalogTableImpl#fromProperties case sensitive

2021-02-28 Thread Lsw_aka_laplace (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292688#comment-17292688 ] Lsw_aka_laplace commented on FLINK-21532: - [~twalthr] Thx for ur reply.  Well, for the current

[jira] [Comment Edited] (FLINK-21532) Make CatalogTableImpl#toProperties and CatalogTableImpl#fromProperties case sensitive

2021-02-28 Thread Lsw_aka_laplace (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292688#comment-17292688 ] Lsw_aka_laplace edited comment on FLINK-21532 at 3/1/21, 7:43 AM: --

[jira] [Updated] (FLINK-21531) Introduce pluggable Parser

2021-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21531: --- Labels: pull-request-available (was: ) > Introduce pluggable Parser >

[jira] [Commented] (FLINK-21532) Make CatalogTableImpl#toProperties and CatalogTableImpl#fromProperties case sensitive

2021-02-28 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292685#comment-17292685 ] Timo Walther commented on FLINK-21532: -- [~neighborhood] This issue should belong to the past after

[GitHub] [flink] lirui-apache opened a new pull request #15050: [FLINK-21531][table-planner-blink][table-api-java][hive] Introduce pluggable Parser

2021-02-28 Thread GitBox
lirui-apache opened a new pull request #15050: URL: https://github.com/apache/flink/pull/15050 ## What is the purpose of the change Introduce pluggable `Parser` and add simple implementation for hive. ## Brief change log - Add `ParserFactory` interface

[jira] [Commented] (FLINK-21532) Make CatalogTableImpl#toProperties and CatalogTableImpl#fromProperties case sensitive

2021-02-28 Thread Lsw_aka_laplace (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292681#comment-17292681 ] Lsw_aka_laplace commented on FLINK-21532: - [~twalthr] Would u mind having a discussion on this

[jira] [Updated] (FLINK-21529) [Umbrella] Hive Query Syntax Compatibility

2021-02-28 Thread Rui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Li updated FLINK-21529: --- Summary: [Umbrella] Hive Query Syntax Compatibility (was: FLIP-152: Hive Query Syntax Compatibility) >

[GitHub] [flink] flinkbot commented on pull request #15049: [FLINK-21190][runtime-web] Expose exception history

2021-02-28 Thread GitBox
flinkbot commented on pull request #15049: URL: https://github.com/apache/flink/pull/15049#issuecomment-787719691 ## CI report: * 2cbffce55c35f7e163739d07f88e480870a0fc37 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #15027: [FLINK-21509][python] Add 'withProcessingTime()' method call when creating proctime slide window assigner in 'StreamExecPythonGroupWi

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #15027: URL: https://github.com/apache/flink/pull/15027#issuecomment-786485028 ## CI report: * 9524d19b147288bf7151479926cb4d8909b37fb0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15028: [FLINK-21115][python] Add AggregatingState and corresponding StateDescriptor for Python DataStream API

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #15028: URL: https://github.com/apache/flink/pull/15028#issuecomment-786507942 ## CI report: * f0e7fd3639f4a804c831abbd2dcfc68a20afe7bb Azure:

[jira] [Commented] (FLINK-21532) Make CatalogTableImpl#toProperties and CatalogTableImpl#fromProperties case sensitive

2021-02-28 Thread Lsw_aka_laplace (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292679#comment-17292679 ] Lsw_aka_laplace commented on FLINK-21532: - [~jark] Would u mind @ guys who relate this

[jira] [Updated] (FLINK-21532) Make CatalogTableImpl#toProperties and CatalogTableImpl#fromProperties case sensitive

2021-02-28 Thread Lsw_aka_laplace (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lsw_aka_laplace updated FLINK-21532: Description: For now, both legacy Table/SQL API and implementation and current Table/SQL

[jira] [Updated] (FLINK-21532) Make CatalogTableImpl#toProperties and CatalogTableImpl#fromProperties case sensitive

2021-02-28 Thread Lsw_aka_laplace (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lsw_aka_laplace updated FLINK-21532: Description: For now, both legacy Table/SQL API and implementation and current Table/SQL

[jira] [Commented] (FLINK-21512) flink MemorySize.parseBytes bug if users use it by setting dynamic properties like

2021-02-28 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292677#comment-17292677 ] Xintong Song commented on FLINK-21512: -- Hi [~jackylau], Could you share more details on how you

[jira] [Updated] (FLINK-21532) Make CatalogTableImpl#toProperties and CatalogTableImpl#fromProperties case sensitive

2021-02-28 Thread Lsw_aka_laplace (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lsw_aka_laplace updated FLINK-21532: Description: For now, both legacy Table/SQL API and implementation and current Table/SQL

[GitHub] [flink] XComp commented on a change in pull request #15049: [FLINK-21190][runtime-web] Expose exception history

2021-02-28 Thread GitBox
XComp commented on a change in pull request #15049: URL: https://github.com/apache/flink/pull/15049#discussion_r584484818 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobExceptionsHandlerTest.java ## @@ -79,26 +113,35 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #15028: [FLINK-21115][python] Add AggregatingState and corresponding StateDescriptor for Python DataStream API

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #15028: URL: https://github.com/apache/flink/pull/15028#issuecomment-786507942 ## CI report: * f0e7fd3639f4a804c831abbd2dcfc68a20afe7bb Azure:

[GitHub] [flink] XComp commented on a change in pull request #15049: [FLINK-21190][runtime-web] Expose exception history

2021-02-28 Thread GitBox
XComp commented on a change in pull request #15049: URL: https://github.com/apache/flink/pull/15049#discussion_r584484526 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/history/OnlyExecutionGraphJsonArchivist.java ## @@ -0,0 +1,53 @@ +/* + *

[jira] [Updated] (FLINK-21509) "w.start" returns "1970-01-01" when used with Pandas UDAF after grouping by slide window with processing time

2021-02-28 Thread Wei Zhong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zhong updated FLINK-21509: -- Affects Version/s: (was: 1.12.1) > "w.start" returns "1970-01-01" when used with Pandas UDAF

[jira] [Updated] (FLINK-21190) Expose extended exception history through REST handler and adapt UI accordingly

2021-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21190: --- Labels: pull-request-available (was: ) > Expose extended exception history through REST

[GitHub] [flink] XComp opened a new pull request #15049: [FLINK-21190][runtime-web] Expose exception history

2021-02-28 Thread GitBox
XComp opened a new pull request #15049: URL: https://github.com/apache/flink/pull/15049 ## What is the purpose of the change Draft PR for discussing the approach of exposing the exception history. ## Brief change log * ❗ needs to be updated ## Verifying this

[jira] [Updated] (FLINK-21531) Introduce pluggable Parser

2021-02-28 Thread Rui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Li updated FLINK-21531: --- Component/s: Connectors / Hive > Introduce pluggable Parser > -- > >

[jira] [Created] (FLINK-21532) Make CatalogTableImpl#toProperties and CatalogTableImpl#fromProperties case sensitive

2021-02-28 Thread Lsw_aka_laplace (Jira)
Lsw_aka_laplace created FLINK-21532: --- Summary: Make CatalogTableImpl#toProperties and CatalogTableImpl#fromProperties case sensitive Key: FLINK-21532 URL: https://issues.apache.org/jira/browse/FLINK-21532

[GitHub] [flink] flinkbot commented on pull request #15049: [FLINK-21190][runtime-web] Expose exception history

2021-02-28 Thread GitBox
flinkbot commented on pull request #15049: URL: https://github.com/apache/flink/pull/15049#issuecomment-787705992 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] WeiZhong94 commented on pull request #15028: [FLINK-21115][python] Add AggregatingState and corresponding StateDescriptor for Python DataStream API

2021-02-28 Thread GitBox
WeiZhong94 commented on pull request #15028: URL: https://github.com/apache/flink/pull/15028#issuecomment-787702491 @HuangXingBo Thanks for your comments. I have updated this PR. This is an automated message from the Apache

[GitHub] [flink] xintongsong commented on a change in pull request #15047: [FLINK-21502][coordination] Reduce frequency of global re-allocate re…

2021-02-28 Thread GitBox
xintongsong commented on a change in pull request #15047: URL: https://github.com/apache/flink/pull/15047#discussion_r584475304 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java ## @@ -594,6 +608,30 @@

[GitHub] [flink] flinkbot edited a comment on pull request #15048: [FLINK-21477][table-planner-blink] Lookup joins now deal with intermediate table scans containing just the table source correctly

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #15048: URL: https://github.com/apache/flink/pull/15048#issuecomment-787621304 ## CI report: * eaf149cccb97ef7f66d4698a56c510ddbee18065 Azure:

[jira] [Updated] (FLINK-21530) Precompute TypeName's canonical string representation

2021-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21530: --- Labels: pull-request-available (was: ) > Precompute TypeName's canonical string

[GitHub] [flink-statefun] tzulitai opened a new pull request #204: [FLINK-21530] Precompute TypeName's canonical representation

2021-02-28 Thread GitBox
tzulitai opened a new pull request #204: URL: https://github.com/apache/flink-statefun/pull/204 There's room for improvement in `PersistedRemoteFunctionValues`, where we currently concatenate strings to build the typename string for each state value we attach to a `ToFunction` message.

[jira] [Created] (FLINK-21531) Introduce pluggable Parser

2021-02-28 Thread Rui Li (Jira)
Rui Li created FLINK-21531: -- Summary: Introduce pluggable Parser Key: FLINK-21531 URL: https://issues.apache.org/jira/browse/FLINK-21531 Project: Flink Issue Type: Sub-task Components:

[jira] [Created] (FLINK-21530) Precompute TypeName's canonical string representation

2021-02-28 Thread Tzu-Li (Gordon) Tai (Jira)
Tzu-Li (Gordon) Tai created FLINK-21530: --- Summary: Precompute TypeName's canonical string representation Key: FLINK-21530 URL: https://issues.apache.org/jira/browse/FLINK-21530 Project: Flink

[jira] [Updated] (FLINK-21523) ArrayIndexOutOfBoundsException occurs while run a hive streaming job with partitioned table source

2021-02-28 Thread zouyunhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zouyunhe updated FLINK-21523: - Description: we have two hive table, the ddl as below {code:java} //test_tbl5 create table test.test_5

[GitHub] [flink] flinkbot edited a comment on pull request #15048: [FLINK-21477][table-planner-blink] Lookup joins now deal with intermediate table scans containing just the table source correctly

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #15048: URL: https://github.com/apache/flink/pull/15048#issuecomment-787621304 ## CI report: * eaf149cccb97ef7f66d4698a56c510ddbee18065 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14977: [FLINK-18726][table-planner-blink] Support INSERT INTO specific colum…

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #14977: URL: https://github.com/apache/flink/pull/14977#issuecomment-783054931 ## CI report: * cbb43f980354f2a108ec2f40fe4e7c194c7f73a1 Azure:

[jira] [Created] (FLINK-21529) FLIP-152: Hive Query Syntax Compatibility

2021-02-28 Thread Rui Li (Jira)
Rui Li created FLINK-21529: -- Summary: FLIP-152: Hive Query Syntax Compatibility Key: FLINK-21529 URL: https://issues.apache.org/jira/browse/FLINK-21529 Project: Flink Issue Type: New Feature

[GitHub] [flink] flinkbot edited a comment on pull request #15046: [hotfix][state] Remove hardcoded backend class name check

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #15046: URL: https://github.com/apache/flink/pull/15046#issuecomment-787541270 ## CI report: * bfa4f8e54378936a1b8184d19673674b8f4c33ff Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14977: [FLINK-18726][table-planner-blink] Support INSERT INTO specific colum…

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #14977: URL: https://github.com/apache/flink/pull/14977#issuecomment-783054931 ## CI report: * cbb43f980354f2a108ec2f40fe4e7c194c7f73a1 Azure:

[GitHub] [flink] wuchong commented on pull request #15018: [FLINK-21460][table api] Use Configuration to create TableEnvironment

2021-02-28 Thread GitBox
wuchong commented on pull request #15018: URL: https://github.com/apache/flink/pull/15018#issuecomment-787656476 I agree with @twalthr . Current approach is a bit complex and easy to have bugs. Validating the configuration when executing is an easy way to support this. From my perpective,

[jira] [Updated] (FLINK-21324) statefun-testutil can't assert messages function sends to itself

2021-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21324: --- Labels: pull-request-available (was: ) > statefun-testutil can't assert messages function

[GitHub] [flink-statefun] tzulitai commented on pull request #199: [FLINK-21324] fix assertions for messages function sends to itself

2021-02-28 Thread GitBox
tzulitai commented on pull request #199: URL: https://github.com/apache/flink-statefun/pull/199#issuecomment-787655343 I do agree that the contract of `FunctionTestHarness.invoke()` should include messages sent to the same function instance, as part of the returned responses map.

[GitHub] [flink-statefun] tzulitai commented on a change in pull request #200: [FLINK-21422][docs] Migrate docs to Hugo

2021-02-28 Thread GitBox
tzulitai commented on a change in pull request #200: URL: https://github.com/apache/flink-statefun/pull/200#discussion_r584454728 ## File path: tools/ci/docs.sh ## @@ -17,29 +17,22 @@ # limitations under the License.

[GitHub] [flink] crazyzhou commented on pull request #14890: [FLINK-21178][Runtime/Checkpointing] Task failure should trigger master hook's reset()

2021-02-28 Thread GitBox
crazyzhou commented on pull request #14890: URL: https://github.com/apache/flink/pull/14890#issuecomment-787648466 @StephanEwen @becketqin Can you assign this Flink jira ticket to me and are there any more concerns about this pull request? If we are fine about this, can we merge it now

[GitHub] [flink] docete commented on a change in pull request #14977: [FLINK-18726][table-planner-blink] Support INSERT INTO specific colum…

2021-02-28 Thread GitBox
docete commented on a change in pull request #14977: URL: https://github.com/apache/flink/pull/14977#discussion_r584449925 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/table/TableSinkITCase.scala ## @@ -207,4

[GitHub] [flink] flinkbot edited a comment on pull request #15048: [FLINK-21477][table-planner-blink] Lookup joins now deal with intermediate table scans containing just the table source correctly

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #15048: URL: https://github.com/apache/flink/pull/15048#issuecomment-787621304 ## CI report: * eaf149cccb97ef7f66d4698a56c510ddbee18065 Azure:

[jira] [Closed] (FLINK-21498) Avoid copying when converting byte[] to ByteString in StateFun

2021-02-28 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-21498. --- Fix Version/s: statefun-3.0.0 Resolution: Fixed flink-statefun/master:

[GitHub] [flink-statefun] tzulitai closed pull request #203: [FLINK-21498] Avoid copying when converting byte[] to ByteString

2021-02-28 Thread GitBox
tzulitai closed pull request #203: URL: https://github.com/apache/flink-statefun/pull/203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Introduce ChangelogStateBackend to delegate state access

2021-02-28 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r584440186 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackendLoader.java ## @@ -249,6 +266,66 @@ public static StateBackend

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Introduce ChangelogStateBackend to delegate state access

2021-02-28 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r584026554 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java ## @@ -136,6 +138,15 @@ */ boolean

[GitHub] [flink] flinkbot edited a comment on pull request #15048: [FLINK-21477][table-planner-blink] Lookup joins now deal with intermediate table scans containing just the table source correctly

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #15048: URL: https://github.com/apache/flink/pull/15048#issuecomment-787621304 ## CI report: * eaf149cccb97ef7f66d4698a56c510ddbee18065 Azure:

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Introduce ChangelogStateBackend to delegate state access

2021-02-28 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r584026554 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java ## @@ -136,6 +138,15 @@ */ boolean

[jira] [Commented] (FLINK-21382) Standalone K8s documentation does not explain usage of standby JobManagers

2021-02-28 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292597#comment-17292597 ] Yang Wang commented on FLINK-21382: --- [~chesnay] Thanks for the kind reminding. I will try to find some

[GitHub] [flink] wuchong commented on a change in pull request #15005: [FLINK-21298][table] Support 'USE MODULES' syntax both in SQL parser, TableEnvironment and SQL CLI

2021-02-28 Thread GitBox
wuchong commented on a change in pull request #15005: URL: https://github.com/apache/flink/pull/15005#discussion_r584435518 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala ## @@ -592,6 +593,66 @@ class

[jira] [Created] (FLINK-21528) Rest Api Support Wildcard

2021-02-28 Thread wxmimperio (Jira)
wxmimperio created FLINK-21528: -- Summary: Rest Api Support Wildcard Key: FLINK-21528 URL: https://issues.apache.org/jira/browse/FLINK-21528 Project: Flink Issue Type: Improvement

[GitHub] [flink] flinkbot commented on pull request #15048: [FLINK-21477][table-planner-blink] Lookup joins now deal with intermediate table scans containing just the table source correctly

2021-02-28 Thread GitBox
flinkbot commented on pull request #15048: URL: https://github.com/apache/flink/pull/15048#issuecomment-787621304 ## CI report: * eaf149cccb97ef7f66d4698a56c510ddbee18065 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] wuchong commented on a change in pull request #15005: [FLINK-21298][table] Support 'USE MODULES' syntax both in SQL parser, TableEnvironment and SQL CLI

2021-02-28 Thread GitBox
wuchong commented on a change in pull request #15005: URL: https://github.com/apache/flink/pull/15005#discussion_r584432452 ## File path: flink-table/flink-sql-parser-hive/src/main/codegen/data/Parser.tdd ## @@ -129,6 +130,7 @@ "LINES" "LOAD" "LOCATION" +

[jira] [Updated] (FLINK-21434) When UDAF return ROW type, and the number of fields is more than 14, the crash happend

2021-02-28 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-21434: Fix Version/s: 1.12.3 1.13.0 > When UDAF return ROW type, and the number of fields is

[GitHub] [flink] dianfu commented on a change in pull request #14741: [FLINK-21021][python] Bump Beam to 2.27.0

2021-02-28 Thread GitBox
dianfu commented on a change in pull request #14741: URL: https://github.com/apache/flink/pull/14741#discussion_r584429699 ## File path: flink-python/setup.py ## @@ -321,12 +321,11 @@ def find_file_path(pattern): license='https://www.apache.org/licenses/LICENSE-2.0',

[GitHub] [flink] dianfu commented on a change in pull request #14741: [FLINK-21021][python] Bump Beam to 2.27.0

2021-02-28 Thread GitBox
dianfu commented on a change in pull request #14741: URL: https://github.com/apache/flink/pull/14741#discussion_r584429699 ## File path: flink-python/setup.py ## @@ -321,12 +321,11 @@ def find_file_path(pattern): license='https://www.apache.org/licenses/LICENSE-2.0',

[GitHub] [flink] flinkbot edited a comment on pull request #15047: [FLINK-21502][coordination] Reduce frequency of global re-allocate re…

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #15047: URL: https://github.com/apache/flink/pull/15047#issuecomment-787603325 ## CI report: * ec740e36bf9c727139ed108ac44c9aca0f7c6838 UNKNOWN * a9f91f45d9db4c5382311313f17116f4ee5c6f51 Azure:

[GitHub] [flink] wuchong commented on a change in pull request #15005: [FLINK-21298][table] Support 'USE MODULES' syntax both in SQL parser, TableEnvironment and SQL CLI

2021-02-28 Thread GitBox
wuchong commented on a change in pull request #15005: URL: https://github.com/apache/flink/pull/15005#discussion_r584428711 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java ## @@ -428,6 +429,13 @@ public

[jira] [Created] (FLINK-21527) fromValues function cost enormous network buffer

2021-02-28 Thread Spongebob (Jira)
Spongebob created FLINK-21527: - Summary: fromValues function cost enormous network buffer Key: FLINK-21527 URL: https://issues.apache.org/jira/browse/FLINK-21527 Project: Flink Issue Type: Bug

[GitHub] [flink] flinkbot commented on pull request #15048: [FLINK-21477][table-planner-blink] Lookup joins now deal with intermediate table scans containing just the table source correctly

2021-02-28 Thread GitBox
flinkbot commented on pull request #15048: URL: https://github.com/apache/flink/pull/15048#issuecomment-787612779 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-21477) Lookup joins should deal with intermediate table scans containing just the table source correctly

2021-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21477: --- Labels: pull-request-available (was: ) > Lookup joins should deal with intermediate table

[GitHub] [flink] TsReaper commented on pull request #15048: [FLINK-21477][table-planner-blink] Lookup joins now deal with intermediate table scans containing just the table source correctly

2021-02-28 Thread GitBox
TsReaper commented on pull request #15048: URL: https://github.com/apache/flink/pull/15048#issuecomment-787612258 @godfreyhe please help for the review. Thanks. This is an automated message from the Apache Git Service. To

[GitHub] [flink] TsReaper opened a new pull request #15048: [FLINK-21477][table-planner-blink] Lookup joins now deal with intermediate table scans containing just the table source correctly

2021-02-28 Thread GitBox
TsReaper opened a new pull request #15048: URL: https://github.com/apache/flink/pull/15048 ## What is the purpose of the change Lookup joins related rules and nodes currently does not deal with intermediate table scans. This might cause exceptions when the same lookup table is

[jira] [Closed] (FLINK-20984) can not convert an array into Table

2021-02-28 Thread Spongebob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Spongebob closed FLINK-20984. - Resolution: Incomplete > can not convert an array into Table > --- > >

[jira] [Commented] (FLINK-21524) Improve the stability of scheduler benchmarks

2021-02-28 Thread Zhilong Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292580#comment-17292580 ] Zhilong Hong commented on FLINK-21524: -- cc [~zhuzh], [~pnowojski], and [~chesnay]. > Improve the

[jira] [Created] (FLINK-21526) Replace scheduler benchmarks with wrapper classes

2021-02-28 Thread Zhilong Hong (Jira)
Zhilong Hong created FLINK-21526: Summary: Replace scheduler benchmarks with wrapper classes Key: FLINK-21526 URL: https://issues.apache.org/jira/browse/FLINK-21526 Project: Flink Issue

[GitHub] [flink] flinkbot edited a comment on pull request #15047: [FLINK-21502][coordination] Reduce frequency of global re-allocate re…

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #15047: URL: https://github.com/apache/flink/pull/15047#issuecomment-787603325 ## CI report: * ec740e36bf9c727139ed108ac44c9aca0f7c6838 UNKNOWN * a9f91f45d9db4c5382311313f17116f4ee5c6f51 UNKNOWN Bot commands The

[GitHub] [flink] flinkbot edited a comment on pull request #14840: [FLINK-21231][sql-client] add "SHOW VIEWS" to SQL client

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #14840: URL: https://github.com/apache/flink/pull/14840#issuecomment-772110005 ## CI report: * a0754755251151fb821cf56cca728eaaf43e89a7 Azure:

[jira] [Updated] (FLINK-21524) Improve the stability of scheduler benchmarks

2021-02-28 Thread Zhilong Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhilong Hong updated FLINK-21524: - Summary: Improve the stability of scheduler benchmarks (was: Replace scheduler benchmarks with

[jira] [Created] (FLINK-21525) Move scheduler benchmarks to Flink and add unit tests

2021-02-28 Thread Zhilong Hong (Jira)
Zhilong Hong created FLINK-21525: Summary: Move scheduler benchmarks to Flink and add unit tests Key: FLINK-21525 URL: https://issues.apache.org/jira/browse/FLINK-21525 Project: Flink Issue

[jira] [Created] (FLINK-21524) Replace scheduler benchmarks with wrapper classes

2021-02-28 Thread Zhilong Hong (Jira)
Zhilong Hong created FLINK-21524: Summary: Replace scheduler benchmarks with wrapper classes Key: FLINK-21524 URL: https://issues.apache.org/jira/browse/FLINK-21524 Project: Flink Issue

[GitHub] [flink] wuchong commented on pull request #15003: [FLINK-21482][table-planner-blink] Support grouping set syntax for WindowAggregate

2021-02-28 Thread GitBox
wuchong commented on pull request #15003: URL: https://github.com/apache/flink/pull/15003#issuecomment-787605245 It would be better not squash commits, otherwise it's quite hard to track which part is modified since last review. And we don't need to rebase branch unless there is

[GitHub] [flink] wuchong commented on a change in pull request #15003: [FLINK-21482][table-planner-blink] Support grouping set syntax for WindowAggregate

2021-02-28 Thread GitBox
wuchong commented on a change in pull request #15003: URL: https://github.com/apache/flink/pull/15003#discussion_r584421852 ## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/agg/WindowAggregateTest.scala ## @@

[GitHub] [flink] wuchong commented on pull request #14725: [FLINK-20977] Fix use the "USE DATABASE" command bug

2021-02-28 Thread GitBox
wuchong commented on pull request #14725: URL: https://github.com/apache/flink/pull/14725#issuecomment-787604614 `CliClientTest.testUseDatabaseAndShowCurrentDatabase` is failed. This is an automated message from the Apache

[GitHub] [flink] flinkbot commented on pull request #15047: [FLINK-21502][coordination] Reduce frequency of global re-allocate re…

2021-02-28 Thread GitBox
flinkbot commented on pull request #15047: URL: https://github.com/apache/flink/pull/15047#issuecomment-787603325 ## CI report: * ec740e36bf9c727139ed108ac44c9aca0f7c6838 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #14840: [FLINK-21231][sql-client] add "SHOW VIEWS" to SQL client

2021-02-28 Thread GitBox
flinkbot edited a comment on pull request #14840: URL: https://github.com/apache/flink/pull/14840#issuecomment-772110005 ## CI report: * a0754755251151fb821cf56cca728eaaf43e89a7 Azure:

[jira] [Commented] (FLINK-21501) Sync Chinese documentation with FLINK-21343

2021-02-28 Thread zl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292574#comment-17292574 ] zl commented on FLINK-21501: Hi [~dwysakowicz], I can do this work, can assign this issue to me ? > Sync

[GitHub] [flink] flinkbot commented on pull request #15047: [FLINK-21502][coordination] Reduce frequency of global re-allocate re…

2021-02-28 Thread GitBox
flinkbot commented on pull request #15047: URL: https://github.com/apache/flink/pull/15047#issuecomment-787600632 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-21502) Reduce frequency of global re-allocate resources

2021-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21502: --- Labels: pull-request-available (was: ) > Reduce frequency of global re-allocate resources

[GitHub] [flink] KarmaGYZ opened a new pull request #15047: [FLINK-21502][coordination] Reduce frequency of global re-allocate re…

2021-02-28 Thread GitBox
KarmaGYZ opened a new pull request #15047: URL: https://github.com/apache/flink/pull/15047 …sources The trigger of requirements check will be delay by a fixed time to reduce the frequency of it. ## Verifying this change This change is already covered by

[GitHub] [flink] wuchong commented on pull request #14894: [FLINK-20895][flink-table-planner-blink] support local aggregate push down in blink planner

2021-02-28 Thread GitBox
wuchong commented on pull request #14894: URL: https://github.com/apache/flink/pull/14894#issuecomment-787599288 Sorry for the late reponse. I will review this PR this week. This is an automated message from the Apache Git

[jira] [Commented] (FLINK-21523) ArrayIndexOutOfBoundsException occurs while run a hive streaming job with partitioned table source

2021-02-28 Thread zouyunhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292571#comment-17292571 ] zouyunhe commented on FLINK-21523: -- [~lzljs3620320]  hello, please take a look at this issue。  >

  1   2   >