[GitHub] [flink] hehuiyuan commented on pull request #15395: [FLINK-15146][core][ttl] Fix check that incremental cleanup size must be greater than zero

2021-03-27 Thread GitBox
hehuiyuan commented on pull request #15395: URL: https://github.com/apache/flink/pull/15395#issuecomment-808849693 Hi @azagrebin , please take a look at the remaining issues before. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] flinkbot edited a comment on pull request #15395: [FLINK-15146][core][ttl] Fix check that incremental cleanup size must be greater than zero

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15395: URL: https://github.com/apache/flink/pull/15395#issuecomment-808844283 ## CI report: * 7c02ad0fd1be737add77d6d9fc2c5dd0cfcd1959 Azure:

[GitHub] [flink] flinkbot commented on pull request #15395: [FLINK-15146][core][ttl] Fix check that incremental cleanup size must be greater than zero

2021-03-27 Thread GitBox
flinkbot commented on pull request #15395: URL: https://github.com/apache/flink/pull/15395#issuecomment-808844283 ## CI report: * 7c02ad0fd1be737add77d6d9fc2c5dd0cfcd1959 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] hehuiyuan commented on pull request #15395: [FLINK-15146][core][ttl] Fix check that incremental cleanup size must be greater than zero

2021-03-27 Thread GitBox
hehuiyuan commented on pull request #15395: URL: https://github.com/apache/flink/pull/15395#issuecomment-808843844 @flinkbot re-run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #15395: [FLINK-15146][core][ttl] Fix check that incremental cleanup size must be greater than zero

2021-03-27 Thread GitBox
flinkbot commented on pull request #15395: URL: https://github.com/apache/flink/pull/15395#issuecomment-808843849 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] hehuiyuan closed pull request #10507: [FLINK-15146][core][ttl] Fix check that incremental cleanup size must be greater than zero

2021-03-27 Thread GitBox
hehuiyuan closed pull request #10507: URL: https://github.com/apache/flink/pull/10507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [flink] hehuiyuan opened a new pull request #15395: [FLINK-15146][core][ttl] Fix check that incremental cleanup size must be greater than zero

2021-03-27 Thread GitBox
hehuiyuan opened a new pull request #15395: URL: https://github.com/apache/flink/pull/15395 ## What is the purpose of the change At the moment, we allow zero value for the TTL incremental cleanup size. Although technically zero value will not break the cleanup but practically

[GitHub] [flink] flinkbot edited a comment on pull request #15340: [FLINK-21669][table-api] Support "table.dml-sync" option to execute statement in sync mode

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15340: URL: https://github.com/apache/flink/pull/15340#issuecomment-804732503 ## CI report: * 518b68bf680b8daa26c2543daa871e19623e723f Azure:

[jira] [Closed] (FLINK-21702) Support option `sql-client.verbose` to print the exception stack

2021-03-27 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-21702. --- Fix Version/s: 1.13.0 Resolution: Fixed Fixed in master: e19d383488a753483ac0f94ffda42592bc6f7765 >

[GitHub] [flink] wuchong closed pull request #15383: [FLINK-21702][sql-client]Support option `sql-client.verbose` to print the exception stack

2021-03-27 Thread GitBox
wuchong closed pull request #15383: URL: https://github.com/apache/flink/pull/15383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [flink] flinkbot edited a comment on pull request #15340: [FLINK-21669][table-api] Support "table.dml-sync" option to execute statement in sync mode

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15340: URL: https://github.com/apache/flink/pull/15340#issuecomment-804732503 ## CI report: * f7bbe73a8f843fc9df757da7c0e9d4e1473f10a9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15282: [FLINK-21664][table-api] Support STATEMENT SET syntax in TableEnvironment

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15282: URL: https://github.com/apache/flink/pull/15282#issuecomment-802718786 ## CI report: * 742935e509dbe46d5fbadc573d65401af76d910b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15282: [FLINK-21664][table-api] Support STATEMENT SET syntax in TableEnvironment

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15282: URL: https://github.com/apache/flink/pull/15282#issuecomment-802718786 ## CI report: * 742935e509dbe46d5fbadc573d65401af76d910b Azure:

[GitHub] [flink] SteNicholas commented on pull request #15282: [FLINK-21664][table-api] Support STATEMENT SET syntax in TableEnvironment

2021-03-27 Thread GitBox
SteNicholas commented on pull request #15282: URL: https://github.com/apache/flink/pull/15282#issuecomment-808830430 @wuchong , thanks for detailed review. I have followed your comments and only supported the statement set parser. Please help to review again. -- This is an automated

[GitHub] [flink] flinkbot edited a comment on pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15294: URL: https://github.com/apache/flink/pull/15294#issuecomment-803058203 ## CI report: * b22d2cdd4e457842b585e64089858a0ae8eb9a2b UNKNOWN * 19964baf25121c6f0a4f85d75ffcc568d98dcdaa Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15294: URL: https://github.com/apache/flink/pull/15294#issuecomment-803058203 ## CI report: * b22d2cdd4e457842b585e64089858a0ae8eb9a2b UNKNOWN * e22f0481e529520e30de4d39f18e6abeb42f4292 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15294: URL: https://github.com/apache/flink/pull/15294#issuecomment-803058203 ## CI report: * b22d2cdd4e457842b585e64089858a0ae8eb9a2b UNKNOWN * ad7438bf00bd94dff31ffe0dd0e819198e27396f Azure:

[GitHub] [flink] AHeise commented on pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
AHeise commented on pull request #15294: URL: https://github.com/apache/flink/pull/15294#issuecomment-808808907 Based on the suggestion in https://github.com/apache/flink/pull/15294#discussion_r602381593, I created a new version which should be less intrusive to the current code. I'd say

[GitHub] [flink] flinkbot edited a comment on pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15294: URL: https://github.com/apache/flink/pull/15294#issuecomment-803058203 ## CI report: * b22d2cdd4e457842b585e64089858a0ae8eb9a2b UNKNOWN * ad7438bf00bd94dff31ffe0dd0e819198e27396f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15294: URL: https://github.com/apache/flink/pull/15294#issuecomment-803058203 ## CI report: * b22d2cdd4e457842b585e64089858a0ae8eb9a2b UNKNOWN * ad7438bf00bd94dff31ffe0dd0e819198e27396f Azure:

[GitHub] [flink] AHeise commented on a change in pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
AHeise commented on a change in pull request #15294: URL: https://github.com/apache/flink/pull/15294#discussion_r602781363 ## File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointTestBase.java ## @@ -871,13 +875,15 @@ public String

[GitHub] [flink] AHeise commented on a change in pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
AHeise commented on a change in pull request #15294: URL: https://github.com/apache/flink/pull/15294#discussion_r602781005 ## File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointRescaleITCase.java ## @@ -61,7 +67,7 @@ PIPELINE

[GitHub] [flink] AHeise commented on a change in pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
AHeise commented on a change in pull request #15294: URL: https://github.com/apache/flink/pull/15294#discussion_r602780900 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java ## @@ -343,7 +343,7 @@ public static DataType

[GitHub] [flink] AHeise commented on a change in pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
AHeise commented on a change in pull request #15294: URL: https://github.com/apache/flink/pull/15294#discussion_r602780284 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/AlignedController.java ## @@ -39,6 +40,8 @@ /**

[GitHub] [flink] AHeise commented on a change in pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
AHeise commented on a change in pull request #15294: URL: https://github.com/apache/flink/pull/15294#discussion_r602780231 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamConfig.java ## @@ -107,13 +107,20 @@ private static

[GitHub] [flink] AHeise commented on a change in pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
AHeise commented on a change in pull request #15294: URL: https://github.com/apache/flink/pull/15294#discussion_r602779836 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java ## @@ -686,6 +686,8 @@ private void

[GitHub] [flink] AHeise commented on a change in pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
AHeise commented on a change in pull request #15294: URL: https://github.com/apache/flink/pull/15294#discussion_r602779580 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java ## @@ -400,32 +400,31 @@ public

[GitHub] [flink] flinkbot edited a comment on pull request #15383: [FLINK-21702][sql-client]Support option `sql-client.verbose` to print the exception stack

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15383: URL: https://github.com/apache/flink/pull/15383#issuecomment-808001666 ## CI report: * d43ae92d5cf478899c4ba3cdfac4417383dc7701 UNKNOWN * 78ee0ae84d1ce3c305fafb8deca6399e2c4e98f4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15340: [FLINK-21669][table-api] Support "table.dml-sync" option to execute statement in sync mode

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15340: URL: https://github.com/apache/flink/pull/15340#issuecomment-804732503 ## CI report: * f7bbe73a8f843fc9df757da7c0e9d4e1473f10a9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15282: [FLINK-21664][table-api] Support STATEMENT SET syntax in TableEnvironment

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15282: URL: https://github.com/apache/flink/pull/15282#issuecomment-802718786 ## CI report: * 742935e509dbe46d5fbadc573d65401af76d910b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15340: [FLINK-21669][table-api] Support "table.dml-sync" option to execute statement in sync mode

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15340: URL: https://github.com/apache/flink/pull/15340#issuecomment-804732503 ## CI report: * 927ecabf6e1065c0983dbe7e7859db6f748fe0ee Azure:

[GitHub] [flink] afedulov commented on a change in pull request #15054: [FLINK-13550][runtime][ui] Operator's Flame Graph

2021-03-27 Thread GitBox
afedulov commented on a change in pull request #15054: URL: https://github.com/apache/flink/pull/15054#discussion_r602761257 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/stats/TaskStatsRequestCoordinator.java ## @@ -0,0 +1,323 @@ +/* + *

[GitHub] [flink] afedulov commented on a change in pull request #15054: [FLINK-13550][runtime][ui] Operator's Flame Graph

2021-03-27 Thread GitBox
afedulov commented on a change in pull request #15054: URL: https://github.com/apache/flink/pull/15054#discussion_r602761159 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/stats/TaskStatsRequestCoordinator.java ## @@ -0,0 +1,323 @@ +/* + *

[GitHub] [flink] afedulov commented on a change in pull request #15054: [FLINK-13550][runtime][ui] Operator's Flame Graph

2021-03-27 Thread GitBox
afedulov commented on a change in pull request #15054: URL: https://github.com/apache/flink/pull/15054#discussion_r602741349 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/messages/ThreadInfoSample.java ## @@ -0,0 +1,283 @@ +/* + * Licensed to the Apache

[GitHub] [flink] wuchong commented on a change in pull request #15282: [FLINK-21664][table-api] Support STATEMENT SET syntax in TableEnvironment

2021-03-27 Thread GitBox
wuchong commented on a change in pull request #15282: URL: https://github.com/apache/flink/pull/15282#discussion_r602725834 ## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/SqlEnd.java ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-21008) Residual HA related Kubernetes ConfigMaps and ZooKeeper nodes when cluster entrypoint received SIGTERM in shutdown

2021-03-27 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309979#comment-17309979 ] Yang Wang commented on FLINK-21008: --- Thanks for the reminding. I will try to provide a PR before next

[GitHub] [flink] flinkbot edited a comment on pull request #15340: [FLINK-21669][table-api] Support "table.dml-sync" option to execute statement in sync mode

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15340: URL: https://github.com/apache/flink/pull/15340#issuecomment-804732503 ## CI report: * 9bde769eb36c7efbc065f025f09d55ecee41a0a4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15383: [FLINK-21702][sql-client]Support option `sql-client.verbose` to print the exception stack

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15383: URL: https://github.com/apache/flink/pull/15383#issuecomment-808001666 ## CI report: * d43ae92d5cf478899c4ba3cdfac4417383dc7701 UNKNOWN * 013bfa5f096fc17b2941c0debcf6b8907f94d929 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15383: [FLINK-21702][sql-client]Support option `sql-client.verbose` to print the exception stack

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15383: URL: https://github.com/apache/flink/pull/15383#issuecomment-808001666 ## CI report: * d43ae92d5cf478899c4ba3cdfac4417383dc7701 UNKNOWN * 013bfa5f096fc17b2941c0debcf6b8907f94d929 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15282: [FLINK-21664][table-api] Support STATEMENT SET syntax in TableEnvironment

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15282: URL: https://github.com/apache/flink/pull/15282#issuecomment-802718786 ## CI report: * 0cc3f9d704c561c3eb6c6cec6741e1b0e8b59510 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15383: [FLINK-21702][sql-client]Support option `sql-client.verbose` to print the exception stack

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15383: URL: https://github.com/apache/flink/pull/15383#issuecomment-808001666 ## CI report: * d43ae92d5cf478899c4ba3cdfac4417383dc7701 UNKNOWN * 013bfa5f096fc17b2941c0debcf6b8907f94d929 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15340: [FLINK-21669][table-api] Support "table.dml-sync" option to execute statement in sync mode

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15340: URL: https://github.com/apache/flink/pull/15340#issuecomment-804732503 ## CI report: * bd59806ebbb919d248ed5a7d024313f035431726 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15282: [FLINK-21664][table-api] Support STATEMENT SET syntax in TableEnvironment

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15282: URL: https://github.com/apache/flink/pull/15282#issuecomment-802718786 ## CI report: * 0cc3f9d704c561c3eb6c6cec6741e1b0e8b59510 Azure:

[GitHub] [flink] zhuxiaoshang commented on pull request #15383: [FLINK-21702][sql-client]Support option `sql-client.verbose` to print the exception stack

2021-03-27 Thread GitBox
zhuxiaoshang commented on pull request #15383: URL: https://github.com/apache/flink/pull/15383#issuecomment-808740112 Thanks for Jark's help. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] SteNicholas commented on pull request #15282: [FLINK-21664][table-api] Support STATEMENT SET syntax in TableEnvironment

2021-03-27 Thread GitBox
SteNicholas commented on pull request #15282: URL: https://github.com/apache/flink/pull/15282#issuecomment-808737900 @wuchong @fsk119 , I have followed the statement set syntax as follows: ``` BEGIN STATEMENT SET; INSERT INTO xx SELECT * FROM xxx; END; ``` Please help to

[GitHub] [flink] SteNicholas removed a comment on pull request #15282: [FLINK-21664][table-api] Support STATEMENT SET syntax in TableEnvironment

2021-03-27 Thread GitBox
SteNicholas removed a comment on pull request #15282: URL: https://github.com/apache/flink/pull/15282#issuecomment-803719407 @fsk119 , thanks for your detailed review. The question you mentioned above has already been discussed by @wuchong . I would like to unify the parser behavior of

[GitHub] [flink] flinkbot edited a comment on pull request #15340: [FLINK-21669][table-api] Support "table.dml-sync" option to execute statement in sync mode

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15340: URL: https://github.com/apache/flink/pull/15340#issuecomment-804732503 ## CI report: * bd59806ebbb919d248ed5a7d024313f035431726 Azure:

[jira] [Commented] (FLINK-21888) Maintain our own ASTNode class

2021-03-27 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309947#comment-17309947 ] Jark Wu commented on FLINK-21888: - Fixed in master: 23afdbc060f6e50e13ba2aec6500a86dc1fcac7f > Maintain

[jira] [Closed] (FLINK-21888) Maintain our own ASTNode class

2021-03-27 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-21888. --- Assignee: Rui Li Resolution: Fixed > Maintain our own ASTNode class > --

[GitHub] [flink] wuchong merged pull request #15301: [FLINK-21888][hive] Maintain our own ASTNode class

2021-03-27 Thread GitBox
wuchong merged pull request #15301: URL: https://github.com/apache/flink/pull/15301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [flink] wuchong commented on pull request #15301: [FLINK-21888][hive] Maintain our own ASTNode class

2021-03-27 Thread GitBox
wuchong commented on pull request #15301: URL: https://github.com/apache/flink/pull/15301#issuecomment-808732755 The failed case is not related to the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] wangyang0918 commented on a change in pull request #15385: [FLINK-21685][k8s] Introduce dedicated thread pool and cache for Kubernetes client

2021-03-27 Thread GitBox
wangyang0918 commented on a change in pull request #15385: URL: https://github.com/apache/flink/pull/15385#discussion_r602718973 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/FlinkKubeClientFactory.java ## @@ -83,11 +89,19 @@ public

[GitHub] [flink] AHeise commented on a change in pull request #15294: [FLINK-21945][streaming] Omit pointwise connections from checkpointing in unaligned checkpoints.

2021-03-27 Thread GitBox
AHeise commented on a change in pull request #15294: URL: https://github.com/apache/flink/pull/15294#discussion_r602718485 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java ## @@ -400,32 +400,31 @@ public

[GitHub] [flink] flinkbot edited a comment on pull request #15340: [FLINK-21669][table-api] Support "table.dml-sync" option to execute statement in sync mode

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15340: URL: https://github.com/apache/flink/pull/15340#issuecomment-804732503 ## CI report: * bd59806ebbb919d248ed5a7d024313f035431726 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15340: [FLINK-21669][table-api] Support "table.dml-sync" option to execute statement in sync mode

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15340: URL: https://github.com/apache/flink/pull/15340#issuecomment-804732503 ## CI report: * bd59806ebbb919d248ed5a7d024313f035431726 Azure:

[GitHub] [flink-web] rmetzger opened a new pull request #427: Add reactive mode blog post

2021-03-27 Thread GitBox
rmetzger opened a new pull request #427: URL: https://github.com/apache/flink-web/pull/427 blog post about reactive mode. Let's decide together if we want to publish it before or after the release of 1.13. I can adjust the text if we release afterwards . -- This is an automated message

[GitHub] [flink] hehuiyuan commented on pull request #15250: [FLINK-20318][Connector/kafka]Fix cast question for properies() method in kafka ConnectorDescriptor

2021-03-27 Thread GitBox
hehuiyuan commented on pull request #15250: URL: https://github.com/apache/flink/pull/15250#issuecomment-808722995 Hi @twalthr , please look at this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (FLINK-21978) Disable cast conversion between Numeric type and TIMESTAMP_LTZ type

2021-03-27 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-21978: --- Fix Version/s: 1.13.0 > Disable cast conversion between Numeric type and TIMESTAMP_LTZ type >

[jira] [Closed] (FLINK-21978) Disable cast conversion between Numeric type and TIMESTAMP_LTZ type

2021-03-27 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-21978. -- Resolution: Fixed Temporary disabled: cb6b5c1282f2d7ac226fa5c04ff650107382bb6d > Disable cast

[GitHub] [flink] KurtYoung merged pull request #15374: [FLINK-21978][table-planner] Disable cast conversion between Numeric type and TIMESTAMP_LTZ type

2021-03-27 Thread GitBox
KurtYoung merged pull request #15374: URL: https://github.com/apache/flink/pull/15374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [flink] flinkbot edited a comment on pull request #15366: [FLINK-12828][sql-client] Support -f option with a sql script as input

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15366: URL: https://github.com/apache/flink/pull/15366#issuecomment-806388017 ## CI report: * 347d38bc59e3ffa1d3854da26163c2170c2f6986 UNKNOWN * 6d024aff193115fa273063efcdc616d5f506da85 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15301: [FLINK-21888][hive] Maintain our own ASTNode class

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15301: URL: https://github.com/apache/flink/pull/15301#issuecomment-803353789 ## CI report: * 34b9a0ffa359bcf623a9f4bd672689274cc5d88f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15340: [FLINK-21669][table-api] Support "table.dml-sync" option to execute statement in sync mode

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15340: URL: https://github.com/apache/flink/pull/15340#issuecomment-804732503 ## CI report: * bd59806ebbb919d248ed5a7d024313f035431726 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15383: [FLINK-21702][sql-client]Support option `sql-client.verbose` to print the exception stack

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15383: URL: https://github.com/apache/flink/pull/15383#issuecomment-808001666 ## CI report: * d43ae92d5cf478899c4ba3cdfac4417383dc7701 UNKNOWN * ef3d73a5dfd2c970e38e817e20c7e97041b919be Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15374: [FLINK-21978][table-planner] Disable cast conversion between Numeric type and TIMESTAMP_LTZ type

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15374: URL: https://github.com/apache/flink/pull/15374#issuecomment-807049695 ## CI report: * 21ca2ed25b26f69e598821279bfb1fac43aa6c6f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15340: [FLINK-21669][table-api] Support "table.dml-sync" option to execute statement in sync mode

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15340: URL: https://github.com/apache/flink/pull/15340#issuecomment-804732503 ## CI report: * bd59806ebbb919d248ed5a7d024313f035431726 Azure:

[GitHub] [flink] fsk119 commented on pull request #15340: [FLINK-21669][table-api] Support "table.dml-sync" option to execute statement in sync mode

2021-03-27 Thread GitBox
fsk119 commented on pull request #15340: URL: https://github.com/apache/flink/pull/15340#issuecomment-808705584 The implementation is wrong. I need to fix again... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-21713) Correct function CURRENT_TIMESTAMP/CURRENT_TIME/CURRENT_DATE/NOW/LOCALTIME/LOCALTIMESTAMP

2021-03-27 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-21713: --- Environment: * 1.The CURRENT_TIMESTAMP function returned timestamp of UTC+0 timezone with

[jira] [Updated] (FLINK-21713) Correct function CURRENT_TIMESTAMP/CURRENT_TIME/CURRENT_DATE/NOW/LOCALTIME/LOCALTIMESTAMP

2021-03-27 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-21713: --- Release Note: Environment: * 1.The CURRENT_TIMESTAMP function returned timestamp of UTC+0

[GitHub] [flink] flinkbot edited a comment on pull request #15374: [FLINK-21978][table-planner] Disable cast conversion between Numeric type and TIMESTAMP_LTZ type

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15374: URL: https://github.com/apache/flink/pull/15374#issuecomment-807049695 ## CI report: * 21ca2ed25b26f69e598821279bfb1fac43aa6c6f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15383: [FLINK-21702][sql-client]Support option `sql-client.verbose` to print the exception stack

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15383: URL: https://github.com/apache/flink/pull/15383#issuecomment-808001666 ## CI report: * d43ae92d5cf478899c4ba3cdfac4417383dc7701 UNKNOWN * ef3d73a5dfd2c970e38e817e20c7e97041b919be Azure:

[GitHub] [flink] fsk119 commented on a change in pull request #15340: [FLINK-21669][table-api] Support "table.dml-sync" option to execute statement in sync mode

2021-03-27 Thread GitBox
fsk119 commented on a change in pull request #15340: URL: https://github.com/apache/flink/pull/15340#discussion_r602697057 ## File path: flink-table/flink-sql-client/src/test/resources/sql/select.q ## @@ -50,8 +50,38 @@ java.lang.IllegalArgumentException: testing elements of

[GitHub] [flink] KurtYoung commented on a change in pull request #15374: [FLINK-21978][table-planner] Disable cast conversion between Numeric type and TIMESTAMP_LTZ type

2021-03-27 Thread GitBox
KurtYoung commented on a change in pull request #15374: URL: https://github.com/apache/flink/pull/15374#discussion_r602696466 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/data/DecimalDataUtils.java ## @@ -208,23 +205,8 @@ public

[GitHub] [flink] leonardBang commented on a change in pull request #15374: [FLINK-21978][table-planner] Disable cast conversion between Numeric type and TIMESTAMP_LTZ type

2021-03-27 Thread GitBox
leonardBang commented on a change in pull request #15374: URL: https://github.com/apache/flink/pull/15374#discussion_r602694836 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/data/DecimalDataUtils.java ## @@ -208,23 +205,8 @@ public

[jira] [Closed] (FLINK-21623) Introduce CURRENT_ROW_TIMESTAMP() function

2021-03-27 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-21623. --- Fix Version/s: 1.13.0 Resolution: Fixed Fixed in master: ab51671617976fd56bd6bdb63620378dab0ae4c1 >

[GitHub] [flink] wuchong closed pull request #15306: [FLINK-21623][table-planner] Introduce CURRENT_ROW_TIMESTAMP() function

2021-03-27 Thread GitBox
wuchong closed pull request #15306: URL: https://github.com/apache/flink/pull/15306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [flink] KurtYoung commented on a change in pull request #15374: [FLINK-21978][table-planner] Disable cast conversion between Numeric type and TIMESTAMP_LTZ type

2021-03-27 Thread GitBox
KurtYoung commented on a change in pull request #15374: URL: https://github.com/apache/flink/pull/15374#discussion_r602693430 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/data/DecimalDataUtils.java ## @@ -208,23 +205,8 @@ public

[GitHub] [flink] KurtYoung merged pull request #15394: [hotfix][format] package format-common to flink-csv and flink-json

2021-03-27 Thread GitBox
KurtYoung merged pull request #15394: URL: https://github.com/apache/flink/pull/15394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [flink] flinkbot edited a comment on pull request #15394: [hotfix][format] package format-common to flink-csv and flink-json

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15394: URL: https://github.com/apache/flink/pull/15394#issuecomment-808652774 ## CI report: * d12b0de0aa1b7e7ebd697244f2ee8afdac052d44 Azure:

[GitHub] [flink] leonardBang commented on pull request #15394: [hotfix][format] package format-common to flink-csv and flink-json

2021-03-27 Thread GitBox
leonardBang commented on pull request #15394: URL: https://github.com/apache/flink/pull/15394#issuecomment-808693848 @KurtYoung the azure passed, could you help take a look this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Closed] (FLINK-21984) Change precision argument from optional to required in TO_TIMESTAMP_LTZ(numeric, precision)

2021-03-27 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-21984. -- Resolution: Fixed fixed: 1af31a5648f4ecf15bd850a12a41f051ff6c15d2 > Change precision argument from

[GitHub] [flink] KurtYoung merged pull request #15379: [FLINK-21984][table-planner] Change precision argument from optional to required in TO_TIMESTAMP_LTZ(numeric, precision)

2021-03-27 Thread GitBox
KurtYoung merged pull request #15379: URL: https://github.com/apache/flink/pull/15379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [flink] KurtYoung commented on a change in pull request #15366: [FLINK-12828][sql-client] Support -f option with a sql script as input

2021-03-27 Thread GitBox
KurtYoung commented on a change in pull request #15366: URL: https://github.com/apache/flink/pull/15366#discussion_r602684056 ## File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/SqlClient.java ## @@ -106,9 +111,28 @@ private void

[GitHub] [flink] flinkbot edited a comment on pull request #15391: [FLINK-21630][python] Support Python UDAF in Session Window

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15391: URL: https://github.com/apache/flink/pull/15391#issuecomment-808283258 ## CI report: * d55091ff03d9749e1be6b240d93b8b63a4a2b7b6 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15366: [FLINK-12828][sql-client] Support -f option with a sql script as input

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15366: URL: https://github.com/apache/flink/pull/15366#issuecomment-806388017 ## CI report: * d879f73ab948f4782455d18442095b360c7b8fbc Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15379: [FLINK-21984][table-planner] Change precision argument from optional to required in TO_TIMESTAMP_LTZ(numeric, precision)

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15379: URL: https://github.com/apache/flink/pull/15379#issuecomment-807932155 ## CI report: * c8228017e07ff5007c61c37b6fcadccf495a6903 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15366: [FLINK-12828][sql-client] Support -f option with a sql script as input

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15366: URL: https://github.com/apache/flink/pull/15366#issuecomment-806388017 ## CI report: * d879f73ab948f4782455d18442095b360c7b8fbc Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15306: [FLINK-21623][table-planner] Introduce CURRENT_ROW_TIMESTAMP() function

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15306: URL: https://github.com/apache/flink/pull/15306#issuecomment-803566547 ## CI report: * 32ff07ca0a4132bbfb2627211ae9f30eae7a55e3 Azure:

[jira] [Updated] (FLINK-21623) Introduce CURRENT_ROW_TIMESTAMP() function

2021-03-27 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-21623: --- Summary: Introduce CURRENT_ROW_TIMESTAMP() function (was: Introduce CURRENT_ROW_TIMESTAMP

[GitHub] [flink] flinkbot edited a comment on pull request #15366: [FLINK-12828][sql-client] Support -f option with a sql script as input

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15366: URL: https://github.com/apache/flink/pull/15366#issuecomment-806388017 ## CI report: * d879f73ab948f4782455d18442095b360c7b8fbc Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15259: [FLINK-20757][network] Optimize data broadcast for sort-merge blocking shuffle

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15259: URL: https://github.com/apache/flink/pull/15259#issuecomment-801679503 ## CI report: * 0185457ce617de9dbe393680a37681aa1415d9ed Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15383: [FLINK-21702][sql-client]Support option `sql-client.verbose` to print the exception stack

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15383: URL: https://github.com/apache/flink/pull/15383#issuecomment-808001666 ## CI report: * d43ae92d5cf478899c4ba3cdfac4417383dc7701 UNKNOWN * ef3d73a5dfd2c970e38e817e20c7e97041b919be Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15301: [FLINK-21888][hive] Maintain our own ASTNode class

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15301: URL: https://github.com/apache/flink/pull/15301#issuecomment-803353789 ## CI report: * b396325ab19ee75949e87d006c9e17096dbd50a2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15383: [FLINK-21702][sql-client]Support option `sql-client.verbose` to print the exception stack

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15383: URL: https://github.com/apache/flink/pull/15383#issuecomment-808001666 ## CI report: * d43ae92d5cf478899c4ba3cdfac4417383dc7701 UNKNOWN * 83ca14682c7a6651d8c8201ad7fbb058373fc17d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #15301: [FLINK-21888][hive] Maintain our own ASTNode class

2021-03-27 Thread GitBox
flinkbot edited a comment on pull request #15301: URL: https://github.com/apache/flink/pull/15301#issuecomment-803353789 ## CI report: * b396325ab19ee75949e87d006c9e17096dbd50a2 Azure: