[jira] [Updated] (FLINK-23465) JobListener#onJobExecuted cannot be called when sql job finished

2021-07-23 Thread camilesing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] camilesing updated FLINK-23465: --- Affects Version/s: 1.13.1 > JobListener#onJobExecuted cannot be called when sql job finished >

[jira] [Updated] (FLINK-23465) JobListener#onJobExecuted cannot be called when sql job finished

2021-07-23 Thread camilesing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] camilesing updated FLINK-23465: --- Component/s: (was: API / Core) Table SQL / API > JobListener#onJobExecuted

[GitHub] [flink] JackWangCS commented on pull request #14841: [FLINK-21232][YARN][Common] Introduce pluggable Hadoop delegation token providers

2021-07-23 Thread GitBox
JackWangCS commented on pull request #14841: URL: https://github.com/apache/flink/pull/14841#issuecomment-885999002 Hi @XComp , @tillrohrmann , could you help to review this PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] flinkbot edited a comment on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885655624 ## CI report: * 81a5e20202b5e8e50c97bfe8d39296f03af6ca4d UNKNOWN * eb5d06214f3f898d250d9bb3ff9b8a41a46700e7 Azure:

[jira] [Commented] (FLINK-22405) Support fixed-lengh chars in the LeadLag built-in function

2021-07-23 Thread liwei li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386640#comment-17386640 ] liwei li commented on FLINK-22405: -- I added a case statement block to match the data of CHAR type ,

[GitHub] [flink] flinkbot edited a comment on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885655624 ## CI report: * 81a5e20202b5e8e50c97bfe8d39296f03af6ca4d UNKNOWN * e3cfa005beefb341b54371390694d81710879cc7 Azure:

[jira] [Created] (FLINK-23488) Please unsubscribe/remove me from jira user emails

2021-07-23 Thread Bhagi (Jira)
Bhagi created FLINK-23488: - Summary: Please unsubscribe/remove me from jira user emails Key: FLINK-23488 URL: https://issues.apache.org/jira/browse/FLINK-23488 Project: Flink Issue Type: Bug

[GitHub] [flink] wangyang0918 commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
wangyang0918 commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675926561 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,17 +265,17

[GitHub] [flink] flinkbot edited a comment on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885655624 ## CI report: * 11dc520b8de778ba970d39914d1e7b9ffb5b9872 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885655624 ## CI report: * 11dc520b8de778ba970d39914d1e7b9ffb5b9872 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885655624 ## CI report: * 11dc520b8de778ba970d39914d1e7b9ffb5b9872 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885655624 ## CI report: * 11dc520b8de778ba970d39914d1e7b9ffb5b9872 Azure:

[GitHub] [flink] yittg commented on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
yittg commented on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885950936 > I would prefer the option 4. > > Passing a dedicated single thread, instead of the current shared cached thread pool, when call the `KubernetesSharedInformer#watch`.

[GitHub] [flink] yittg commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
yittg commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675898651 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[jira] [Updated] (FLINK-21268) Logs view can't scroll in Firefox

2021-07-23 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-21268: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the

[jira] [Commented] (FLINK-23479) IncrementalAggregateJsonPlanTest.testIncrementalAggregateWithSumCountDistinctAndRetraction fail

2021-07-23 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386494#comment-17386494 ] Dawid Wysakowicz commented on FLINK-23479: --

[GitHub] [flink] flinkbot edited a comment on pull request #16584: [FLINK-22781][table-planner-blink] Fix bug that when implements the L…

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16584: URL: https://github.com/apache/flink/pull/16584#issuecomment-885710999 ## CI report: * beeecc75734e1ffe1033d4ffbda7ee43e7d57e5f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16563: [FLINK-22540][sql-client] Remove Yaml environment file in SQL Client

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16563: URL: https://github.com/apache/flink/pull/16563#issuecomment-884699874 ## CI report: * 1dcffb44fe168dbd3aeff5f763508bd35d56da31 UNKNOWN * f6c5853b2621ae128d27838237aad6200dc52489 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885655624 ## CI report: * 11dc520b8de778ba970d39914d1e7b9ffb5b9872 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16585: [FLINK-23482][table] Simplify BlinkExecutorFactory stack

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16585: URL: https://github.com/apache/flink/pull/16585#issuecomment-885711125 ## CI report: * d3b1b923e7281cf73528203380352e5cf2fd8f60 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885655624 ## CI report: * 6d52dc0b2a06b3aab47330cded257aac8ba306f8 Azure:

[GitHub] [flink] wangyang0918 commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
wangyang0918 commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675693787 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +266,32

[GitHub] [flink] wangyang0918 commented on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
wangyang0918 commented on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885758095 > Thanks @wangyang0918 @dmvk ; > So here are three options if i understand correctly? > > 1. Revert the previous merged change; > 2. Fix with simple lock

[GitHub] [flink] dannycranmer commented on a change in pull request #16513: [FLINK-23389][Formats] Glue schema registry JSON support

2021-07-23 Thread GitBox
dannycranmer commented on a change in pull request #16513: URL: https://github.com/apache/flink/pull/16513#discussion_r675688621 ## File path: flink-formats/flink-json-glue-schema-registry/pom.xml ## @@ -0,0 +1,115 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink] yittg commented on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
yittg commented on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885753989 Thanks @wangyang0918 @dmvk ; So here are three options if i understand correctly? 1. Revert the previous merged change; 2. Fix with simple lock solution provided by

[GitHub] [flink] dannycranmer commented on a change in pull request #16513: [FLINK-23389][Formats] Glue schema registry JSON support

2021-07-23 Thread GitBox
dannycranmer commented on a change in pull request #16513: URL: https://github.com/apache/flink/pull/16513#discussion_r675688047 ## File path: flink-formats/flink-json-glue-schema-registry/pom.xml ## @@ -0,0 +1,115 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Commented] (FLINK-22802) Bump Fabric8 Kubernetes Client to >= 5.X

2021-07-23 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386350#comment-17386350 ] Yang Wang commented on FLINK-22802: --- When I bump the fabric8 Kubernetes client version from 4.5.2 to

[GitHub] [flink] wangyang0918 commented on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
wangyang0918 commented on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885742344 > > I have to admit that using a dedicated thread for each watch will make the code easier to read and maintain. IIRC, each job will need three threads for watching the HA

[GitHub] [flink] dannycranmer commented on a change in pull request #16513: [FLINK-23389][Formats] Glue schema registry JSON support

2021-07-23 Thread GitBox
dannycranmer commented on a change in pull request #16513: URL: https://github.com/apache/flink/pull/16513#discussion_r675673040 ## File path: flink-formats/flink-json-glue-schema-registry/pom.xml ## @@ -0,0 +1,115 @@ + + +http://maven.apache.org/POM/4.0.0; Review comment:

[GitHub] [flink] dmvk commented on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
dmvk commented on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885737142 > I have to admit that using a dedicated thread for each watch will make the code easier to read and maintain. IIRC, each job will need three threads for watching the HA related

[GitHub] [flink] dannycranmer commented on a change in pull request #16513: [FLINK-23389][Formats] Glue schema registry JSON support

2021-07-23 Thread GitBox
dannycranmer commented on a change in pull request #16513: URL: https://github.com/apache/flink/pull/16513#discussion_r675671689 ## File path: flink-formats/flink-json-glue-schema-registry/pom.xml ## @@ -0,0 +1,115 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Updated] (FLINK-23479) IncrementalAggregateJsonPlanTest.testIncrementalAggregateWithSumCountDistinctAndRetraction fail

2021-07-23 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-23479: - Affects Version/s: 1.13.1 >

[jira] [Commented] (FLINK-23479) IncrementalAggregateJsonPlanTest.testIncrementalAggregateWithSumCountDistinctAndRetraction fail

2021-07-23 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386340#comment-17386340 ] Dawid Wysakowicz commented on FLINK-23479: --

[jira] [Commented] (FLINK-23479) IncrementalAggregateJsonPlanTest.testIncrementalAggregateWithSumCountDistinctAndRetraction fail

2021-07-23 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386338#comment-17386338 ] Dawid Wysakowicz commented on FLINK-23479: -- https://issues.apache.org/jira/browse/FLINK-23479

[jira] [Issue Comment Deleted] (FLINK-23479) IncrementalAggregateJsonPlanTest.testIncrementalAggregateWithSumCountDistinctAndRetraction fail

2021-07-23 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-23479: - Comment: was deleted (was: https://issues.apache.org/jira/browse/FLINK-23479) >

[jira] [Commented] (FLINK-23479) IncrementalAggregateJsonPlanTest.testIncrementalAggregateWithSumCountDistinctAndRetraction fail

2021-07-23 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386337#comment-17386337 ] Dawid Wysakowicz commented on FLINK-23479: -- Reverted FLINK-23434 because of test instabilities:

[GitHub] [flink] flinkbot edited a comment on pull request #16585: [FLINK-23482][table] Simplify BlinkExecutorFactory stack

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16585: URL: https://github.com/apache/flink/pull/16585#issuecomment-885711125 ## CI report: * d3b1b923e7281cf73528203380352e5cf2fd8f60 Azure:

[jira] [Reopened] (FLINK-23434) Inconsistent rowtypes occur in IncrementalAggregateRule

2021-07-23 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reopened FLINK-23434: -- > Inconsistent rowtypes occur in IncrementalAggregateRule >

[jira] [Commented] (FLINK-23434) Inconsistent rowtypes occur in IncrementalAggregateRule

2021-07-23 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386335#comment-17386335 ] Dawid Wysakowicz commented on FLINK-23434: -- Reverted because of test instabilities: * master **

[GitHub] [flink] flinkbot edited a comment on pull request #16584: [FLINK-22781][table-planner-blink] Fix bug that when implements the L…

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16584: URL: https://github.com/apache/flink/pull/16584#issuecomment-885710999 ## CI report: * beeecc75734e1ffe1033d4ffbda7ee43e7d57e5f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16582: [FLINK-21504][checkpoint] Introduce notification of subsumed checkpoint

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16582: URL: https://github.com/apache/flink/pull/16582#issuecomment-885598535 ## CI report: * 935abc391163053cdc2d5fb35d5f321844f0e8b1 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16581: [FLINK-23474] Extract internal version of InputStatus

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16581: URL: https://github.com/apache/flink/pull/16581#issuecomment-885598437 ## CI report: * 01e8a49c115ed91e3f1b50c0cb518e1575440452 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885655624 ## CI report: * 6d52dc0b2a06b3aab47330cded257aac8ba306f8 Azure:

[GitHub] [flink] tillrohrmann commented on a change in pull request #16558: [FLINK-22893][zookeeper] Replace NodeCache with TreeCache

2021-07-23 Thread GitBox
tillrohrmann commented on a change in pull request #16558: URL: https://github.com/apache/flink/pull/16558#discussion_r675665817 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/util/ZooKeeperUtilsTreeCacheTest.java ## @@ -0,0 +1,158 @@ +/* + * Licensed to

[GitHub] [flink] flinkbot edited a comment on pull request #16563: [FLINK-22540][sql-client] Remove Yaml environment file in SQL Client

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16563: URL: https://github.com/apache/flink/pull/16563#issuecomment-884699874 ## CI report: * 821aceafdd1a40911266c5be58a65a5f63fa535d Azure:

[GitHub] [flink] dmvk commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
dmvk commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675667186 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[GitHub] [flink] wangyang0918 commented on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
wangyang0918 commented on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885725731 @yittg @dmvk I have to admit that using a dedicated thread for each watch will make the code easier to read and maintain. IIRC, each job will need three threads for

[GitHub] [flink] tillrohrmann commented on a change in pull request #16535: [FLINK-21979] Cleanup completed checkpoint store after dispatcher cleans up HA services

2021-07-23 Thread GitBox
tillrohrmann commented on a change in pull request #16535: URL: https://github.com/apache/flink/pull/16535#discussion_r675614877 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherFailoverITCase.java ## @@ -0,0 +1,205 @@ +package

[GitHub] [flink] flinkbot commented on pull request #16585: [FLINK-23482][table] Simplify BlinkExecutorFactory stack

2021-07-23 Thread GitBox
flinkbot commented on pull request #16585: URL: https://github.com/apache/flink/pull/16585#issuecomment-885711125 ## CI report: * d3b1b923e7281cf73528203380352e5cf2fd8f60 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #16584: [FLINK-22781][table-planner-blink] Fix bug that when implements the L…

2021-07-23 Thread GitBox
flinkbot commented on pull request #16584: URL: https://github.com/apache/flink/pull/16584#issuecomment-885710999 ## CI report: * beeecc75734e1ffe1033d4ffbda7ee43e7d57e5f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #16563: [FLINK-22540][sql-client] Remove Yaml environment file in SQL Client

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16563: URL: https://github.com/apache/flink/pull/16563#issuecomment-884699874 ## CI report: * 821aceafdd1a40911266c5be58a65a5f63fa535d Azure:

[GitHub] [flink] yittg commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
yittg commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675641227 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[GitHub] [flink] flinkbot edited a comment on pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #15229: URL: https://github.com/apache/flink/pull/15229#issuecomment-82978 ## CI report: * 3634233a1caa445258572701262e326c90b7ecf4 Azure:

[GitHub] [flink] pnowojski commented on a change in pull request #16581: [FLINK-23474] Extract internal version of InputStatus

2021-07-23 Thread GitBox
pnowojski commented on a change in pull request #16581: URL: https://github.com/apache/flink/pull/16581#discussion_r675633835 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java ## @@ -276,20 +277,33 @@ public void

[GitHub] [flink] flinkbot commented on pull request #16585: [FLINK-23482][table] Simplify BlinkExecutorFactory stack

2021-07-23 Thread GitBox
flinkbot commented on pull request #16585: URL: https://github.com/apache/flink/pull/16585#issuecomment-885701404 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-23482) Simplify BlinkExecutorFactory stack

2021-07-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-23482: --- Labels: pull-request-available (was: ) > Simplify BlinkExecutorFactory stack >

[GitHub] [flink] twalthr opened a new pull request #16585: [FLINK-23482][table] Simplify BlinkExecutorFactory stack

2021-07-23 Thread GitBox
twalthr opened a new pull request #16585: URL: https://github.com/apache/flink/pull/16585 ## What is the purpose of the change This simplifies the `Executor` stack in the table modules to unified single `DefaultExecutor` that is discovered using `FactoryUtil`. ## Verifying

[GitHub] [flink] flinkbot edited a comment on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885655624 ## CI report: * 6d52dc0b2a06b3aab47330cded257aac8ba306f8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16563: [FLINK-22540][sql-client] Remove Yaml environment file in SQL Client

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16563: URL: https://github.com/apache/flink/pull/16563#issuecomment-884699874 ## CI report: * 821aceafdd1a40911266c5be58a65a5f63fa535d Azure:

[GitHub] [flink] flinkbot commented on pull request #16584: [FLINK-22781][table-planner-blink] Fix bug that when implements the L…

2021-07-23 Thread GitBox
flinkbot commented on pull request #16584: URL: https://github.com/apache/flink/pull/16584#issuecomment-885690663 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] adiaixin opened a new pull request #16584: [FLINK-22781][table-planner-blink] Fix bug that when implements the L…

2021-07-23 Thread GitBox
adiaixin opened a new pull request #16584: URL: https://github.com/apache/flink/pull/16584 …ookupFunction In SQL that indirect extends (Async)TableFunction, throw exception ## What is the purpose of the change when implements the LookupFunction In SQL that indirect

[GitHub] [flink] yittg commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
yittg commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675606956 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[GitHub] [flink] yittg commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
yittg commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675606956 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[jira] [Commented] (FLINK-22802) Bump Fabric8 Kubernetes Client to >= 5.X

2021-07-23 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386261#comment-17386261 ] Till Rohrmann commented on FLINK-22802: --- Is there a specific reason why you suspect that it might

[jira] [Closed] (FLINK-23402) Expose a consistent GlobalDataExchangeMode

2021-07-23 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-23402. Release Note: The default DataStream API shuffle mode for batch executions has been changed to

[jira] [Updated] (FLINK-23402) Expose a consistent GlobalDataExchangeMode

2021-07-23 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-23402: - Description: The Table API makes the {{GlobalDataExchangeMode}} configurable via

[GitHub] [flink] flinkbot edited a comment on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885655624 ## CI report: * 6d52dc0b2a06b3aab47330cded257aac8ba306f8 Azure:

[GitHub] [flink] twalthr closed pull request #16578: [FLINK-23402][streaming-java][table-planner] Add ShuffleMode option

2021-07-23 Thread GitBox
twalthr closed pull request #16578: URL: https://github.com/apache/flink/pull/16578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] dmvk commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
dmvk commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675599266 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[GitHub] [flink] yittg commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
yittg commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675595456 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[GitHub] [flink] dmvk commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
dmvk commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675594854 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[GitHub] [flink] yittg commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
yittg commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675588061 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[GitHub] [flink] yittg commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
yittg commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675590385 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[GitHub] [flink] yittg commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
yittg commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675589947 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[jira] [Updated] (FLINK-23312) Use -Dfast for building e2e tests on AZP

2021-07-23 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-23312: - Fix Version/s: (was: 1.13.3) 1.13.2 > Use -Dfast for building e2e tests on AZP >

[GitHub] [flink] yittg commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
yittg commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675588061 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[jira] [Updated] (FLINK-22547) OperatorCoordinatorHolderTest. verifyCheckpointEventOrderWhenCheckpointFutureCompletesLate fail

2021-07-23 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-22547: - Fix Version/s: (was: 1.13.3) 1.13.2 > OperatorCoordinatorHolderTest. >

[jira] [Updated] (FLINK-22898) HiveParallelismInference limit return wrong parallelism

2021-07-23 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-22898: - Fix Version/s: (was: 1.13.3) 1.13.2 > HiveParallelismInference limit return

[jira] [Updated] (FLINK-23201) The check on alignmentDurationNanos seems to be too strict

2021-07-23 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-23201: - Fix Version/s: (was: 1.13.3) 1.13.2 > The check on alignmentDurationNanos seems

[jira] [Updated] (FLINK-23188) Unsupported function definition: IFNULL. Only user defined functions are supported as inline functions

2021-07-23 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-23188: - Fix Version/s: (was: 1.13.3) 1.13.2 > Unsupported function definition: IFNULL.

[jira] [Resolved] (FLINK-21411) The components on which Flink depends may contain vulnerabilities. If yes, fix them.

2021-07-23 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-21411. -- Assignee: Yun Tang Resolution: Fixed > The components on which Flink depends may contain

[jira] [Updated] (FLINK-21411) The components on which Flink depends may contain vulnerabilities. If yes, fix them.

2021-07-23 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-21411: - Fix Version/s: 1.14.0 > The components on which Flink depends may contain vulnerabilities. If yes, >

[jira] [Updated] (FLINK-21411) The components on which Flink depends may contain vulnerabilities. If yes, fix them.

2021-07-23 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-21411: - Fix Version/s: 1.13.2 1.12.5 1.11.4 > The components on which

[GitHub] [flink] flinkbot commented on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
flinkbot commented on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885655624 ## CI report: * 6d52dc0b2a06b3aab47330cded257aac8ba306f8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #15229: URL: https://github.com/apache/flink/pull/15229#issuecomment-82978 ## CI report: * 6e7591d29175ce0541c63d7e17dcc4dfcebd6c02 Azure:

[GitHub] [flink] twalthr commented on a change in pull request #16482: [FLINK-23369][docs][connector-hive][connector-kafka] Improve config options by using enums

2021-07-23 Thread GitBox
twalthr commented on a change in pull request #16482: URL: https://github.com/apache/flink/pull/16482#discussion_r675575951 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/config/StartupMode.java ## @@ -19,6 +19,8

[GitHub] [flink] dmvk commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
dmvk commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675579447 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[GitHub] [flink] dmvk commented on a change in pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
dmvk commented on a change in pull request #16583: URL: https://github.com/apache/flink/pull/16583#discussion_r675576934 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesSharedInformer.java ## @@ -265,14 +265,26 @@

[jira] [Commented] (FLINK-23478) KubernetesSharedInformerITCase.testWatchWithBlockHandler fails on Azure

2021-07-23 Thread Yi Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386232#comment-17386232 ] Yi Tang commented on FLINK-23478: - [~fly_in_gis] I've added a patch to fix this issue, please help to

[GitHub] [flink] flinkbot edited a comment on pull request #15229: [FLINK-19142][runtime] Fix slot hijacking after task failover

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #15229: URL: https://github.com/apache/flink/pull/15229#issuecomment-82978 ## CI report: * 6e7591d29175ce0541c63d7e17dcc4dfcebd6c02 Azure:

[GitHub] [flink] flinkbot commented on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
flinkbot commented on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885630061 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-23478) KubernetesSharedInformerITCase.testWatchWithBlockHandler fails on Azure

2021-07-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-23478: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] yittg commented on pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
yittg commented on pull request #16583: URL: https://github.com/apache/flink/pull/16583#issuecomment-885628185 cc @wangyang0918 @dmvk @tillrohrmann -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] yittg opened a new pull request #16583: [FLINK-23478][k8s] Guarantee the watching event handling order

2021-07-23 Thread GitBox
yittg opened a new pull request #16583: URL: https://github.com/apache/flink/pull/16583 ## What is the purpose of the change Guarantee the watching event handling order manually in KubernetesSharedInformer instead of depending on a lock. ## Brief change log

[GitHub] [flink] flinkbot edited a comment on pull request #16581: [FLINK-23474] Extract internal version of InputStatus

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16581: URL: https://github.com/apache/flink/pull/16581#issuecomment-885598437 ## CI report: * 01e8a49c115ed91e3f1b50c0cb518e1575440452 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16582: [FLINK-21504][checkpoint] Introduce notification of subsumed checkpoint

2021-07-23 Thread GitBox
flinkbot edited a comment on pull request #16582: URL: https://github.com/apache/flink/pull/16582#issuecomment-885598535 ## CI report: * 935abc391163053cdc2d5fb35d5f321844f0e8b1 Azure:

[jira] [Commented] (FLINK-23479) IncrementalAggregateJsonPlanTest.testIncrementalAggregateWithSumCountDistinctAndRetraction fail

2021-07-23 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386217#comment-17386217 ] Dawid Wysakowicz commented on FLINK-23479: --

[GitHub] [flink] zhuzhurk commented on a change in pull request #16314: [FLINK-23005][coordination] Cache the compressed serialized value of ShuffleDescriptors

2021-07-23 Thread GitBox
zhuzhurk commented on a change in pull request #16314: URL: https://github.com/apache/flink/pull/16314#discussion_r675531633 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactoryTest.java ## @@ -0,0 +1,398 @@ +/* + *

[jira] [Updated] (FLINK-11813) Standby per job mode Dispatchers don't know job's JobSchedulingStatus

2021-07-23 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-11813: -- Fix Version/s: (was: 1.14.0) 1.15.0 > Standby per job mode Dispatchers

[jira] [Assigned] (FLINK-19142) Investigate slot hijacking from preceding pipelined regions after failover

2021-07-23 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-19142: - Assignee: Zhu Zhu > Investigate slot hijacking from preceding pipelined regions after

  1   2   3   >