[GitHub] [flink] flinkbot edited a comment on pull request #17010: [FLINK-24003][python] Fix lookback mode doesn't work when mixing use of Python Table API and Python DataStream API

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17010: URL: https://github.com/apache/flink/pull/17010#issuecomment-906989888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol merged pull request #17057: [FLINK-24056][HA]Remove unused ZooKeeperUtilityFactory.java

2021-08-31 Thread GitBox
zentol merged pull request #17057: URL: https://github.com/apache/flink/pull/17057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17065: [FLINK-24062][python] Fix the serialization of timer to avoid serializing timer data partially

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17065: URL: https://github.com/apache/flink/pull/17065#issuecomment-908917839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] AHeise merged pull request #17052: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
AHeise merged pull request #17052: URL: https://github.com/apache/flink/pull/17052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] wsry commented on a change in pull request #16988: [FLINK-23458][docs] Added the network buffer documentation along wit…

2021-08-31 Thread GitBox
wsry commented on a change in pull request #16988: URL: https://github.com/apache/flink/pull/16988#discussion_r699354935 ## File path: docs/content/docs/deployment/network_buffer.md ## @@ -0,0 +1,125 @@ +--- +title: "Network Tuning" +weight: 100 +type: docs +aliases: + -

[GitHub] [flink] RocMarshal commented on pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-31 Thread GitBox
RocMarshal commented on pull request #16723: URL: https://github.com/apache/flink/pull/16723#issuecomment-909273188 @wuchong Thank you so much for the comments. And I updated it based on your suggestions. PTAL. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] twalthr closed pull request #17011: [FLINK-23663][table-planner] Reduce state size of ChangelogNormalize

2021-08-31 Thread GitBox
twalthr closed pull request #17011: URL: https://github.com/apache/flink/pull/17011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] dianfu closed pull request #17045: [FLINK-23924][python][examples] Add PyFlink examples

2021-08-31 Thread GitBox
dianfu closed pull request #17045: URL: https://github.com/apache/flink/pull/17045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] hililiwei commented on pull request #17056: [FLINK-23748][tests] Testing window TVF session window

2021-08-31 Thread GitBox
hililiwei commented on pull request #17056: URL: https://github.com/apache/flink/pull/17056#issuecomment-908772017 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] sjwiesman closed pull request #17076: [FLINK-24084][docs] Correct the examples in SQL JOIN docs

2021-08-31 Thread GitBox
sjwiesman closed pull request #17076: URL: https://github.com/apache/flink/pull/17076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-23797) SavepointITCase.testStopSavepointWithBoundedInput fails on azure

2021-08-31 Thread Anton Kalashnikov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Kalashnikov reassigned FLINK-23797: - Assignee: Anton Kalashnikov >

[jira] [Created] (FLINK-24088) "Internal server error" when quitting a SELECT query in the SqlClient

2021-08-31 Thread Matthias (Jira)
Matthias created FLINK-24088: Summary: "Internal server error" when quitting a SELECT query in the SqlClient Key: FLINK-24088 URL: https://issues.apache.org/jira/browse/FLINK-24088 Project: Flink

[GitHub] [flink] flinkbot edited a comment on pull request #17063: [FLINK-24060][Tests]Move ZooKeeperUtilTest to right class

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17063: URL: https://github.com/apache/flink/pull/17063#issuecomment-908868069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] AHeise commented on a change in pull request #17058: [FLINK-23664][docs] Add docs for KafkaSink

2021-08-31 Thread GitBox
AHeise commented on a change in pull request #17058: URL: https://github.com/apache/flink/pull/17058#discussion_r698621444 ## File path: docs/content/docs/connectors/datastream/kafka.md ## @@ -613,134 +613,89 @@ Otherwise, the watermarks of the whole application cannot

[GitHub] [flink] flinkbot commented on pull request #17055: [FLINK-22367][streaming] Reset syncSavepointId only if it is equal to…

2021-08-31 Thread GitBox
flinkbot commented on pull request #17055: URL: https://github.com/apache/flink/pull/17055#issuecomment-908431742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] Airblader commented on a change in pull request #17011: [FLINK-23663][table-planner] Reduce state size of ChangelogNormalize

2021-08-31 Thread GitBox
Airblader commented on a change in pull request #17011: URL: https://github.com/apache/flink/pull/17011#discussion_r698432369 ## File path:

[GitHub] [flink] flinkbot edited a comment on pull request #17068: [FLINK-24041][connectors] Flip 171 - Abstract Async Sink Base

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17068: URL: https://github.com/apache/flink/pull/17068#issuecomment-909101643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17022: [FLINK-24020][web] Aggregate HTTP requests before custom netty handers are getting the data

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17022: URL: https://github.com/apache/flink/pull/17022#issuecomment-907158087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17056: [FLINK-23748][tests] Testing window TVF session window

2021-08-31 Thread GitBox
flinkbot commented on pull request #17056: URL: https://github.com/apache/flink/pull/17056#issuecomment-908431706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17065: [FLINK-24062][python] Fix the serialization of timer to avoid serializing timer data partially

2021-08-31 Thread GitBox
flinkbot commented on pull request #17065: URL: https://github.com/apache/flink/pull/17065#issuecomment-908909475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-web] sjwiesman closed pull request #463: Statefun release 3.1

2021-08-31 Thread GitBox
sjwiesman closed pull request #463: URL: https://github.com/apache/flink-web/pull/463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] fapaul commented on a change in pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-31 Thread GitBox
fapaul commented on a change in pull request #17019: URL: https://github.com/apache/flink/pull/17019#discussion_r699070362 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PrioritizedOperatorSubtaskState.java ## @@ -192,7 +196,17 @@ *

[GitHub] [flink] flinkbot commented on pull request #17059: [FLINK-24005][coordination] Only return fulfilled requirements for reserved slots

2021-08-31 Thread GitBox
flinkbot commented on pull request #17059: URL: https://github.com/apache/flink/pull/17059#issuecomment-908435350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol commented on a change in pull request #17051: [FLINK-23978][scala] Move Scala-reliant FieldAccessors to flink-streaming-scala

2021-08-31 Thread GitBox
zentol commented on a change in pull request #17051: URL: https://github.com/apache/flink/pull/17051#discussion_r698607055 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java ## @@ -30,14 +30,23 @@ import

[GitHub] [flink] flinkbot edited a comment on pull request #17025: [FLINK-24029][docs] Update doc example sql field in release-1.13.2 to dept_id

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17025: URL: https://github.com/apache/flink/pull/17025#issuecomment-907189639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-24087) Kafka connector StartupMode requires a table dependency

2021-08-31 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407424#comment-17407424 ] Leonard Xu commented on FLINK-24087: nice catch! I'd like to help fix this one > Kafka connector

[GitHub] [flink] flinkbot edited a comment on pull request #17055: [FLINK-22367][streaming] Reset syncSavepointId only if it is equal to…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17055: URL: https://github.com/apache/flink/pull/17055#issuecomment-908449155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Assigned] (FLINK-24087) Kafka connector StartupMode requires a table dependency

2021-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-24087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Bürk reassigned FLINK-24087: - Assignee: Ingo Bürk > Kafka connector StartupMode requires a table dependency >

[GitHub] [flink] AHeise commented on pull request #16966: [FLINK-23875][connectors/kafka] Snapshot reduceBuffer of ReducingUpse…

2021-08-31 Thread GitBox
AHeise commented on pull request #16966: URL: https://github.com/apache/flink/pull/16966#issuecomment-909147805 Failure completely unrelated (FLINK-15451). Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] flinkbot edited a comment on pull request #17052: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17052: URL: https://github.com/apache/flink/pull/17052#issuecomment-908310855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17062: [FLINK-21090][tests] Add IT case for stop-with-savepoint and final checkpoint (1.14)

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17062: URL: https://github.com/apache/flink/pull/17062#issuecomment-908868024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17074: [FLINK-24081][table-planner] Fix StreamExecOverAggregate and StreamExecTemporalSort operator didn't support LocalZonedTimestampType

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17074: URL: https://github.com/apache/flink/pull/17074#issuecomment-909240894 ## CI report: * 3a29aa6e7ce0cd8c5c4a46615378b7eb36bea78d Azure:

[GitHub] [flink] fapaul commented on a change in pull request #17058: [FLINK-23664][docs] Add docs for KafkaSink

2021-08-31 Thread GitBox
fapaul commented on a change in pull request #17058: URL: https://github.com/apache/flink/pull/17058#discussion_r699022014 ## File path: docs/content/docs/connectors/datastream/kafka.md ## @@ -613,134 +613,89 @@ Otherwise, the watermarks of the whole application cannot

[GitHub] [flink] flinkbot commented on pull request #17061: [FLINK-23977][elasticsearch] Added DynamicElasticsearchSink for Dynamic ES Cluster Routing

2021-08-31 Thread GitBox
flinkbot commented on pull request #17061: URL: https://github.com/apache/flink/pull/17061#issuecomment-908713061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17078: [FLINK-23468][test] Do not hide original exception if SSL is not available

2021-08-31 Thread GitBox
flinkbot commented on pull request #17078: URL: https://github.com/apache/flink/pull/17078#issuecomment-909252758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17063: [FLINK-24060][Tests]Move ZooKeeperUtilTest to right class

2021-08-31 Thread GitBox
flinkbot commented on pull request #17063: URL: https://github.com/apache/flink/pull/17063#issuecomment-908856687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] Myasuka commented on pull request #17025: [FLINK-24029][docs] Update doc example sql field in release-1.13.2 to dept_id

2021-08-31 Thread GitBox
Myasuka commented on pull request #17025: URL: https://github.com/apache/flink/pull/17025#issuecomment-908850566 Though this PR is samll, I think @wuchong is better to review this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] flinkbot commented on pull request #17077: [FLINK-24085][docs] Add first class subject for page `versioned table` and `Timezone`

2021-08-31 Thread GitBox
flinkbot commented on pull request #17077: URL: https://github.com/apache/flink/pull/17077#issuecomment-909236529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17075: [FLINK-24035][network][refactor] Move the blocking allocation of one floating buffer logic from the constructor of LocalBufferPool to

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17075: URL: https://github.com/apache/flink/pull/17075#issuecomment-909241018 ## CI report: * ccdf9bfaaa9e6d6eefb728b07ccf69df8233e93a Azure:

[GitHub] [flink] dmvk commented on pull request #17000: [FLINK-23946][clients] Application mode should shutdown gracefully on…

2021-08-31 Thread GitBox
dmvk commented on pull request #17000: URL: https://github.com/apache/flink/pull/17000#issuecomment-908711529 @tillrohrmann Thanks for the review! I've incorporated your suggestions, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] twalthr closed pull request #17060: [FLINK-23895][table] Upsert materializer is not inserted for all sink providers

2021-08-31 Thread GitBox
twalthr closed pull request #17060: URL: https://github.com/apache/flink/pull/17060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17069: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17069: URL: https://github.com/apache/flink/pull/17069#issuecomment-909162379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17019: [FLINK-23854][connectors/Kafka] Ensure lingering Kafka transactions are aborted reliably.

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17019: URL: https://github.com/apache/flink/pull/17019#issuecomment-907120059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17071: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
flinkbot commented on pull request #17071: URL: https://github.com/apache/flink/pull/17071#issuecomment-909159653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] wuchong merged pull request #16997: [FLINK-23287][docs][table] Create user document for Window Join in SQL

2021-08-31 Thread GitBox
wuchong merged pull request #16997: URL: https://github.com/apache/flink/pull/16997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] pnowojski commented on a change in pull request #16988: [FLINK-23458][docs] Added the network buffer documentation along wit…

2021-08-31 Thread GitBox
pnowojski commented on a change in pull request #16988: URL: https://github.com/apache/flink/pull/16988#discussion_r699022660 ## File path: docs/content/docs/deployment/network_buffer.md ## @@ -0,0 +1,125 @@ +--- +title: "Network Tuning" +weight: 100 +type: docs +aliases: + -

[GitHub] [flink] flinkbot commented on pull request #17060: [FLINK-23895][table] Upsert materializer is not inserted for all sink providers

2021-08-31 Thread GitBox
flinkbot commented on pull request #17060: URL: https://github.com/apache/flink/pull/17060#issuecomment-908477234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol commented on pull request #17051: [FLINK-23978][scala] Move Scala-reliant FieldAccessors to flink-streaming-scala

2021-08-31 Thread GitBox
zentol commented on pull request #17051: URL: https://github.com/apache/flink/pull/17051#issuecomment-908462664 > Also compare to my draft #17036 which when user uses Scala, the reflection always succeeds, this patch let the user explicitly depend on flink-streaming-scala. It is user

[GitHub] [flink] zentol closed pull request #17043: [FLINK-23976] [Runtime / Metrics] Add additional availability timing metrics to Job lifecycle events

2021-08-31 Thread GitBox
zentol closed pull request #17043: URL: https://github.com/apache/flink/pull/17043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] autophagy commented on a change in pull request #16941: [FLINK-23839][connectors-kafka] Give a more descriptive warnings on I…

2021-08-31 Thread GitBox
autophagy commented on a change in pull request #16941: URL: https://github.com/apache/flink/pull/16941#discussion_r698580433 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaCommitter.java ## @@ -61,13 +62,25 @@

[GitHub] [flink] RocMarshal commented on a change in pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-31 Thread GitBox
RocMarshal commented on a change in pull request #16723: URL: https://github.com/apache/flink/pull/16723#discussion_r698603916 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentITCase.scala ## @@ -808,6 +808,162 @@ class

[GitHub] [flink] flinkbot edited a comment on pull request #17073: [FLINK-24058][coordination][tests] Harden TaskSlotTableImplTest#runDeactivateSlotTimeoutTest

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17073: URL: https://github.com/apache/flink/pull/17073#issuecomment-909190473 ## CI report: * 64652a612587229163e00d740031f8b303308c86 Azure:

[GitHub] [flink-web] xintongsong closed pull request #465: announcing the 1.14.0 release candidate

2021-08-31 Thread GitBox
xintongsong closed pull request #465: URL: https://github.com/apache/flink-web/pull/465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #16997: [FLINK-23287][docs][table] Create user document for Window Join in SQL

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16997: URL: https://github.com/apache/flink/pull/16997#issuecomment-906324142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17068: [FLINK-24041][connectors] Flip 171 - Abstract Async Sink Base

2021-08-31 Thread GitBox
flinkbot commented on pull request #17068: URL: https://github.com/apache/flink/pull/17068#issuecomment-909061122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17067: [FLINK-23817][docs] Add metric description to Kafka source and File sink.

2021-08-31 Thread GitBox
flinkbot commented on pull request #17067: URL: https://github.com/apache/flink/pull/17067#issuecomment-908956953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] pnowojski merged pull request #17037: [FLINK-24035][network] Guarantee that the LocalBufferPool is initialized with one buffer

2021-08-31 Thread GitBox
pnowojski merged pull request #17037: URL: https://github.com/apache/flink/pull/17037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] tweise merged pull request #17044: [FLINK-24010][connector/common] HybridSourceReader/Enumerator delegate checkpoint notifications

2021-08-31 Thread GitBox
tweise merged pull request #17044: URL: https://github.com/apache/flink/pull/17044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] AHeise commented on a change in pull request #17067: [FLINK-23817][docs] Add metric description to Kafka source and File sink.

2021-08-31 Thread GitBox
AHeise commented on a change in pull request #17067: URL: https://github.com/apache/flink/pull/17067#discussion_r699181895 ## File path: docs/content/docs/connectors/datastream/kafka.md ## @@ -213,26 +213,115 @@ Note that Kafka source does **NOT** rely on committed offsets

[GitHub] [flink] flinkbot commented on pull request #17064: [FLINK-24059][Connectors/Common] Allow SourceReaderTestBase.NUM_SPLITS to be overridden

2021-08-31 Thread GitBox
flinkbot commented on pull request #17064: URL: https://github.com/apache/flink/pull/17064#issuecomment-908886277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] gaoyunhaii commented on pull request #17062: [FLINK-21090][tests] Add IT case for stop-with-savepoint and final checkpoint (1.14)

2021-08-31 Thread GitBox
gaoyunhaii commented on pull request #17062: URL: https://github.com/apache/flink/pull/17062#issuecomment-908916557 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] Airblader commented on a change in pull request #16805: [FLINK-16501][table] Support IS JSON for Table API

2021-08-31 Thread GitBox
Airblader commented on a change in pull request #16805: URL: https://github.com/apache/flink/pull/16805#discussion_r688288352 ## File path: docs/data/sql_functions.yml ## @@ -83,7 +83,7 @@ logical: table: BOOLEAN1 && BOOLEAN2 description: Returns TRUE if BOOLEAN1 and

[GitHub] [flink] flinkbot edited a comment on pull request #16963: [FLINK-23582][docs][table] Add documentation for session window tvf.

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16963: URL: https://github.com/apache/flink/pull/16963#issuecomment-904569734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] XComp commented on pull request #16989: [FLINK-23611][yarn-tests] Refactors yarn tests and enable hadoop logs

2021-08-31 Thread GitBox
XComp commented on pull request #16989: URL: https://github.com/apache/flink/pull/16989#issuecomment-909301145 FYI: Build failures covered by [FLINK-23984](https://issues.apache.org/jira/browse/FLINK-23984) and [FLINK-23828](https://issues.apache.org/jira/browse/FLINK-23828) -- This is

[GitHub] [flink] flinkbot edited a comment on pull request #17000: [FLINK-23946][clients] Application mode should shutdown gracefully on…

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17000: URL: https://github.com/apache/flink/pull/17000#issuecomment-906394364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol commented on a change in pull request #17007: [FLINK-17495][metrics] Add additional variables config for metric reporters

2021-08-31 Thread GitBox
zentol commented on a change in pull request #17007: URL: https://github.com/apache/flink/pull/17007#discussion_r699155868 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/ReporterSetup.java ## @@ -284,12 +304,19 @@ private static ReporterSetup

[GitHub] [flink] twalthr commented on a change in pull request #17060: [FLINK-23895][table] Upsert materializer is not inserted for all sink providers

2021-08-31 Thread GitBox
twalthr commented on a change in pull request #17060: URL: https://github.com/apache/flink/pull/17060#discussion_r699129141 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java ## @@ -260,76

[GitHub] [flink-web] infoverload commented on a change in pull request #465: announcing the 1.14.0 release candidate

2021-08-31 Thread GitBox
infoverload commented on a change in pull request #465: URL: https://github.com/apache/flink-web/pull/465#discussion_r699076774 ## File path: _posts/2021-08-31-release-1.14.0-rc0.md ## @@ -0,0 +1,39 @@ +--- +layout: post +title: "Help us stabilize Apache Flink 1.14.0 RC0"

[GitHub] [flink] zhwangke commented on pull request #17025: [FLINK-24029][docs] Update doc example sql field in release-1.13.2 to dept_id

2021-08-31 Thread GitBox
zhwangke commented on pull request #17025: URL: https://github.com/apache/flink/pull/17025#issuecomment-908973841 > Could you fix `DeptId` in line 108 as well? @wuchong done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] XComp edited a comment on pull request #16989: [FLINK-23611][yarn-tests] Refactors yarn tests and enable hadoop logs

2021-08-31 Thread GitBox
XComp edited a comment on pull request #16989: URL: https://github.com/apache/flink/pull/16989#issuecomment-909301145 FYI: Build failures of the [most-recent build](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22955) covered by

[GitHub] [flink] lirui-apache commented on a change in pull request #16936: [FLINK-23857][table-runtime][hive] Insert overwrite should clear exis…

2021-08-31 Thread GitBox
lirui-apache commented on a change in pull request #16936: URL: https://github.com/apache/flink/pull/16936#discussion_r698470965 ## File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/TableEnvHiveConnectorITCase.java ## @@ -73,6

[GitHub] [flink] flinkbot edited a comment on pull request #17040: [FLINK-24041][connectors] Flip 171 - Abstract Async Sink Base

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17040: URL: https://github.com/apache/flink/pull/17040#issuecomment-907834154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17053: [FLINK-36488942][HA]Handle curator framework start error by register fatalErrorHandler before start zk client

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17053: URL: https://github.com/apache/flink/pull/17053#issuecomment-908359102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] wuchong merged pull request #16852: [FLINK-13636][docs-zh]Translate the "Flink DataStream API Programming Guide" page into Chinese

2021-08-31 Thread GitBox
wuchong merged pull request #16852: URL: https://github.com/apache/flink/pull/16852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17066: FLINK-24066

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17066: URL: https://github.com/apache/flink/pull/17066#issuecomment-908973411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #16192: [FLINK-22954][table-planner-blink] Rewrite Join on constant TableFunctionScan to Correlate

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16192: URL: https://github.com/apache/flink/pull/16192#issuecomment-863860019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17051: [FLINK-23978][scala] Move Scala-reliant FieldAccessors to flink-streaming-scala

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17051: URL: https://github.com/apache/flink/pull/17051#issuecomment-908310738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-web] joemoe closed pull request #464: announcing the rc0 for 1.14. and asking for help

2021-08-31 Thread GitBox
joemoe closed pull request #464: URL: https://github.com/apache/flink-web/pull/464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17061: [FLINK-23977][elasticsearch] Added DynamicElasticsearchSink for Dynamic ES Cluster Routing

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17061: URL: https://github.com/apache/flink/pull/17061#issuecomment-908742444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17067: [FLINK-23817][docs] Add metric description to Kafka source and File sink.

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17067: URL: https://github.com/apache/flink/pull/17067#issuecomment-908989247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17051: [FLINK-23978][scala] Move Scala-reliant FieldAccessors to flink-streaming-scala

2021-08-31 Thread GitBox
flinkbot commented on pull request #17051: URL: https://github.com/apache/flink/pull/17051#issuecomment-908310738 ## CI report: * 4170c598fb3bfcf4bb9bdf08d06619cf600e3938 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] lirui-apache closed pull request #16907: [FLINK-23897][hive][doc] Fix obsolete doc about creating hive table w…

2021-08-31 Thread GitBox
lirui-apache closed pull request #16907: URL: https://github.com/apache/flink/pull/16907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] zentol commented on a change in pull request #17067: [FLINK-23817][docs] Add metric description to Kafka source and File sink.

2021-08-31 Thread GitBox
zentol commented on a change in pull request #17067: URL: https://github.com/apache/flink/pull/17067#discussion_r699159076 ## File path: docs/content/docs/connectors/datastream/kafka.md ## @@ -213,26 +213,115 @@ Note that Kafka source does **NOT** rely on committed offsets

[GitHub] [flink] wuchong commented on a change in pull request #16723: [FLINK-22885][table] Supports 'SHOW COLUMNS' syntax.

2021-08-31 Thread GitBox
wuchong commented on a change in pull request #16723: URL: https://github.com/apache/flink/pull/16723#discussion_r698484240 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentITCase.scala ## @@ -808,6 +808,162 @@ class

[GitHub] [flink] flinkbot commented on pull request #17053: [FLINK-36488942][HA]Handle curator framework start error by register fatalErrorHandler befor start zk client

2021-08-31 Thread GitBox
flinkbot commented on pull request #17053: URL: https://github.com/apache/flink/pull/17053#issuecomment-908335697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] HuangXingBo closed pull request #17010: [FLINK-24003][python] Fix lookback mode doesn't work when mixing use of Python Table API and Python DataStream API

2021-08-31 Thread GitBox
HuangXingBo closed pull request #17010: URL: https://github.com/apache/flink/pull/17010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] twalthr closed pull request #17048: [FLINK-24033][table-planner] Propagate unique keys for fromChangelogStream

2021-08-31 Thread GitBox
twalthr closed pull request #17048: URL: https://github.com/apache/flink/pull/17048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #17074: [FLINK-24081][table-planner] Fix StreamExecOverAggregate and StreamExecTemporalSort operator didn't support LocalZonedTimestampType

2021-08-31 Thread GitBox
flinkbot commented on pull request #17074: URL: https://github.com/apache/flink/pull/17074#issuecomment-909201603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #16606: [FLINK-21357][runtime/statebackend]Periodic materialization for generalized incremental checkpoints

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #16606: URL: https://github.com/apache/flink/pull/16606#issuecomment-887431748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] twalthr commented on a change in pull request #17011: [FLINK-23663][table-planner] Reduce state size of ChangelogNormalize

2021-08-31 Thread GitBox
twalthr commented on a change in pull request #17011: URL: https://github.com/apache/flink/pull/17011#discussion_r698472194 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableDescriptor.java ## @@ -51,14 +51,14 @@ *

[GitHub] [flink] fapaul commented on pull request #17071: [FLINK-24051][connectors/kafka] Make groupId optional when constructi…

2021-08-31 Thread GitBox
fapaul commented on pull request #17071: URL: https://github.com/apache/flink/pull/17071#issuecomment-909253263 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] wuchong commented on pull request #16852: [FLINK-13636][docs-zh]Translate the "Flink DataStream API Programming Guide" page into Chinese

2021-08-31 Thread GitBox
wuchong commented on pull request #16852: URL: https://github.com/apache/flink/pull/16852#issuecomment-908881206 Thanks @RocMarshal and @hapihu . Will merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-24087) Kafka connector StartupMode requires a table dependency

2021-08-31 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-24087: - Description: Table dependencies are marked as {{optional}} for the Kafka connector. We should

[jira] [Created] (FLINK-24087) Kafka connector StartupMode requires a table dependency

2021-08-31 Thread Timo Walther (Jira)
Timo Walther created FLINK-24087: Summary: Kafka connector StartupMode requires a table dependency Key: FLINK-24087 URL: https://issues.apache.org/jira/browse/FLINK-24087 Project: Flink

[GitHub] [flink] flinkbot edited a comment on pull request #17024: [FLINK-23457][network] The upstream sends the buffer of the right size for broadcast case

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17024: URL: https://github.com/apache/flink/pull/17024#issuecomment-907189537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] Myasuka merged pull request #16992: [FLINK-23519][metrics] Expose state name as varibale if enable state latency tracking

2021-08-31 Thread GitBox
Myasuka merged pull request #16992: URL: https://github.com/apache/flink/pull/16992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] beyond1920 commented on pull request #16997: [FLINK-23287][docs][table] Create user document for Window Join in SQL

2021-08-31 Thread GitBox
beyond1920 commented on pull request #16997: URL: https://github.com/apache/flink/pull/16997#issuecomment-908345723 @wuchong Thanks for suggestion, I've updated the results of sql query. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] flinkbot commented on pull request #17079: [FLINK-24054][table-runtime] Let SinkUpsertMaterializer produce +U's when possible

2021-08-31 Thread GitBox
flinkbot commented on pull request #17079: URL: https://github.com/apache/flink/pull/17079#issuecomment-909298595 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-24087) Kafka connector StartupMode requires a table dependency

2021-08-31 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-24087: - Fix Version/s: 1.14.0 > Kafka connector StartupMode requires a table dependency >

[GitHub] [flink] flinkbot edited a comment on pull request #17060: [FLINK-23895][table] Upsert materializer is not inserted for all sink providers

2021-08-31 Thread GitBox
flinkbot edited a comment on pull request #17060: URL: https://github.com/apache/flink/pull/17060#issuecomment-908500808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

<    1   2   3   4   5   6   7   8   >