[GitHub] [flink] flinkbot edited a comment on pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17581: URL: https://github.com/apache/flink/pull/17581#issuecomment-953068068 ## CI report: * f633faa2fda3807d4600c1c99ab31e666c72c211 Azure:

[GitHub] [flink] fapaul commented on a change in pull request #17687: [FLINK-24227][connectors] Improved AsyncSink base by adding a builder…

2021-11-08 Thread GitBox
fapaul commented on a change in pull request #17687: URL: https://github.com/apache/flink/pull/17687#discussion_r744759976 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java ## @@ -219,25 +278,38

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * 7dfe3c64086dbe4ef1981c8e62512cb34552348b UNKNOWN * 9de90269f89a3d997b4f6083ad68dbe1570b228d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17725: [FLINK-24750][table][docs] Code blocks to prevent sql quotes convertion

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17725: URL: https://github.com/apache/flink/pull/17725#issuecomment-963191520 ## CI report: * 472be86049919833eceb17604ecc04c0ec69fa16 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * 7dfe3c64086dbe4ef1981c8e62512cb34552348b UNKNOWN * 9de90269f89a3d997b4f6083ad68dbe1570b228d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17656: [FLINK-24741]Deprecate FileRecordFormat

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17656: URL: https://github.com/apache/flink/pull/17656#issuecomment-958746092 ## CI report: * 81def1e6dce443bfb65be41356f66bdc751b10a0 Azure:

[GitHub] [flink] flinkbot commented on pull request #17725: [FLINK-24750][table][docs] Code blocks to prevent sql quotes convertion

2021-11-08 Thread GitBox
flinkbot commented on pull request #17725: URL: https://github.com/apache/flink/pull/17725#issuecomment-963192326 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #17725: [FLINK-24750][table][docs] Code blocks to prevent sql quotes convertion

2021-11-08 Thread GitBox
flinkbot commented on pull request #17725: URL: https://github.com/apache/flink/pull/17725#issuecomment-963191520 ## CI report: * 472be86049919833eceb17604ecc04c0ec69fa16 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17656: [FLINK-24741]Deprecate FileRecordFormat

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17656: URL: https://github.com/apache/flink/pull/17656#issuecomment-958746092 ## CI report: * 81def1e6dce443bfb65be41356f66bdc751b10a0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * 7dfe3c64086dbe4ef1981c8e62512cb34552348b UNKNOWN * 9de90269f89a3d997b4f6083ad68dbe1570b228d Azure:

[GitHub] [flink] JingGe commented on pull request #17656: [FLINK-24741]Deprecate FileRecordFormat

2021-11-08 Thread GitBox
JingGe commented on pull request #17656: URL: https://github.com/apache/flink/pull/17656#issuecomment-963188025 fixed all issues, @AHeise would you please help merging the PR, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (FLINK-24750) Single quotes converted to left/right single quotes during docs generation

2021-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24750: --- Labels: pull-request-available (was: ) > Single quotes converted to left/right single

[GitHub] [flink] snuyanzin opened a new pull request #17725: [FLINK-24750][table][docs] Code blocks to prevent sql quotes convertion

2021-11-08 Thread GitBox
snuyanzin opened a new pull request #17725: URL: https://github.com/apache/flink/pull/17725 ## What is the purpose of the change 1. Use code blocks for SQL and backticks for table API to prevent conversion of single quotes to left or right quote (Hugo's default behavior). This was

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * 7dfe3c64086dbe4ef1981c8e62512cb34552348b UNKNOWN * 9de90269f89a3d997b4f6083ad68dbe1570b228d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17560: [FLINK-22315][table] Support ADD column/constraint/watermark for ALTER TABLE statement.

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17560: URL: https://github.com/apache/flink/pull/17560#issuecomment-951002521 ## CI report: * fa9e6f15fb8300ace5f8484289f02474d53a38bf Azure:

[jira] [Updated] (FLINK-24824) AdaptiveScheduler#getJobStatus never returns CREATED

2021-11-08 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-24824: - Parent: (was: FLINK-21510) Issue Type: Bug (was: Sub-task) >

[GitHub] [flink] flinkbot edited a comment on pull request #17712: [FLINK-24816][rabbitmq] Bump amqp-client to v5.13.1

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17712: URL: https://github.com/apache/flink/pull/17712#issuecomment-962935797 ## CI report: * 9faf7e7beed534bdab0458cd636dcc5e00117e64 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * 7dfe3c64086dbe4ef1981c8e62512cb34552348b UNKNOWN * 9de90269f89a3d997b4f6083ad68dbe1570b228d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17560: [FLINK-22315][table] Support ADD column/constraint/watermark for ALTER TABLE statement.

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17560: URL: https://github.com/apache/flink/pull/17560#issuecomment-951002521 ## CI report: * fa9e6f15fb8300ace5f8484289f02474d53a38bf Azure:

[jira] [Resolved] (FLINK-24798) Bump commons-cli to v1.5.0

2021-11-08 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser resolved FLINK-24798. Resolution: Fixed Merged into master: a9522367bdfb339a90e820086d7ac61b09083978 > Bump

[GitHub] [flink] ysymi commented on a change in pull request #17698: [FLINK-24689][runtime-web] Add log's last modify time in log list view

2021-11-08 Thread GitBox
ysymi commented on a change in pull request #17698: URL: https://github.com/apache/flink/pull/17698#discussion_r744745247 ## File path: flink-runtime-web/web-dashboard/src/app/pages/task-manager/log-list/task-manager-log-list.component.html ## @@ -29,14 +29,16 @@

[GitHub] [flink] flinkbot edited a comment on pull request #17724: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17724: URL: https://github.com/apache/flink/pull/17724#issuecomment-963167087 ## CI report: * c9ce7f29985ef0b82983c86ca24920b54ebb67f3 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * 7dfe3c64086dbe4ef1981c8e62512cb34552348b UNKNOWN * 9de90269f89a3d997b4f6083ad68dbe1570b228d Azure:

[jira] [Resolved] (FLINK-24665) Update Presto Hadoop dependency to latest version

2021-11-08 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser resolved FLINK-24665. Resolution: Fixed Merged in master: 756158ada389daca27c32bfa19a5e38e25079a91 > Update

[GitHub] [flink] flinkbot commented on pull request #17724: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-08 Thread GitBox
flinkbot commented on pull request #17724: URL: https://github.com/apache/flink/pull/17724#issuecomment-963167087 ## CI report: * c9ce7f29985ef0b82983c86ca24920b54ebb67f3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #17724: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-08 Thread GitBox
flinkbot commented on pull request #17724: URL: https://github.com/apache/flink/pull/17724#issuecomment-963166617 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * 7dfe3c64086dbe4ef1981c8e62512cb34552348b UNKNOWN * 9de90269f89a3d997b4f6083ad68dbe1570b228d Azure:

[GitHub] [flink] RocMarshal edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-11-08 Thread GitBox
RocMarshal edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337942 @dianfu @twalthr @JingsongLi Could you help me to check it ? Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] RocMarshal edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the n

2021-11-08 Thread GitBox
RocMarshal edited a comment on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-963105801 @Airblader @twalthr @klion26 Could you help me to review this pr ? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] RocMarshal edited a comment on pull request #17548: [FLINK-24383][streaming] Remove the deprecated SlidingTimeWindows, TumblingTimeWindows, BaseAlignedWindowAssigner.

2021-11-08 Thread GitBox
RocMarshal edited a comment on pull request #17548: URL: https://github.com/apache/flink/pull/17548#issuecomment-950549753 Hi, @wuchong @xintongsong @twalthr @klion26 Could you help me to check this pr ?Thank you. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] Tartarus0zm commented on pull request #17724: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-08 Thread GitBox
Tartarus0zm commented on pull request #17724: URL: https://github.com/apache/flink/pull/17724#issuecomment-963163405 @JingsongLi please take a look, if you have time, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] Tartarus0zm opened a new pull request #17724: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-08 Thread GitBox
Tartarus0zm opened a new pull request #17724: URL: https://github.com/apache/flink/pull/17724 ## What is the purpose of the change Solve the problem of compile fail of PartitionPruner generated code due to classloader error. ## Brief change log Change `PartitionPruner`

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * 7dfe3c64086dbe4ef1981c8e62512cb34552348b UNKNOWN * 9de90269f89a3d997b4f6083ad68dbe1570b228d Azure:

[GitHub] [flink] ysymi commented on a change in pull request #17698: [FLINK-24689][runtime-web] Add log's last modify time in log list view

2021-11-08 Thread GitBox
ysymi commented on a change in pull request #17698: URL: https://github.com/apache/flink/pull/17698#discussion_r744734983 ## File path: flink-runtime-web/web-dashboard/src/app/pages/task-manager/log-list/task-manager-log-list.component.html ## @@ -29,14 +29,16 @@

[GitHub] [flink] CrynetLogistics commented on a change in pull request #17583: [FLINK-24639][kinesis] Add UniformShardAssigner

2021-11-08 Thread GitBox
CrynetLogistics commented on a change in pull request #17583: URL: https://github.com/apache/flink/pull/17583#discussion_r744733412 ## File path: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/UniformShardAssignerTest.java

[GitHub] [flink] AHeise merged pull request #17574: [FLINK-24665][s3] Update Presto Hadoop dependency to v2.7.4-9

2021-11-08 Thread GitBox
AHeise merged pull request #17574: URL: https://github.com/apache/flink/pull/17574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] AHeise merged pull request #17695: [FLINK-24798][cli] Bump commons-cli to v1.5.0

2021-11-08 Thread GitBox
AHeise merged pull request #17695: URL: https://github.com/apache/flink/pull/17695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * 7dfe3c64086dbe4ef1981c8e62512cb34552348b UNKNOWN * 9de90269f89a3d997b4f6083ad68dbe1570b228d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17723: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17723: URL: https://github.com/apache/flink/pull/17723#issuecomment-963153415 ## CI report: * 2f4c6603733bdd34346318fb593486f85557d2ac Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17676: [FLINK-14100][connectors] Add Oracle dialect

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17676: URL: https://github.com/apache/flink/pull/17676#issuecomment-960641444 ## CI report: * 899520e58b5703af7160bc10bc74a52852fc0e74 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * 7dfe3c64086dbe4ef1981c8e62512cb34552348b UNKNOWN * ff2edf06abac54e2c41cc4d11d29feba0e8b6d29 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors/kinesis] Added Kinesis Data Streams Sink i…

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * 4f4b9435ed8af37966a5a5216f149745da511c84 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17722: [FLINK-24774] Adaptive scheduler notifies listeners for all job state transitions

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17722: URL: https://github.com/apache/flink/pull/17722#issuecomment-963149329 ## CI report: * 71cfbc8ea9a642b8cbef6b67e5c51bf45dea9600 Azure:

[GitHub] [flink] flinkbot commented on pull request #17723: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-08 Thread GitBox
flinkbot commented on pull request #17723: URL: https://github.com/apache/flink/pull/17723#issuecomment-963153415 ## CI report: * 2f4c6603733bdd34346318fb593486f85557d2ac UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * 7dfe3c64086dbe4ef1981c8e62512cb34552348b UNKNOWN * ff2edf06abac54e2c41cc4d11d29feba0e8b6d29 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17634: [FLINK-24691][table-common] Fix precision for sum on decimal types

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17634: URL: https://github.com/apache/flink/pull/17634#issuecomment-956440201 ## CI report: * 81cc36e55a9bce75278098f44deb8b370dcd2b16 Azure:

[GitHub] [flink] Airblader commented on a change in pull request #17691: [FLINK-24586][table] SQL functions should return STRING instead of VARCHAR(2000)

2021-11-08 Thread GitBox
Airblader commented on a change in pull request #17691: URL: https://github.com/apache/flink/pull/17691#discussion_r744724075 ## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java ## @@ -339,7 +339,7 @@

[GitHub] [flink] flinkbot edited a comment on pull request #17345: [FLINK-24227][connectors/kinesis] Added Kinesis Data Streams Sink i…

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17345: URL: https://github.com/apache/flink/pull/17345#issuecomment-926109717 ## CI report: * 4f4b9435ed8af37966a5a5216f149745da511c84 Azure:

[GitHub] [flink] flinkbot commented on pull request #17723: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-08 Thread GitBox
flinkbot commented on pull request #17723: URL: https://github.com/apache/flink/pull/17723#issuecomment-963151287 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Comment Edited] (FLINK-22869) SQLClientSchemaRegistryITCase timeouts on azure

2021-11-08 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440455#comment-17440455 ] Martijn Visser edited comment on FLINK-22869 at 11/8/21, 1:28 PM: --

[jira] [Commented] (FLINK-22869) SQLClientSchemaRegistryITCase timeouts on azure

2021-11-08 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440455#comment-17440455 ] Martijn Visser commented on FLINK-22869: [~trohrmann] I briefly looked into the test but I

[GitHub] [flink] flinkbot edited a comment on pull request #17721: [FLINK-24822][table-planner]Improve CatalogTableSpecBase and its subclass related method parameter

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17721: URL: https://github.com/apache/flink/pull/17721#issuecomment-963145399 ## CI report: * d52449c9e030acb1936ee2b5429fedcd2b6f2744 Azure:

[GitHub] [flink] flinkbot commented on pull request #17722: [FLINK-24774] Adaptive scheduler notifies listeners for all job state transitions

2021-11-08 Thread GitBox
flinkbot commented on pull request #17722: URL: https://github.com/apache/flink/pull/17722#issuecomment-963149329 ## CI report: * 71cfbc8ea9a642b8cbef6b67e5c51bf45dea9600 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17714: [FLINK-24818][API/State Processor]Correct the ttlConfig comment in StateDescriptor

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17714: URL: https://github.com/apache/flink/pull/17714#issuecomment-962984732 ## CI report: * 4f403273ab56bb1cf5bad8952e87bff315e28444 Azure:

[GitHub] [flink] Tartarus0zm commented on pull request #17723: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-08 Thread GitBox
Tartarus0zm commented on pull request #17723: URL: https://github.com/apache/flink/pull/17723#issuecomment-963148880 @JingsongLi please take a look, if you have time, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] flinkbot commented on pull request #17722: [FLINK-24774] Adaptive scheduler notifies listeners for all job state transitions

2021-11-08 Thread GitBox
flinkbot commented on pull request #17722: URL: https://github.com/apache/flink/pull/17722#issuecomment-963148969 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-24824) AdaptiveScheduler#getJobStatus never returns CREATED

2021-11-08 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-24824: - Parent: FLINK-21510 Issue Type: Sub-task (was: Bug) >

[GitHub] [flink] flinkbot edited a comment on pull request #17696: [FLINK-24765][kafka] Bump Kafka version to 2.8

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17696: URL: https://github.com/apache/flink/pull/17696#issuecomment-961875755 ## CI report: * 8c9f16f661c9f317d0766acfd00f1be581a06d9a Azure:

[GitHub] [flink] Tartarus0zm opened a new pull request #17723: [FLINK-24761][table] Fix PartitionPruner code gen compile fail

2021-11-08 Thread GitBox
Tartarus0zm opened a new pull request #17723: URL: https://github.com/apache/flink/pull/17723 ## What is the purpose of the change Solve the problem of compile fail of PartitionPruner generated code due to classloader error. ## Brief change log Change `PartitionPruner`

[GitHub] [flink] flinkbot edited a comment on pull request #17519: [FLINK-24368][testutils] Print logs JobManager and TaskManager on STDOUT in Flink container for redirecting to log4j in tests

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17519: URL: https://github.com/apache/flink/pull/17519#issuecomment-946579332 ## CI report: * ebe077c26b5f3c6214e6d9308af6925ab3f9a53f Azure:

[jira] [Updated] (FLINK-24774) AdaptiveScheduler should inform job status listener of all state changes

2021-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24774: --- Labels: pull-request-available (was: ) > AdaptiveScheduler should inform job status

[GitHub] [flink] flinkbot commented on pull request #17721: [FLINK-24822][table-planner]Improve CatalogTableSpecBase and its subclass related method parameter

2021-11-08 Thread GitBox
flinkbot commented on pull request #17721: URL: https://github.com/apache/flink/pull/17721#issuecomment-963146526 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] zentol opened a new pull request #17722: [FLINK-24774] Adaptive scheduler notifies listeners for all job state transitions

2021-11-08 Thread GitBox
zentol opened a new pull request #17722: URL: https://github.com/apache/flink/pull/17722 The AdaptiveScheduler now informs the JobStatusListener of all state transitions. The current behavior of only reporting terminal states is surprising, and I intend to alter hook into these

[GitHub] [flink] flinkbot commented on pull request #17721: [FLINK-24822][table-planner]Improve CatalogTableSpecBase and its subclass related method parameter

2021-11-08 Thread GitBox
flinkbot commented on pull request #17721: URL: https://github.com/apache/flink/pull/17721#issuecomment-963145399 ## CI report: * d52449c9e030acb1936ee2b5429fedcd2b6f2744 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17720: [FLINK-24210][serializer] Return the correct serialized length for wi…

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17720: URL: https://github.com/apache/flink/pull/17720#issuecomment-963141306 ## CI report: * 0c8d9c69ed2cf13ebdb1dfb6e0b44ca31ad4e706 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17696: [FLINK-24765][kafka] Bump Kafka version to 2.8

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17696: URL: https://github.com/apache/flink/pull/17696#issuecomment-961875755 ## CI report: * 8c9f16f661c9f317d0766acfd00f1be581a06d9a Azure:

[GitHub] [flink] CrynetLogistics commented on pull request #17687: [FLINK-24227][connectors] Improved AsyncSink base by adding a builder…

2021-11-08 Thread GitBox
CrynetLogistics commented on pull request #17687: URL: https://github.com/apache/flink/pull/17687#issuecomment-963145256 Thank you @dannycranmer for your time in providing the review here and in #17345.  -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (FLINK-24750) Single quotes converted to left/right single quotes during docs generation

2021-11-08 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-24750: Component/s: Table SQL / API > Single quotes converted to left/right single quotes during

[jira] [Updated] (FLINK-24820) Examples in documentation for value1 IS DISTINCT FROM value2 are wrong

2021-11-08 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-24820: Component/s: Table SQL / API > Examples in documentation for value1 IS DISTINCT FROM

[GitHub] [flink] lsyldliu commented on pull request #17721: [FLINK-24822][table-planner]Improve CatalogTableSpecBase and its subclass related method parameter

2021-11-08 Thread GitBox
lsyldliu commented on pull request #17721: URL: https://github.com/apache/flink/pull/17721#issuecomment-963143877 cc @godfreyhe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-24822) Improve CatalogTableSpecBase and its subclass method parameter

2021-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24822: --- Labels: pull-request-available (was: ) > Improve CatalogTableSpecBase and its subclass

[GitHub] [flink] CrynetLogistics commented on a change in pull request #17687: [FLINK-24227][connectors] Improved AsyncSink base by adding a builder…

2021-11-08 Thread GitBox
CrynetLogistics commented on a change in pull request #17687: URL: https://github.com/apache/flink/pull/17687#discussion_r744713834 ## File path: flink-connectors/flink-connector-base/src/main/resources/log4j2.properties ## @@ -16,7 +16,7 @@ # limitations under the License.

[GitHub] [flink] dannycranmer commented on pull request #17687: [FLINK-24227][connectors] Improved AsyncSink base by adding a builder…

2021-11-08 Thread GitBox
dannycranmer commented on pull request #17687: URL: https://github.com/apache/flink/pull/17687#issuecomment-963142831 LGTM, I will merge once @fapaul has provided feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] lsyldliu opened a new pull request #17721: [FLINK-24822][table-planner]Improve CatalogTableSpecBase and its subclass related method parameter

2021-11-08 Thread GitBox
lsyldliu opened a new pull request #17721: URL: https://github.com/apache/flink/pull/17721 ## What is the purpose of the change Currently, CatalogTableSpecBase and its subclass related method use PlannerBase as parameter, we can improve it use FlinkContext enough. ## Brief

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17691: [FLINK-24586][table] SQL functions should return STRING instead of VARCHAR(2000)

2021-11-08 Thread GitBox
slinkydeveloper commented on a change in pull request #17691: URL: https://github.com/apache/flink/pull/17691#discussion_r744708841 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/type/FlinkReturnTypes.java ## @@ -104,9 +104,9

[GitHub] [flink] flinkbot commented on pull request #17720: [FLINK-24210][serializer] Return the correct serialized length for wi…

2021-11-08 Thread GitBox
flinkbot commented on pull request #17720: URL: https://github.com/apache/flink/pull/17720#issuecomment-963141470 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #17720: [FLINK-24210][serializer] Return the correct serialized length for wi…

2021-11-08 Thread GitBox
flinkbot commented on pull request #17720: URL: https://github.com/apache/flink/pull/17720#issuecomment-963141306 ## CI report: * 0c8d9c69ed2cf13ebdb1dfb6e0b44ca31ad4e706 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] CrynetLogistics commented on a change in pull request #17687: [FLINK-24227][connectors] Improved AsyncSink base by adding a builder…

2021-11-08 Thread GitBox
CrynetLogistics commented on a change in pull request #17687: URL: https://github.com/apache/flink/pull/17687#discussion_r744713834 ## File path: flink-connectors/flink-connector-base/src/main/resources/log4j2.properties ## @@ -16,7 +16,7 @@ # limitations under the License.

[GitHub] [flink] dannycranmer commented on a change in pull request #17687: [FLINK-24227][connectors] Improved AsyncSink base by adding a builder…

2021-11-08 Thread GitBox
dannycranmer commented on a change in pull request #17687: URL: https://github.com/apache/flink/pull/17687#discussion_r744711570 ## File path: flink-connectors/flink-connector-base/src/main/resources/log4j2.properties ## @@ -16,7 +16,7 @@ # limitations under the License.

[jira] [Updated] (FLINK-24812) compile_cron_python_wheels should use Ubuntu 20

2021-11-08 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao updated FLINK-24812: Labels: pull-request-available test-stability (was: pull-request-available) > compile_cron_python_wheels

[jira] [Updated] (FLINK-24210) Window related serailizer should not return 0 as its serialized length

2021-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24210: --- Labels: pull-request-available (was: ) > Window related serailizer should not return 0 as

[GitHub] [flink] ljz2051 opened a new pull request #17720: [FLINK-24210][serializer] Return the correct serialized length for wi…

2021-11-08 Thread GitBox
ljz2051 opened a new pull request #17720: URL: https://github.com/apache/flink/pull/17720 …ndow-related serializer ## What is the purpose of the change This pull request return the correct serialized length for window-related serializer, rather than return 0.

[jira] [Commented] (FLINK-24824) AdaptiveScheduler#getJobStatus never returns CREATED

2021-11-08 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440444#comment-17440444 ] Chesnay Schepler commented on FLINK-24824: -- [~trohrmann] WDYT? >

[jira] [Created] (FLINK-24824) AdaptiveScheduler#getJobStatus never returns CREATED

2021-11-08 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-24824: Summary: AdaptiveScheduler#getJobStatus never returns CREATED Key: FLINK-24824 URL: https://issues.apache.org/jira/browse/FLINK-24824 Project: Flink

[GitHub] [flink] Airblader commented on a change in pull request #17698: [FLINK-24689][runtime-web] Add log's last modify time in log list view

2021-11-08 Thread GitBox
Airblader commented on a change in pull request #17698: URL: https://github.com/apache/flink/pull/17698#discussion_r744705277 ## File path: flink-runtime-web/web-dashboard/src/app/pages/task-manager/log-list/task-manager-log-list.component.html ## @@ -29,14 +29,16 @@

[GitHub] [flink] flinkbot edited a comment on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-958647607 ## CI report: * 77b1c3da470c39baef3c58ff9a88c17df6159524 Azure:

[GitHub] [flink] CrynetLogistics edited a comment on pull request #17687: [FLINK-24227][connectors] Improved AsyncSink base by adding a builder…

2021-11-08 Thread GitBox
CrynetLogistics edited a comment on pull request #17687: URL: https://github.com/apache/flink/pull/17687#issuecomment-963076298 @fapaul Hi Fabian, would you mind taking a look at this PR which is a subset of the other main PR which is quite big now? This would unblock Yuri Gusev

[GitHub] [flink] CrynetLogistics edited a comment on pull request #17687: [FLINK-24227][connectors] Improved AsyncSink base by adding a builder…

2021-11-08 Thread GitBox
CrynetLogistics edited a comment on pull request #17687: URL: https://github.com/apache/flink/pull/17687#issuecomment-963076298 @fapaul Hi Fabian, would you mind taking a look at this PR which is a subset of the other main PR which is quite big now? This would unblock Yuri Gusev on

[GitHub] [flink] flinkbot edited a comment on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17658: URL: https://github.com/apache/flink/pull/17658#issuecomment-958884763 ## CI report: * 7dfe3c64086dbe4ef1981c8e62512cb34552348b UNKNOWN * ff2edf06abac54e2c41cc4d11d29feba0e8b6d29 Azure:

[GitHub] [flink] RocMarshal edited a comment on pull request #17548: [FLINK-24383][streaming] Remove the deprecated SlidingTimeWindows, TumblingTimeWindows, BaseAlignedWindowAssigner.

2021-11-08 Thread GitBox
RocMarshal edited a comment on pull request #17548: URL: https://github.com/apache/flink/pull/17548#issuecomment-950549753 Hi, @wuchong @xintongsong @twalthr Could you help me to check this pr ? Thank you. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] RocMarshal edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the n

2021-11-08 Thread GitBox
RocMarshal edited a comment on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-963105801 @Airblader @twalthr Could you help me to review this pr ? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] RocMarshal edited a comment on pull request #17553: [Hotfix][git] Add 'flink-python/.idea/' into .gitignore file.

2021-11-08 Thread GitBox
RocMarshal edited a comment on pull request #17553: URL: https://github.com/apache/flink/pull/17553#issuecomment-950337942 @dianfu @twalthr Could you help me to check it ? Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] RocMarshal commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number o

2021-11-08 Thread GitBox
RocMarshal commented on pull request #17692: URL: https://github.com/apache/flink/pull/17692#issuecomment-963105801 @Airblader Could you help me to review this pr ? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] flinkbot edited a comment on pull request #17712: [FLINK-24816][rabbitmq] Bump amqp-client to v5.13.1

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17712: URL: https://github.com/apache/flink/pull/17712#issuecomment-962935797 ## CI report: * 9faf7e7beed534bdab0458cd636dcc5e00117e64 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17664: [FLINK-24658][runtime] Added debug logs for BufferDebloater

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17664: URL: https://github.com/apache/flink/pull/17664#issuecomment-959645843 ## CI report: * 6ce5ee7ee72cd281a2e02de99efee59cf0ace46f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17712: [FLINK-24816][rabbitmq] Bump amqp-client to v5.13.1

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17712: URL: https://github.com/apache/flink/pull/17712#issuecomment-962935797 ## CI report: * 9faf7e7beed534bdab0458cd636dcc5e00117e64 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17664: [FLINK-24658][runtime] Added debug logs for BufferDebloater

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17664: URL: https://github.com/apache/flink/pull/17664#issuecomment-959645843 ## CI report: * 6ce5ee7ee72cd281a2e02de99efee59cf0ace46f Azure:

[GitHub] [flink] MartijnVisser commented on pull request #17712: [FLINK-24816][rabbitmq] Bump amqp-client to v5.13.1

2021-11-08 Thread GitBox
MartijnVisser commented on pull request #17712: URL: https://github.com/apache/flink/pull/17712#issuecomment-963101203 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot edited a comment on pull request #17696: [FLINK-24765][kafka] Bump Kafka version to 2.8

2021-11-08 Thread GitBox
flinkbot edited a comment on pull request #17696: URL: https://github.com/apache/flink/pull/17696#issuecomment-961875755 ## CI report: * 8c9f16f661c9f317d0766acfd00f1be581a06d9a Azure:

[GitHub] [flink] twalthr commented on pull request #17652: [FLINK-24717][table-planner]Push down partitions before filters

2021-11-08 Thread GitBox
twalthr commented on pull request #17652: URL: https://github.com/apache/flink/pull/17652#issuecomment-963097130 @xuyangzhong I did the rebase my self to speed things up. Will merge this now, once my build turns green. Thanks. -- This is an automated message from the Apache Git Service.

<    1   2   3   4   5   6   7   8   >