[GitHub] [flink] wsry commented on a change in pull request #18364: [FLINK-25654][network] Remove the redundant locks in SortMergeResultPartition

2022-01-16 Thread GitBox
wsry commented on a change in pull request #18364: URL: https://github.com/apache/flink/pull/18364#discussion_r785605658 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionSortedBuffer.java ## @@ -65,7 +63,6 @@ private final

[GitHub] [flink] wanglijie95 commented on pull request #18130: [FLINK-25035][runtime] Shuffle service supports consuming subpartition range

2022-01-16 Thread GitBox
wanglijie95 commented on pull request #18130: URL: https://github.com/apache/flink/pull/18130#issuecomment-1014091234 > Thanks for opening this PR! @wanglijie95 The changes of commit [12880fe](https://github.com/apache/flink/commit/12880feeedbbba9d3beb93225843218f4d6776f6) looks generally

[GitHub] [flink] KarmaGYZ commented on a change in pull request #18360: [FLINK-25329][runtime] Support memory execution graph store in session cluster

2022-01-16 Thread GitBox
KarmaGYZ commented on a change in pull request #18360: URL: https://github.com/apache/flink/pull/18360#discussion_r785606436 ## File path: flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java ## @@ -316,6 +316,27 @@

[GitHub] [flink] flinkbot edited a comment on pull request #18130: [FLINK-25035][runtime] Shuffle service supports consuming subpartition range

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18130: URL: https://github.com/apache/flink/pull/18130#issuecomment-995629902 ## CI report: * 12880feeedbbba9d3beb93225843218f4d6776f6 Azure:

[jira] [Assigned] (FLINK-25580) Minor improvements for RocksDBIncrementalCheckpointUtils

2022-01-16 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang reassigned FLINK-25580: Assignee: Aitozi > Minor improvements for RocksDBIncrementalCheckpointUtils >

[jira] [Updated] (FLINK-25580) Minor improvements for RocksDBIncrementalCheckpointUtils

2022-01-16 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-25580: - Fix Version/s: 1.15.0 > Minor improvements for RocksDBIncrementalCheckpointUtils >

[jira] [Resolved] (FLINK-25580) Minor improvements for RocksDBIncrementalCheckpointUtils

2022-01-16 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-25580. -- Resolution: Fixed Megred in master: b7fd63b41500dbfeadbf2ee48e1a83d77cd1259b > Minor improvements

[GitHub] [flink] Myasuka closed pull request #18305: [FLINK-25580][State Backends]Improve the logic of over fraction calcu…

2022-01-16 Thread GitBox
Myasuka closed pull request #18305: URL: https://github.com/apache/flink/pull/18305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #18130: [FLINK-25035][runtime] Shuffle service supports consuming subpartition range

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18130: URL: https://github.com/apache/flink/pull/18130#issuecomment-995629902 ## CI report: * 12880feeedbbba9d3beb93225843218f4d6776f6 Azure:

[GitHub] [flink] wanglijie95 commented on a change in pull request #18130: [FLINK-25035][runtime] Shuffle service supports consuming subpartition range

2022-01-16 Thread GitBox
wanglijie95 commented on a change in pull request #18130: URL: https://github.com/apache/flink/pull/18130#discussion_r785604984 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannel.java ## @@ -54,6 +54,8 @@

[jira] [Commented] (FLINK-23545) Use new schema in SqlCreateTableConverter

2022-01-16 Thread jinfeng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17476927#comment-17476927 ] jinfeng commented on FLINK-23545: - [~airblader] [~twalthr] This feature seems to be supported in 1.15

[GitHub] [flink] jelly-1203 commented on pull request #18358: [FLINK-25651][docs] Update kafka.md

2022-01-16 Thread GitBox
jelly-1203 commented on pull request #18358: URL: https://github.com/apache/flink/pull/18358#issuecomment-1014083259 @biyuhao Thanks for your suggestion. I have modified the document -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] zjureel commented on pull request #18360: [FLINK-25329][runtime] Support memory execution graph store in session cluster

2022-01-16 Thread GitBox
zjureel commented on pull request #18360: URL: https://github.com/apache/flink/pull/18360#issuecomment-1014082856 @rmetzger Can you please help to review this PR when you're free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] flinkbot edited a comment on pull request #18360: [FLINK-25329][runtime] Support memory execution graph store in session cluster

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18360: URL: https://github.com/apache/flink/pull/18360#issuecomment-1012981724 ## CI report: * d7927cf9b7e4205d59e788be867174141d7cd901 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18360: [FLINK-25329][runtime] Support memory execution graph store in session cluster

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18360: URL: https://github.com/apache/flink/pull/18360#issuecomment-1012981724 ## CI report: * d7927cf9b7e4205d59e788be867174141d7cd901 Azure:

[jira] [Commented] (FLINK-25660) Failed to build flink-runtime-web

2022-01-16 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17476924#comment-17476924 ] Yangze Guo commented on FLINK-25660: [~aitozi] It might be a known issue. You can: 1. update

[GitHub] [flink] flinkbot edited a comment on pull request #18361: [FLINK-25631][table] Support enhanced `show tables` syntax

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18361: URL: https://github.com/apache/flink/pull/18361#issuecomment-1012985152 ## CI report: * Unknown: [CANCELED](TBD) * be68a936d3efddd37a731cdbd5608741850ca1bf Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18361: [FLINK-25631][table] Support enhanced `show tables` syntax

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18361: URL: https://github.com/apache/flink/pull/18361#issuecomment-1012985152 ## CI report: * Unknown: [CANCELED](TBD) * be68a936d3efddd37a731cdbd5608741850ca1bf UNKNOWN Bot commands The @flinkbot bot supports the

[GitHub] [flink] liyubin117 commented on pull request #18361: [FLINK-25631][table] Support enhanced `show tables` syntax

2022-01-16 Thread GitBox
liyubin117 commented on pull request #18361: URL: https://github.com/apache/flink/pull/18361#issuecomment-1014068749 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-25648) Redundant to querying deployment when creating task manager pod

2022-01-16 Thread Yuan Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17476922#comment-17476922 ] Yuan Huang commented on FLINK-25648: - Hi, [~trohrm...@apache.org], do you think it is useful to

[GitHub] [flink] yangjunhan commented on pull request #17711: [FLINK-24737][runtime-web] Update outdated web dependencies

2022-01-16 Thread GitBox
yangjunhan commented on pull request #17711: URL: https://github.com/apache/flink/pull/17711#issuecomment-1014064093 > I would prefer bumping this in a separate PR using the JIRA issue @MartijnVisser pointed to. I'm happy to review and merge that one as well, of course (no vacation in

[GitHub] [flink] mans2singh commented on pull request #18259: [hotfix][javadoc] Minor correction to javadoc

2022-01-16 Thread GitBox
mans2singh commented on pull request #18259: URL: https://github.com/apache/flink/pull/18259#issuecomment-1014003794 @leonardBang - Can you please review this javadoc correction and let me know your recommendations ? Thanks -- This is an automated message from the

[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18297: URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142 ## CI report: * 83a05868dd4718112ebcd8f92271d84aa90fa733 Azure:

[GitHub] [flink] rkhachatryan commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-16 Thread GitBox
rkhachatryan commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r785532350 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateObject.java ## @@ -63,4 +63,14 @@ * @return Size of the state

[GitHub] [flink] rkhachatryan commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-16 Thread GitBox
rkhachatryan commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r785532350 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateObject.java ## @@ -63,4 +63,14 @@ * @return Size of the state

[GitHub] [flink] rkhachatryan commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-16 Thread GitBox
rkhachatryan commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r785523680 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandle.java ## @@ -204,6 +203,21 @@ public long

[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18297: URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142 ## CI report: * 1f13ac7621406c519bb21cada599448bda822453 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18297: URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142 ## CI report: * 1f13ac7621406c519bb21cada599448bda822453 Azure:

[GitHub] [flink] rkhachatryan commented on a change in pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state

2022-01-16 Thread GitBox
rkhachatryan commented on a change in pull request #18297: URL: https://github.com/apache/flink/pull/18297#discussion_r785510841 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java ## @@ -83,11 +80,7 @@ public

[GitHub] [flink] rkhachatryan commented on a change in pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state

2022-01-16 Thread GitBox
rkhachatryan commented on a change in pull request #18297: URL: https://github.com/apache/flink/pull/18297#discussion_r785510841 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java ## @@ -83,11 +80,7 @@ public

[GitHub] [flink] rkhachatryan commented on a change in pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state

2022-01-16 Thread GitBox
rkhachatryan commented on a change in pull request #18297: URL: https://github.com/apache/flink/pull/18297#discussion_r785510841 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java ## @@ -83,11 +80,7 @@ public

[GitHub] [flink] rkhachatryan commented on a change in pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state

2022-01-16 Thread GitBox
rkhachatryan commented on a change in pull request #18297: URL: https://github.com/apache/flink/pull/18297#discussion_r785510841 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java ## @@ -83,11 +80,7 @@ public

[GitHub] [flink] zentol commented on a change in pull request #18368: [FLINK-18356][Azure] Enforce memory limits for docker containers

2022-01-16 Thread GitBox
zentol commented on a change in pull request #18368: URL: https://github.com/apache/flink/pull/18368#discussion_r785488446 ## File path: tools/ci/compile.sh ## @@ -48,7 +48,7 @@ echo "== EXIT_CODE=0

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] vahmed-hamdy commented on a change in pull request #18348: [FLINK-24905][connectors/kinesis] Adding support for Kinesis DataStream sink as kinesis table connector sink.

2022-01-16 Thread GitBox
vahmed-hamdy commented on a change in pull request #18348: URL: https://github.com/apache/flink/pull/18348#discussion_r785480092 ## File path: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/KinesisPartitioner.java ## @@

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[jira] [Commented] (FLINK-25432) Implement cleanup strategy

2022-01-16 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17476836#comment-17476836 ] Matthias Pohl commented on FLINK-25432: --- We're experiencing

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] metaswirl commented on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
metaswirl commented on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-1013909245 > Thanks for explaining how the Yarn logic works @metaswirl. I think this is a good solution and works. One last question is whether we want to add an IT test that ensures

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] galenwarren commented on pull request #15599: [FLINK-11838][flink-gs-fs-hadoop] Create Google Storage file system with recoverable writer support

2022-01-16 Thread GitBox
galenwarren commented on pull request #15599: URL: https://github.com/apache/flink/pull/15599#issuecomment-1013907994 > Did you use -Pcheck-convergence? Otherwise dependency-convergence isn't checked. Ah, that's probably it. Sorry, I'm not that familiar with that plugin. > I

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18102: [FLINK-25033][runtime] Let some scheduler components updatable

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18102: URL: https://github.com/apache/flink/pull/18102#issuecomment-993332110 ## CI report: * 6ca8ad8ab7817ed28cf8619b36d7a8a21f1db987 Azure:

[GitHub] [flink] zentol commented on pull request #15599: [FLINK-11838][flink-gs-fs-hadoop] Create Google Storage file system with recoverable writer support

2022-01-16 Thread GitBox
zentol commented on pull request #15599: URL: https://github.com/apache/flink/pull/15599#issuecomment-1013905276 > Running locally with dependency-convergence enabled didn't yield anything to resolve Did you use `-Pcheck-convergence`? Otherwise dependency-convergence isn't checked.

[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18306: URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006 ## CI report: * 3efa1bed35ddcfcf74e1de739ebc355e404eb73b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] galenwarren commented on pull request #15599: [FLINK-11838][flink-gs-fs-hadoop] Create Google Storage file system with recoverable writer support

2022-01-16 Thread GitBox
galenwarren commented on pull request #15599: URL: https://github.com/apache/flink/pull/15599#issuecomment-1013896727 @xintongsong @rmetzger @zentol The CI build [succeeded](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=29496=results)! Running locally with

[GitHub] [flink] flinkbot edited a comment on pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #17485: URL: https://github.com/apache/flink/pull/17485#issuecomment-943315428 ## CI report: * dd4a85dae4b59ff533c3cfdba8bfc28dae5e2ebc Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18102: [FLINK-25033][runtime] Let some scheduler components updatable

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18102: URL: https://github.com/apache/flink/pull/18102#issuecomment-993332110 ## CI report: * 114a3c714e91f1075ddc647417ff59bc1d2cc907 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18102: [FLINK-25033][runtime] Let some scheduler components updatable

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18102: URL: https://github.com/apache/flink/pull/18102#issuecomment-993332110 ## CI report: * 114a3c714e91f1075ddc647417ff59bc1d2cc907 Azure:

[GitHub] [flink] zuston commented on a change in pull request #18157: [FLINK-17808] Rename checkpoint meta file to "_metadata" until it has…

2022-01-16 Thread GitBox
zuston commented on a change in pull request #18157: URL: https://github.com/apache/flink/pull/18157#discussion_r785443599 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointMetadataOutputStream.java ## @@ -44,7 +46,7 @@ //

[GitHub] [flink] zuston commented on a change in pull request #18157: [FLINK-17808] Rename checkpoint meta file to "_metadata" until it has…

2022-01-16 Thread GitBox
zuston commented on a change in pull request #18157: URL: https://github.com/apache/flink/pull/18157#discussion_r785443414 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointMetadataOutputStream.java ## @@ -62,7 +64,15 @@ public

[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18306: URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006 ## CI report: * 32883ca0240ef8ef0f3fb7162035a3aff23cdb7d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18306: URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006 ## CI report: * 32883ca0240ef8ef0f3fb7162035a3aff23cdb7d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] metaswirl commented on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
metaswirl commented on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-1013875342 > Also I would probably choose the Phaser approach as I find the interface kind of confusing, by no objections there. Do you have an alternative approach in mind?

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #17485: URL: https://github.com/apache/flink/pull/17485#issuecomment-943315428 ## CI report: * f8f21fd77139eee5f97f39195d31fcb67ae6d996 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #17485: URL: https://github.com/apache/flink/pull/17485#issuecomment-943315428 ## CI report: * f8f21fd77139eee5f97f39195d31fcb67ae6d996 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] flinkbot edited a comment on pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
flinkbot edited a comment on pull request #18169: URL: https://github.com/apache/flink/pull/18169#issuecomment-998925832 ## CI report: * 35011a0fb8ca36b38d854e88a2937357b8736f4d UNKNOWN * fc7193f9336b272ced363c100517ad4f4f793804 UNKNOWN *

[GitHub] [flink] metaswirl commented on a change in pull request #18169: [FLINK-25277] add shutdown hook to stop TaskExecutor on SIGTERM

2022-01-16 Thread GitBox
metaswirl commented on a change in pull request #18169: URL: https://github.com/apache/flink/pull/18169#discussion_r785435594 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java ## @@ -106,6 +107,8 @@ private static

[jira] [Closed] (FLINK-23976) Add additional availability timing metrics to Job lifecycle events

2022-01-16 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-23976. Fix Version/s: 1.15.0 Release Note: The "restartingTime" metric now only returns a

[GitHub] [flink] zentol merged pull request #18143: [FLINK-23976][metrics] Add additional job status metrics

2022-01-16 Thread GitBox
zentol merged pull request #18143: URL: https://github.com/apache/flink/pull/18143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    1   2   3   >