[GitHub] [flink-table-store] shenzhu commented on pull request #24: [FLINK-26217] Introduce manifest.merge-min-count in commit

2022-02-23 Thread GitBox
shenzhu commented on pull request #24: URL: https://github.com/apache/flink-table-store/pull/24#issuecomment-1049587025 > Hi @shenzhu . > > After a second thought, I believe we should still stick to your current implementation with a small change. There are several reasons: >

[jira] [Commented] (FLINK-25695) TemporalJoin cause state leak in some cases

2022-02-23 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497238#comment-17497238 ] Lyn Zhang commented on FLINK-25695: --- If we create a KeyedMapState and add some elements in it, then

[jira] [Commented] (FLINK-26178) Use the same enum for expected and observed jobstate (JobState / JobStatus.state)

2022-02-23 Thread Biao Geng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497233#comment-17497233 ] Biao Geng commented on FLINK-26178: --- Hi [~gyfora], seems this ticket has been opened for some days. I

[jira] [Closed] (FLINK-26297) Introduce ExecutionNodeConfig which will be used in all Exec Nodes

2022-02-23 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-26297. Fix Version/s: 1.15.0 Resolution: Fixed Fixed in master: commit

[jira] [Updated] (FLINK-26297) Introduce ExecutionNodeConfig which will be used in all Exec Nodes

2022-02-23 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-26297: - Description: Introduce ExecutionNodeConfig to be used instead of planner.getConfiguration()

[jira] [Commented] (FLINK-14902) JDBCTableSource support AsyncLookupFunction

2022-02-23 Thread ranqiqiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497231#comment-17497231 ] ranqiqiang commented on FLINK-14902: [~jark]   [~ana4]  , what can I  to do next ?  Do you have

[GitHub] [flink] twalthr closed pull request #18888: [FLINK-26297][table-planner][table-runtime] Introduce ExecNodeConfiguration

2022-02-23 Thread GitBox
twalthr closed pull request #1: URL: https://github.com/apache/flink/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-25771) CassandraConnectorITCase.testRetrialAndDropTables timeouts on AZP

2022-02-23 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497228#comment-17497228 ] Yun Gao commented on FLINK-25771: -

[GitHub] [flink] flinkbot edited a comment on pull request #18893: [FLINK-25813][table-planner] Fix unstable test TableITCase#testCollectWithClose

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18893: URL: https://github.com/apache/flink/pull/18893#issuecomment-1048447718 ## CI report: * 76fb53a83db840acfbaca060e9358d809b2aa3f1 Azure:

[jira] [Commented] (FLINK-24538) ZooKeeperLeaderElectionTest.testLeaderShouldBeCorrectedWhenOverwritten fails with NPE

2022-02-23 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497226#comment-17497226 ] Yun Gao commented on FLINK-24538: -

[jira] [Commented] (FLINK-26314) StreamingCompactingFileSinkITCase.testFileSink failed on azure

2022-02-23 Thread Gen Luo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497225#comment-17497225 ] Gen Luo commented on FLINK-26314: - I'll take a look soon. >

[jira] [Assigned] (FLINK-26314) StreamingCompactingFileSinkITCase.testFileSink failed on azure

2022-02-23 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao reassigned FLINK-26314: --- Assignee: Gen Luo > StreamingCompactingFileSinkITCase.testFileSink failed on azure >

[jira] [Commented] (FLINK-26314) StreamingCompactingFileSinkITCase.testFileSink failed on azure

2022-02-23 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497224#comment-17497224 ] Yun Gao commented on FLINK-26314: -

[jira] [Commented] (FLINK-25986) Add FLIP-190 new API methods to python

2022-02-23 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497212#comment-17497212 ] Dian Fu commented on FLINK-25986: - [~nicholasjiang] I have assigned it to you ~ > Add FLIP-190 new API

[jira] [Updated] (FLINK-26042) PyFlinkEmbeddedSubInterpreterTests. test_udf_without_arguments failed on azure

2022-02-23 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-26042: Fix Version/s: 1.15.0 > PyFlinkEmbeddedSubInterpreterTests. test_udf_without_arguments failed on azure >

[jira] [Assigned] (FLINK-25986) Add FLIP-190 new API methods to python

2022-02-23 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-25986: --- Assignee: Nicholas Jiang > Add FLIP-190 new API methods to python >

[jira] [Commented] (FLINK-26136) Implement shared validation logic for FlinkDeployment objects

2022-02-23 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497202#comment-17497202 ] Aitozi commented on FLINK-26136: Got it, thanks. > Implement shared validation logic for

[jira] [Commented] (FLINK-24697) Kafka table source cannot change the auto.offset.reset setting for 'group-offsets' startup mode

2022-02-23 Thread JieFang.He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497197#comment-17497197 ] JieFang.He commented on FLINK-24697: Whether need to change the default value to LATEST? The problem

[GitHub] [flink-table-store] tsreaper edited a comment on pull request #24: [FLINK-26217] Introduce manifest.merge-min-count in commit

2022-02-23 Thread GitBox
tsreaper edited a comment on pull request #24: URL: https://github.com/apache/flink-table-store/pull/24#issuecomment-1049521064 Hi @shenzhu . After a second thought, I believe we should still stick to your current implementation with a small change. There are several reasons: *

[jira] [Closed] (FLINK-26332) Move the Operator Env to the common Utils

2022-02-23 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang closed FLINK-26332. - Resolution: Fixed Fixed via: main: eebb796bd903337891f2fce95a4a415d2b208b86 > Move the Operator Env

[GitHub] [flink-table-store] tsreaper edited a comment on pull request #24: [FLINK-26217] Introduce manifest.merge-min-count in commit

2022-02-23 Thread GitBox
tsreaper edited a comment on pull request #24: URL: https://github.com/apache/flink-table-store/pull/24#issuecomment-1049521064 Hi @shenzhu . After a second thought, I believe we should still stick to your current implementation with a small change. There are several reasons: *

[GitHub] [flink-table-store] tsreaper commented on pull request #24: [FLINK-26217] Introduce manifest.merge-min-count in commit

2022-02-23 Thread GitBox
tsreaper commented on pull request #24: URL: https://github.com/apache/flink-table-store/pull/24#issuecomment-1049521064 Hi @shenzhu . After a second thought, I believe we should still stick to your current implementation with a small change. There are several reasons: * After

[jira] [Updated] (FLINK-26138) Create controller test for stateful/stateless upgrade flow

2022-02-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26138: --- Labels: pull-request-available (was: ) > Create controller test for stateful/stateless

[jira] [Commented] (FLINK-26344) waitForClusterShutdown does not work correctly in Flink Kubernetes operator

2022-02-23 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497186#comment-17497186 ] Yang Wang commented on FLINK-26344: --- [~nicholasjiang]  You have got assigned. Happy coding. >

[jira] [Assigned] (FLINK-26344) waitForClusterShutdown does not work correctly in Flink Kubernetes operator

2022-02-23 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Wang reassigned FLINK-26344: - Assignee: Nicholas Jiang > waitForClusterShutdown does not work correctly in Flink Kubernetes

[jira] [Commented] (FLINK-26136) Implement shared validation logic for FlinkDeployment objects

2022-02-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497185#comment-17497185 ] Gyula Fora commented on FLINK-26136: [~aitozi] the reason why need validation in both places is

[jira] [Commented] (FLINK-26136) Implement shared validation logic for FlinkDeployment objects

2022-02-23 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497184#comment-17497184 ] Aitozi commented on FLINK-26136: Hi [~gyfora], I have a doubt for this issue. I think the webhook will

[jira] [Updated] (FLINK-26261) Reconciliation should try to start job when not already started or move to permanent error

2022-02-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26261: --- Labels: pull-request-available (was: ) > Reconciliation should try to start job when not

[jira] [Assigned] (FLINK-26136) Implement shared validation logic for FlinkDeployment objects

2022-02-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-26136: -- Assignee: Gyula Fora > Implement shared validation logic for FlinkDeployment objects >

[jira] [Updated] (FLINK-26345) Observer should detect flink job even if deployment status is empty

2022-02-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-26345: --- Parent: FLINK-25963 Issue Type: Sub-task (was: Bug) > Observer should detect flink job

[GitHub] [flink] flinkbot edited a comment on pull request #18607: [FLINK-24345] [docs] Translate "File Systems" page of "Internals" int…

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18607: URL: https://github.com/apache/flink/pull/18607#issuecomment-1027976960 ## CI report: * 4468d4ef8c7ec45bb90c9ae0997e0be22dbbd866 Azure:

[jira] [Updated] (FLINK-26345) Observer should detect flink job even if deployment status is empty

2022-02-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-26345: --- Component/s: Kubernetes Operator > Observer should detect flink job even if deployment status is

[jira] [Commented] (FLINK-26336) Deletion should remove HA related configmaps also

2022-02-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497178#comment-17497178 ] Gyula Fora commented on FLINK-26336: No I mean any cluster, the cleanup is called on deletion i

[jira] [Created] (FLINK-26345) Observer should detect flink job even if deployment status is empty

2022-02-23 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-26345: -- Summary: Observer should detect flink job even if deployment status is empty Key: FLINK-26345 URL: https://issues.apache.org/jira/browse/FLINK-26345 Project: Flink

[GitHub] [flink] flinkbot edited a comment on pull request #18607: [FLINK-24345] [docs] Translate "File Systems" page of "Internals" int…

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18607: URL: https://github.com/apache/flink/pull/18607#issuecomment-1027976960 ## CI report: * 4468d4ef8c7ec45bb90c9ae0997e0be22dbbd866 Azure:

[jira] [Commented] (FLINK-25986) Add FLIP-190 new API methods to python

2022-02-23 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497177#comment-17497177 ] Nicholas Jiang commented on FLINK-25986: [~slinkydeveloper], could you please assign this ticket

[jira] [Commented] (FLINK-26336) Deletion should remove HA related configmaps also

2022-02-23 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497174#comment-17497174 ] Yang Wang commented on FLINK-26336: --- Aha, I think you mean session cluster. Flink could not support

[jira] [Closed] (FLINK-26337) Avoid load flink conf each reconcile loop

2022-02-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-26337. -- Resolution: Fixed merged: aa4fa0d9263a74318201076b165b352080f5df12 > Avoid load flink conf each

[jira] [Commented] (FLINK-26344) waitForClusterShutdown does not work correctly in Flink Kubernetes operator

2022-02-23 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497172#comment-17497172 ] Nicholas Jiang commented on FLINK-26344: [~wangyang0918], I would like to fix this bug above

[GitHub] [flink] 2011aad commented on a change in pull request #18822: [FLINK-24677][flink-connector-jdbc] JdbcBatchingOutputFormat should not generate circulate chaining of exceptions when flushing f

2022-02-23 Thread GitBox
2011aad commented on a change in pull request #18822: URL: https://github.com/apache/flink/pull/18822#discussion_r813544404 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcOutputFormat.java ## @@ -154,7 +154,9 @@

[GitHub] [flink] flinkbot edited a comment on pull request #18903: [FLINK-26342][docs][formats] Add DataStream documentation for the CSV format

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18903: URL: https://github.com/apache/flink/pull/18903#issuecomment-1049367947 ## CI report: * 53d933b146bfe3cc9bae334b15aa333cfa0cb812 Azure:

[jira] [Commented] (FLINK-26336) Deletion should remove HA related configmaps also

2022-02-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497168#comment-17497168 ] Gyula Fora commented on FLINK-26336: I think we are not doing cancel:

[GitHub] [flink-table-store] shenzhu commented on pull request #24: [FLINK-26217] Introduce manifest.merge-min-count in commit

2022-02-23 Thread GitBox
shenzhu commented on pull request #24: URL: https://github.com/apache/flink-table-store/pull/24#issuecomment-1049484761 > Hey @tsreaper , thanks for your feedback! I think that's a good point I'm still new to this code base, please correct me if I didn't understand it

[jira] [Closed] (FLINK-26339) Introduce the webhook config to free the environment options

2022-02-23 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi closed FLINK-26339. -- Resolution: Not A Problem > Introduce the webhook config to free the environment options >

[GitHub] [flink] nyingping edited a comment on pull request #18722: [hotfix][docs]fixed some causing ambiguities including the 'shit' comment

2022-02-23 Thread GitBox
nyingping edited a comment on pull request #18722: URL: https://github.com/apache/flink/pull/18722#issuecomment-1049429937 cc @twalthr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-26339) Introduce the webhook config to free the environment options

2022-02-23 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497158#comment-17497158 ] Aitozi commented on FLINK-26339: I mixed it up, there is no need to do this now, sorry for bother :( >

[jira] [Commented] (FLINK-26336) Deletion should remove HA related configmaps also

2022-02-23 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497157#comment-17497157 ] Yang Wang commented on FLINK-26336: --- I think we are doing a cancel when delete the FlinkDeployment. In

[GitHub] [flink] nyingping edited a comment on pull request #18722: [hotfix][docs]fixed some causing ambiguities including the 'shit' comment

2022-02-23 Thread GitBox
nyingping edited a comment on pull request #18722: URL: https://github.com/apache/flink/pull/18722#issuecomment-1049429937 cc [@twalthr](https://github.com/twalthr) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (FLINK-26344) waitForClusterShutdown does not work correctly in Flink Kubernetes operator

2022-02-23 Thread Yang Wang (Jira)
Yang Wang created FLINK-26344: - Summary: waitForClusterShutdown does not work correctly in Flink Kubernetes operator Key: FLINK-26344 URL: https://issues.apache.org/jira/browse/FLINK-26344 Project:

[jira] [Updated] (FLINK-26315) Stream job which have multily region would not recover when connection with zookeeper/hbase lost.

2022-02-23 Thread Janick Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janick Wu updated FLINK-26315: -- Attachment: (was: image-2022-02-24-11-31-04-677.png) > Stream job which have multily region would

[jira] [Updated] (FLINK-26315) Stream job which have multily region would not recover when connection with zookeeper/hbase lost.

2022-02-23 Thread Janick Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janick Wu updated FLINK-26315: -- Attachment: image-2022-02-24-11-31-04-677.png Description:   Our platfrom use failure-rate

[jira] [Commented] (FLINK-26339) Introduce the webhook config to free the environment options

2022-02-23 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497150#comment-17497150 ] Yang Wang commented on FLINK-26339: --- Actually, I do not completely understand this ticket. >

[jira] [Updated] (FLINK-26315) Stream job which have multily region would not recover when connection with zookeeper/hbase lost.

2022-02-23 Thread Janick Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Janick Wu updated FLINK-26315: -- Attachment:

[jira] [Commented] (FLINK-26318) ChangelogCompatibilityITCase.testRestore failed on azure

2022-02-23 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497145#comment-17497145 ] Yun Gao commented on FLINK-26318: - Fix on master via f8ac2bf8f9a8f95f8c82554c994a98ee984967d9 >

[jira] [Closed] (FLINK-26318) ChangelogCompatibilityITCase.testRestore failed on azure

2022-02-23 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao closed FLINK-26318. --- Resolution: Fixed > ChangelogCompatibilityITCase.testRestore failed on azure >

[GitHub] [flink] gaoyunhaii closed pull request #18898: [FLINK-26318][tests] Recover from the latest checkpoint in ChangelogCompatibilityITCase

2022-02-23 Thread GitBox
gaoyunhaii closed pull request #18898: URL: https://github.com/apache/flink/pull/18898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #18641: [FLINK-25761] [docs] Translate Avro format page into Chinese.

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18641: URL: https://github.com/apache/flink/pull/18641#issuecomment-1031234534 ## CI report: * 995943ebd415f3b43e55d8fe2c491e3e16cdc82c Azure:

[GitHub] [flink] MrWhiteSike commented on pull request #18641: [FLINK-25761] [docs] Translate Avro format page into Chinese.

2022-02-23 Thread GitBox
MrWhiteSike commented on pull request #18641: URL: https://github.com/apache/flink/pull/18641#issuecomment-1049446082 [@RocMarshal](https://github.com/RocMarshal) Would you mind helping to review it again? Thx -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] flinkbot edited a comment on pull request #18641: [FLINK-25761] [docs] Translate Avro format page into Chinese.

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18641: URL: https://github.com/apache/flink/pull/18641#issuecomment-1031234534 ## CI report: * 995943ebd415f3b43e55d8fe2c491e3e16cdc82c Azure:

[jira] [Commented] (FLINK-26247) Introduce a better expire strategy

2022-02-23 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497132#comment-17497132 ] Caizhi Weng commented on FLINK-26247: - Why is this solving the problem? With the snapshot id, we can

[GitHub] [flink-table-store] tsreaper commented on a change in pull request #24: [FLINK-26217] Introduce manifest.merge-min-count in commit

2022-02-23 Thread GitBox
tsreaper commented on a change in pull request #24: URL: https://github.com/apache/flink-table-store/pull/24#discussion_r813503144 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/manifest/ManifestFileMeta.java ## @@ -135,19 +135,22 @@

[GitHub] [flink-table-store] tsreaper commented on pull request #24: [FLINK-26217] Introduce manifest.merge-min-count in commit

2022-02-23 Thread GitBox
tsreaper commented on pull request #24: URL: https://github.com/apache/flink-table-store/pull/24#issuecomment-1049439763 Hi @shenzhu ! Firstly thanks for your interest in contributing and also thanks @JingsongLi for the review. I understand that we're introducing this configuration

[jira] [Commented] (FLINK-26320) Update hive doc for 1 m->1 min

2022-02-23 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497124#comment-17497124 ] Jark Wu commented on FLINK-26320: - [~hehuiyuan] do you want to help fixing this? > Update hive doc for

[jira] [Updated] (FLINK-26320) Update hive doc for 1 m->1 min

2022-02-23 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-26320: Component/s: Connectors / Hive > Update hive doc for 1 m->1 min > -- > >

[jira] [Commented] (FLINK-26327) throw not a literal exception in callContext.getArgumentValue when getTypeInference

2022-02-23 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497123#comment-17497123 ] Jark Wu commented on FLINK-26327: - Could you share the full exception stack ? > throw not a literal

[GitHub] [flink-table-store] tsreaper commented on a change in pull request #23: [FLINK-26276] Introduce ITCase for table store source and sink

2022-02-23 Thread GitBox
tsreaper commented on a change in pull request #23: URL: https://github.com/apache/flink-table-store/pull/23#discussion_r813497170 ## File path: flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/global/GlobalCommitterOperator.java ## @@

[GitHub] [flink] flinkbot edited a comment on pull request #18893: [FLINK-25813][table-planner] Fix unstable test TableITCase#testCollectWithClose

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18893: URL: https://github.com/apache/flink/pull/18893#issuecomment-1048447718 ## CI report: * 7767fbe8a612035dd9ff3702884d2e2bc1d95012 Azure:

[jira] [Created] (FLINK-26343) IndexOutOfBoundsException when subquery select all field from using hive dialect

2022-02-23 Thread luoyuxia (Jira)
luoyuxia created FLINK-26343: Summary: IndexOutOfBoundsException when subquery select all field from using hive dialect Key: FLINK-26343 URL: https://issues.apache.org/jira/browse/FLINK-26343 Project:

[GitHub] [flink] flinkbot edited a comment on pull request #18893: [FLINK-25813][table-planner] Fix unstable test TableITCase#testCollectWithClose

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18893: URL: https://github.com/apache/flink/pull/18893#issuecomment-1048447718 ## CI report: * 7767fbe8a612035dd9ff3702884d2e2bc1d95012 Azure:

[GitHub] [flink] nyingping edited a comment on pull request #18722: [hotfix][docs]fixed some causing ambiguities including the 'shit' comment

2022-02-23 Thread GitBox
nyingping edited a comment on pull request #18722: URL: https://github.com/apache/flink/pull/18722#issuecomment-1049429937 cc [@twalthr](https://github.com/apache/flink/commits?author=twalthr) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] nyingping commented on pull request #18722: [hotfix][docs]fixed some causing ambiguities including the 'shit' comment

2022-02-23 Thread GitBox
nyingping commented on pull request #18722: URL: https://github.com/apache/flink/pull/18722#issuecomment-1049429937 cc @[twalthr](https://github.com/apache/flink/commits?author=twalthr) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (FLINK-26086) fixed some causing ambiguities including the 'shit' comment

2022-02-23 Thread nyingping (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nyingping updated FLINK-26086: -- Description: such as [`@param shiftTimeZone the shit timezone of the

[jira] [Resolved] (FLINK-24607) SourceCoordinator may miss to close SplitEnumerator when failover frequently

2022-02-23 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin resolved FLINK-24607. -- Resolution: Fixed > SourceCoordinator may miss to close SplitEnumerator when failover

[jira] [Updated] (FLINK-24607) SourceCoordinator may miss to close SplitEnumerator when failover frequently

2022-02-23 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated FLINK-24607: - Fix Version/s: 1.13.7 > SourceCoordinator may miss to close SplitEnumerator when failover

[jira] [Commented] (FLINK-24607) SourceCoordinator may miss to close SplitEnumerator when failover frequently

2022-02-23 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497109#comment-17497109 ] Jiangjie Qin commented on FLINK-24607: -- Patch merged. Master: 

[jira] (FLINK-26086) fixed some causing ambiguities including the 'shit' comment

2022-02-23 Thread nyingping (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26086 ] nyingping deleted comment on FLINK-26086: --- was (Author: JIRAUSER282677): Hi [~mapohl] could you assign this simple fix to me when you are free? if you think this fix is necessary. Thanks in

[jira] [Commented] (FLINK-26086) fixed some causing ambiguities including the 'shit' comment

2022-02-23 Thread nyingping (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497108#comment-17497108 ] nyingping commented on FLINK-26086: --- Hi [~trohrmann] could you assign this simple fix to me when you

[GitHub] [flink] MrWhiteSike commented on pull request #18641: [FLINK-25761] [docs] Translate Avro format page into Chinese.

2022-02-23 Thread GitBox
MrWhiteSike commented on pull request #18641: URL: https://github.com/apache/flink/pull/18641#issuecomment-1049414119 [@RocMarshal](https://github.com/RocMarshal) Thanks for the comment. I will review it based on the experience of My first PR! -- This is an automated message from the

[GitHub] [flink] flinkbot edited a comment on pull request #18902: [FLINK-25793][connector/base] Fix high thourouput bug for throttling …

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18902: URL: https://github.com/apache/flink/pull/18902#issuecomment-1049258613 ## CI report: * 23cb39034ac4d2ba09fdbc98db52ee7a5ce1b26f Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18903: [FLINK-26342][docs][formats] Add DataStream documentation for the CSV format

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18903: URL: https://github.com/apache/flink/pull/18903#issuecomment-1049367947 ## CI report: * 53d933b146bfe3cc9bae334b15aa333cfa0cb812 Azure:

[jira] [Updated] (FLINK-26311) Test CsvFormat

2022-02-23 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-26311: -- Description: https://issues.apache.org/jira/browse/FLINK-24703 adds new

[GitHub] [flink] flinkbot commented on pull request #18903: [FLINK-26342][docs][formats] Add DataStream documentation for the CSV format

2022-02-23 Thread GitBox
flinkbot commented on pull request #18903: URL: https://github.com/apache/flink/pull/18903#issuecomment-1049368246 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-26342) Add missing CSV format page

2022-02-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26342: --- Labels: pull-request-available (was: ) > Add missing CSV format page >

[GitHub] [flink] flinkbot commented on pull request #18903: [FLINK-26342][docs][formats] Add DataStream documentation for the CSV format

2022-02-23 Thread GitBox
flinkbot commented on pull request #18903: URL: https://github.com/apache/flink/pull/18903#issuecomment-1049367947 ## CI report: * 53d933b146bfe3cc9bae334b15aa333cfa0cb812 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] afedulov opened a new pull request #18903: [FLINK-25927][docs][formats] Add DataStream documentation for the CSV format

2022-02-23 Thread GitBox
afedulov opened a new pull request #18903: URL: https://github.com/apache/flink/pull/18903 ## What is the purpose of the change This PR adds documentation for the DataStream CSV format. ## Verifying this change This change is a trivial addition to the documentation

[GitHub] [flink] mans2singh commented on pull request #18855: [hotfix][sqlclient][docs] Improved sql client docs

2022-02-23 Thread GitBox
mans2singh commented on pull request #18855: URL: https://github.com/apache/flink/pull/18855#issuecomment-1049342727 @SteNicholas, @fapaul - Can you please review this PR ? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] mans2singh removed a comment on pull request #18576: [FLINK-25900][Table][Timezone][docs] Added aliases to functions calls to match the columns in docs instead of EXPR$5, EXPR$6, EXPR

2022-02-23 Thread GitBox
mans2singh removed a comment on pull request #18576: URL: https://github.com/apache/flink/pull/18576#issuecomment-1032129266 @wuchong - Can you please review this PR ? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] flinkbot edited a comment on pull request #18825: [FLINK-26126][kafka] fix numRecordsOut metric error

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18825: URL: https://github.com/apache/flink/pull/18825#issuecomment-1043598537 ## CI report: * 6332fddc216d7e4345cd7030de81cb35c87245fa Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18896: [FLINK-26186][test] update the API_ANNOTATIONS rule

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18896: URL: https://github.com/apache/flink/pull/18896#issuecomment-1048561075 ## CI report: * 2f45072a3e44b2f0edd017b94cd09aac292161e8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18898: [FLINK-26318][tests] Recover from the latest checkpoint in ChangelogCompatibilityITCase

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18898: URL: https://github.com/apache/flink/pull/18898#issuecomment-1048674504 ## CI report: * ec9759d010299f54be9c1739727f0c3bfac5d831 Azure:

[GitHub] [flink-table-store] shenzhu commented on a change in pull request #24: [FLINK-26217] Introduce manifest.merge-min-count in commit

2022-02-23 Thread GitBox
shenzhu commented on a change in pull request #24: URL: https://github.com/apache/flink-table-store/pull/24#discussion_r813411229 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/manifest/ManifestFileMeta.java ## @@ -135,19 +135,22 @@

[GitHub] [flink-table-store] shenzhu commented on a change in pull request #24: [FLINK-26217] Introduce manifest.merge-min-count in commit

2022-02-23 Thread GitBox
shenzhu commented on a change in pull request #24: URL: https://github.com/apache/flink-table-store/pull/24#discussion_r813410229 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/manifest/ManifestFileMeta.java ## @@ -135,19 +135,22 @@

[GitHub] [flink] flinkbot edited a comment on pull request #18902: [FLINK-25793][connector/base] Fix high thourouput bug for throttling …

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18902: URL: https://github.com/apache/flink/pull/18902#issuecomment-1049258613 ## CI report: * 931a95b46be4f941c596178a95f20b0bdabb79fc Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18902: [FLINK-25793][connector/base] Fix high thourouput bug for throttling …

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18902: URL: https://github.com/apache/flink/pull/18902#issuecomment-1049258613 ## CI report: * 931a95b46be4f941c596178a95f20b0bdabb79fc Azure:

[jira] [Assigned] (FLINK-26342) Add missing CSV format page

2022-02-23 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov reassigned FLINK-26342: - Assignee: Alexander Fedulov > Add missing CSV format page >

[jira] [Created] (FLINK-26342) Add missing CSV format page

2022-02-23 Thread Alexander Fedulov (Jira)
Alexander Fedulov created FLINK-26342: - Summary: Add missing CSV format page Key: FLINK-26342 URL: https://issues.apache.org/jira/browse/FLINK-26342 Project: Flink Issue Type:

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-23 Thread GitBox
CrynetLogistics commented on a change in pull request #18651: URL: https://github.com/apache/flink/pull/18651#discussion_r813374887 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java ## @@ -290,17

[GitHub] [flink] flinkbot edited a comment on pull request #18902: [FLINK-25793][connector/base] Fix high thourouput bug for throttling …

2022-02-23 Thread GitBox
flinkbot edited a comment on pull request #18902: URL: https://github.com/apache/flink/pull/18902#issuecomment-1049258613 ## CI report: * 931a95b46be4f941c596178a95f20b0bdabb79fc Azure:

[GitHub] [flink] vahmed-hamdy closed pull request #18880: [FLINK-25793][connector/base] Implement additive increase/multiplicative decrease to limit throughput

2022-02-23 Thread GitBox
vahmed-hamdy closed pull request #18880: URL: https://github.com/apache/flink/pull/18880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] vahmed-hamdy commented on pull request #18880: [FLINK-25793][connector/base] Implement additive increase/multiplicative decrease to limit throughput

2022-02-23 Thread GitBox
vahmed-hamdy commented on pull request #18880: URL: https://github.com/apache/flink/pull/18880#issuecomment-1049260730 superseded by #18902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

  1   2   3   4   5   6   >