[GitHub] [flink] trushev commented on pull request #20314: [hotfix][runtime] Replace com.sun.istack.NotNull with org.jetbrains.annotations.NotNull

2022-07-19 Thread GitBox
trushev commented on PR #20314: URL: https://github.com/apache/flink/pull/20314#issuecomment-1189849073 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-28614) Empty local state folders not cleanup on retrieving local state

2022-07-19 Thread Yanfei Lei (Jira)
Yanfei Lei created FLINK-28614: -- Summary: Empty local state folders not cleanup on retrieving local state Key: FLINK-28614 URL: https://issues.apache.org/jira/browse/FLINK-28614 Project: Flink

[GitHub] [flink] reswqa commented on a diff in pull request #20306: [FLINK-28581][state/changelog] Close stream of StateChangeFsUploader normally while enabling compression

2022-07-19 Thread GitBox
reswqa commented on code in PR #20306: URL: https://github.com/apache/flink/pull/20306#discussion_r925151253 ## flink-dstl/flink-dstl-dfs/src/test/java/org/apache/flink/changelog/fs/StateChangeFsUploaderTest.java: ## @@ -19,18 +19,32 @@ package org.apache.flink.changelog.fs;

[GitHub] [flink] TanYuxin-tyx commented on pull request #20308: [FLINK-28376][network] Restrict the number of threads for sort-shuffle data read

2022-07-19 Thread GitBox
TanYuxin-tyx commented on PR #20308: URL: https://github.com/apache/flink/pull/20308#issuecomment-1189785395 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-table-store] JingsongLi merged pull request #229: [hotfix] Upgrade to 0.3-SNAPSHOT

2022-07-19 Thread GitBox
JingsongLi merged PR #229: URL: https://github.com/apache/flink-table-store/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #20314: [hotfix][runtime] Replace com.sun.istack.NotNull with org.jetbrains.annotations.NotNull

2022-07-19 Thread GitBox
flinkbot commented on PR #20314: URL: https://github.com/apache/flink/pull/20314#issuecomment-1189780215 ## CI report: * 32e07a9d01a177f4586de8c1a0bd99ad054d708d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] fsk119 commented on a diff in pull request #20101: [FLINK-28150][sql-gateway][hive] Introduce the hiveserver2 endpoint and factory

2022-07-19 Thread GitBox
fsk119 commented on code in PR #20101: URL: https://github.com/apache/flink/pull/20101#discussion_r925140186 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/SessionContext.java: ## @@ -157,10 +148,39 @@ public synchronized void

[GitHub] [flink] trushev opened a new pull request, #20314: [hotfix][runtime] Replace com.sun.istack.NotNull with org.jetbrains.annotations.NotNull

2022-07-19 Thread GitBox
trushev opened a new pull request, #20314: URL: https://github.com/apache/flink/pull/20314 ## What is the purpose of the change I believe `com.sun.istack.NotNull` was accidentally used instead of `org.jetbrains.annotations.NotNull` in testuils ``` $ grep -rw . -e 'import

[GitHub] [flink] fredia closed pull request #20291: don't delay the deletion of checkpoints of incremental rocksdb

2022-07-19 Thread GitBox
fredia closed pull request #20291: don't delay the deletion of checkpoints of incremental rocksdb URL: https://github.com/apache/flink/pull/20291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] wuchong commented on pull request #19989: [FLINK-28089][hive] Hive dialect support "TABLESAMPLE (N rows)"

2022-07-19 Thread GitBox
wuchong commented on PR #19989: URL: https://github.com/apache/flink/pull/19989#issuecomment-1189765626 Looks good to me. @luoyuxia could you rebase the branch and resolve the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Closed] (FLINK-27655) Implement Avro File statistic collector

2022-07-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-27655. Resolution: Invalid > Implement Avro File statistic collector >

[jira] [Commented] (FLINK-27655) Implement Avro File statistic collector

2022-07-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568800#comment-17568800 ] Jingsong Lee commented on FLINK-27655: -- Avro dose not provide statistics. > Implement Avro File

[jira] [Closed] (FLINK-28184) LogStoreE2eTest is not stable

2022-07-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-28184. Resolution: Fixed > LogStoreE2eTest is not stable > - > >

[jira] [Updated] (FLINK-27679) Add tests for append-only table with log store

2022-07-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-27679: - Parent: (was: FLINK-27307) Issue Type: Bug (was: Sub-task) > Add tests for

[jira] [Closed] (FLINK-27307) Flink table store support append-only ingestion without primary keys.

2022-07-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-27307. Resolution: Fixed > Flink table store support append-only ingestion without primary keys. >

[GitHub] [flink] fredia commented on a diff in pull request #20313: [FLINK-28597][state] Discard initial checkpoints without a delay in common cases

2022-07-19 Thread GitBox
fredia commented on code in PR #20313: URL: https://github.com/apache/flink/pull/20313#discussion_r925114799 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java: ## @@ -162,7 +174,14 @@ public Set unregisterUnusedState(long

[jira] [Updated] (FLINK-28535) Support create namespace/table for SparkCatalog

2022-07-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-28535: - Priority: Minor (was: Major) > Support create namespace/table for SparkCatalog >

[jira] [Updated] (FLINK-27679) Add tests for append-only table with log store

2022-07-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-27679: - Summary: Add tests for append-only table with log store (was: Support append-only table for

[jira] [Closed] (FLINK-28458) Document append-only mode

2022-07-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-28458. Resolution: Fixed master: 81eb8830e22b0e8411fbc9296229d0e8a3343a0e > Document append-only mode >

[GitHub] [flink-table-store] JingsongLi merged pull request #228: [FLINK-28458] Add documentation for append-only table

2022-07-19 Thread GitBox
JingsongLi merged PR #228: URL: https://github.com/apache/flink-table-store/pull/228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #131: [FLINK-28563] Add Transformer for VectorSlicer

2022-07-19 Thread GitBox
weibozhao commented on code in PR #131: URL: https://github.com/apache/flink-ml/pull/131#discussion_r925115735 ## flink-ml-core/src/main/java/org/apache/flink/ml/param/ParamValidators.java: ## @@ -38,6 +38,22 @@ public static ParamValidator gtEq(double lowerBound) {

[GitHub] [flink-ml] weibozhao commented on a diff in pull request #131: [FLINK-28563] Add Transformer for VectorSlicer

2022-07-19 Thread GitBox
weibozhao commented on code in PR #131: URL: https://github.com/apache/flink-ml/pull/131#discussion_r925115735 ## flink-ml-core/src/main/java/org/apache/flink/ml/param/ParamValidators.java: ## @@ -38,6 +38,22 @@ public static ParamValidator gtEq(double lowerBound) {

[GitHub] [flink] lincoln-lil commented on a diff in pull request #20242: [FLINK-28490][sql-parser] Introduce `ANALYZE TABLE` syntax in sql parser

2022-07-19 Thread GitBox
lincoln-lil commented on code in PR #20242: URL: https://github.com/apache/flink/pull/20242#discussion_r925114125 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -2203,3 +2203,94 @@ SqlNode TryCastFunctionCall() : return

[GitHub] [flink] wuchong merged pull request #20309: [hotfix][table] Remove unnecessary reset on underlying collector of TableFunctionCollector

2022-07-19 Thread GitBox
wuchong merged PR #20309: URL: https://github.com/apache/flink/pull/20309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #228: [FLINK-28458] Add documentation for append-only table

2022-07-19 Thread GitBox
JingsongLi commented on code in PR #228: URL: https://github.com/apache/flink-table-store/pull/228#discussion_r925107204 ## docs/content/docs/development/create-table.md: ## @@ -166,10 +166,38 @@ Partitioned filtering is the most effective way to improve performance, your

[GitHub] [flink] Sxnan commented on pull request #20147: [FLINK-27524][datastream] Introduce cache API to DataStream

2022-07-19 Thread GitBox
Sxnan commented on PR #20147: URL: https://github.com/apache/flink/pull/20147#issuecomment-1189737080 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] JingsongLi closed pull request #19794: [hotfix] Fix document in Catalog.supportsManagedTable

2022-07-19 Thread GitBox
JingsongLi closed pull request #19794: [hotfix] Fix document in Catalog.supportsManagedTable URL: https://github.com/apache/flink/pull/19794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] leozhangsr commented on a diff in pull request #20234: [FLINK-28475] [Connector/kafka] Stopping offset can be 0

2022-07-19 Thread GitBox
leozhangsr commented on code in PR #20234: URL: https://github.com/apache/flink/pull/20234#discussion_r925103325 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/split/KafkaPartitionSplitSerializerTest.java: ## @@ -0,0 +1,54 @@ +/*

[jira] [Resolved] (FLINK-27523) Runtime supports producing and consuming cached intermediate result

2022-07-19 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved FLINK-27523. -- Resolution: Fixed > Runtime supports producing and consuming cached intermediate result >

[jira] [Assigned] (FLINK-27524) Introduce cache API to DataStream

2022-07-19 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-27524: Assignee: Xuannan Su > Introduce cache API to DataStream > - > >

[jira] [Assigned] (FLINK-27523) Runtime supports producing and consuming cached intermediate result

2022-07-19 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-27523: Assignee: Xuannan Su > Runtime supports producing and consuming cached intermediate result >

[GitHub] [flink] 1996fanrui commented on pull request #20233: [FLINK-28474][checkpoint] Simplify the ChannelStateWriterImpl due to concurrent unaligned checkpoint isn't supported

2022-07-19 Thread GitBox
1996fanrui commented on PR #20233: URL: https://github.com/apache/flink/pull/20233#issuecomment-1189732263 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] lincoln-lil commented on pull request #20309: [hotfix][table] Remove unnecessary reset on underlying collector of TableFunctionCollector

2022-07-19 Thread GitBox
lincoln-lil commented on PR #20309: URL: https://github.com/apache/flink/pull/20309#issuecomment-1189725263 LGTM! +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Assigned] (FLINK-15289) Run sql appear error of "Zero-length character strings have no serializable string representation".

2022-07-19 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-15289: --- Assignee: Jark Wu > Run sql appear error of "Zero-length character strings have no serializable >

[jira] [Updated] (FLINK-15289) Run sql appear error of "Zero-length character strings have no serializable string representation".

2022-07-19 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-15289: Fix Version/s: 1.16.0 > Run sql appear error of "Zero-length character strings have no serializable >

[GitHub] [flink] fsk119 commented on a diff in pull request #20159: [FLINK-28360][SQL Client] Support stop job statement in SQL client

2022-07-19 Thread GitBox
fsk119 commented on code in PR #20159: URL: https://github.com/apache/flink/pull/20159#discussion_r925095048 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java: ## @@ -322,4 +339,96 @@ public List listJars(String

[GitHub] [flink] lsyldliu commented on pull request #20001: [FLINK-27659][table] Planner support to use jar which is registered by 'CREATE FUNTION USING JAR' syntax

2022-07-19 Thread GitBox
lsyldliu commented on PR #20001: URL: https://github.com/apache/flink/pull/20001#issuecomment-1189711920 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #131: [FLINK-28563] Add Transformer for VectorSlicer

2022-07-19 Thread GitBox
yunfengzhou-hub commented on code in PR #131: URL: https://github.com/apache/flink-ml/pull/131#discussion_r925083352 ## flink-ml-core/src/main/java/org/apache/flink/ml/param/ParamValidators.java: ## @@ -38,6 +38,22 @@ public static ParamValidator gtEq(double lowerBound) {

[GitHub] [flink] godfreyhe commented on pull request #20243: [FLINK-28491][table-planner] Introduce APPROX_COUNT_DISTINCT aggregate function for batch sql

2022-07-19 Thread GitBox
godfreyhe commented on PR #20243: URL: https://github.com/apache/flink/pull/20243#issuecomment-1189706693 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] yunfengzhou-hub commented on pull request #130: [FLINK-28502] Add Transformer for RegexTokenizer

2022-07-19 Thread GitBox
yunfengzhou-hub commented on PR #130: URL: https://github.com/apache/flink-ml/pull/130#issuecomment-1189696621 Thanks for the update. It LGTM now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] mas-chen commented on a diff in pull request #20164: [FLINK-28370][connector/kafka] add close method to the interface KafkaRecordSerializationSchema

2022-07-19 Thread GitBox
mas-chen commented on code in PR #20164: URL: https://github.com/apache/flink/pull/20164#discussion_r925068981 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchema.java: ## @@ -48,6 +48,12 @@ default void

[GitHub] [flink] mas-chen commented on a diff in pull request #20234: [FLINK-28475] [Connector/kafka] Stopping offset can be 0

2022-07-19 Thread GitBox
mas-chen commented on code in PR #20234: URL: https://github.com/apache/flink/pull/20234#discussion_r925038355 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReaderTest.java: ## @@ -84,6 +85,7 @@ public

[GitHub] [flink] sunshineJK commented on pull request #20127: [FLINK-26270] Flink SQL write data to kafka by CSV format , whether d…

2022-07-19 Thread GitBox
sunshineJK commented on PR #20127: URL: https://github.com/apache/flink/pull/20127#issuecomment-1189661563 Hi @afedulov @MartijnVisser @PatrickRen What are the next steps? Do I need to do any more operations -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (FLINK-24119) KafkaITCase.testTimestamps fails due to "Topic xxx already exist"

2022-07-19 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-24119: --- Labels: stale-critical test-stability (was: test-stability) I am the [Flink Jira

[jira] [Updated] (FLINK-26402) MinioTestContainerTest.testS3EndpointNeedsToBeSpecifiedBeforeInitializingFileSyste failed due to Container startup failed

2022-07-19 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-26402: --- Labels: pull-request-available stale-critical test-stability (was: pull-request-available

[jira] [Updated] (FLINK-28395) Elasticsearch6DynamicSinkITCase.testWritingDocumentsFromTableApi fails with Elasticsearch exception [type=index_not_found_exception, reason=no such index]

2022-07-19 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28395: --- Labels: stale-critical test-stability (was: test-stability) I am the [Flink Jira

[GitHub] [flink] JingGe commented on a diff in pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-07-19 Thread GitBox
JingGe commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r924934341 ## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownVisitor.java: ## @@ -53,7 +52,6 @@ * Visitor to walk a

[GitHub] [flink] JingGe commented on a diff in pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-07-19 Thread GitBox
JingGe commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r924934341 ## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownVisitor.java: ## @@ -53,7 +52,6 @@ * Visitor to walk a

[GitHub] [flink] MartijnVisser commented on a diff in pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-07-19 Thread GitBox
MartijnVisser commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r924911685 ## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownVisitor.java: ## @@ -53,7 +52,6 @@ * Visitor to

[GitHub] [flink] rkhachatryan commented on pull request #20091: [FLINK-27570][runtime] Fix checkFailureCounter in CheckpointFailureManager for finalize failure

2022-07-19 Thread GitBox
rkhachatryan commented on PR #20091: URL: https://github.com/apache/flink/pull/20091#issuecomment-1189495948 I have added a couple of fixup commits on top of this PR changes: https://github.com/rkhachatryan/flink/tree/f27570-exception Would you mind picking them (unless you have

[GitHub] [flink] qingwei91 commented on a diff in pull request #20140: [Flink 16024][Connector][JDBC] Support FilterPushdown

2022-07-19 Thread GitBox
qingwei91 commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r924891272 ## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownVisitor.java: ## @@ -53,7 +52,6 @@ * Visitor to walk

[GitHub] [flink] qingwei91 commented on a diff in pull request #20235: [Flink 14101][Connectors][Jdbc] SQL Server dialect

2022-07-19 Thread GitBox
qingwei91 commented on code in PR #20235: URL: https://github.com/apache/flink/pull/20235#discussion_r924890763 ## flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/dialect/sqlserver/SqlServerPreparedStatementTest.java: ## @@ -0,0 +1,93 @@ +/*

[GitHub] [flink] rkhachatryan commented on pull request #20091: [FLINK-27570][runtime] Fix checkFailureCounter in CheckpointFailureManager for finalize failure

2022-07-19 Thread GitBox
rkhachatryan commented on PR #20091: URL: https://github.com/apache/flink/pull/20091#issuecomment-1189475857 AZP failure unrelated: FLINK-28269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (FLINK-27570) Checkpoint path error does not cause the job to stop

2022-07-19 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-27570: -- Priority: Major (was: Critical) > Checkpoint path error does not cause the job to

[GitHub] [flink] afedulov commented on pull request #20049: [FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

2022-07-19 Thread GitBox
afedulov commented on PR #20049: URL: https://github.com/apache/flink/pull/20049#issuecomment-1189456851 Update: this effort is currently pending the introduction of the FLIP-238 data generation sources. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (FLINK-28613) PyFlink 1.15 unable to start in Application Mode in k8s

2022-07-19 Thread Clive Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clive Wong resolved FLINK-28613. Resolution: Workaround > PyFlink 1.15 unable to start in Application Mode in k8s >

[jira] [Commented] (FLINK-28613) PyFlink 1.15 unable to start in Application Mode in k8s

2022-07-19 Thread Clive Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568685#comment-17568685 ] Clive Wong commented on FLINK-28613: Turns out it's because of this change:

[GitHub] [flink] MartijnVisser commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2022-07-19 Thread GitBox
MartijnVisser commented on PR #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-1189337469 @maosuhan You'll need to add `com.google.protobuf:protobuf-java:3.21.2` to the NOTICE file for `flink-sql-protobuf` -- This is an automated message from the Apache Git Service.

[GitHub] [flink] flinkbot commented on pull request #20313: [FLINK-28597][state] Discard initial checkpoints without a delay in common cases

2022-07-19 Thread GitBox
flinkbot commented on PR #20313: URL: https://github.com/apache/flink/pull/20313#issuecomment-1189312666 ## CI report: * 815fc355232f40adb363bf55031ffb942e7f8a78 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] rkhachatryan opened a new pull request, #20313: [FLINK-28597][state] Discard initial checkpoints without a delay in common cases

2022-07-19 Thread GitBox
rkhachatryan opened a new pull request, #20313: URL: https://github.com/apache/flink/pull/20313 ## What is the purpose of the change This PR limits checkpoint discard delay in CLAIM restore mode to two cases: 1. Changelog (off -> on). Adjust `SharedStateRegsitry` API to make it

[jira] [Updated] (FLINK-28613) PyFlink 1.15 unable to start in Application Mode in k8s

2022-07-19 Thread Clive Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clive Wong updated FLINK-28613: --- Description: I recently bumped my PyFlink job from 1.14 to 1.15, and the job is failing with build

[GitHub] [flink] reswqa commented on a diff in pull request #20293: [FLINK-27904][runtime] Introduce HsMemoryDataManager

2022-07-19 Thread GitBox
reswqa commented on code in PR #20293: URL: https://github.com/apache/flink/pull/20293#discussion_r924687852 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsMemoryDataManager.java: ## @@ -0,0 +1,673 @@ +/* + * Licensed to the Apache

[jira] [Updated] (FLINK-28223) Add artifact-fetcher to the pod-template.yaml example

2022-07-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-28223: --- Fix Version/s: kubernetes-operator-1.2.0 > Add artifact-fetcher to the pod-template.yaml example >

[jira] [Updated] (FLINK-28223) Add artifact-fetcher to the pod-template.yaml example

2022-07-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-28223: --- Affects Version/s: (was: kubernetes-operator-1.1.0) > Add artifact-fetcher to the

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #314: [FLINK-28494] Add new job status states to CRD

2022-07-19 Thread GitBox
gyfora commented on PR #314: URL: https://github.com/apache/flink-kubernetes-operator/pull/314#issuecomment-1189204455 @darenwkt I think we can close this PR for now based on the offline discussions -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Closed] (FLINK-28207) Disabling webhook should also disable mutator

2022-07-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-28207. -- Resolution: Fixed merged to main a2908f5b773573fe2b76dd6061512a27f698ec4f > Disabling webhook should

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #323: [FLINK-28207] Improve webhook helm configuration

2022-07-19 Thread GitBox
gyfora merged PR #323: URL: https://github.com/apache/flink-kubernetes-operator/pull/323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] reswqa commented on a diff in pull request #20293: [FLINK-27904][runtime] Introduce HsMemoryDataManager

2022-07-19 Thread GitBox
reswqa commented on code in PR #20293: URL: https://github.com/apache/flink/pull/20293#discussion_r924647096 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsMemoryDataManager.java: ## @@ -0,0 +1,673 @@ +/* + * Licensed to the Apache

[GitHub] [flink] reswqa commented on a diff in pull request #20293: [FLINK-27904][runtime] Introduce HsMemoryDataManager

2022-07-19 Thread GitBox
reswqa commented on code in PR #20293: URL: https://github.com/apache/flink/pull/20293#discussion_r924646640 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsMemoryDataManager.java: ## @@ -0,0 +1,673 @@ +/* + * Licensed to the Apache

[GitHub] [flink] reswqa commented on a diff in pull request #20293: [FLINK-27904][runtime] Introduce HsMemoryDataManager

2022-07-19 Thread GitBox
reswqa commented on code in PR #20293: URL: https://github.com/apache/flink/pull/20293#discussion_r924645809 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsMemoryDataManager.java: ## @@ -0,0 +1,673 @@ +/* + * Licensed to the Apache

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #323: [FLINK-28207] Improve webhook helm configuration

2022-07-19 Thread GitBox
gyfora commented on code in PR #323: URL: https://github.com/apache/flink-kubernetes-operator/pull/323#discussion_r924644841 ## helm/flink-kubernetes-operator/values.yaml: ## @@ -83,8 +83,10 @@ webhookSecurityContext: {} webhook: create: true - mutator: -create:

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #323: [FLINK-28207] Improve webhook helm configuration

2022-07-19 Thread GitBox
morhidi commented on PR #323: URL: https://github.com/apache/flink-kubernetes-operator/pull/323#issuecomment-1189180965 +1 LGTM, tested locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #323: [FLINK-28207] Improve webhook helm configuration

2022-07-19 Thread GitBox
morhidi commented on code in PR #323: URL: https://github.com/apache/flink-kubernetes-operator/pull/323#discussion_r924632811 ## helm/flink-kubernetes-operator/values.yaml: ## @@ -83,8 +83,10 @@ webhookSecurityContext: {} webhook: create: true - mutator: -create:

[jira] [Commented] (FLINK-28521) Hostname verification in ssl context is not working

2022-07-19 Thread Jean-Damien HATZENBUHLER (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568600#comment-17568600 ] Jean-Damien HATZENBUHLER commented on FLINK-28521: -- It make sense to skip hostname

[jira] [Updated] (FLINK-28521) Hostname verification in ssl context is not working

2022-07-19 Thread Jean-Damien HATZENBUHLER (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Damien HATZENBUHLER updated FLINK-28521: - Description: The hostname certificate is not check in ssl context.

[jira] [Assigned] (FLINK-28521) Hostname verification in ssl context is not working

2022-07-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-28521: -- Assignee: Jean-Damien HATZENBUHLER > Hostname verification in ssl context is not

[jira] [Assigned] (FLINK-28520) RestClient doesn't use SNI TLS extension

2022-07-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-28520: -- Assignee: Jean-Damien HATZENBUHLER > RestClient doesn't use SNI TLS extension >

[GitHub] [flink] reswqa commented on a diff in pull request #20293: [FLINK-27904][runtime] Introduce HsMemoryDataManager

2022-07-19 Thread GitBox
reswqa commented on code in PR #20293: URL: https://github.com/apache/flink/pull/20293#discussion_r924610288 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsMemoryDataManager.java: ## @@ -0,0 +1,673 @@ +/* + * Licensed to the Apache

[GitHub] [flink] reswqa commented on a diff in pull request #20293: [FLINK-27904][runtime] Introduce HsMemoryDataManager

2022-07-19 Thread GitBox
reswqa commented on code in PR #20293: URL: https://github.com/apache/flink/pull/20293#discussion_r924600342 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsMemoryDataManager.java: ## @@ -0,0 +1,673 @@ +/* + * Licensed to the Apache

[GitHub] [flink] link3280 commented on a diff in pull request #20159: [FLINK-28360][SQL Client] Support stop job statement in SQL client

2022-07-19 Thread GitBox
link3280 commented on code in PR #20159: URL: https://github.com/apache/flink/pull/20159#discussion_r924595473 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java: ## @@ -322,4 +339,96 @@ public List listJars(String

[GitHub] [flink] link3280 commented on a diff in pull request #20159: [FLINK-28360][SQL Client] Support stop job statement in SQL client

2022-07-19 Thread GitBox
link3280 commented on code in PR #20159: URL: https://github.com/apache/flink/pull/20159#discussion_r924224755 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java: ## @@ -322,4 +339,96 @@ public List listJars(String

[jira] [Closed] (FLINK-27447) Implement last-state with ZooKeeper HA

2022-07-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-27447. -- Resolution: Won't Fix This is already covered by the operator logic > Implement last-state with

[jira] [Closed] (FLINK-28113) Document periodic savepointing

2022-07-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-28113. -- Resolution: Fixed > Document periodic savepointing > -- > >

[jira] [Commented] (FLINK-28521) Hostname verification in ssl context is not working

2022-07-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568586#comment-17568586 ] Chesnay Schepler commented on FLINK-28521: -- Seems intentional that we skip hostname

[GitHub] [flink] wuchong commented on pull request #20309: [hotfix][table] Remove unnecessary reset on underlying collector of TableFunctionCollector

2022-07-19 Thread GitBox
wuchong commented on PR #20309: URL: https://github.com/apache/flink/pull/20309#issuecomment-1189117044 cc @lincoln-lil -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] 1996fanrui commented on pull request #20233: [FLINK-28474][checkpoint] Simplify the ChannelStateWriterImpl due to concurrent unaligned checkpoint isn't supported

2022-07-19 Thread GitBox
1996fanrui commented on PR #20233: URL: https://github.com/apache/flink/pull/20233#issuecomment-1189094363 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] lindong28 merged pull request #129: [FLINK-28500] Add Transformer for Tokenizer

2022-07-19 Thread GitBox
lindong28 merged PR #129: URL: https://github.com/apache/flink-ml/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-ml] lindong28 commented on pull request #129: [FLINK-28500] Add Transformer for Tokenizer

2022-07-19 Thread GitBox
lindong28 commented on PR #129: URL: https://github.com/apache/flink-ml/pull/129#issuecomment-1189089858 Thanks for the update. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (FLINK-28411) OperatorCoordinator exception may fail Session Cluster

2022-07-19 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-28411: - Assignee: Daren Wong > OperatorCoordinator exception may fail Session Cluster >

[jira] [Comment Edited] (FLINK-24932) Frocksdb cannot run on Apple M1

2022-07-19 Thread Sebastian Mattheis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568556#comment-17568556 ] Sebastian Mattheis edited comment on FLINK-24932 at 7/19/22 1:40 PM: -

[GitHub] [flink] link3280 commented on a diff in pull request #20101: [FLINK-28150][sql-gateway][hive] Introduce the hiveserver2 endpoint and factory

2022-07-19 Thread GitBox
link3280 commented on code in PR #20101: URL: https://github.com/apache/flink/pull/20101#discussion_r924392099 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/HiveServer2EndpointConfigOptions.java: ## @@ -0,0 +1,119 @@ +/* + *

[GitHub] [flink] hlteoh37 commented on a diff in pull request #20245: [FLINK-28487][connectors] Introduce configurable RateLimitingStrategy…

2022-07-19 Thread GitBox
hlteoh37 commented on code in PR #20245: URL: https://github.com/apache/flink/pull/20245#discussion_r924509131 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriterTest.java: ## @@ -19,6 +19,8 @@ import

[jira] [Created] (FLINK-28613) PyFlink 1.15 unable to start in Application Mode in k8s

2022-07-19 Thread Clive Wong (Jira)
Clive Wong created FLINK-28613: -- Summary: PyFlink 1.15 unable to start in Application Mode in k8s Key: FLINK-28613 URL: https://issues.apache.org/jira/browse/FLINK-28613 Project: Flink Issue

[GitHub] [flink] fsk119 closed pull request #20302: [hotfix][table-runtime] Avoid NPE for SliceAssigner and improve error message

2022-07-19 Thread GitBox
fsk119 closed pull request #20302: [hotfix][table-runtime] Avoid NPE for SliceAssigner and improve error message URL: https://github.com/apache/flink/pull/20302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] hlteoh37 commented on a diff in pull request #20245: [FLINK-28487][connectors] Introduce configurable RateLimitingStrategy…

2022-07-19 Thread GitBox
hlteoh37 commented on code in PR #20245: URL: https://github.com/apache/flink/pull/20245#discussion_r924493155 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java: ## @@ -344,69 +351,69 @@ public void

[jira] [Commented] (FLINK-24932) Frocksdb cannot run on Apple M1

2022-07-19 Thread Sebastian Mattheis (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568556#comment-17568556 ] Sebastian Mattheis commented on FLINK-24932: [~yunta] In theory it would be best to test it,

[GitHub] [flink] godfreyhe commented on pull request #20243: [FLINK-28491][table-planner] Introduce APPROX_COUNT_DISTINCT aggregate function for batch sql

2022-07-19 Thread GitBox
godfreyhe commented on PR #20243: URL: https://github.com/apache/flink/pull/20243#issuecomment-1189039700 Thanks for the review, I will rebase the master and squash the commit. I will merge the pr once it turns green -- This is an automated message from the Apache Git Service. To respond

[jira] [Closed] (FLINK-28490) Introduce "ANALYZE TABLE" Syntax in sql parser

2022-07-19 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-28490. -- Resolution: Fixed Fixed in master: e54c86415b106f253b58c54670fe5b84b5c40f25 > Introduce "ANALYZE

[GitHub] [flink] godfreyhe closed pull request #20242: [FLINK-28490][sql-parser] Introduce `ANALYZE TABLE` syntax in sql parser

2022-07-19 Thread GitBox
godfreyhe closed pull request #20242: [FLINK-28490][sql-parser] Introduce `ANALYZE TABLE` syntax in sql parser URL: https://github.com/apache/flink/pull/20242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] godfreyhe commented on pull request #20242: [FLINK-28490][sql-parser] Introduce `ANALYZE TABLE` syntax in sql parser

2022-07-19 Thread GitBox
godfreyhe commented on PR #20242: URL: https://github.com/apache/flink/pull/20242#issuecomment-1189019390 I will merge the pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

  1   2   3   >