[GitHub] [flink] gaoyunhaii commented on pull request #20351: [FLINK-28380][runtime] Produce one intermediate dataset for multiple consumer job vertices consuming the same data

2022-07-30 Thread GitBox
gaoyunhaii commented on PR #20351: URL: https://github.com/apache/flink/pull/20351#issuecomment-1200354111 Thanks @wsry for the PR! LGTM, let's have a final check after the commit merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (FLINK-28625) Guard against changing target session deployment for sessionjob

2022-07-30 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573340#comment-17573340 ] Aitozi commented on FLINK-28625: Make sense, I will push a PR for this. > Guard against

[jira] [Updated] (FLINK-28751) Poor performance of the built in json_value function

2022-07-30 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi updated FLINK-28751: --- Description: When I use the JSON_VALUE function, I found the performance is very poor. It's mainly affected

[GitHub] [flink] luoyuxia commented on a diff in pull request #20000: [FLINK-28096][hive] Hive dialect support set variables

2022-07-30 Thread GitBox
luoyuxia commented on code in PR #2: URL: https://github.com/apache/flink/pull/2#discussion_r933919454 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java: ## @@ -918,6 +918,72 @@ public void testMacro() throws E

[jira] [Updated] (FLINK-28751) Poor performance of the built in json_value function

2022-07-30 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi updated FLINK-28751: --- Description: When I use the JSON_VALUE function, I found the performance is very poor. It's mainly affected

[jira] [Commented] (FLINK-26937) Introduce Leveled compression for LSM

2022-07-30 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573335#comment-17573335 ] xingyuan cheng commented on FLINK-26937: I would like to try to tease out the ba

[jira] [Commented] (FLINK-28552) GenerateUtils#generateCompare supports MULTISET and MAP

2022-07-30 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573336#comment-17573336 ] xingyuan cheng commented on FLINK-28552: I would like to try to tease out the ba

[GitHub] [flink] swuferhong commented on pull request #20084: [FLINK-27988][table-planner] Let HiveTableSource extend from SupportStatisticsReport

2022-07-30 Thread GitBox
swuferhong commented on PR #20084: URL: https://github.com/apache/flink/pull/20084#issuecomment-1200334904 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] wuchong commented on a diff in pull request #20000: [FLINK-28096][hive] Hive dialect support set variables

2022-07-30 Thread GitBox
wuchong commented on code in PR #2: URL: https://github.com/apache/flink/pull/2#discussion_r933836257 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java: ## @@ -918,6 +918,72 @@ public void testMacro() throws Ex

[GitHub] [flink] lindong28 commented on a diff in pull request #20275: [FLINK-28606][Runtime/Checkpointing] Preserve consistency of OperatorEvent from OperatorCoordinator to subtasks

2022-07-30 Thread GitBox
lindong28 commented on code in PR #20275: URL: https://github.com/apache/flink/pull/20275#discussion_r932818606 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java: ## @@ -121,7 +118,15 @@ private final OperatorID op

[jira] [Created] (FLINK-28754) document that Java 8 is required to build table store

2022-07-30 Thread David Anderson (Jira)
David Anderson created FLINK-28754: -- Summary: document that Java 8 is required to build table store Key: FLINK-28754 URL: https://issues.apache.org/jira/browse/FLINK-28754 Project: Flink Iss

[jira] [Closed] (FLINK-27387) Support Insert Multi-Table

2022-07-30 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-27387. --- Fix Version/s: 1.16.0 Resolution: Fixed Fixed in master: bed7993aaf9838efdd254c8140c36d4ae1f80a56 >

[GitHub] [flink] wuchong merged pull request #19647: [FLINK-27387][hive] Hive dialect supports multi-insert statement

2022-07-30 Thread GitBox
wuchong merged PR #19647: URL: https://github.com/apache/flink/pull/19647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Closed] (FLINK-25142) The user-defined hive udtf initialize exception in hive dialect

2022-07-30 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-25142. --- Fix Version/s: 1.16.0 Assignee: xiangqiao Resolution: Fixed Fixed in master: 541c66b7b71b396

[GitHub] [flink] wuchong merged pull request #19400: [FLINK-25142][Connectors / Hive]Fix user-defined hive udtf initialize exception in hive dialect

2022-07-30 Thread GitBox
wuchong merged PR #19400: URL: https://github.com/apache/flink/pull/19400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Comment Edited] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'

2022-07-30 Thread DavidLiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573268#comment-17573268 ] DavidLiu edited comment on FLINK-28111 at 7/30/22 1:58 PM: --- Th

[jira] [Commented] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'

2022-07-30 Thread DavidLiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573268#comment-17573268 ] DavidLiu commented on FLINK-28111: -- This is not an issue, but rather, by design. The t

[GitHub] [flink] leozhangsr commented on pull request #20387: [FLINK-28475] [Connector/kafka] stopping offset can be 0.

2022-07-30 Thread GitBox
leozhangsr commented on PR #20387: URL: https://github.com/apache/flink/pull/20387#issuecomment-1200156751 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Commented] (FLINK-27019) use hive dialect in SqlClient would thrown an error based on 1.15 version

2022-07-30 Thread DavidLiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573263#comment-17573263 ] DavidLiu commented on FLINK-27019: -- The source codes have supported hive-dialect. This

[GitHub] [flink] simplejason commented on a diff in pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution

2022-07-30 Thread GitBox
simplejason commented on code in PR #20380: URL: https://github.com/apache/flink/pull/20380#discussion_r933797678 ## flink-runtime-web/web-dashboard/src/app/pages/overview/statistic/overview-statistic.component.less: ## @@ -17,50 +17,56 @@ */ @import "theme"; -nz-card { -

[GitHub] [flink] simplejason commented on a diff in pull request #20380: [FLINK-28589][runtime-web] enhance web UI for speculative execution

2022-07-30 Thread GitBox
simplejason commented on code in PR #20380: URL: https://github.com/apache/flink/pull/20380#discussion_r933797173 ## flink-runtime-web/web-dashboard/src/app/pages/job/overview/backpressure/job-overview-drawer-backpressure.component.html: ## @@ -63,9 +63,18 @@ -

[jira] [Commented] (FLINK-28653) State Schema Evolution does not work - Flink defaults to Kryo serialization even for POJOs and Avro SpecificRecords

2022-07-30 Thread Peleg Tsadok (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573247#comment-17573247 ] Peleg Tsadok commented on FLINK-28653: -- Okay I fixed the AvroMissingFieldException

[GitHub] [flink] flinkbot commented on pull request #20398: [FLINK-28752][python][table-planner] Add the json plan support in Python UDFs

2022-07-30 Thread GitBox
flinkbot commented on PR #20398: URL: https://github.com/apache/flink/pull/20398#issuecomment-1200139640 ## CI report: * e4136d7989e9a1876aa7c37424b6a4d135b000d5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28752) Add the json plan support in Python UDFs

2022-07-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28752: --- Labels: pull-request-available (was: ) > Add the json plan support in Python UDFs > ---

[GitHub] [flink] HuangXingBo opened a new pull request, #20398: [FLINK-28752][python][table-planner] Add the json plan support in Python UDFs

2022-07-30 Thread GitBox
HuangXingBo opened a new pull request, #20398: URL: https://github.com/apache/flink/pull/20398 ## What is the purpose of the change *This pull request will add the json plan support in Python UDFs* ## Brief change log - *Add the json plan support in Python UDFs*

[jira] [Commented] (FLINK-28653) State Schema Evolution does not work - Flink defaults to Kryo serialization even for POJOs and Avro SpecificRecords

2022-07-30 Thread Peleg Tsadok (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573242#comment-17573242 ] Peleg Tsadok commented on FLINK-28653: -- [~chesnay] Great comments! I fixed the ign

[jira] [Created] (FLINK-28753) Improve FilterIntoJoinRule which could push some predicate to another side

2022-07-30 Thread godfrey he (Jira)
godfrey he created FLINK-28753: -- Summary: Improve FilterIntoJoinRule which could push some predicate to another side Key: FLINK-28753 URL: https://issues.apache.org/jira/browse/FLINK-28753 Project: Flink

[jira] [Closed] (FLINK-28707) Introduce interface SupportsDynamicPartitionPruning

2022-07-30 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-28707. -- Resolution: Fixed Fixed in master: c9d34ed773e311bcb0e1c54ed1b3ca31973e8853 > Introduce interface Sup

[jira] [Commented] (FLINK-28751) Poor performance of the built in json_value function

2022-07-30 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573238#comment-17573238 ] Aitozi commented on FLINK-28751: I opened a PR for this. cc [~jark] [~libenchao]  > Poo

[GitHub] [flink] flinkbot commented on pull request #20397: [FLINK-28751][Table SQL/Runtime] Optimize the performance of the json…

2022-07-30 Thread GitBox
flinkbot commented on PR #20397: URL: https://github.com/apache/flink/pull/20397#issuecomment-1200123756 ## CI report: * 91f7fef85fc48bbeaf4737e3a55b48fd422a1849 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28751) Poor performance of the built in json_value function

2022-07-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28751: --- Labels: pull-request-available (was: ) > Poor performance of the built in json_value functi

[GitHub] [flink] Aitozi opened a new pull request, #20397: [FLINK-28751][Table SQL/Runtime] Optimize the performance of the json…

2022-07-30 Thread GitBox
Aitozi opened a new pull request, #20397: URL: https://github.com/apache/flink/pull/20397 … functions ## What is the purpose of the change This PR is meant to improve the performance of the built in json functions. The default `LRUCache` used in the JsonPath CacheProvider heavi

[jira] [Updated] (FLINK-28750) Whether to add field comment for hive table

2022-07-30 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hehuiyuan updated FLINK-28750: -- Attachment: image-2022-07-30-16-36-37-032.png > Whether to add field comment for hive table >

[jira] [Updated] (FLINK-28750) Whether to add field comment for hive table

2022-07-30 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hehuiyuan updated FLINK-28750: -- Description: Currently,  I have a hive ddl,as follows {code:java} "set table.sql-dialect=hive;\n" + "C

[jira] [Created] (FLINK-28752) Add the json plan support in Python UDFs

2022-07-30 Thread Huang Xingbo (Jira)
Huang Xingbo created FLINK-28752: Summary: Add the json plan support in Python UDFs Key: FLINK-28752 URL: https://issues.apache.org/jira/browse/FLINK-28752 Project: Flink Issue Type: New Feat

[GitHub] [flink] flinkbot commented on pull request #20396: [FLINK-28745][python] Support DataStream PythonCoProcessOperator and PythonKeyedCoProcessOperator in Thread Mode

2022-07-30 Thread GitBox
flinkbot commented on PR #20396: URL: https://github.com/apache/flink/pull/20396#issuecomment-1200115276 ## CI report: * 650e7b2a693a8f6989f6ad20e17ceca5ef6a8359 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28750) Whether to add field comment for hive table

2022-07-30 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hehuiyuan updated FLINK-28750: -- Summary: Whether to add field comment for hive table (was: Whether to add comment for hive table) >

[jira] [Updated] (FLINK-28750) Whether to add comment for hive table

2022-07-30 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hehuiyuan updated FLINK-28750: -- Priority: Minor (was: Major) > Whether to add comment for hive table > --

[jira] [Updated] (FLINK-28745) Support DataStream PythonCoProcessOperator and PythonKeyedCoProcessOperator in Thread Mode

2022-07-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28745: --- Labels: pull-request-available (was: ) > Support DataStream PythonCoProcessOperator and Pyt

[GitHub] [flink] HuangXingBo opened a new pull request, #20396: [FLINK-28745][python] Support DataStream PythonCoProcessOperator and PythonKeyedCoProcessOperator in Thread Mode

2022-07-30 Thread GitBox
HuangXingBo opened a new pull request, #20396: URL: https://github.com/apache/flink/pull/20396 ## What is the purpose of the change *This pull request will support DataStream PythonCoProcessOperator and PythonKeyedCoProcessOperator in Thread Mode* ## Brief change log -

[jira] [Updated] (FLINK-28750) Whether to add comment for hive table

2022-07-30 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hehuiyuan updated FLINK-28750: -- Description: Currently,  I have a hive ddl,as follows {code:java} "set table.sql-dialect=hive;\n" + "C

[jira] [Updated] (FLINK-28750) Whether to add comment for hive table

2022-07-30 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hehuiyuan updated FLINK-28750: -- Description: Currently,  I have a hive ddl,as follows {code:java} "set table.sql-dialect=hive;\n" + "C

[GitHub] [flink] swuferhong commented on pull request #20084: [FLINK-27988][table-planner] Let HiveTableSource extend from SupportStatisticsReport

2022-07-30 Thread GitBox
swuferhong commented on PR #20084: URL: https://github.com/apache/flink/pull/20084#issuecomment-1200113237 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Updated] (FLINK-28750) Whether to add comment for hive table

2022-07-30 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hehuiyuan updated FLINK-28750: -- Attachment: image-2022-07-30-15-53-03-754.png > Whether to add comment for hive table > --

[jira] [Updated] (FLINK-28750) Whether to add comment for hive table

2022-07-30 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hehuiyuan updated FLINK-28750: -- Description: Currently,  I have a hive ddl,as follows {code:java} "set table.sql-dialect=hive;\n" + "C

[jira] [Updated] (FLINK-28750) Whether to add comment for hive table

2022-07-30 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hehuiyuan updated FLINK-28750: -- Description: Currently,  I have a hive ddl,as follows {code:java} "set table.sql-dialect=hive;\n" + "C

[jira] [Updated] (FLINK-28751) Poor performance of the built in json_value function

2022-07-30 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi updated FLINK-28751: --- Description: When I use the JSON_VALUE function, I found the performance is very poor. It's mainly affected

[GitHub] [flink] WencongLiu commented on pull request #20236: [FLINK-27769][sql-gateway]Introduce the REST endpoint framework

2022-07-30 Thread GitBox
WencongLiu commented on PR #20236: URL: https://github.com/apache/flink/pull/20236#issuecomment-1200111512 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Updated] (FLINK-28751) Poor performance of the built in json_value function

2022-07-30 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi updated FLINK-28751: --- Description: When I use the JSON_VALUE function, I found the performance is very poor. It's mainly affected

[jira] [Created] (FLINK-28751) Poor performance of the built in json_value function

2022-07-30 Thread Aitozi (Jira)
Aitozi created FLINK-28751: -- Summary: Poor performance of the built in json_value function Key: FLINK-28751 URL: https://issues.apache.org/jira/browse/FLINK-28751 Project: Flink Issue Type: Improvem

[jira] [Updated] (FLINK-28750) Whether to add comment for hive table

2022-07-30 Thread hehuiyuan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hehuiyuan updated FLINK-28750: -- Description: Currently,  I have a hive ddl,as follows {code:java} "set table.sql-dialect=hive;\n" + "C

[jira] [Created] (FLINK-28750) Whether to add comment for hive table

2022-07-30 Thread hehuiyuan (Jira)
hehuiyuan created FLINK-28750: - Summary: Whether to add comment for hive table Key: FLINK-28750 URL: https://issues.apache.org/jira/browse/FLINK-28750 Project: Flink Issue Type: Improvement

[GitHub] [flink] SmirAlex commented on a diff in pull request #20196: [FLINK-28417][table] Add interfaces for LookupCache and default implementation

2022-07-30 Thread GitBox
SmirAlex commented on code in PR #20196: URL: https://github.com/apache/flink/pull/20196#discussion_r933765687 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/lookup/cache/DefaultLookupCache.java: ## @@ -0,0 +1,270 @@ +/* + * Licensed to t