[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1044175579 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/converter/BsonToRowDataConverters.java: ## @@ -0,0 +1,677 @@ +/* + *

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1044175579 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/converter/BsonToRowDataConverters.java: ## @@ -0,0 +1,677 @@ +/* + *

[GitHub] [flink] liyubin117 commented on a diff in pull request #21182: [FLINK-29679][table] Migrate to new schema framework & show column comment

liyubin117 commented on code in PR #21182: URL: https://github.com/apache/flink/pull/21182#discussion_r1044056409 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/typeutils/TimeIndicatorTypeInfo.java: ## @@ -62,13 +61,10 @@ protected

[jira] [Commented] (FLINK-30325) the column lost comments, also find some issue ,but that commit is not mr. i have some diff solution

[ https://issues.apache.org/jira/browse/FLINK-30325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645125#comment-17645125 ] blackpighe commented on FLINK-30325: Yes, I only want to be responsible for 1.14.3 now, because our

[jira] [Commented] (FLINK-30250) The flame graph type is wrong

[ https://issues.apache.org/jira/browse/FLINK-30250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645113#comment-17645113 ] Rui Fan commented on FLINK-30250: - [~xtsong] [~junhan] thanks for your help and review :) > The flame

[GitHub] [flink] 1996fanrui commented on pull request #21368: [FLINK-30165][runtime][JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

1996fanrui commented on PR #21368: URL: https://github.com/apache/flink/pull/21368#issuecomment-1343929889 > Thanks for the PR and for pulling me in. I've left only some minor comments, PTAL. Hi @rkhachatryan , thanks for your review, I have updated. -- This is an automated

[GitHub] [flink] flinkbot commented on pull request #21472: [hotfix][doc] Fix some errors in sql gateway docs

flinkbot commented on PR #21472: URL: https://github.com/apache/flink/pull/21472#issuecomment-1343924424 ## CI report: * 6cce43c237a81e8ab2825a86b0dc0f47324ae7ad UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] paul8263 opened a new pull request, #21472: [hotfix][doc] Fix some errors in sql gateway docs

paul8263 opened a new pull request, #21472: URL: https://github.com/apache/flink/pull/21472 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each

[GitHub] [flink] jiexray commented on pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

jiexray commented on PR #21410: URL: https://github.com/apache/flink/pull/21410#issuecomment-1343908038 Thank you @snuyanzin for your comments, I will fix them as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Comment Edited] (FLINK-23408) Wait for a checkpoint completed after finishing a task

[ https://issues.apache.org/jira/browse/FLINK-23408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645097#comment-17645097 ] qiunan edited comment on FLINK-23408 at 12/9/22 6:25 AM: - [~dwysakowicz] Why not

[jira] [Comment Edited] (FLINK-23408) Wait for a checkpoint completed after finishing a task

[ https://issues.apache.org/jira/browse/FLINK-23408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645097#comment-17645097 ] qiunan edited comment on FLINK-23408 at 12/9/22 6:23 AM: - [~dwysakowicz] Why not

[jira] [Commented] (FLINK-23408) Wait for a checkpoint completed after finishing a task

[ https://issues.apache.org/jira/browse/FLINK-23408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645097#comment-17645097 ] qiunan commented on FLINK-23408: Why not suspend source at  suspend  savepoint ？ > Wait for a

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1044117642 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/MongoDynamicTableSource.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-30334) SourceCoordinator error splitRequest check cause HybridSource loss of data and hang

[ https://issues.apache.org/jira/browse/FLINK-30334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645087#comment-17645087 ] Ran Tao commented on FLINK-30334: - [~zhuzh] Yes, the key point is that we need to distinguish the

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #187: [FLINK-29601] Add Estimator and Transformer for UnivariateFeatureSelector

lindong28 commented on code in PR #187: URL: https://github.com/apache/flink-ml/pull/187#discussion_r1044092761 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/univariatefeatureselector/UnivariateFeatureSelector.java: ## @@ -0,0 +1,305 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-30081) Local executor can not accept different jvm-overhead.min/max values

[ https://issues.apache.org/jira/browse/FLINK-30081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645077#comment-17645077 ] Mingliang Liu commented on FLINK-30081: --- [~xtsong] Thanks for providing more context. I'd love to

[GitHub] [flink-ml] lindong28 merged pull request #183: [FLINK-29603] Add Transformer for StopWordsRemover

lindong28 merged PR #183: URL: https://github.com/apache/flink-ml/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-ml] lindong28 commented on pull request #183: [FLINK-29603] Add Transformer for StopWordsRemover

lindong28 commented on PR #183: URL: https://github.com/apache/flink-ml/pull/183#issuecomment-1343849468 Thanks for the PR. And thanks @jiangxin369 for the review. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #430: [FLINK-30333] Supports lookup a partial-update table

tsreaper commented on code in PR #430: URL: https://github.com/apache/flink-table-store/pull/430#discussion_r1044089189 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/source/TableStreamingReader.java: ## @@ -88,13 +86,7 @@ public

[GitHub] [flink] flinkbot commented on pull request #21471: [FLINK-29940][runtime] ExecutionGraph logs job state change at WARN level when job fails

flinkbot commented on PR #21471: URL: https://github.com/apache/flink/pull/21471#issuecomment-1343847686 ## CI report: * 19c2cc5fdcaccc137649f63f8f7408496fe7ad66 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] liuml07 commented on pull request #21471: [FLINK-29940] ExecutionGraph logs job state change at WARN level when job fails

liuml07 commented on PR #21471: URL: https://github.com/apache/flink/pull/21471#issuecomment-1343846067 Per discussion in the JIRA, I closed the non-merged old PR #21266. Later we think we can make it WARN level to make it more visible. CC: @rmetzger -- This is an automated message from

[GitHub] [flink] liuml07 opened a new pull request, #21471: [FLINK-29940] ExecutionGraph logs job state change at WARN level when job fails

liuml07 opened a new pull request, #21471: URL: https://github.com/apache/flink/pull/21471 ## What is the purpose of the change When job switched to FAILED state, the log is very useful to understand why it failed along with the root cause exception stack. However, the current log

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21432: [FLINK-30250][web][flame-graph] Fix the bug that show the flame graph of old type

1996fanrui commented on code in PR #21432: URL: https://github.com/apache/flink/pull/21432#discussion_r1044086036 ## flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.ts: ## @@ -55,7 +55,7 @@ export class

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1044082086 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/converter/BsonToRowDataConverters.java: ## @@ -0,0 +1,681 @@ +/* + *

[GitHub] [flink] saLeox commented on pull request #21149: [FLINK-29527][formats/parquet] Make unknownFieldsIndices work for single ParquetReader

saLeox commented on PR #21149: URL: https://github.com/apache/flink/pull/21149#issuecomment-1343829748 Hi @luoyuxia, glad to hear the feedback and the idea behind design! The case that mix different schema files in one single partition will happen when we use date as partition key in the

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1044077023 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/converter/BsonToRowDataConverters.java: ## @@ -0,0 +1,677 @@ +/* + *

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1044075759 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/MongoDynamicTableSink.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to

[jira] [Updated] (FLINK-30333) Supports lookup a partial-update table

[ https://issues.apache.org/jira/browse/FLINK-30333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-30333: - Description: The lookup uses streaming read for reading table. (In TableStreamingReader) - We

[jira] [Updated] (FLINK-30333) Supports lookup a partial-update table

[ https://issues.apache.org/jira/browse/FLINK-30333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30333: --- Labels: pull-request-available (was: ) > Supports lookup a partial-update table >

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #430: [FLINK-30333] Supports lookup a partial-update table

JingsongLi opened a new pull request, #430: URL: https://github.com/apache/flink-table-store/pull/430 The lookup uses streaming read for reading table. (In TableStreamingReader) - We should support lookup a partial-update table with full compaction. - But partial-update table without

[jira] [Assigned] (FLINK-30333) Supports lookup a partial-update table

[ https://issues.apache.org/jira/browse/FLINK-30333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-30333: Assignee: Jingsong Lee > Supports lookup a partial-update table >

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1044071447 ## flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/table/MongoDynamicTableSourceITCase.java: ## @@ -0,0 +1,370 @@ +/* + *

[jira] [Updated] (FLINK-30348) Refine Transformer for RandomSplitter

[ https://issues.apache.org/jira/browse/FLINK-30348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30348: --- Labels: pull-request-available (was: ) > Refine Transformer for RandomSplitter >

[GitHub] [flink-ml] weibozhao opened a new pull request, #189: [FLINK-30348] Refine Transformer for RandomSplitter

weibozhao opened a new pull request, #189: URL: https://github.com/apache/flink-ml/pull/189 ## This pull request refines Transformer for RandomSplitter ## Brief change log - *Adds API setSeed() for RandomSplitter Transformer in Java and Python* - *Adds ut for this new API.

[GitHub] [flink] flinkbot commented on pull request #21470: [FLINK-30346] change the code comment

flinkbot commented on PR #21470: URL: https://github.com/apache/flink/pull/21470#issuecomment-1343813782 ## CI report: * 620cb97ce3fa5b6e86a648a07679f7d772a5cf55 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30346) wrong code comment in class Trigger

[ https://issues.apache.org/jira/browse/FLINK-30346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30346: --- Labels: pull-request-available (was: ) > wrong code comment in class Trigger >

[GitHub] [flink] ruanliang-hualun opened a new pull request, #21470: [FLINK-30346] change the code comment

ruanliang-hualun opened a new pull request, #21470: URL: https://github.com/apache/flink/pull/21470 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid

[GitHub] [flink] flinkbot commented on pull request #21469: [FLINK-29925] fix: improve configuration tables' column widths

flinkbot commented on PR #21469: URL: https://github.com/apache/flink/pull/21469#issuecomment-1343809995 ## CI report: * b0811353a34dd37a30505f9b6ddbc318206f67ed UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30334) SourceCoordinator error splitRequest check cause HybridSource loss of data and hang

[ https://issues.apache.org/jira/browse/FLINK-30334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645062#comment-17645062 ] Zhu Zhu commented on FLINK-30334: - Thanks for reporting this issue! [~lemonjing] It is unexpected that

[jira] [Updated] (FLINK-29925) table ui of configure value is strange

[ https://issues.apache.org/jira/browse/FLINK-29925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29925: --- Labels: pull-request-available (was: ) > table ui of configure value is strange >

[GitHub] [flink] yangjunhan opened a new pull request, #21469: [FLINK-29925] fix: improve configuration tables' column widths

yangjunhan opened a new pull request, #21469: URL: https://github.com/apache/flink/pull/21469 ## What is the purpose of the change FLINK-29925 ## Brief change log Fix job configuration table ui ## Verifying this change This change is a

[jira] [Assigned] (FLINK-30250) The flame graph type is wrong

[ https://issues.apache.org/jira/browse/FLINK-30250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-30250: Assignee: Rui Fan > The flame graph type is wrong > - > >

[jira] [Assigned] (FLINK-29925) table ui of configure value is strange

[ https://issues.apache.org/jira/browse/FLINK-29925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-29925: Assignee: Junhan Yang > table ui of configure value is strange >

[jira] [Created] (FLINK-30348) Refine Transformer for RandomSplitter

weibo zhao created FLINK-30348: -- Summary: Refine Transformer for RandomSplitter Key: FLINK-30348 URL: https://issues.apache.org/jira/browse/FLINK-30348 Project: Flink Issue Type: Improvement

[jira] [Closed] (FLINK-30347) Connecting SqlGateway via beeline gets java.lang.UnsupportedOperationException:: Unrecognized TGetInfoType value: CLI_ODBC_KEYWORDS

[ https://issues.apache.org/jira/browse/FLINK-30347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-30347. Resolution: Fixed Similar issue as FLINK-29839 > Connecting SqlGateway via beeline gets >

[jira] [Created] (FLINK-30347) Connecting SqlGateway via beeline gets java.lang.UnsupportedOperationException:: Unrecognized TGetInfoType value: CLI_ODBC_KEYWORDS

Yao Zhang created FLINK-30347: - Summary: Connecting SqlGateway via beeline gets java.lang.UnsupportedOperationException:: Unrecognized TGetInfoType value: CLI_ODBC_KEYWORDS Key: FLINK-30347 URL:

[GitHub] [flink] liyubin117 commented on a diff in pull request #21182: [FLINK-29679][table] Migrate to new schema framework & show column comment

liyubin117 commented on code in PR #21182: URL: https://github.com/apache/flink/pull/21182#discussion_r1044052680 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java: ## @@ -346,6 +346,41 @@ public Schema toSchema() { return

[GitHub] [flink] liyubin117 commented on a diff in pull request #21182: [FLINK-29679][table] Migrate to new schema framework & show column comment

liyubin117 commented on code in PR #21182: URL: https://github.com/apache/flink/pull/21182#discussion_r1044056409 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/typeutils/TimeIndicatorTypeInfo.java: ## @@ -62,13 +61,10 @@ protected

[jira] [Commented] (FLINK-28177) Elasticsearch6DynamicSinkITCase.testWritingDocumentsNoPrimaryKey failed with 503 Service Unavailable

[ https://issues.apache.org/jira/browse/FLINK-28177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645059#comment-17645059 ] KurtDing commented on FLINK-28177: -- [~mapohl]  Would you like to  look at this PR ?

[GitHub] [flink] liyubin117 commented on a diff in pull request #21182: [FLINK-29679][table] Migrate to new schema framework & show column comment

liyubin117 commented on code in PR #21182: URL: https://github.com/apache/flink/pull/21182#discussion_r1044052680 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java: ## @@ -346,6 +346,41 @@ public Schema toSchema() { return

[GitHub] [flink] xintongsong commented on a diff in pull request #21419: [FLINK-30233] Hybrid full result partition should also work with speculative execution

xintongsong commented on code in PR #21419: URL: https://github.com/apache/flink/pull/21419#discussion_r1043991638 ## flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java: ## @@ -605,6 +605,17 @@ public enum SchedulerType {

[GitHub] [flink] fsk119 commented on a diff in pull request #21141: [FLINK-29742][sql-gateway] Support completing statement in SqlGatewayService.

fsk119 commented on code in PR #21141: URL: https://github.com/apache/flink/pull/21141#discussion_r1044047364 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceITCase.java: ## @@ -554,6 +554,55 @@ public void

[GitHub] [flink] liyubin117 commented on pull request #21182: [FLINK-29679][table] Migrate to new schema framework & show column comment

liyubin117 commented on PR #21182: URL: https://github.com/apache/flink/pull/21182#issuecomment-1343775931 @godfreyhe Thanks for your excelent review! I have refactored toSchema() as you figured. Question: `can we improve the conversion logic of ResolvedSchema to TableSchema ?`

[GitHub] [flink] chucheng92 commented on pull request #21464: [FLINK-30334][runtime] Reset SourceCoordinator#handleRequestSplitEvent check logic because hasNoMoreSplits check not consider the hybridso

chucheng92 commented on PR #21464: URL: https://github.com/apache/flink/pull/21464#issuecomment-1343769087 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] liyubin117 commented on a diff in pull request #21182: [FLINK-29679][table] Migrate to new schema framework & show column comment

liyubin117 commented on code in PR #21182: URL: https://github.com/apache/flink/pull/21182#discussion_r1044035987 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java: ## @@ -1600,23 +1619,34 @@ private Object[][]

[GitHub] [flink] liyubin117 commented on a diff in pull request #21182: [FLINK-29679][table] Migrate to new schema framework & show column comment

liyubin117 commented on code in PR #21182: URL: https://github.com/apache/flink/pull/21182#discussion_r1044033884 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableFactory.java: ## @@ -49,7 +47,6 @@ public List

[GitHub] [flink] liyubin117 commented on a diff in pull request #21182: [FLINK-29679][table] Migrate to new schema framework & show column comment

liyubin117 commented on code in PR #21182: URL: https://github.com/apache/flink/pull/21182#discussion_r1044033884 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableFactory.java: ## @@ -49,7 +47,6 @@ public List

[jira] [Commented] (FLINK-30326) SQL Client should not create table directory structure

[ https://issues.apache.org/jira/browse/FLINK-30326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645056#comment-17645056 ] Jingsong Lee commented on FLINK-30326: -- Thanks [~Ge]for reporting. I think it is the

[jira] [Created] (FLINK-30346) wrong code comment in class Trigger

ruanliang created FLINK-30346: - Summary: wrong code comment in class Trigger Key: FLINK-30346 URL: https://issues.apache.org/jira/browse/FLINK-30346 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-30209) Introduce CompactFileStoreSource for compact jobs of Table Store

[ https://issues.apache.org/jira/browse/FLINK-30209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30209: --- Labels: pull-request-available (was: ) > Introduce CompactFileStoreSource for compact jobs

[GitHub] [flink-table-store] tsreaper opened a new pull request, #429: [FLINK-30209] Introduce StaticCompactorSource and ContinuousCompactorSource for stand-alone compact jobs

tsreaper opened a new pull request, #429: URL: https://github.com/apache/flink-table-store/pull/429 In this ticket we create the CompactFileStoreSource Flink source for separated compact jobs. The behavior of this source is sketched as follows: * For batch compact jobs, this

[GitHub] [flink] wanglijie95 commented on a diff in pull request #21388: [FLINK-30188][coordination] Set partition finished state in ConsumedPartitionGroup for dynamic graph correctly.

wanglijie95 commented on code in PR #21388: URL: https://github.com/apache/flink/pull/21388#discussion_r1044005122 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/EdgeManagerBuildUtil.java: ## @@ -197,10 +202,22 @@ private static ConsumedPartitionGroup

[jira] [Commented] (FLINK-30250) The flame graph type is wrong

[ https://issues.apache.org/jira/browse/FLINK-30250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645055#comment-17645055 ] Junhan Yang commented on FLINK-30250: - [~fanrui] I left some comments in the PR :) > The flame

[jira] [Commented] (FLINK-29925) table ui of configure value is strange

[ https://issues.apache.org/jira/browse/FLINK-29925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645054#comment-17645054 ] Junhan Yang commented on FLINK-29925: - No worries, I will take care of this UI problem :) > table

[GitHub] [flink] yangjunhan commented on a diff in pull request #21432: [FLINK-30250][web][flame-graph] Fix the bug that show the flame graph of old type

yangjunhan commented on code in PR #21432: URL: https://github.com/apache/flink/pull/21432#discussion_r1044001784 ## flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.ts: ## @@ -55,7 +55,7 @@ export class

[GitHub] [flink] luoyuxia commented on pull request #21316: [FLINK-30019] Remove the unused HiveTableFileInputFormat in hive conn…

luoyuxia commented on PR #21316: URL: https://github.com/apache/flink/pull/21316#issuecomment-1343748060 @Aitozi Could you please rebase the master, and then I'll find a committer help merge. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] flinkbot commented on pull request #21468: [FLINK-30345][state/changelog] Avoid using sync DataOutputViewStreamWrapper to serialize records to changelog

flinkbot commented on PR #21468: URL: https://github.com/apache/flink/pull/21468#issuecomment-1343746095 ## CI report: * 5a1781b239e8211e8e5a451aa71fe1eab67d2bd3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] masteryhx commented on pull request #21468: [FLINK-30345][state/changelog] Avoid using sync DataOutputViewStreamWrapper to serialize records to changelog

masteryhx commented on PR #21468: URL: https://github.com/apache/flink/pull/21468#issuecomment-1343745102 @rkhachatryan WDYT? Could you help to take a review ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-30345) Improve the serializer performace of state change of changelog

[ https://issues.apache.org/jira/browse/FLINK-30345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30345: --- Labels: pull-request-available (was: ) > Improve the serializer performace of state change

[GitHub] [flink] masteryhx opened a new pull request, #21468: [FLINK-30345][state/changelog] Avoid using sync DataOutputViewStreamWrapper to serialize records to changelog

masteryhx opened a new pull request, #21468: URL: https://github.com/apache/flink/pull/21468 ## What is the purpose of the change Currently, AbstractStateChangeLogger use sync DataOutputViewStreamWrapper to serialize state change which is unnecessary because it

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #183: [FLINK-29603] Add Transformer for StopWordsRemover

lindong28 commented on code in PR #183: URL: https://github.com/apache/flink-ml/pull/183#discussion_r1043969902 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/stopwordsremover/StopWordsRemoverBase.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (FLINK-30345) Improve the serializer performace of state change of changelog

Hangxiang Yu created FLINK-30345: Summary: Improve the serializer performace of state change of changelog Key: FLINK-30345 URL: https://issues.apache.org/jira/browse/FLINK-30345 Project: Flink

[jira] [Commented] (FLINK-30328) TaskManagerWideRocksDbMemorySharingITCase.testBlockCache failed

[ https://issues.apache.org/jira/browse/FLINK-30328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645031#comment-17645031 ] Roman Khachatryan commented on FLINK-30328: --- The failure is most likely unrelated and I can

[jira] [Assigned] (FLINK-30328) TaskManagerWideRocksDbMemorySharingITCase.testBlockCache failed

[ https://issues.apache.org/jira/browse/FLINK-30328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan reassigned FLINK-30328: - Assignee: Roman Khachatryan >

[jira] [Updated] (FLINK-30301) TaskExecutorTest.testSharedResourcesLifecycle failed with TaskException

[ https://issues.apache.org/jira/browse/FLINK-30301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30301: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] flinkbot commented on pull request #21467: [FLINK-30301][tests] Increase heartbeat timeout in TaskExecutorTest to prevent unrelated failures

flinkbot commented on PR #21467: URL: https://github.com/apache/flink/pull/21467#issuecomment-1343515195 ## CI report: * 3feba713bfeffb89cdfd618abe0c0d3006b60a1e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30301) TaskExecutorTest.testSharedResourcesLifecycle failed with TaskException

[ https://issues.apache.org/jira/browse/FLINK-30301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645029#comment-17645029 ] Roman Khachatryan commented on FLINK-30301: --- Sorry for introducing the instability and thanks

[jira] [Closed] (FLINK-27852) Contribute k8s operator to OperatorHub

[ https://issues.apache.org/jira/browse/FLINK-27852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi closed FLINK-27852. - Fix Version/s: kubernetes-operator-1.3.0 Resolution: Fixed fixed via:

[jira] [Closed] (FLINK-29536) Add WATCH_NAMESPACES env var to kubernetes operator

[ https://issues.apache.org/jira/browse/FLINK-29536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi closed FLINK-29536. - Fix Version/s: kubernetes-operator-1.3.0 Resolution: Fixed fixed via:

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata

rkhachatryan commented on code in PR #21405: URL: https://github.com/apache/flink/pull/21405#discussion_r1043827297 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/StateChange.java: ## @@ -26,14 +26,21 @@ @Internal public class StateChange implements

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21368: [FLINK-30165][runtime][JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

rkhachatryan commented on code in PR #21368: URL: https://github.com/apache/flink/pull/21368#discussion_r1043759772 ## flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateChunkReaderTest.java: ## @@ -34,61 +34,66 @@ import java.util.List;

[GitHub] [flink] snuyanzin commented on pull request #17830: [FLINK-24893][Table SQL/Client][FLIP-189] SQL Client prompts customization

snuyanzin commented on PR #17830: URL: https://github.com/apache/flink/pull/17830#issuecomment-1343132721 @fsk119 this is a friendly reminder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] snuyanzin commented on pull request #21459: [hotfix] Replace deprecated Calcite's APIs

snuyanzin commented on PR #21459: URL: https://github.com/apache/flink/pull/21459#issuecomment-1343100225 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] XComp commented on pull request #21368: [FLINK-30165][runtime][JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

XComp commented on PR #21368: URL: https://github.com/apache/flink/pull/21368#issuecomment-1343091444 Why another review. I was just waiting with merging because I wanted to give @rkhachatryan the opportunity to verify that we didn't miss something. Merging the PR is on my list of things

[GitHub] [flink] snuyanzin commented on pull request #19637: [FLINK-25567][table] Add support casting of multisets to multisets

snuyanzin commented on PR #19637: URL: https://github.com/apache/flink/pull/19637#issuecomment-1343067192 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #479: [docs] Update Known issues for v1.3

mbalassi merged PR #479: URL: https://github.com/apache/flink-kubernetes-operator/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #480: [docs] Update Known issues for v1.3

mbalassi merged PR #480: URL: https://github.com/apache/flink-kubernetes-operator/pull/480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-mongodb] twalthr commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

twalthr commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1043369287 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/MongoDynamicTableSource.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the

[jira] (FLINK-30338) Clean leader election legacy code

[ https://issues.apache.org/jira/browse/FLINK-30338 ] Matthias Pohl deleted comment on FLINK-30338: --- was (Author: mapohl): WIP ||ZooKeeperLeaderElectionTest||ZooKeeperMultipleComponentLeaderElectionDriverTest||

[jira] [Updated] (FLINK-30342) Migrate ZooKeeperLeaderElectionTest

[ https://issues.apache.org/jira/browse/FLINK-30342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30342: -- Description:

[jira] [Created] (FLINK-30344) Migrate KubernetesHighAvailabilityTestBase and implementing test classes

Matthias Pohl created FLINK-30344: - Summary: Migrate KubernetesHighAvailabilityTestBase and implementing test classes Key: FLINK-30344 URL: https://issues.apache.org/jira/browse/FLINK-30344 Project:

[jira] [Created] (FLINK-30343) Migrate KubernetesLeaderElectionAndRetrievalITCase

Matthias Pohl created FLINK-30343: - Summary: Migrate KubernetesLeaderElectionAndRetrievalITCase Key: FLINK-30343 URL: https://issues.apache.org/jira/browse/FLINK-30343 Project: Flink Issue

[jira] [Created] (FLINK-30342) Migrate ZooKeeperLeaderElectionTest

Matthias Pohl created FLINK-30342: - Summary: Migrate ZooKeeperLeaderElectionTest Key: FLINK-30342 URL: https://issues.apache.org/jira/browse/FLINK-30342 Project: Flink Issue Type: Sub-task

[jira] [Comment Edited] (FLINK-30338) Clean leader election legacy code

[ https://issues.apache.org/jira/browse/FLINK-30338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17644811#comment-17644811 ] Matthias Pohl edited comment on FLINK-30338 at 12/8/22 3:47 PM: WIP

[GitHub] [flink] gaborgsomogyi commented on pull request #21128: [FLINK-29710] Bump minimum supported Hadoop version to 2.10.2

gaborgsomogyi commented on PR #21128: URL: https://github.com/apache/flink/pull/21128#issuecomment-1342922281 BTW, nice catch related the directory diff  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] gaborgsomogyi commented on pull request #21128: [FLINK-29710] Bump minimum supported Hadoop version to 2.10.2

gaborgsomogyi commented on PR #21128: URL: https://github.com/apache/flink/pull/21128#issuecomment-1342921503 +1 on Hadoop 3.x update if it's not horror complex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1342895879 Hi @snuyanzin, I am on vacation and didn't have access to my laptop. Will address the comments by this weekend. Thanks for waiting :) -- This is an automated

[GitHub] [flink-kubernetes-operator] mbalassi opened a new pull request, #480: [docs] Update Known issues for v1.3

mbalassi opened a new pull request, #480: URL: https://github.com/apache/flink-kubernetes-operator/pull/480 #479 for `release-1.3`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] zentol commented on pull request #21128: [FLINK-29710] Bump minimum supported Hadoop version to 2.10.2

zentol commented on PR #21128: URL: https://github.com/apache/flink/pull/21128#issuecomment-1342889378 Or we setup a system property to control the directory but I'd rely like to avoid that. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink-kubernetes-operator] mbalassi opened a new pull request, #479: [docs] Update Known issues for v1.3

mbalassi opened a new pull request, #479: URL: https://github.com/apache/flink-kubernetes-operator/pull/479 Removes outdated info on standalone mode and articulates FLINK-30306. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

  1   2   3   >