[jira] [Commented] (FLINK-30117) Evaluate operator error log whitelist entries added in FLINK-29475

2022-12-30 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653268#comment-17653268 ] Wencong Liu commented on FLINK-30117: - Thanks [~gaborgsomogyi] . According to the code part, the

[GitHub] [flink] flinkbot commented on pull request #21579: [FLINK-30536][runtime] Invoke CountingOutput and ChainingOutput as listeners

2022-12-30 Thread GitBox
flinkbot commented on PR #21579: URL: https://github.com/apache/flink/pull/21579#issuecomment-1368144511 ## CI report: * 46d9a1842ebe7f2187250e79a3db9bd5bdd24f66 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30536) Invoke CountingOutput and ChainingOutput as listeners

2022-12-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30536: --- Labels: pull-request-available (was: ) > Invoke CountingOutput and ChainingOutput as

[GitHub] [flink] lindong28 opened a new pull request, #21579: [FLINK-30536][runtime] Invoke CountingOutput and ChainingOutput as listeners

2022-12-30 Thread GitBox
lindong28 opened a new pull request, #21579: URL: https://github.com/apache/flink/pull/21579 ## What is the purpose of the change Improve Flink performance by reducing the average depth of the call stack needed to produce a record. ## Brief change log - Added interface

[GitHub] [flink-kubernetes-operator] nowke commented on pull request #487: [FLINK-30411] Validate empty JmSpec and TmSpec

2022-12-30 Thread GitBox
nowke commented on PR #487: URL: https://github.com/apache/flink-kubernetes-operator/pull/487#issuecomment-1368142154 > I am still a bit torn on this PR. This adds quite a lot of complexity to the validation with some risks involved. Maybe we should just leave it as it is? Agreed on

[GitHub] [flink-kubernetes-operator] nowke commented on a diff in pull request #487: [FLINK-30411] Validate empty JmSpec and TmSpec

2022-12-30 Thread GitBox
nowke commented on code in PR #487: URL: https://github.com/apache/flink-kubernetes-operator/pull/487#discussion_r1059562798 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/validation/DefaultValidatorTest.java: ## @@ -248,13 +252,40 @@ public

[jira] [Updated] (FLINK-30488) OpenSearch implementation of Async Sink

2022-12-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30488: --- Labels: pull-request-available (was: ) > OpenSearch implementation of Async Sink >

[GitHub] [flink-connector-opensearch] reta opened a new pull request, #5: [FLINK-30488] OpenSearch implementation of Async Sink

2022-12-30 Thread GitBox
reta opened a new pull request, #5: URL: https://github.com/apache/flink-connector-opensearch/pull/5 OpenSearch implementation of Async Sink (https://cwiki.apache.org/confluence/display/FLINK/FLIP-171%3A+Async+Sink), a few TODO items: - [ ] More test cases - [ ] More sensitive

[jira] [Commented] (FLINK-30530) Flink configuration from user-provided ConfigMap

2022-12-30 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653167#comment-17653167 ] Gyula Fora commented on FLINK-30530: At the end of the day you would still need to create separate

[jira] [Comment Edited] (FLINK-30530) Flink configuration from user-provided ConfigMap

2022-12-30 Thread Arseniy Tashoyan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653159#comment-17653159 ] Arseniy Tashoyan edited comment on FLINK-30530 at 12/30/22 4:43 PM:

[jira] [Commented] (FLINK-30530) Flink configuration from user-provided ConfigMap

2022-12-30 Thread Arseniy Tashoyan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653159#comment-17653159 ] Arseniy Tashoyan commented on FLINK-30530: -- Hi [~gyfora]  The YAML descriptor contains

[jira] [Commented] (FLINK-27246) Code of method "processElement(Lorg/apache/flink/streaming/runtime/streamrecord/StreamRecord;)V" of class "HashAggregateWithKeys$9211" grows beyond 64 KB

2022-12-30 Thread Krzysztof Chmielewski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653156#comment-17653156 ] Krzysztof Chmielewski commented on FLINK-27246: --- Hi [~TsReaper] I have modified my PR. I

[jira] [Commented] (FLINK-30117) Evaluate operator error log whitelist entries added in FLINK-29475

2022-12-30 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653151#comment-17653151 ] Gabor Somogyi commented on FLINK-30117: --- [~Wencong Liu] Please have a look at the following code

[GitHub] [flink] fsk119 commented on pull request #21571: [FLINK-22317][table] Support DROP column/constraint/watermark for ALTER TABLE statement

2022-12-30 Thread GitBox
fsk119 commented on PR #21571: URL: https://github.com/apache/flink/pull/21571#issuecomment-1367973121 Thanks for the update! I add a commit to improve some codes. Please take a look at the last commit when you are free. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (FLINK-30492) hive overview document given an Incorrect dependency artifactId example

2022-12-30 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653146#comment-17653146 ] Martijn Visser commented on FLINK-30492: [~luoyuxia] I do think it is needed, because the Hive

[jira] [Created] (FLINK-30536) Invoke CountingOutput and ChainingOutput as listeners

2022-12-30 Thread Dong Lin (Jira)
Dong Lin created FLINK-30536: Summary: Invoke CountingOutput and ChainingOutput as listeners Key: FLINK-30536 URL: https://issues.apache.org/jira/browse/FLINK-30536 Project: Flink Issue Type:

[jira] [Commented] (FLINK-30530) Flink configuration from user-provided ConfigMap

2022-12-30 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653133#comment-17653133 ] Gyula Fora commented on FLINK-30530: The YAML descriptor too is very application specific so I don't

[jira] [Commented] (FLINK-30530) Flink configuration from user-provided ConfigMap

2022-12-30 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653132#comment-17653132 ] Gyula Fora commented on FLINK-30530: Because flink and log config is probably different for every

[jira] [Updated] (FLINK-30530) Flink configuration from user-provided ConfigMap

2022-12-30 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30530: --- Affects Version/s: (was: 1.15.2) > Flink configuration from user-provided ConfigMap >

[GitHub] [flink] LadyForest commented on a diff in pull request #21577: [FLINK-30496][table-api] Introduce TableChange to represent MODIFY change

2022-12-30 Thread GitBox
LadyForest commented on code in PR #21577: URL: https://github.com/apache/flink/pull/21577#discussion_r1059352101 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/TableChange.java: ## @@ -94,6 +96,137 @@ static AddWatermark add(WatermarkSpec

[GitHub] [flink] kristoffSC commented on pull request #21393: [Draft][FLINK-27246_master] - Split generated java methods - Work in progress

2022-12-30 Thread GitBox
kristoffSC commented on PR #21393: URL: https://github.com/apache/flink/pull/21393#issuecomment-1367883271 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (FLINK-29607) Simplify controller flow by introducing FlinkControllerContext

2022-12-30 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-29607: -- Assignee: Gyula Fora > Simplify controller flow by introducing FlinkControllerContext >

[GitHub] [flink] LadyForest commented on a diff in pull request #21571: [FLINK-22317][table] Support DROP column/constraint/watermark for ALTER TABLE statement

2022-12-30 Thread GitBox
LadyForest commented on code in PR #21571: URL: https://github.com/apache/flink/pull/21571#discussion_r1059269728 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterTableDropConstraint.java: ## @@ -24,25 +24,29 @@ import

[GitHub] [flink] 1996fanrui commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default

2022-12-30 Thread GitBox
1996fanrui commented on PR #21540: URL: https://github.com/apache/flink/pull/21540#issuecomment-1367867001 Thanks @Myasuka and @yuchen-ecnu 's review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (FLINK-30492) hive overview document given an Incorrect dependency artifactId example

2022-12-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653108#comment-17653108 ] Weijie Guo commented on FLINK-30492: [~luoyuxia] Yes, I only remove the suffix of

[jira] [Comment Edited] (FLINK-30492) hive overview document given an Incorrect dependency artifactId example

2022-12-30 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653102#comment-17653102 ] luoyuxia edited comment on FLINK-30492 at 12/30/22 10:55 AM: - If just for

[jira] [Commented] (FLINK-30492) hive overview document given an Incorrect dependency artifactId example

2022-12-30 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653102#comment-17653102 ] luoyuxia commented on FLINK-30492: -- If just for `flink-table-api-java-bridge`, we don't need the scala

[jira] [Comment Edited] (FLINK-30492) hive overview document given an Incorrect dependency artifactId example

2022-12-30 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653092#comment-17653092 ] Martijn Visser edited comment on FLINK-30492 at 12/30/22 10:08 AM: ---

[jira] [Commented] (FLINK-30492) hive overview document given an Incorrect dependency artifactId example

2022-12-30 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653092#comment-17653092 ] Martijn Visser commented on FLINK-30492: [~Weijie Guo] See

[jira] [Comment Edited] (FLINK-30492) hive overview document given an Incorrect dependency artifactId example

2022-12-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653081#comment-17653081 ] Weijie Guo edited comment on FLINK-30492 at 12/30/22 9:36 AM: --

[GitHub] [flink-ml] yunfengzhou-hub commented on a diff in pull request #193: [FLINK-30515] Add benchmark for CountVectorizer, Imputer, RobustScale…

2022-12-30 Thread GitBox
yunfengzhou-hub commented on code in PR #193: URL: https://github.com/apache/flink-ml/pull/193#discussion_r105931 ## flink-ml-benchmark/src/test/java/org/apache/flink/ml/benchmark/BenchmarkTest.java: ## @@ -54,6 +56,33 @@ public void testParseJsonFile() throws Exception {

[jira] [Comment Edited] (FLINK-30492) hive overview document given an Incorrect dependency artifactId example

2022-12-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653081#comment-17653081 ] Weijie Guo edited comment on FLINK-30492 at 12/30/22 9:31 AM: --

[jira] [Commented] (FLINK-30492) hive overview document given an Incorrect dependency artifactId example

2022-12-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653081#comment-17653081 ] Weijie Guo commented on FLINK-30492: [~martijnvisser] Thanks for the feedback, but I may have some

[GitHub] [flink] reswqa commented on pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.

2022-12-30 Thread GitBox
reswqa commented on PR #21553: URL: https://github.com/apache/flink/pull/21553#issuecomment-1367810973 @MartijnVisser If I haven't misunderstood your meaning, you mean that the scala version is still needed as a suffix for the hi connector dependency, but I only modified the artifactId of

[jira] [Closed] (FLINK-30492) hive overview document given an Incorrect dependency artifactId example

2022-12-30 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30492. -- Resolution: Invalid The Hive connector is still tied to the Flink Planner, which requires you

[GitHub] [flink] MartijnVisser closed pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.

2022-12-30 Thread GitBox
MartijnVisser closed pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview. URL: https://github.com/apache/flink/pull/21553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-30087) sql-gateway-api is bundled twice in the distribution

2022-12-30 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653074#comment-17653074 ] Wencong Liu commented on FLINK-30087: - Hello [~chesnay] , it the module flink-table-uber named

[jira] [Commented] (FLINK-30117) Evaluate operator error log whitelist entries added in FLINK-29475

2022-12-30 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653069#comment-17653069 ] Wencong Liu commented on FLINK-30117: - Hello [~gaborgsomogyi] , I'm quite interested in this issue,

[jira] [Assigned] (FLINK-30496) Introduce TableChange to represent MODIFY change

2022-12-30 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-30496: - Assignee: Shengkai Fang > Introduce TableChange to represent MODIFY change >

[jira] [Closed] (FLINK-30495) Introduce TableChange to represent ADD change

2022-12-30 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-30495. - Fix Version/s: 1.17.0 Resolution: Implemented Merged into master:

[GitHub] [flink] fsk119 closed pull request #21566: [FLINK-30495][table-api] Introduce TableChange to represent ADD change

2022-12-30 Thread GitBox
fsk119 closed pull request #21566: [FLINK-30495][table-api] Introduce TableChange to represent ADD change URL: https://github.com/apache/flink/pull/21566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] yuchen-ecnu commented on pull request #21498: [FLINK-30392] Replace default thread dump depth to 50

2022-12-30 Thread GitBox
yuchen-ecnu commented on PR #21498: URL: https://github.com/apache/flink/pull/21498#issuecomment-1367782568 Hi @Myasuka @1996fanrui , Thanks for the discussion. As discussed above, I've set the default depth value of the thread dump to 50 and updated the related commit

[GitHub] [flink] flinkbot commented on pull request #21578: [bp-1.16][FLINK-28988] Don't push filters down into the right table for temporal join

2022-12-30 Thread GitBox
flinkbot commented on PR #21578: URL: https://github.com/apache/flink/pull/21578#issuecomment-1367782296 ## CI report: * c14355243995bff7b03a527ed073a2bbaab70ce8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Myasuka commented on pull request #21406: [FLINK-30088][runtime] Fix excessive state updates for TtlMapState and TtlListState

2022-12-30 Thread GitBox
Myasuka commented on PR #21406: URL: https://github.com/apache/flink/pull/21406#issuecomment-1367780705 @rovboyko I created ticket FLINK-30535 to focus on the TTL state benchmarks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (FLINK-30535) Introduce TTL state based benchmarks

2022-12-30 Thread Yun Tang (Jira)
Yun Tang created FLINK-30535: Summary: Introduce TTL state based benchmarks Key: FLINK-30535 URL: https://issues.apache.org/jira/browse/FLINK-30535 Project: Flink Issue Type: New Feature

[GitHub] [flink] lincoln-lil opened a new pull request, #21578: [bp-1.16][FLINK-28988] Don't push filters down into the right table for temporal join

2022-12-30 Thread GitBox
lincoln-lil opened a new pull request, #21578: URL: https://github.com/apache/flink/pull/21578 this is a backport pr for FLINK-28988 to release-1.16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go