[jira] [Commented] (FLINK-31095) FileSink doesn't work with s3a on EKS

2023-02-15 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689593#comment-17689593 ] Martijn Visser commented on FLINK-31095: That error is not related to EKS, but you're trying to

[GitHub] [flink-connector-pulsar] syhily commented on pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#issuecomment-1432660315 @reswqa All the review issues have been fixed. Can you check it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] wanglijie95 merged pull request #19824: [FLINK-27800][streaming] Fix the error check in StreamNode#addInEdge

2023-02-15 Thread via GitHub
wanglijie95 merged PR #19824: URL: https://github.com/apache/flink/pull/19824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] gaoyunhaii commented on pull request #19798: [FLINK-27299][Runtime/Configuration] flink parsing parameter bug fixed.

2023-02-15 Thread via GitHub
gaoyunhaii commented on PR #19798: URL: https://github.com/apache/flink/pull/19798#issuecomment-1432658405 Hi @wolfboys , sorry that based on the above point we have to postpone merging this PR. Logically we could postpone it till a main version bump, like Flink 2.0. We also have some

[jira] [Commented] (FLINK-31036) StateCheckpointedITCase timed out due to deadlock

2023-02-15 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689591#comment-17689591 ] Rui Fan commented on FLINK-31036: - Hi, [~pnowojski] , do you have time help take a look this JIRA? I

[jira] [Commented] (FLINK-30238) Unified Sink committer does not clean up state on final savepoint

2023-02-15 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689588#comment-17689588 ] Yun Gao commented on FLINK-30238: - Hi [~pnowojski] , for this specific issue, based on my understanding, 

[GitHub] [flink] XComp merged pull request #21946: [hotfix] [doc] Fix typo in zh/docs/dev/datastream/overview.md

2023-02-15 Thread via GitHub
XComp merged PR #21946: URL: https://github.com/apache/flink/pull/21946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] XComp commented on pull request #21946: [hotfix] [doc] Fix typo in zh/docs/dev/datastream/overview.md

2023-02-15 Thread via GitHub
XComp commented on PR #21946: URL: https://github.com/apache/flink/pull/21946#issuecomment-1432651596 No worries, @xuzhiwen1255. Again, you might want to read through the contributions documentation (see the [Apache Flink

[GitHub] [flink-ml] vacaly commented on a diff in pull request #192: [FLINK-30451] Add AlgoOperator for Swing

2023-02-15 Thread via GitHub
vacaly commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1108109143 ## flink-ml-lib/src/test/java/org/apache/flink/ml/recommendation/SwingTest.java: ## @@ -0,0 +1,278 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Assigned] (FLINK-31084) DataGen sequence generator requires the definition of start/end values

2023-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-31084: - Assignee: xzw0223 > DataGen sequence generator requires the definition of start/end

[jira] [Comment Edited] (FLINK-31036) StateCheckpointedITCase timed out due to deadlock

2023-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689584#comment-17689584 ] Matthias Pohl edited comment on FLINK-31036 at 2/16/23 7:34 AM: {quote}

[GitHub] [flink] waywtdcc commented on pull request #21159: [FLINK-28985][table]Create table statement supports create table like view

2023-02-15 Thread via GitHub
waywtdcc commented on PR #21159: URL: https://github.com/apache/flink/pull/21159#issuecomment-1432645367 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] waywtdcc commented on pull request #21159: [FLINK-28985][table]Create table statement supports create table like view

2023-02-15 Thread via GitHub
waywtdcc commented on PR #21159: URL: https://github.com/apache/flink/pull/21159#issuecomment-1432645254 @flinkbot run azur -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-31036) StateCheckpointedITCase timed out due to deadlock

2023-02-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689584#comment-17689584 ] Matthias Pohl commented on FLINK-31036: --- > FLINK-26803 added a lock at TM level during task is

[GitHub] [flink] flinkbot commented on pull request #21948: [FLINK-31099][python] Fix chained WindowOperator throws NPE in PyFlink Thread Mode

2023-02-15 Thread via GitHub
flinkbot commented on PR #21948: URL: https://github.com/apache/flink/pull/21948#issuecomment-1432644510 ## CI report: * f6bdfd5b7569cd550b1a043a44e8f86399b5e516 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30989) Configuration table.exec.spill-compression.block-size not take effect in batch job

2023-02-15 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang updated FLINK-30989: --- Component/s: Table SQL / Runtime (was: API / DataStream) > Configuration

[GitHub] [flink-kubernetes-operator] tamirsagi commented on pull request #531: [FLINK-31046][FLINK-31047][Kubernetes-Operator] - Improvement/enhance Flink operator template YAML

2023-02-15 Thread via GitHub
tamirsagi commented on PR #531: URL: https://github.com/apache/flink-kubernetes-operator/pull/531#issuecomment-1432641711 @gyfora Would you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] wanglijie95 commented on pull request #21840: [FLINK-29481] Show jobType in webUI

2023-02-15 Thread via GitHub
wanglijie95 commented on PR #21840: URL: https://github.com/apache/flink/pull/21840#issuecomment-1432641020 Hi @dangshazi, thanks for creating this PR. But I noticed that it will change the response body of REST API

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #536: [FLINK-31028]Provide different compression for per level

2023-02-15 Thread via GitHub
JingsongLi commented on code in PR #536: URL: https://github.com/apache/flink-table-store/pull/536#discussion_r1108099973 ## flink-table-store-common/src/main/java/org/apache/flink/table/store/format/FormatWriterFactory.java: ## @@ -29,8 +29,9 @@ public interface

[jira] [Updated] (FLINK-31099) Chained WindowOperator throws NPE in PyFlink ThreadMode

2023-02-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31099: --- Labels: pull-request-available (was: ) > Chained WindowOperator throws NPE in PyFlink

[GitHub] [flink] HuangXingBo opened a new pull request, #21948: [FLINK-31099][python] Fix chained WindowOperator throws NPE in PyFlink Thread Mode

2023-02-15 Thread via GitHub
HuangXingBo opened a new pull request, #21948: URL: https://github.com/apache/flink/pull/21948 ## What is the purpose of the change *This pull request will fix chained WindowOperator throws NPE in PyFlink Thread Mode* ## Verifying this change This change added tests

[GitHub] [flink-table-store] zhangjun0x01 commented on pull request #536: [FLINK-31028]Provide different compression for per level

2023-02-15 Thread via GitHub
zhangjun0x01 commented on PR #536: URL: https://github.com/apache/flink-table-store/pull/536#issuecomment-1432638935 > Hi @zhangjun0x01 , we can introduce a unified `file.compression.per.level`, so we can get `String compression` in core, and pass compression to format from

[GitHub] [flink-ml] Fanoid commented on pull request #211: [FLINK-31026] Fix KBinsDiscretizer when the input values of one column are same

2023-02-15 Thread via GitHub
Fanoid commented on PR #211: URL: https://github.com/apache/flink-ml/pull/211#issuecomment-1432637635 Hi, @zhipeng93 could you help review this commit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (FLINK-31084) DataGen sequence generator requires the definition of start/end values

2023-02-15 Thread xzw0223 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689580#comment-17689580 ] xzw0223 commented on FLINK-31084: - I think this may be more in line with the optional statement, I think

[jira] [Created] (FLINK-31099) Chained WindowOperator throws NPE in PyFlink ThreadMode

2023-02-15 Thread Huang Xingbo (Jira)
Huang Xingbo created FLINK-31099: Summary: Chained WindowOperator throws NPE in PyFlink ThreadMode Key: FLINK-31099 URL: https://issues.apache.org/jira/browse/FLINK-31099 Project: Flink

[GitHub] [flink] reswqa commented on a diff in pull request #21943: [FLINK-31077][runtime] Mark pending checkpoint onCompletionPromise complete only after the completed checkpoint is added to the stor

2023-02-15 Thread via GitHub
reswqa commented on code in PR #21943: URL: https://github.com/apache/flink/pull/21943#discussion_r1108050732 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/exceptionhistory/ExceptionHistoryEntryTestingUtils.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108081850 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/handler/PulsarAdminInvocationHandler.java: ## @@ -0,0 +1,152 @@ +/* + *

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108076299 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java: ## @@ -210,6 +210,10 @@ public

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108075205 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/handler/PulsarAdminInvocationHandler.java: ## @@ -0,0 +1,152 @@ +/* + *

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108074830 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/handler/PulsarAdminInvocationHandler.java: ## @@ -0,0 +1,152 @@ +/* + *

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108073067 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/handler/PulsarAdminInvocationHandler.java: ## @@ -0,0 +1,152 @@ +/* + *

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108071129 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/handler/PulsarAdminInvocationHandler.java: ## @@ -0,0 +1,129 @@ +/* + *

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108071391 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/handler/PulsarAdminInvocationHandler.java: ## @@ -0,0 +1,152 @@ +/* + *

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108071129 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/handler/PulsarAdminInvocationHandler.java: ## @@ -0,0 +1,129 @@ +/* + *

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108070573 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/handler/PulsarAdminInvocationHandler.java: ## @@ -0,0 +1,152 @@ +/* + *

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108066608 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/subscriber/impl/TopicPatternSubscriber.java: ## @@ -52,11 +62,80

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108066146 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/handler/PulsarAdminInvocationHandler.java: ## @@ -0,0 +1,129 @@ +/* + *

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108061722 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/handler/PulsarAdminInvocationHandler.java: ## @@ -0,0 +1,129 @@ +/* + *

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108059276 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java: ## @@ -210,6 +210,10 @@ public

[jira] [Assigned] (FLINK-31009) Add recordCount to snapshot meta

2023-02-15 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-31009: Assignee: Nicholas Jiang > Add recordCount to snapshot meta >

[GitHub] [flink] reswqa commented on a diff in pull request #21943: [FLINK-31077][runtime] Mark pending checkpoint onCompletionPromise complete only after the completed checkpoint is added to the stor

2023-02-15 Thread via GitHub
reswqa commented on code in PR #21943: URL: https://github.com/apache/flink/pull/21943#discussion_r1107488313 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java: ## @@ -1373,6 +1373,7 @@ private void cleanupAfterCompletedCheckpoint(

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108048087 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java: ## @@ -210,6 +210,10 @@ public

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108047720 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/handler/PulsarAdminInvocationHandler.java: ## @@ -0,0 +1,129 @@ +/* + *

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108046387 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/subscriber/impl/TopicPatternSubscriber.java: ## @@ -52,11 +62,80

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108045888 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java: ## @@ -210,6 +210,10 @@ public

[jira] [Commented] (FLINK-18235) Improve the checkpoint strategy for Python UDF execution

2023-02-15 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689545#comment-17689545 ] Dian Fu commented on FLINK-18235: - I agree that the there are no fundamental problems in theory and just

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108044338 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/subscriber/impl/TopicPatternSubscriber.java: ## @@ -52,11 +62,80

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108043250 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java: ## @@ -210,6 +210,10 @@ public

[GitHub] [flink] JunRuiLee commented on pull request #21943: [FLINK-31077][runtime] Mark pending checkpoint onCompletionPromise complete only after the completed checkpoint is added to the store.

2023-02-15 Thread via GitHub
JunRuiLee commented on PR #21943: URL: https://github.com/apache/flink/pull/21943#issuecomment-1432562382 @reswqa Thanks for review and I've addressed all comments. PTAL! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1107991791 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/subscriber/impl/TopicPatternSubscriber.java: ## @@ -52,11 +62,80

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1107991791 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/subscriber/impl/TopicPatternSubscriber.java: ## @@ -52,11 +62,80

[jira] [Commented] (FLINK-31009) Add recordCount to snapshot meta

2023-02-15 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689530#comment-17689530 ] Nicholas Jiang commented on FLINK-31009: [~lzljs3620320], I'm working for this feature. Please

[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
syhily commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108031407 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/handler/PulsarAdminInvocationHandler.java: ## @@ -0,0 +1,129 @@ +/* + *

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108030494 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/topic/TopicPartition.java: ## @@ -96,8 +100,12 @@ public

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1108030494 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/topic/TopicPartition.java: ## @@ -96,8 +100,12 @@ public

[jira] [Closed] (FLINK-31096) Unify versions in pom of table store

2023-02-15 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31096. Fix Version/s: table-store-0.4.0 Assignee: Shammon Resolution: Fixed master:

[jira] [Updated] (FLINK-31096) Unify versions in pom of table store

2023-02-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31096: --- Labels: pull-request-available (was: ) > Unify versions in pom of table store >

[GitHub] [flink-table-store] JingsongLi merged pull request #543: [FLINK-31096] unify versions in pom

2023-02-15 Thread via GitHub
JingsongLi merged PR #543: URL: https://github.com/apache/flink-table-store/pull/543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #21947: [FLINK-31098][table] Add ARRAY_SIZE function.

2023-02-15 Thread via GitHub
flinkbot commented on PR #21947: URL: https://github.com/apache/flink/pull/21947#issuecomment-1432521882 ## CI report: * 5e6e4d1af65e2e94f946a8684e7916e806d4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31098) Add ARRAY_SIZE supported in SQL & Table API

2023-02-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31098: --- Labels: pull-request-available (was: ) > Add ARRAY_SIZE supported in SQL & Table API >

[GitHub] [flink] liuyongvs opened a new pull request, #21947: [FLINK-31098][table] Add ARRAY_SIZE function.

2023-02-15 Thread via GitHub
liuyongvs opened a new pull request, #21947: URL: https://github.com/apache/flink/pull/21947 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink-kubernetes-operator] gauravmiglanid11 commented on pull request #533: [FLINK-30920] [AutoScaler] adds exclude vertex ids for autoscaler to ignore for evaluation and scaling

2023-02-15 Thread via GitHub
gauravmiglanid11 commented on PR #533: URL: https://github.com/apache/flink-kubernetes-operator/pull/533#issuecomment-1432511239 @mxm can you rerun it, https://github.com/apache/flink-kubernetes-operator/actions/runs/4184688801/jobs/7250685066, i have ran command from my local as

[jira] [Assigned] (FLINK-31091) SQL interval related queries stop working via SQL client

2023-02-15 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31091: -- Assignee: Sergey Nuyanzin > SQL interval related queries stop working via SQL client >

[jira] [Updated] (FLINK-31094) Add table name to Writer

2023-02-15 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-31094: - Fix Version/s: table-store-0.3.1 > Add table name to Writer > - > >

[jira] [Closed] (FLINK-31094) Add table name to Writer

2023-02-15 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31094. Resolution: Fixed master: 9edee3afec998c186726bb7d30d486f34d47c461 release-0.3:

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1107965351 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/handler/PulsarAdminInvocationHandler.java: ## @@ -0,0 +1,129 @@ +/* + *

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1107945178 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/config/PulsarAdminBuilder.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] JingsongLi merged pull request #542: [FLINK-31094] Add table name to Writer

2023-02-15 Thread via GitHub
JingsongLi merged PR #542: URL: https://github.com/apache/flink-table-store/pull/542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1107945178 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/config/PulsarAdminBuilder.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #29: [FLINK-28959][Stream] Add retry and rate limit for admin request. Use binary protocol for topic filtering.

2023-02-15 Thread via GitHub
reswqa commented on code in PR #29: URL: https://github.com/apache/flink-connector-pulsar/pull/29#discussion_r1107945178 ## flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/config/PulsarAdminBuilder.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the

[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #192: [FLINK-30451] Add AlgoOperator for Swing

2023-02-15 Thread via GitHub
zhipeng93 commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1107984853 ## docs/content/docs/operators/recommendation/swing.md: ## @@ -0,0 +1,194 @@ +--- +title: "Swing" +type: docs +aliases: +- /operators/recommendation/swing.html +--- +

[jira] [Commented] (FLINK-30936) Release Testing: Verify FLINK-29941 Support SQL Client connects to SQL Gateway

2023-02-15 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689500#comment-17689500 ] luoyuxia commented on FLINK-30936: -- [~fsk119] If you don't mind, I would like to take it.  > Release

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21932: [FLINK-31055][runtime] Fix the bug that dynamic flag of stream graph does not take effect when translating the transformations

2023-02-15 Thread via GitHub
zhuzhurk commented on code in PR #21932: URL: https://github.com/apache/flink/pull/21932#discussion_r1107989004 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java: ## @@ -359,6 +345,17 @@ private boolean

[GitHub] [flink] wanglijie95 commented on a diff in pull request #21932: [FLINK-31055][runtime] Fix the bug that dynamic flag of stream graph does not take effect when translating the transformations

2023-02-15 Thread via GitHub
wanglijie95 commented on code in PR #21932: URL: https://github.com/apache/flink/pull/21932#discussion_r1107982799 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java: ## @@ -316,6 +316,14 @@ public StreamGraph generate() {

[GitHub] [flink] wanglijie95 commented on a diff in pull request #21932: [FLINK-31055][runtime] Fix the bug that dynamic flag of stream graph does not take effect when translating the transformations

2023-02-15 Thread via GitHub
wanglijie95 commented on code in PR #21932: URL: https://github.com/apache/flink/pull/21932#discussion_r1107982799 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java: ## @@ -316,6 +316,14 @@ public StreamGraph generate() {

[jira] [Commented] (FLINK-31065) Support more split assigner strategy for batch job

2023-02-15 Thread yunfan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689497#comment-17689497 ] yunfan commented on FLINK-31065: [~luoyuxia] Yes, hive is the main usage of this strategy. And I don't

[jira] [Created] (FLINK-31098) Add ARRAY_SIZE supported in SQL & Table API

2023-02-15 Thread jackylau (Jira)
jackylau created FLINK-31098: Summary: Add ARRAY_SIZE supported in SQL & Table API Key: FLINK-31098 URL: https://issues.apache.org/jira/browse/FLINK-31098 Project: Flink Issue Type: New Feature

[GitHub] [flink] wanglijie95 commented on a diff in pull request #21932: [FLINK-31055][runtime] Fix the bug that dynamic flag of stream graph does not take effect when translating the transformations

2023-02-15 Thread via GitHub
wanglijie95 commented on code in PR #21932: URL: https://github.com/apache/flink/pull/21932#discussion_r1107982799 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java: ## @@ -316,6 +316,14 @@ public StreamGraph generate() {

[jira] [Assigned] (FLINK-30951) Release Testing: Verify FLINK-29635 Hive sink should support merge files in batch mode

2023-02-15 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-30951: - Assignee: Shengkai Fang > Release Testing: Verify FLINK-29635 Hive sink should support

[GitHub] [flink] swuferhong commented on pull request #21938: [FLINK-31082][table-planner] Setting maven property 'flink.resueForks' to false in table planner module

2023-02-15 Thread via GitHub
swuferhong commented on PR #21938: URL: https://github.com/apache/flink/pull/21938#issuecomment-1432480921 > I would at least move it to `release-1.17` given that we're trying to stabilize that as much as possible. Ok, I will do it. -- This is an automated message from the Apache

[GitHub] [flink] liangguohun commented on pull request #21940: Branch release 1.15.2

2023-02-15 Thread via GitHub
liangguohun commented on PR #21940: URL: https://github.com/apache/flink/pull/21940#issuecomment-1432475588 > the purpose is i just want upload one jar through grpc to push dynamic sql task ,that can get the status like localenvironment -- This is an automated message from the Apache

[jira] [Commented] (FLINK-31095) FileSink doesn't work with s3a on EKS

2023-02-15 Thread Yaroslav Tkachenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689491#comment-17689491 ] Yaroslav Tkachenko commented on FLINK-31095: It works for me (specifically on EKS). Did you

[jira] [Comment Edited] (FLINK-31089) pin L0 index in memory can lead to slow memory grow finally lead to memory beyond limit

2023-02-15 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689482#comment-17689482 ] xiaogang zhou edited comment on FLINK-31089 at 2/16/23 3:39 AM: [~yunta] 

[jira] [Comment Edited] (FLINK-31089) pin L0 index in memory can lead to slow memory grow finally lead to memory beyond limit

2023-02-15 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689482#comment-17689482 ] xiaogang zhou edited comment on FLINK-31089 at 2/16/23 3:29 AM: [~yunta] 

[jira] [Commented] (FLINK-31089) pin L0 index in memory can lead to slow memory grow finally lead to memory beyond limit

2023-02-15 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689482#comment-17689482 ] xiaogang zhou commented on FLINK-31089: --- [~yunta]  Master, Do you aware  : Invalid conf pair:

[jira] [Commented] (FLINK-31020) Read-only mode for Rest API

2023-02-15 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689480#comment-17689480 ] Xintong Song commented on FLINK-31020: -- Speaking of attacks, the biggest concern is usually in

[jira] [Closed] (FLINK-31097) mysql catalog datatype mapping error tinyint mapping boolean

2023-02-15 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 谢波 closed FLINK-31097. -- Resolution: Fixed mysql driver bug > mysql catalog datatype mapping error tinyint mapping boolean >

[GitHub] [flink] reswqa commented on a diff in pull request #21943: [FLINK-31077][runtime] Mark pending checkpoint onCompletionPromise complete only after the completed checkpoint is added to the stor

2023-02-15 Thread via GitHub
reswqa commented on code in PR #21943: URL: https://github.com/apache/flink/pull/21943#discussion_r1107962538 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java: ## @@ -141,27 +140,15 @@ import static

[jira] [Created] (FLINK-31097) mysql catalog datatype mapping error tinyint mapping boolean

2023-02-15 Thread Jira
谢波 created FLINK-31097: -- Summary: mysql catalog datatype mapping error tinyint mapping boolean Key: FLINK-31097 URL: https://issues.apache.org/jira/browse/FLINK-31097 Project: Flink Issue Type: Bug

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21932: [FLINK-31055][runtime] Fix the bug that dynamic flag of stream graph does not take effect when translating the transformations

2023-02-15 Thread via GitHub
zhuzhurk commented on code in PR #21932: URL: https://github.com/apache/flink/pull/21932#discussion_r1107961853 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java: ## @@ -316,6 +316,14 @@ public StreamGraph generate() {

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21932: [FLINK-31055][runtime] Fix the bug that dynamic flag of stream graph does not take effect when translating the transformations

2023-02-15 Thread via GitHub
zhuzhurk commented on code in PR #21932: URL: https://github.com/apache/flink/pull/21932#discussion_r1107960286 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java: ## @@ -316,6 +316,14 @@ public StreamGraph generate() {

[jira] [Commented] (FLINK-31089) pin L0 index in memory can lead to slow memory grow finally lead to memory beyond limit

2023-02-15 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689471#comment-17689471 ] Yun Tang commented on FLINK-31089: -- [~zhoujira86] Maybe you did not get what I mean. I am sure that you

[jira] [Commented] (FLINK-31036) StateCheckpointedITCase timed out due to deadlock

2023-02-15 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689468#comment-17689468 ] Rui Fan commented on FLINK-31036: - {quote}Why would you assume to get more from the logs than what is

[GitHub] [flink-table-store] daixiaoyu commented on a diff in pull request #542: [FLINK-31094] Add table name to Writer

2023-02-15 Thread via GitHub
daixiaoyu commented on code in PR #542: URL: https://github.com/apache/flink-table-store/pull/542#discussion_r1107955391 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/FlinkSink.java: ## @@ -103,7 +103,7 @@ public DataStreamSink

[jira] (FLINK-31020) Read-only mode for Rest API

2023-02-15 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31020 ] Wencong Liu deleted comment on FLINK-31020: - was (Author: JIRAUSER281639): cc [~xtsong]  > Read-only mode for Rest API > --- > > Key: FLINK-31020 >

[GitHub] [flink] xuzhiwen1255 commented on pull request #21946: [hotfix] [doc] Fix typo in zh/docs/dev/datastream/overview.md

2023-02-15 Thread via GitHub
xuzhiwen1255 commented on PR #21946: URL: https://github.com/apache/flink/pull/21946#issuecomment-1432412507 @reswqa Thank you for your review. It has been revised. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (FLINK-31096) Unify versions in pom of table store

2023-02-15 Thread Shammon (Jira)
Shammon created FLINK-31096: --- Summary: Unify versions in pom of table store Key: FLINK-31096 URL: https://issues.apache.org/jira/browse/FLINK-31096 Project: Flink Issue Type: Improvement

[GitHub] [flink] JunRuiLee commented on a diff in pull request #21943: [FLINK-31077][runtime] Mark pending checkpoint onCompletionPromise complete only after the completed checkpoint is added to the s

2023-02-15 Thread via GitHub
JunRuiLee commented on code in PR #21943: URL: https://github.com/apache/flink/pull/21943#discussion_r1107952321 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java: ## @@ -141,27 +140,15 @@ import static

[jira] [Commented] (FLINK-31020) Read-only mode for Rest API

2023-02-15 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689458#comment-17689458 ] Wencong Liu commented on FLINK-31020: - Sorry [~chesnay] , my statement may not be very accurate. My

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #542: [FLINK-31094] Add table name to Writer

2023-02-15 Thread via GitHub
JingsongLi commented on code in PR #542: URL: https://github.com/apache/flink-table-store/pull/542#discussion_r1107946811 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/sink/FlinkSink.java: ## @@ -103,7 +103,7 @@ public DataStreamSink

  1   2   3   4   >