[GitHub] [flink-table-store] JingsongLi commented on pull request #569: [FLINK-31269] Split hive connector to each module of each version

2023-03-02 Thread via GitHub
JingsongLi commented on PR #569: URL: https://github.com/apache/flink-table-store/pull/569#issuecomment-1453120013 I'm mainly worried about whether Hive-catalog can work properly. Have you tested all Hive versions? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #426: [FLINK-30323] Support table statistics in table store

2023-03-02 Thread via GitHub
JingsongLi commented on code in PR #426: URL: https://github.com/apache/flink-table-store/pull/426#discussion_r1124125253 ## flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/source/TableStoreSource.java: ## @@ -209,4

[GitHub] [flink] SinBex commented on a diff in pull request #21634: [FLINK-30480][runtime] Add benchmarks for adaptive batch scheduler.

2023-03-02 Thread via GitHub
SinBex commented on code in PR #21634: URL: https://github.com/apache/flink/pull/21634#discussion_r1124119471 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/deploying/DeployingDownstreamTasksInBatchJobBenchmarkTest.java: ## @@ -31,7 +31,7 @@ public

[GitHub] [flink] SinBex commented on a diff in pull request #21634: [FLINK-30480][runtime] Add benchmarks for adaptive batch scheduler.

2023-03-02 Thread via GitHub
SinBex commented on code in PR #21634: URL: https://github.com/apache/flink/pull/21634#discussion_r1124119471 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/deploying/DeployingDownstreamTasksInBatchJobBenchmarkTest.java: ## @@ -31,7 +31,7 @@ public

[jira] [Closed] (FLINK-31302) Split spark modules according to version

2023-03-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31302. Fix Version/s: table-store-0.4.0 Assignee: yuzelin Resolution: Fixed master:

[jira] [Updated] (FLINK-31302) Split spark modules according to version

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31302: --- Labels: pull-request-available (was: ) > Split spark modules according to version >

[GitHub] [flink-table-store] JingsongLi merged pull request #570: [FLINK-31302] Split spark modules according to version

2023-03-02 Thread via GitHub
JingsongLi merged PR #570: URL: https://github.com/apache/flink-table-store/pull/570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] reswqa commented on pull request #22076: [BP-1.16][FLINK-31288][runtime] Disable overdraft buffer for non pipelined result partition.

2023-03-02 Thread via GitHub
reswqa commented on PR #22076: URL: https://github.com/apache/flink/pull/22076#issuecomment-1453109144 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] SinBex commented on a diff in pull request #21634: [FLINK-30480][runtime] Add benchmarks for adaptive batch scheduler.

2023-03-02 Thread via GitHub
SinBex commented on code in PR #21634: URL: https://github.com/apache/flink/pull/21634#discussion_r1124116656 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerTest.java: ## @@ -73,7 +74,7 @@ import static

[GitHub] [flink] SinBex commented on a diff in pull request #21634: [FLINK-30480][runtime] Add benchmarks for adaptive batch scheduler.

2023-03-02 Thread via GitHub
SinBex commented on code in PR #21634: URL: https://github.com/apache/flink/pull/21634#discussion_r1124116265 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerTest.java: ## @@ -400,4 +401,10 @@ private SchedulerBase

[GitHub] [flink] SinBex commented on a diff in pull request #21634: [FLINK-30480][runtime] Add benchmarks for adaptive batch scheduler.

2023-03-02 Thread via GitHub
SinBex commented on code in PR #21634: URL: https://github.com/apache/flink/pull/21634#discussion_r1124116265 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerTest.java: ## @@ -400,4 +401,10 @@ private SchedulerBase

[GitHub] [flink] gaoyunhaii commented on pull request #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

2023-03-02 Thread via GitHub
gaoyunhaii commented on PR #21736: URL: https://github.com/apache/flink/pull/21736#issuecomment-1453107730 > "Especially, the test data generation should be covered in a separate commit." Hi @XComp I have some concern with this point: for the formal process, if we want to split the

[jira] [Commented] (FLINK-31092) Hive ITCases fail with OutOfMemoryError

2023-03-02 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696063#comment-17696063 ] Shengkai Fang commented on FLINK-31092: --- Merged into release-1.17:

[GitHub] [flink] fsk119 closed pull request #22072: [FLINK-31092][sql-gateway][table-common] Fix Hive ITCase fail with OutOfMemoryError

2023-03-02 Thread via GitHub
fsk119 closed pull request #22072: [FLINK-31092][sql-gateway][table-common] Fix Hive ITCase fail with OutOfMemoryError URL: https://github.com/apache/flink/pull/22072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Comment Edited] (FLINK-30238) Unified Sink committer does not clean up state on final savepoint

2023-03-02 Thread Neha Aggarwal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696060#comment-17696060 ] Neha Aggarwal edited comment on FLINK-30238 at 3/3/23 7:36 AM: --- This issue

[jira] [Commented] (FLINK-30238) Unified Sink committer does not clean up state on final savepoint

2023-03-02 Thread Neha Aggarwal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696060#comment-17696060 ] Neha Aggarwal commented on FLINK-30238: --- This issue is not limited to stop-with-savepoint, It is

[GitHub] [flink-table-store] xuzhiwen1255 commented on a diff in pull request #577: [FLINK-31287]Modify the default value of changelog-producer.compactio…

2023-03-02 Thread via GitHub
xuzhiwen1255 commented on code in PR #577: URL: https://github.com/apache/flink-table-store/pull/577#discussion_r1124097472 ## flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/FlinkConnectorOptions.java: ## @@ -102,7

[jira] [Commented] (FLINK-31310) Force clear directory no matter what situation in HiveCatalog.dropTable

2023-03-02 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696048#comment-17696048 ] Nicholas Jiang commented on FLINK-31310: [~lzljs3620320], could you assign this to me? > Force

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #577: [FLINK-31287]Modify the default value of changelog-producer.compactio…

2023-03-02 Thread via GitHub
SteNicholas commented on code in PR #577: URL: https://github.com/apache/flink-table-store/pull/577#discussion_r1124094970 ## flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/FlinkConnectorOptions.java: ## @@ -102,7

[jira] [Commented] (FLINK-25217) FLIP-190: Support Version Upgrades for Table API & SQL Programs

2023-03-02 Thread ConradJam (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696047#comment-17696047 ] ConradJam commented on FLINK-25217: --- I can help with Parts 1 and 2, and I'm slowly learning about the

[GitHub] [flink-table-store] liming30 opened a new pull request, #578: [FLINK-31291] Close the Committer when the CommitterOperator closes.

2023-03-02 Thread via GitHub
liming30 opened a new pull request, #578: URL: https://github.com/apache/flink-table-store/pull/578 Close the Committer when the CommitterOperator closes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Closed] (FLINK-31252) Improve StaticFileStoreSplitEnumerator to assign batch splits

2023-03-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31252. Resolution: Fixed master: 4296d7c1cca7ff8fb5525401b1ef1659aae5879a > Improve

[GitHub] [flink-table-store] JingsongLi merged pull request #563: [FLINK-31252] Improve StaticFileStoreSplitEnumerator to assign batch splits

2023-03-02 Thread via GitHub
JingsongLi merged PR #563: URL: https://github.com/apache/flink-table-store/pull/563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-25986) Add FLIP-190 new API methods to python

2023-03-02 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696044#comment-17696044 ] Dian Fu commented on FLINK-25986: - Thanks [~qingyue] for taking this issue and also thanks

[jira] [Assigned] (FLINK-25986) Add FLIP-190 new API methods to python

2023-03-02 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-25986: --- Assignee: Jane Chan (was: Nicholas Jiang) > Add FLIP-190 new API methods to python >

[GitHub] [flink] pgaref commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-03-02 Thread via GitHub
pgaref commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1124085401 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -255,23 +258,52 @@ private final

[GitHub] [flink] fsk119 commented on pull request #22072: [FLINK-31092][sql-gateway][table-common] Fix Hive ITCase fail with OutOfMemoryError

2023-03-02 Thread via GitHub
fsk119 commented on PR #22072: URL: https://github.com/apache/flink/pull/22072#issuecomment-1453063763 All tests pass in my pipeline: https://dev.azure.com/1059623455/Flink/_build/results?buildId=565=results -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] pgaref commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-03-02 Thread via GitHub
pgaref commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1124078380 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -733,8 +764,7 @@ void restoreInternal() throws Exception {

[GitHub] [flink] pgaref commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-03-02 Thread via GitHub
pgaref commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1124078380 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -733,8 +764,7 @@ void restoreInternal() throws Exception {

[GitHub] [flink] pgaref commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-03-02 Thread via GitHub
pgaref commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1124078380 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -733,8 +764,7 @@ void restoreInternal() throws Exception {

[GitHub] [flink] pgaref commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-03-02 Thread via GitHub
pgaref commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1124081750 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -1019,16 +1049,24 @@ public CanEmitBatchOfRecordsChecker

[GitHub] [flink] pgaref commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-03-02 Thread via GitHub
pgaref commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1124078380 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -733,8 +764,7 @@ void restoreInternal() throws Exception {

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #577: [FLINK-31287]Modify the default value of changelog-producer.compactio…

2023-03-02 Thread via GitHub
SteNicholas commented on code in PR #577: URL: https://github.com/apache/flink-table-store/pull/577#discussion_r1124073557 ## docs/content/docs/concepts/primary-key-table.md: ## @@ -150,7 +150,7 @@ If your input can’t produce a complete changelog but you still want to get rid

[GitHub] [flink-table-store] xuzhiwen1255 commented on a diff in pull request #577: [FLINK-31287]Modify the default value of changelog-producer.compactio…

2023-03-02 Thread via GitHub
xuzhiwen1255 commented on code in PR #577: URL: https://github.com/apache/flink-table-store/pull/577#discussion_r1124074482 ## docs/content/docs/concepts/primary-key-table.md: ## @@ -150,7 +150,7 @@ If your input can’t produce a complete changelog but you still want to get rid

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #577: [FLINK-31287]Modify the default value of changelog-producer.compactio…

2023-03-02 Thread via GitHub
SteNicholas commented on code in PR #577: URL: https://github.com/apache/flink-table-store/pull/577#discussion_r1124073557 ## docs/content/docs/concepts/primary-key-table.md: ## @@ -150,7 +150,7 @@ If your input can’t produce a complete changelog but you still want to get rid

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #575: [FLINK-31309] Delete DFS schema when create table failed in HiveCatalog

2023-03-02 Thread via GitHub
JingsongLi commented on code in PR #575: URL: https://github.com/apache/flink-table-store/pull/575#discussion_r1124069564 ## flink-table-store-hive/flink-table-store-hive-catalog/src/main/java/org/apache/flink/table/store/hive/HiveCatalog.java: ## @@ -241,6 +244,12 @@ public

[jira] [Updated] (FLINK-31287) Default value of 'changelog-producer.compaction-interval' can be zero

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31287: --- Labels: pull-request-available (was: ) > Default value of

[GitHub] [flink-table-store] xuzhiwen1255 opened a new pull request, #577: [FLINK-31287]Modify the default value of changelog-producer.compactio…

2023-03-02 Thread via GitHub
xuzhiwen1255 opened a new pull request, #577: URL: https://github.com/apache/flink-table-store/pull/577 …n-interval to 0s -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Assigned] (FLINK-31144) Slow scheduling on large-scale batch jobs

2023-03-02 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-31144: --- Assignee: Junrui Li > Slow scheduling on large-scale batch jobs >

[jira] [Commented] (FLINK-31144) Slow scheduling on large-scale batch jobs

2023-03-02 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696033#comment-17696033 ] Zhu Zhu commented on FLINK-31144: - Thanks for volunteering! [~JunRuiLi] I have assigned you the ticket.

[jira] [Commented] (FLINK-31144) Slow scheduling on large-scale batch jobs

2023-03-02 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696030#comment-17696030 ] Junrui Li commented on FLINK-31144: --- Hi, [~zhuzh]. I'd like to fix this issue, could you help to

[jira] [Commented] (FLINK-25986) Add FLIP-190 new API methods to python

2023-03-02 Thread Nicholas Jiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696029#comment-17696029 ] Nicholas Jiang commented on FLINK-25986: [~dianfu], help to assign to [~qingyue]. > Add

[jira] [Closed] (FLINK-31087) Introduce MergeIntoAction.

2023-03-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31087. Fix Version/s: table-store-0.4.0 Assignee: yuzelin Resolution: Fixed master:

[GitHub] [flink-table-store] JingsongLi merged pull request #540: [FLINK-31087] Introduce merge-into action

2023-03-02 Thread via GitHub
JingsongLi merged PR #540: URL: https://github.com/apache/flink-table-store/pull/540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-31312) EnableObjectReuse cause different behaviors

2023-03-02 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiang Xin updated FLINK-31312: -- Description: I have the following test code which fails with the exception `Accessing a field by

[jira] [Commented] (FLINK-31211) Flink chk files not delete automic after 1.13

2023-03-02 Thread leo.zhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696017#comment-17696017 ] leo.zhi commented on FLINK-31211: - [~martijnvisser]  Hi Martijn, I upgrade to 1.16 now ,and use the

[GitHub] [flink] fsk119 commented on pull request #22072: [FLINK-31092][sql-gateway][table-common] Fix Hive ITCase fail with OutOfMemoryError

2023-03-02 Thread via GitHub
fsk119 commented on PR #22072: URL: https://github.com/apache/flink/pull/22072#issuecomment-1453011294 I have verify the sql-gateway module in the jdk11 environment with command ``` mvn clean verify -Pjava11 ``` and all tests pass. -- This is an automated message from

[jira] [Updated] (FLINK-31211) Flink chk files not delete automic after 1.13

2023-03-02 Thread leo.zhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leo.zhi updated FLINK-31211: Attachment: image-2023-03-03-13-50-32-795.png > Flink chk files not delete automic after 1.13 >

[jira] [Updated] (FLINK-31211) Flink chk files not delete automic after 1.13

2023-03-02 Thread leo.zhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leo.zhi updated FLINK-31211: Attachment: image-2023-03-03-13-49-07-262.png > Flink chk files not delete automic after 1.13 >

[jira] [Updated] (FLINK-31211) Flink chk files not delete automic after 1.13

2023-03-02 Thread leo.zhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leo.zhi updated FLINK-31211: Attachment: image-2023-03-03-13-48-30-510.png > Flink chk files not delete automic after 1.13 >

[jira] [Created] (FLINK-31312) EnableObjectReuse cause different behaviors

2023-03-02 Thread Jiang Xin (Jira)
Jiang Xin created FLINK-31312: - Summary: EnableObjectReuse cause different behaviors Key: FLINK-31312 URL: https://issues.apache.org/jira/browse/FLINK-31312 Project: Flink Issue Type: Bug

[jira] [Closed] (FLINK-31291) Document table.exec.sink.upsert-materialize to none

2023-03-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31291. Resolution: Fixed master: 2d1da3d8780b46740a1962e118a2dbd780791480 > Document

[GitHub] [flink-table-store] JingsongLi merged pull request #571: [FLINK-31291] Document "table.exec.sink.upsert-materialize" to "none" to avoid strange behavior

2023-03-02 Thread via GitHub
JingsongLi merged PR #571: URL: https://github.com/apache/flink-table-store/pull/571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-31311) Supports Bounded Watermark streaming read

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31311: --- Labels: pull-request-available (was: ) > Supports Bounded Watermark streaming read >

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #576: [FLINK-31311] Supports Bounded Watermark streaming read

2023-03-02 Thread via GitHub
JingsongLi opened a new pull request, #576: URL: https://github.com/apache/flink-table-store/pull/576 There are some bound stream scenarios that require that stream reading can be ended. Generally speaking, the end event time is the better. So in this ticket, supports writing the

[GitHub] [flink-table-store] JingsongLi merged pull request #574: [hotfix] Remove ignoreEmptyCommit in StreamTableCommit

2023-03-02 Thread via GitHub
JingsongLi merged PR #574: URL: https://github.com/apache/flink-table-store/pull/574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-31311) Supports Bounded Watermark streaming read

2023-03-02 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-31311: Summary: Supports Bounded Watermark streaming read Key: FLINK-31311 URL: https://issues.apache.org/jira/browse/FLINK-31311 Project: Flink Issue Type:

[jira] [Commented] (FLINK-31309) Rollback DFS schema if hive sync fail in HiveCatalog.createTable

2023-03-02 Thread Shammon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696007#comment-17696007 ] Shammon commented on FLINK-31309: - [~lzljs3620320] Please help to assign to me, thanks > Rollback DFS

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21937: [FLINK-30983][runtime] Support configured ssl algorithms for external REST SSL

2023-03-02 Thread via GitHub
TanYuxin-tyx commented on code in PR #21937: URL: https://github.com/apache/flink/pull/21937#discussion_r1124026276 ## flink-runtime/src/test/java/org/apache/flink/runtime/net/SSLUtilsTest.java: ## @@ -408,20 +433,19 @@ public void testCreateSSLEngineFactory() throws Exception

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #21937: [FLINK-30983][runtime] Support configured ssl algorithms for external REST SSL

2023-03-02 Thread via GitHub
TanYuxin-tyx commented on code in PR #21937: URL: https://github.com/apache/flink/pull/21937#discussion_r1124026035 ## flink-runtime/src/test/java/org/apache/flink/runtime/net/SSLUtilsTest.java: ## @@ -432,21 +456,21 @@ public void testInvalidFingerprintParsing() throws

[GitHub] [flink] TanYuxin-tyx commented on pull request #21937: [FLINK-30983][runtime] Support configured ssl algorithms for external REST SSL

2023-03-02 Thread via GitHub
TanYuxin-tyx commented on PR #21937: URL: https://github.com/apache/flink/pull/21937#issuecomment-1452972780 Thanks for reviewing the change @reswqa . The IT case RestServerEndpointITCase#setup has covered the modified method. -- This is an automated message from the Apache Git Service.

[GitHub] [flink] TanYuxin-tyx commented on pull request #21937: [FLINK-30983][runtime] Support configured ssl algorithms for external REST SSL

2023-03-02 Thread via GitHub
TanYuxin-tyx commented on PR #21937: URL: https://github.com/apache/flink/pull/21937#issuecomment-1452972416 > Thanks @TanYuxin-tyx, this changes overall look good to me. I only left some comments about tests, PTAL~ BTW, I think we also need to introduce an IT case for this, maybe

[jira] [Updated] (FLINK-31309) Rollback DFS schema if hive sync fail in HiveCatalog.createTable

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31309: --- Labels: pull-request-available (was: ) > Rollback DFS schema if hive sync fail in

[GitHub] [flink-table-store] FangYongs opened a new pull request, #575: [FLINK-31309] Delete DFS schema when create table failed in HiveCatalog

2023-03-02 Thread via GitHub
FangYongs opened a new pull request, #575: URL: https://github.com/apache/flink-table-store/pull/575 Delete DFS schema when create table failed in HiveCatalog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] Vancior commented on a diff in pull request #22003: [FLINK-31185][Python] Support side-output in broadcast processing

2023-03-02 Thread via GitHub
Vancior commented on code in PR #22003: URL: https://github.com/apache/flink/pull/22003#discussion_r1124011456 ## flink-python/pyflink/datastream/tests/test_data_stream.py: ## @@ -589,6 +589,40 @@ def process_element2(self, value, ctx: 'CoProcessFunction.Context'):

[GitHub] [flink] Vancior commented on a diff in pull request #22003: [FLINK-31185][Python] Support side-output in broadcast processing

2023-03-02 Thread via GitHub
Vancior commented on code in PR #22003: URL: https://github.com/apache/flink/pull/22003#discussion_r1124010607 ## flink-python/src/main/java/org/apache/flink/streaming/api/transformations/python/DelegateOperatorTransformation.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the

[GitHub] [flink] Aitozi commented on pull request #22069: [FLINK-31296][table-planner] Add JoinConditionEqualityTransferRule to…

2023-03-02 Thread via GitHub
Aitozi commented on PR #22069: URL: https://github.com/apache/flink/pull/22069#issuecomment-1452944267 @godfreyhe can you help review this pr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink-table-store] JingsongLi merged pull request #573: [hotfix] Fix ChangelogWithKeyFileStoreTableTest#testAggMergeFunc

2023-03-02 Thread via GitHub
JingsongLi merged PR #573: URL: https://github.com/apache/flink-table-store/pull/573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-table-store] JingsongLi commented on pull request #573: [hotfix] Fix ChangelogWithKeyFileStoreTableTest#testAggMergeFunc

2023-03-02 Thread via GitHub
JingsongLi commented on PR #573: URL: https://github.com/apache/flink-table-store/pull/573#issuecomment-1452939890 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-31249) Checkpoint timeout mechanism fails when finalizeCheckpoint is stuck

2023-03-02 Thread renxiang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695993#comment-17695993 ] renxiang zhou commented on FLINK-31249: --- [~roman]  When it takes too long to finalize the last

[jira] [Updated] (FLINK-31307) RocksDB:java.lang.UnsatisfiedLinkError

2023-03-02 Thread Wujunzhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wujunzhe updated FLINK-31307: - Attachment: image-2023-03-03-11-28-54-674.png > RocksDB:java.lang.UnsatisfiedLinkError >

[jira] [Commented] (FLINK-31307) RocksDB:java.lang.UnsatisfiedLinkError

2023-03-02 Thread Wujunzhe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695990#comment-17695990 ] Wujunzhe commented on FLINK-31307: -- How to check my jvm process memory left, what I can be sure is that

[GitHub] [flink-table-store] tsreaper opened a new pull request, #573: [hotfix] Fix ChangelogWithKeyFileStoreTableTest#testAggMergeFunc

2023-03-02 Thread via GitHub
tsreaper opened a new pull request, #573: URL: https://github.com/apache/flink-table-store/pull/573 Currently the result of `ChangelogWithKeyFileStoreTableTest#testAggMergeFunc` in branch release-0.3 is not correct. This PR fixes the testing method. -- This is an automated message from

[jira] [Created] (FLINK-31310) Force clear directory no matter what situation in HiveCatalog.dropTable

2023-03-02 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-31310: Summary: Force clear directory no matter what situation in HiveCatalog.dropTable Key: FLINK-31310 URL: https://issues.apache.org/jira/browse/FLINK-31310 Project:

[GitHub] [flink] lsyldliu commented on pull request #22031: [FLINK-31239][hive] Fix native sum function can't get the corrected value when the argument type is string

2023-03-02 Thread via GitHub
lsyldliu commented on PR #22031: URL: https://github.com/apache/flink/pull/22031#issuecomment-1452896206 @godfreyhe Thanks for your reviewing, I've addressed your comments. Could you help retain two commits when you merge? -- This is an automated message from the Apache Git Service. To

[jira] [Created] (FLINK-31309) Rollback DFS schema if hive sync fail in HiveCatalog.createTable

2023-03-02 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-31309: Summary: Rollback DFS schema if hive sync fail in HiveCatalog.createTable Key: FLINK-31309 URL: https://issues.apache.org/jira/browse/FLINK-31309 Project: Flink

[jira] [Assigned] (FLINK-31294) CommitterOperator forgot to close Committer when closing.

2023-03-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-31294: Assignee: Ming Li > CommitterOperator forgot to close Committer when closing. >

[jira] [Assigned] (FLINK-31287) Default value of 'changelog-producer.compaction-interval' can be zero

2023-03-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-31287: Assignee: xzw0223 > Default value of 'changelog-producer.compaction-interval' can be

[jira] [Commented] (FLINK-31287) Default value of 'changelog-producer.compaction-interval' can be zero

2023-03-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695980#comment-17695980 ] Jingsong Lee commented on FLINK-31287: -- [~xzw0223] Thanks! > Default value of

[jira] [Commented] (FLINK-31292) User HadoopUtils to get Configuration in CatalogContext

2023-03-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695979#comment-17695979 ] Jingsong Lee commented on FLINK-31292: -- [~liyubin117]  Thanks! > User HadoopUtils to get

[jira] [Assigned] (FLINK-31292) User HadoopUtils to get Configuration in CatalogContext

2023-03-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-31292: Assignee: Yubin Li > User HadoopUtils to get Configuration in CatalogContext >

[jira] [Commented] (FLINK-31294) CommitterOperator forgot to close Committer when closing.

2023-03-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695978#comment-17695978 ] Jingsong Lee commented on FLINK-31294: -- [~Ming Li] Thanks! > CommitterOperator forgot to close

[jira] [Commented] (FLINK-31307) RocksDB:java.lang.UnsatisfiedLinkError

2023-03-02 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695976#comment-17695976 ] Yun Tang commented on FLINK-31307: -- This is the basic usage of RocksDB TTL and the method existed in

[GitHub] [flink] slfan1989 commented on a diff in pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-03-02 Thread via GitHub
slfan1989 commented on code in PR #22028: URL: https://github.com/apache/flink/pull/22028#discussion_r1123982178 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -1441,13 +1444,17 @@ public String getClusterDescription() {

[GitHub] [flink] slfan1989 commented on a diff in pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-03-02 Thread via GitHub
slfan1989 commented on code in PR #22028: URL: https://github.com/apache/flink/pull/22028#discussion_r1123981772 ## flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java: ## @@ -912,4 +913,17 @@ private Map getTestMasterEnv(

[jira] [Commented] (FLINK-31298) ConnectionUtilsTest.testFindConnectingAddressWhenGetLocalHostThrows swallows IllegalArgumentException

2023-03-02 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695974#comment-17695974 ] Wencong Liu commented on FLINK-31298: - Hello [~mapohl] , I'd like to take this ticket.

[GitHub] [flink] slfan1989 commented on a diff in pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-03-02 Thread via GitHub
slfan1989 commented on code in PR #22028: URL: https://github.com/apache/flink/pull/22028#discussion_r1123981772 ## flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java: ## @@ -912,4 +913,17 @@ private Map getTestMasterEnv(

[jira] [Commented] (FLINK-28691) Improve cache hit rate of generated class

2023-03-02 Thread Shammon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695973#comment-17695973 ] Shammon commented on FLINK-28691: - Hi [~jark] We found the metaspace fullgc problem in codegen and

[jira] [Commented] (FLINK-31308) JobManager's metaspace out-of-memory when submit a flinksessionjobs

2023-03-02 Thread Shammon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695968#comment-17695968 ] Shammon commented on FLINK-31308: - I think it's a same kind of issue in

[GitHub] [flink-table-store] tsreaper opened a new pull request, #572: [FLINK-30608] support rename table

2023-03-02 Thread via GitHub
tsreaper opened a new pull request, #572: URL: https://github.com/apache/flink-table-store/pull/572 This PR is cherry-picked from #471. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (FLINK-31308) JobManager's metaspace out-of-memory when submit a flinksessionjobs

2023-03-02 Thread tanjialiang (Jira)
tanjialiang created FLINK-31308: --- Summary: JobManager's metaspace out-of-memory when submit a flinksessionjobs Key: FLINK-31308 URL: https://issues.apache.org/jira/browse/FLINK-31308 Project: Flink

[jira] [Created] (FLINK-31307) RocksDB:java.lang.UnsatisfiedLinkError

2023-03-02 Thread Wujunzhe (Jira)
Wujunzhe created FLINK-31307: Summary: RocksDB:java.lang.UnsatisfiedLinkError Key: FLINK-31307 URL: https://issues.apache.org/jira/browse/FLINK-31307 Project: Flink Issue Type: Bug Affects

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-03-02 Thread via GitHub
1996fanrui commented on code in PR #22028: URL: https://github.com/apache/flink/pull/22028#discussion_r1123963326 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -1441,13 +1444,17 @@ public String getClusterDescription() {

[GitHub] [flink] lsyldliu commented on a diff in pull request #22031: [FLINK-31239][hive] Fix native sum function can't get the corrected value when the argument type is string

2023-03-02 Thread via GitHub
lsyldliu commented on code in PR #22031: URL: https://github.com/apache/flink/pull/22031#discussion_r1123961288 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSumAggFunction.java: ## @@ -88,27 +97,27 @@ public Expression[]

[GitHub] [flink-ml] jiangxin369 opened a new pull request, #219: Add Servable for Logistic Regression

2023-03-02 Thread via GitHub
jiangxin369 opened a new pull request, #219: URL: https://github.com/apache/flink-ml/pull/219 ## What is the purpose of the change Add Servable for Logistic Regression. ## Brief change log *(for example:)* - Adds Servable for Logistic Regression ##

[jira] [Updated] (FLINK-31306) Add Servable for PipelineModel

2023-03-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31306: --- Labels: pull-request-available (was: ) > Add Servable for PipelineModel >

[GitHub] [flink-ml] jiangxin369 opened a new pull request, #218: [FLINK-31306] Add Servable for PipelineModel

2023-03-02 Thread via GitHub
jiangxin369 opened a new pull request, #218: URL: https://github.com/apache/flink-ml/pull/218 ## What is the purpose of the change Add Servable for PipelineModel. ## Brief change log *(for example:)* - Refactor code structure of utility classes. - Add

[jira] [Created] (FLINK-31306) Add Servable for PipelineModel

2023-03-02 Thread Jiang Xin (Jira)
Jiang Xin created FLINK-31306: - Summary: Add Servable for PipelineModel Key: FLINK-31306 URL: https://issues.apache.org/jira/browse/FLINK-31306 Project: Flink Issue Type: Improvement

[jira] [Comment Edited] (FLINK-30501) Update Flink build instruction to deprecate Java 8 instead of requiring Java 11

2023-03-02 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695954#comment-17695954 ] Dong Lin edited comment on FLINK-30501 at 3/3/23 1:28 AM: -- [~martijnvisser] I

[jira] [Commented] (FLINK-30501) Update Flink build instruction to deprecate Java 8 instead of requiring Java 11

2023-03-02 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695955#comment-17695955 ] Dong Lin commented on FLINK-30501: -- Note that the latest [Spark version

  1   2   3   4   >