[jira] [Commented] (FLINK-31655) Adaptive Channel selection for partitioner

2023-06-23 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736668#comment-17736668 ] Rui Fan commented on FLINK-31655: - Hi [~tartarus] , thanks for the hard testing. >From the result, I

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22806: [FLINK-32362] [SourceAlignment] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-06-23 Thread via GitHub
1996fanrui commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1240580330 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -195,9 +195,19 @@ void announceCombinedWatermark() {

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22854: [FLINK-32137] Added filtering of lambdas when collecting stack traces

2023-06-23 Thread via GitHub
1996fanrui commented on code in PR #22854: URL: https://github.com/apache/flink/pull/22854#discussion_r1240574947 ## flink-runtime/src/main/java/org/apache/flink/runtime/messages/ThreadInfoSample.java: ## @@ -38,7 +42,7 @@ public class ThreadInfoSample implements Serializable {

[GitHub] [flink] flinkbot commented on pull request #22854: [FLINK-32137] Added filtering of lambdas when collecting stack traces

2023-06-23 Thread via GitHub
flinkbot commented on PR #22854: URL: https://github.com/apache/flink/pull/22854#issuecomment-1605228314 ## CI report: * 39e77306d3e69774cfa8b0b591d873e24d7bffb2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32137) Flame graph is hard to use with many task managers

2023-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32137: --- Labels: pull-request-available (was: ) > Flame graph is hard to use with many task

[GitHub] [flink] netvl opened a new pull request, #22854: [FLINK-32137]k Added filtering of lambdas when collecting stack traces

2023-06-23 Thread via GitHub
netvl opened a new pull request, #22854: URL: https://github.com/apache/flink/pull/22854 ## What is the purpose of the change Because lambda "class names" can be different across different JVMs, the flame graph in Flink UI is often unreadable, especially with high parallelism with

[GitHub] [flink] flinkbot commented on pull request #22853: [FLINK-32263]-table-Add-ELT-function

2023-06-23 Thread via GitHub
flinkbot commented on PR #22853: URL: https://github.com/apache/flink/pull/22853#issuecomment-1604949409 ## CI report: * 3b85cb1b917b975deb4caebd531db20444aa32a7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32263) Add ELT support in SQL & Table API

2023-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32263: --- Labels: pull-request-available (was: ) > Add ELT support in SQL & Table API >

[GitHub] [flink] hanyuzheng7 opened a new pull request, #22853: [FLINK-32263]-table-Add-ELT-function

2023-06-23 Thread via GitHub
hanyuzheng7 opened a new pull request, #22853: URL: https://github.com/apache/flink/pull/22853 ## What is the purpose of the change Implement the elt function to extract the n-th input value from a row of inputs. The elt function in the ETL pipeline extracts the value at the n-th

[jira] [Comment Edited] (FLINK-32263) Add ELT support in SQL & Table API

2023-06-23 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736607#comment-17736607 ] Hanyu Zheng edited comment on FLINK-32263 at 6/23/23 8:32 PM: -- Now, we meet

[jira] [Commented] (FLINK-32263) Add ELT support in SQL & Table API

2023-06-23 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736607#comment-17736607 ] Hanyu Zheng commented on FLINK-32263: - Now, we meet a problem. If we use ELT(n, ...), we need know

[GitHub] [flink] reswqa commented on a diff in pull request #21774: [FLINK-28227][connectors] Migrate o.a.f.streaming.examples to the new Source API

2023-06-23 Thread via GitHub
reswqa commented on code in PR #21774: URL: https://github.com/apache/flink/pull/21774#discussion_r1239979075 ## flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/util/CarGeneratorFunction.java: ## @@ -0,0 +1,70 @@ +/* + *

[jira] [Commented] (FLINK-32071) Implement the snapshot manager for merged checkpoint files in TM

2023-06-23 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736556#comment-17736556 ] Yuan Mei commented on FLINK-32071: -- commit 

[jira] [Closed] (FLINK-32071) Implement the snapshot manager for merged checkpoint files in TM

2023-06-23 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei closed FLINK-32071. Resolution: Done > Implement the snapshot manager for merged checkpoint files in TM >

[GitHub] [flink] afedulov commented on pull request #22816: [FLINK-32373][sql-client] Support passing headers with SQL Client gateway requests

2023-06-23 Thread via GitHub
afedulov commented on PR #22816: URL: https://github.com/apache/flink/pull/22816#issuecomment-1604538343 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-32422) EmbeddedLeaderService doesn't handle the leader events properly in edge cases

2023-06-23 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-32422: - Summary: EmbeddedLeaderService doesn't handle the leader events properly in edge cases Key: FLINK-32422 URL: https://issues.apache.org/jira/browse/FLINK-32422

[jira] [Updated] (FLINK-32422) EmbeddedLeaderService doesn't handle the leader events properly in edge cases

2023-06-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-32422: -- Parent: FLINK-26522 Issue Type: Sub-task (was: Bug) > EmbeddedLeaderService doesn't

[jira] [Created] (FLINK-32421) EmbeddedLeaderServiceTest.testConcurrentRevokeLeadershipAndShutdown is not properly implemented

2023-06-23 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-32421: - Summary: EmbeddedLeaderServiceTest.testConcurrentRevokeLeadershipAndShutdown is not properly implemented Key: FLINK-32421 URL:

[GitHub] [flink] flinkbot commented on pull request #22852: [FLINK-32420][connectors/common] Improve the watermark aggregation performance

2023-06-23 Thread via GitHub
flinkbot commented on PR #22852: URL: https://github.com/apache/flink/pull/22852#issuecomment-1604464633 ## CI report: * aca7d16dd959cbeee9376b272e51b4fa46b93e1c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32420) Watermark aggregation performance is poor when watermark alignment is enabled and parallelism is high

2023-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32420: --- Labels: pull-request-available (was: ) > Watermark aggregation performance is poor when

[jira] [Updated] (FLINK-32420) Watermark aggregation performance is poor when watermark alignment is enabled and parallelism is high

2023-06-23 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-32420: Description: The

[jira] [Created] (FLINK-32420) Watermark aggregation performance is poor when watermark alignment is enabled and parallelism is high

2023-06-23 Thread Rui Fan (Jira)
Rui Fan created FLINK-32420: --- Summary: Watermark aggregation performance is poor when watermark alignment is enabled and parallelism is high Key: FLINK-32420 URL: https://issues.apache.org/jira/browse/FLINK-32420

[GitHub] [flink] flinkbot commented on pull request #22851: [FLINK-31646][network] Implement the remote tier producer for the tiered storage

2023-06-23 Thread via GitHub
flinkbot commented on PR #22851: URL: https://github.com/apache/flink/pull/22851#issuecomment-1604403356 ## CI report: * 8c1098cd3fea9913f1a73dd9c13b3442095606a8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31646) Introduce remote storage tier

2023-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31646: --- Labels: pull-request-available (was: ) > Introduce remote storage tier >

[GitHub] [flink] TanYuxin-tyx opened a new pull request, #22851: [FLINK-31646][network] Implement the remote tier producer for the tiered storage

2023-06-23 Thread via GitHub
TanYuxin-tyx opened a new pull request, #22851: URL: https://github.com/apache/flink/pull/22851 ## What is the purpose of the change *Implement the remote tier producer for the tiered storage* ## Brief change log *(for example:)* - *【commit 1】 Implement

[jira] [Updated] (FLINK-32353) Make Cassandra connector tests compatible with archunit rules

2023-06-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32353: --- Labels: pull-request-available (was: ) > Make Cassandra connector tests compatible with

[GitHub] [flink-connector-cassandra] echauchot opened a new pull request, #19: [FLINK-32353] update archunit violations for prod and test code with flink-1.18 rules

2023-06-23 Thread via GitHub
echauchot opened a new pull request, #19: URL: https://github.com/apache/flink-connector-cassandra/pull/19 The mini cluster rule has been fixed in flink-1.18 (here https://github.com/apache/flink/pull/22399/) so: - CassandraConnectorITCase does not use/needs MiniCluster so it is

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #622: [FLINK-32012] Provide rollback feature on savepoint upgrade mode if HA missing and JM never started

2023-06-23 Thread via GitHub
gyfora commented on code in PR #622: URL: https://github.com/apache/flink-kubernetes-operator/pull/622#discussion_r1239818902 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java: ## @@ -140,6 +141,12 @@

[GitHub] [flink] flinkbot commented on pull request #22850: [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2023-06-23 Thread via GitHub
flinkbot commented on PR #22850: URL: https://github.com/apache/flink/pull/22850#issuecomment-1604229112 ## CI report: * d440c55011d86b6a2eb26a11b4a6af78e3ed9847 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] afedulov commented on pull request #21028: [FLINK-28229][streaming-java] Introduce Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2023-06-23 Thread via GitHub
afedulov commented on PR #21028: URL: https://github.com/apache/flink/pull/21028#issuecomment-1604224171 @zentol I implemented the alternative approach you proposed based on the `DataGeneratorSource`. There are a couple of open questions, but I'd like to get your general feedback before

[GitHub] [flink] afedulov opened a new pull request, #22850: [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2023-06-23 Thread via GitHub
afedulov opened a new pull request, #22850: URL: https://github.com/apache/flink/pull/22850 An alternative implementation to https://github.com/apache/flink/pull/21028, based on the `DataGeneratorSource` (as proposed in

[GitHub] [flink] XComp commented on pull request #22846: [FLINK-32413][runtime] Adds fallback error handler to DefaultLeaderElectionService

2023-06-23 Thread via GitHub
XComp commented on PR #22846: URL: https://github.com/apache/flink/pull/22846#issuecomment-1603936210 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] xintongsong commented on a diff in pull request #22833: [FLINK-32283][network] Implement the SortBufferAccumulator for the tiered storage

2023-06-23 Thread via GitHub
xintongsong commented on code in PR #22833: URL: https://github.com/apache/flink/pull/22833#discussion_r1239483891 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/BufferAccumulator.java: ## @@ -46,7 +46,10 @@ public interface

[jira] [Closed] (FLINK-31851) Remove unused KubernetesMultipleComponentLeaderElectionHaServicesFactory

2023-06-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-31851. - Resolution: Won't Fix I did some more code digging and noticed that we actually already support

[jira] [Updated] (FLINK-31851) Remove unused KubernetesMultipleComponentLeaderElectionHaServicesFactory

2023-06-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31851: -- Summary: Remove unused KubernetesMultipleComponentLeaderElectionHaServicesFactory (was:

[jira] [Reopened] (FLINK-31851) Remove unused KubernetesMultipleComponentLeaderElectionHaServicesFactory

2023-06-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reopened FLINK-31851: --- I'm reopening that one because it's not only about removing

[jira] [Updated] (FLINK-31851) Align k8s HA configuration with ZK HA

2023-06-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31851: -- Summary: Align k8s HA configuration with ZK HA (was: Remove unused

[jira] [Closed] (FLINK-31851) Remove unused KubernetesMultipleComponentLeaderElectionHaServicesFactory

2023-06-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-31851. - Resolution: Duplicate > Remove unused

[jira] [Assigned] (FLINK-32419) Remove unused/obsolete classes

2023-06-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-32419: - Assignee: Matthias Pohl > Remove unused/obsolete classes >

[jira] [Created] (FLINK-32419) Remove unused/obsolete classes

2023-06-23 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-32419: - Summary: Remove unused/obsolete classes Key: FLINK-32419 URL: https://issues.apache.org/jira/browse/FLINK-32419 Project: Flink Issue Type: Sub-task

[jira] [Resolved] (FLINK-32415) Add maven wrapper to benchmark to avoid maven version issues

2023-06-23 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi resolved FLINK-32415. --- Resolution: Fixed 62a1db5 on master. > Add maven wrapper to benchmark to avoid maven

[jira] [Closed] (FLINK-32415) Add maven wrapper to benchmark to avoid maven version issues

2023-06-23 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi closed FLINK-32415. - > Add maven wrapper to benchmark to avoid maven version issues >

[GitHub] [flink-benchmarks] gaborgsomogyi merged pull request #76: [FLINK-32415] Add maven wrapper to benchmark to avoid maven version issues

2023-06-23 Thread via GitHub
gaborgsomogyi merged PR #76: URL: https://github.com/apache/flink-benchmarks/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: