[jira] [Commented] (FLINK-32496) Sources with idleness and alignment always wait for alignment when part of multiple sources is idle

2023-07-01 Thread haishui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739346#comment-17739346 ] haishui commented on FLINK-32496: - Hi [~fanrui], I have not yet found that this idle issue leads to

[jira] [Closed] (FLINK-32461) manage union operator state increase very large in Jobmanager

2023-07-01 Thread wgcn (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wgcn closed FLINK-32461. Release Note: it's a usage problem Resolution: Fixed > manage union operator state increase very large in

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-07-01 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1249015509 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayElementOutputTypeStrategy.java: ## @@ -1,47 +0,0 @@ -/* - *

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-07-01 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1249022952 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificTypeStrategies.java: ## @@ -58,8 +58,12 @@ public final

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

2023-07-01 Thread via GitHub
hanyuzheng7 commented on code in PR #22917: URL: https://github.com/apache/flink/pull/22917#discussion_r1249015509 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayElementOutputTypeStrategy.java: ## @@ -1,47 +0,0 @@ -/* - *

[jira] [Updated] (FLINK-32399) Fix flink-sql-connector-kinesis build for maven 3.8.6+

2023-07-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32399: --- Labels: pull-request-available (was: ) > Fix flink-sql-connector-kinesis build for maven

[GitHub] [flink-connector-aws] z3d1k opened a new pull request, #87: [FLINK-32399][Connectors/Kinesis] Update shading configuration for Kinesis SQL connector to support maven 3.8.6+

2023-07-01 Thread via GitHub
z3d1k opened a new pull request, #87: URL: https://github.com/apache/flink-connector-aws/pull/87 ## Purpose of the change Update shading configuration for `flink-sql-connector-kinesis` to support build using Maven 3.8.6 and newer. ## Verifying this change This

[GitHub] [flink] flinkbot commented on pull request #22926: [FLINK-32509][core] Avoid using skip in InputStreamFSInputWrapper

2023-07-01 Thread via GitHub
flinkbot commented on PR #22926: URL: https://github.com/apache/flink/pull/22926#issuecomment-1615989281 ## CI report: * c36a99856f358a46c149f70fd42f2f9b9d0970c4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32509) avoid using skip in InputStreamFSInputWrapper.seek

2023-07-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32509: --- Labels: pull-request-available (was: ) > avoid using skip in

[GitHub] [flink] Allan-QLB opened a new pull request, #22926: [FLINK-32509][core] Avoid using skip in InputStreamFSInputWrapper

2023-07-01 Thread via GitHub
Allan-QLB opened a new pull request, #22926: URL: https://github.com/apache/flink/pull/22926 ## What is the purpose of the change Method "skip" of InputStream does not return -1 for eof, so it can cause to infinite loop when desired exceed end of file. ## Brief

[GitHub] [flink] snuyanzin commented on pull request #22923: [FLINK-32296][table] Support cast of collections with row element types

2023-07-01 Thread via GitHub
snuyanzin commented on PR #22923: URL: https://github.com/apache/flink/pull/22923#issuecomment-1615964683 sql client does not apply any special formats it just outputs results of casting to string, so existing tests should be enough to be sure that results same not only between 2 machines

[GitHub] [flink] hanyuzheng7 commented on pull request #22923: [FLINK-32296][table] Support cast of collections with row element types

2023-07-01 Thread via GitHub
hanyuzheng7 commented on PR #22923: URL: https://github.com/apache/flink/pull/22923#issuecomment-1615951705 @snuyanzin I didn't find any problem. I used sql client run them yesterday, I didn't know the correct format, so I want make sure our results in client are same. -- This is

[GitHub] [flink] lindong28 commented on pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-07-01 Thread via GitHub
lindong28 commented on PR #22670: URL: https://github.com/apache/flink/pull/22670#issuecomment-1615951612 Thanks for the update. Thank you all for the comments. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (FLINK-32509) avoid using skip in InputStreamFSInputWrapper.seek

2023-07-01 Thread Libin Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Libin Qin updated FLINK-32509: -- Description: The implementation of  InputStream does not return -1  for eof. The java doc of

[jira] [Updated] (FLINK-32509) avoid using skip in InputStreamFSInputWrapper.seek

2023-07-01 Thread Libin Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Libin Qin updated FLINK-32509: -- Description: The implementation of  InputStream does not return -1  for eof. The java doc of

[jira] [Created] (FLINK-32509) avoid using skip in InputStreamFSInputWrapper.seek

2023-07-01 Thread Libin Qin (Jira)
Libin Qin created FLINK-32509: - Summary: avoid using skip in InputStreamFSInputWrapper.seek Key: FLINK-32509 URL: https://issues.apache.org/jira/browse/FLINK-32509 Project: Flink Issue Type: Bug

[GitHub] [flink] afedulov commented on a diff in pull request #22850: [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2023-07-01 Thread via GitHub
afedulov commented on code in PR #22850: URL: https://github.com/apache/flink/pull/22850#discussion_r1247721510 ## flink-connectors/flink-connector-datagen-test/pom.xml: ## @@ -0,0 +1,89 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink] xintongsong commented on a diff in pull request #22855: [FLINK-31647][network] Introduce the RemoteTierConsumerAgent

2023-07-01 Thread via GitHub
xintongsong commented on code in PR #22855: URL: https://github.com/apache/flink/pull/22855#discussion_r1248809827 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/remote/RemoteStorageScanner.java: ## @@ -0,0 +1,197 @@ +/* + *

[jira] [Commented] (FLINK-32201) Enable the distribution of shuffle descriptors via the blob server by connection number

2023-07-01 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739293#comment-17739293 ] Lijie Wang commented on FLINK-32201: Done via: master(1.18):

[jira] [Closed] (FLINK-32201) Enable the distribution of shuffle descriptors via the blob server by connection number

2023-07-01 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang closed FLINK-32201. -- Fix Version/s: 1.18.0 Resolution: Done > Enable the distribution of shuffle descriptors via

[GitHub] [flink] wanglijie95 closed pull request #22674: [FLINK-32201][runtime]Automatically determine if the shuffle descriptor needs to be offloaded by the blob server based on the number of Shuffle

2023-07-01 Thread via GitHub
wanglijie95 closed pull request #22674: [FLINK-32201][runtime]Automatically determine if the shuffle descriptor needs to be offloaded by the blob server based on the number of ShuffleDescriptor edges. URL: https://github.com/apache/flink/pull/22674 -- This is an automated message from the

[GitHub] [flink] snuyanzin commented on pull request #22923: [FLINK-32296][table] Support cast of collections with row element types

2023-07-01 Thread via GitHub
snuyanzin commented on PR #22923: URL: https://github.com/apache/flink/pull/22923#issuecomment-1615767306 @hanyuzheng7 can you elaborate what is the problem with sql client? for the first query it is ``` [(1, one), (2, two)] ``` and for the second ``` {(2)=two, (1)=one}

[jira] [Commented] (FLINK-32496) Sources with idleness and alignment always wait for alignment when part of multiple sources is idle

2023-07-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739276#comment-17739276 ] Rui Fan commented on FLINK-32496: - {quote}A source will be marked idle if the source waits for alignment

[jira] [Commented] (FLINK-32496) Sources with idleness and alignment always wait for alignment when part of multiple sources is idle

2023-07-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739274#comment-17739274 ] Rui Fan commented on FLINK-32496: - Add more background here. h2. What is the purpose of the change When

[GitHub] [flink] flinkbot commented on pull request #22925: [FLINK-32496][connectors/common] Fix the bug that source cannot resume after enabling the watermark alignment and idleness

2023-07-01 Thread via GitHub
flinkbot commented on PR #22925: URL: https://github.com/apache/flink/pull/22925#issuecomment-1615535171 ## CI report: * 67801d97613835e438dd6f99ecfc55d417ceabc0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32496) Sources with idleness and alignment always wait for alignment when part of multiple sources is idle

2023-07-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32496: --- Labels: pull-request-available (was: ) > Sources with idleness and alignment always wait

[GitHub] [flink] 1996fanrui opened a new pull request, #22925: [FLINK-32496][connectors/common] Fix the bug that source cannot resume after enabling the watermark alignment and idleness

2023-07-01 Thread via GitHub
1996fanrui opened a new pull request, #22925: URL: https://github.com/apache/flink/pull/22925 ## What is the purpose of the change When one source is always active and other sources are idle (Either there is no data, or alignment causes idle.), these source won't resume. For

[GitHub] [flink] wanglijie95 commented on pull request #22674: [FLINK-32201][runtime]Automatically determine if the shuffle descriptor needs to be offloaded by the blob server based on the number of S

2023-07-01 Thread via GitHub
wanglijie95 commented on PR #22674: URL: https://github.com/apache/flink/pull/22674#issuecomment-1615530606 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific