[GitHub] [flink] masteryhx commented on pull request #23253: [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api

2023-09-27 Thread via GitHub
masteryhx commented on PR #23253: URL: https://github.com/apache/flink/pull/23253#issuecomment-1738497112 @xiangforever2014 Thanks for the detailed clarification. I think remaining too many mapping info in CheckpointCoordinator is not necessary which brings too much unnecessary code

[GitHub] [flink-connector-hbase] Tan-JiaLiang commented on pull request #21: [FLINK-33164] Support write option sink.ignore-null-value

2023-09-27 Thread via GitHub
Tan-JiaLiang commented on PR #21: URL: https://github.com/apache/flink-connector-hbase/pull/21#issuecomment-1738363259 @ferenc-csaky Thanks for the code review, very helpful suggestions. I have changed it, please have a look. -- This is an automated message from the Apache Git Service.

[jira] [Commented] (FLINK-33090) CheckpointsCleaner clean individual checkpoint states in parallel

2023-09-27 Thread Yi Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769854#comment-17769854 ] Yi Zhang commented on FLINK-33090: -- some of our users jobs having large number of state files, this is

[GitHub] [flink-connector-hbase] ferenc-csaky commented on pull request #20: Fix problem due to HBaseRowDataLookupFunction returned to reuse objects

2023-09-27 Thread via GitHub
ferenc-csaky commented on PR #20: URL: https://github.com/apache/flink-connector-hbase/pull/20#issuecomment-1738226095 Thank you for your contribution! Would you mind creating a bug jira with a description about the bug and then modify this PR with that ticket number and also an English

[GitHub] [flink] ferenc-csaky commented on pull request #15847: [FLINK-19647][Connectors/HBase]Support the limit push down for the hb…

2023-09-27 Thread via GitHub
ferenc-csaky commented on PR #15847: URL: https://github.com/apache/flink/pull/15847#issuecomment-1738216998 @shouweikun Do you have the capacity to update this PR and reopen it against the `https://github.com/apache/flink-connector-hbase` repo? -- This is an automated message from the

[GitHub] [flink] ferenc-csaky commented on a diff in pull request #19870: [FLINK-27882][tests][table] Migrate flink-scala to JUnit5

2023-09-27 Thread via GitHub
ferenc-csaky commented on code in PR #19870: URL: https://github.com/apache/flink/pull/19870#discussion_r1339298186 ## flink-scala/src/test/scala/org/apache/flink/api/scala/typeutils/EnumValueSerializerCompatibilityTest.scala: ## @@ -19,26 +19,25 @@ package

[jira] [Updated] (FLINK-13876) Remove ExecutionConfig field from PojoSerializer

2023-09-27 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-13876: --- Labels: auto-deprioritized-major auto-deprioritized-minor (was: auto-deprioritized-major

[jira] [Updated] (FLINK-32866) Unify the TestLoggerExtension config of junit5

2023-09-27 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32866: --- Labels: pull-request-available stale-assigned starter (was: pull-request-available

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #52: [FLINK-28303] Support LatestOffsetsInitializer to avoid latest-offset strategy lose data

2023-09-27 Thread via GitHub
tzulitai commented on PR #52: URL: https://github.com/apache/flink-connector-kafka/pull/52#issuecomment-1738178744 Thanks for the fix and review, @Tan-JiaLiang @Ge. I'll do one last pass and then hopefully merge this ASAP. -- This is an automated message from the Apache Git

[GitHub] [flink-connector-hbase] ferenc-csaky commented on a diff in pull request #21: [FLINK-33164] Support write option sink.ignore-null-value

2023-09-27 Thread via GitHub
ferenc-csaky commented on code in PR #21: URL: https://github.com/apache/flink-connector-hbase/pull/21#discussion_r1338968517 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseDynamicTableFactoryTest.java: ## @@ -260,6 +260,19 @@ public void

[jira] [Updated] (FLINK-32873) Add configuration to allow disabling SQL query hints

2023-09-27 Thread Bonnie Varghese (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bonnie Varghese updated FLINK-32873: Description: Platform providers may want to disable hints completely for security

[jira] [Updated] (FLINK-32873) Add configuration to allow disabling SQL query hints

2023-09-27 Thread Bonnie Varghese (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bonnie Varghese updated FLINK-32873: Description: Platform providers may want to disable hints completely for security

[GitHub] [flink-web] hlteoh37 merged pull request #671: [hotfix] Minor typos and polish for blog post

2023-09-27 Thread via GitHub
hlteoh37 merged PR #671: URL: https://github.com/apache/flink-web/pull/671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-33149) Bump snappy-java to 1.1.10.4

2023-09-27 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33149: Fix Version/s: 1.18.0 1.16.3 1.17.2

[jira] [Comment Edited] (FLINK-33149) Bump snappy-java to 1.1.10.4

2023-09-27 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769678#comment-17769678 ] Sergey Nuyanzin edited comment on FLINK-33149 at 9/27/23 3:54 PM: --

[jira] [Comment Edited] (FLINK-33149) Bump snappy-java to 1.1.10.4

2023-09-27 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769678#comment-17769678 ] Sergey Nuyanzin edited comment on FLINK-33149 at 9/27/23 3:53 PM: --

[jira] [Commented] (FLINK-33149) Bump snappy-java to 1.1.10.4

2023-09-27 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769678#comment-17769678 ] Sergey Nuyanzin commented on FLINK-33149: - Merged to flink main repo master as

[GitHub] [flink] jeyhunkarimov commented on pull request #23470: [FLINK-32622][table-planner] Optimize mini-batch assignment

2023-09-27 Thread via GitHub
jeyhunkarimov commented on PR #23470: URL: https://github.com/apache/flink/pull/23470#issuecomment-1737630761 Hi @swuferhong , could you please review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] flinkbot commented on pull request #23475: [FLINK-33000][sql-gateway][release-1.16] SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-27 Thread via GitHub
flinkbot commented on PR #23475: URL: https://github.com/apache/flink/pull/23475#issuecomment-1737594703 ## CI report: * 2a24942152614758c1c7290ac6711d7a6f3428a5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Jiabao-Sun opened a new pull request, #23475: [FLINK-33000][sql-gateway][release-1.16] SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-27 Thread via GitHub
Jiabao-Sun opened a new pull request, #23475: URL: https://github.com/apache/flink/pull/23475 ## What is the purpose of the change [FLINK-33000][sql-gateway][release-1.16] SqlGatewayServiceITCase and OperationManagerTest should utilize TestExecutorExtension instead of using a

[jira] [Commented] (FLINK-33165) Flink UI stack trace popup continually displayed when a job is deleted

2023-09-27 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769621#comment-17769621 ] Sergey Nuyanzin commented on FLINK-33165: - [~davidradl] thanks for the raising the issue could

[jira] [Created] (FLINK-33165) Flink UI stack trace popup continually displayed when a job is deleted

2023-09-27 Thread david radley (Jira)
david radley created FLINK-33165: Summary: Flink UI stack trace popup continually displayed when a job is deleted Key: FLINK-33165 URL: https://issues.apache.org/jira/browse/FLINK-33165 Project:

[GitHub] [flink-connector-kafka] Tan-JiaLiang commented on a diff in pull request #52: [FLINK-28303] Support LatestOffsetsInitializer to avoid latest-offset strategy lose data

2023-09-27 Thread via GitHub
Tan-JiaLiang commented on code in PR #52: URL: https://github.com/apache/flink-connector-kafka/pull/52#discussion_r1338500811 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/enumerator/KafkaEnumeratorTest.java: ## @@ -300,7 +300,7 @@ public void

[GitHub] [flink-connector-kafka] Tan-JiaLiang commented on pull request #52: [FLINK-28303] Support LatestOffsetsInitializer to avoid latest-offset strategy lose data

2023-09-27 Thread via GitHub
Tan-JiaLiang commented on PR #52: URL: https://github.com/apache/flink-connector-kafka/pull/52#issuecomment-1737250148 > Thanks for the patch! I do think that we should add an e2e test, say to `KafkaTableITCase` that follows the repro instructions in the issue: > > ``` > 1. Set

[jira] [Commented] (FLINK-22014) Flink JobManager failed to restart after failure in kubernetes HA setup

2023-09-27 Thread Alexey Novakov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769548#comment-17769548 ] Alexey Novakov commented on FLINK-22014: the same issue in my case with Flink 1.16.1. Storage

[jira] [Updated] (FLINK-30975) Migrate aws sdk from v1 to v2

2023-09-27 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated FLINK-30975: --- Description: This issue is created to address migration of aws sdk v1 in flink to aws sdk v2  As

[GitHub] [flink] flinkbot commented on pull request #23474: [FLINK-33000][sql-gateway][release-1.17] SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-27 Thread via GitHub
flinkbot commented on PR #23474: URL: https://github.com/apache/flink/pull/23474#issuecomment-1737132054 ## CI report: * 4180f405d19de8a6914eaf81603442d9484de781 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #23473: [FLINK-33000][sql-gateway][release-1.18] SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-27 Thread via GitHub
flinkbot commented on PR #23473: URL: https://github.com/apache/flink/pull/23473#issuecomment-1737131082 ## CI report: * 645926a8a11bdd4f09d84152ec62ba6a764d4954 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] Jiabao-Sun opened a new pull request, #23474: [FLINK-33000][sql-gateway][release-1.17] SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-27 Thread via GitHub
Jiabao-Sun opened a new pull request, #23474: URL: https://github.com/apache/flink/pull/23474 ## What is the purpose of the change [FLINK-33000][sql-gateway][release-1.17] SqlGatewayServiceITCase, ResultFetcherTest and OperationManagerTest should utilize TestExecutorExtension

[GitHub] [flink] Jiabao-Sun opened a new pull request, #23473: [FLINK-33000][sql-gateway][release-1.18] SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-27 Thread via GitHub
Jiabao-Sun opened a new pull request, #23473: URL: https://github.com/apache/flink/pull/23473 ## What is the purpose of the change [FLINK-33000][sql-gateway][release-1.18] SqlGatewayServiceITCase, ResultFetcherTest and OperationManagerTest should utilize TestExecutorExtension

[GitHub] [flink] victor9309 commented on pull request #23472: [FLINK-32108][test] KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-09-27 Thread via GitHub
victor9309 commented on PR #23472: URL: https://github.com/apache/flink/pull/23472#issuecomment-1737048872 Checks whether credentials are available in the environment variables of this JVM. If not, throws an {@link AssumptionViolatedException} which causes JUnit tests to be skipped. --

[jira] [Commented] (FLINK-33155) Flink ResourceManager continuously fails to start TM container on YARN when Kerberos enabled

2023-09-27 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769498#comment-17769498 ] Gabor Somogyi commented on FLINK-33155: --- I would say green light on this :) Just saying that

[jira] (FLINK-30314) Unable to read all records from compressed delimited file input format

2023-09-27 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30314 ] Etienne Chauchot deleted comment on FLINK-30314: -- was (Author: echauchot): https://github.com/apache/flink/pull/23443 > Unable to read all records from compressed delimited file input

[jira] [Reopened] (FLINK-33159) No functional change - Use the variables instead of multiple literals for java and Maven version checks in the pom file

2023-09-27 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] david radley reopened FLINK-33159: -- Re opening - as this change is not changing the versions to check. It is moving to consistently

[jira] [Updated] (FLINK-33159) No functional change - Use the variables instead of multiple literals for java and Maven version checks in the pom file

2023-09-27 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] david radley updated FLINK-33159: - Summary: No functional change - Use the variables instead of multiple literals for java and

[jira] [Assigned] (FLINK-33000) SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-27 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-33000: - Assignee: Jiabao Sun > SqlGatewayServiceITCase should utilize TestExecutorExtension

[jira] [Commented] (FLINK-33000) SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-27 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769470#comment-17769470 ] Shengkai Fang commented on FLINK-33000: --- Merged into master:

[GitHub] [flink] fsk119 merged pull request #23449: [FLINK-33000][sql-gateway] SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using a ThreadFactory

2023-09-27 Thread via GitHub
fsk119 merged PR #23449: URL: https://github.com/apache/flink/pull/23449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #94: [FLINK-33073][Connectors/AWS] Implement end-to-end tests for KinesisS…

2023-09-27 Thread via GitHub
dannycranmer commented on code in PR #94: URL: https://github.com/apache/flink-connector-aws/pull/94#discussion_r1338172936 ##

[GitHub] [flink] flinkbot commented on pull request #23472: [FLINK-32108][test] KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-09-27 Thread via GitHub
flinkbot commented on PR #23472: URL: https://github.com/apache/flink/pull/23472#issuecomment-1736848921 ## CI report: * 029774553ee26549f80e3512706a346f3c75a1a3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-hbase] boring-cyborg[bot] commented on pull request #21: [FLINK-33164] Support write option sink.ignore-null-value

2023-09-27 Thread via GitHub
boring-cyborg[bot] commented on PR #21: URL: https://github.com/apache/flink-connector-hbase/pull/21#issuecomment-1736838943 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[jira] [Updated] (FLINK-33164) HBase connector support ignore null value for partial update

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33164: --- Labels: pull-request-available (was: ) > HBase connector support ignore null value for

[GitHub] [flink] victor9309 opened a new pull request, #23472: [FLINK-32108][test] KubernetesExtension calls assumeThat in @BeforeAll callback which doesn't print the actual failure message

2023-09-27 Thread via GitHub
victor9309 opened a new pull request, #23472: URL: https://github.com/apache/flink/pull/23472 ## What is the purpose of the change *KubernetesExtension implements BeforeAllCallback which calls the assumeThat in the @BeforeAll context. assumeThat doesn't work properly in the

[GitHub] [flink-connector-hbase] Tan-JiaLiang opened a new pull request, #21: [FLINK-33164] Support write option sink.ignore-null-value

2023-09-27 Thread via GitHub
Tan-JiaLiang opened a new pull request, #21: URL: https://github.com/apache/flink-connector-hbase/pull/21 ## What is the purpose of the change Sometimes, user want to write data and ignore null value to achieve partial update. ## Brief change log - *support

[GitHub] [flink] xintongsong closed pull request #23456: [FLINK-33144][datastream]Deprecate Iteration API in DataStream

2023-09-27 Thread via GitHub
xintongsong closed pull request #23456: [FLINK-33144][datastream]Deprecate Iteration API in DataStream URL: https://github.com/apache/flink/pull/23456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (FLINK-33164) HBase connector support ignore null value for partial update

2023-09-27 Thread tanjialiang (Jira)
tanjialiang created FLINK-33164: --- Summary: HBase connector support ignore null value for partial update Key: FLINK-33164 URL: https://issues.apache.org/jira/browse/FLINK-33164 Project: Flink

[jira] [Updated] (FLINK-33162) seperate the executor in DefaultDispatcherResourceManagerComponentFactory for MetricFetcher and webMonitorEndpoint

2023-09-27 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaogang zhou updated FLINK-33162: -- Description: when starting a job with large number of taskmanagers, the jobmanager of the

[jira] [Updated] (FLINK-33163) Support Java 21 (LTS)

2023-09-27 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-33163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maciej Bryński updated FLINK-33163: --- Issue Type: New Feature (was: Bug) > Support Java 21 (LTS) > - > >

[jira] [Created] (FLINK-33163) Support Java 21 (LTS)

2023-09-27 Thread Jira
Maciej Bryński created FLINK-33163: -- Summary: Support Java 21 (LTS) Key: FLINK-33163 URL: https://issues.apache.org/jira/browse/FLINK-33163 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-33157) Support AWS SDK V2 for Flink's S3 FileSystem

2023-09-27 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769442#comment-17769442 ] Samrat Deb commented on FLINK-33157: I think there exists Jira for sdk v1 to v2 migration 

[jira] [Updated] (FLINK-33162) seperate the executor in DefaultDispatcherResourceManagerComponentFactory for MetricFetcher and webMonitorEndpoint

2023-09-27 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaogang zhou updated FLINK-33162: -- Affects Version/s: 1.13.1 (was: 1.16.0) > seperate the executor in

[jira] [Updated] (FLINK-33162) seperate the executor in DefaultDispatcherResourceManagerComponentFactory for MetricFetcher and webMonitorEndpoint

2023-09-27 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaogang zhou updated FLINK-33162: -- Description: when starting a job with large number of taskmanagers, the jobmanager of the

[jira] [Created] (FLINK-33162) seperate the executor in DefaultDispatcherResourceManagerComponentFactory for MetricFetcher and webMonitorEndpoint

2023-09-27 Thread xiaogang zhou (Jira)
xiaogang zhou created FLINK-33162: - Summary: seperate the executor in DefaultDispatcherResourceManagerComponentFactory for MetricFetcher and webMonitorEndpoint Key: FLINK-33162 URL: