[jira] [Commented] (FLINK-33204) Add description for missing options in the all jobmanager/taskmanager options section in document

2023-10-07 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772931#comment-17772931 ] Zhanghao Chen commented on FLINK-33204: --- Hi [~xtsong], I've prepared a quick fix, could you help

[jira] [Updated] (FLINK-33204) Add description for missing options in the all jobmanager/taskmanager options section in document

2023-10-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33204: --- Labels: pull-request-available (was: ) > Add description for missing options in the all

[PR] [FLINK-33204][config] Add description for missing options in the all jobmanager/taskmanager options section in document [flink]

2023-10-07 Thread via GitHub
X-czh opened a new pull request, #23493: URL: https://github.com/apache/flink/pull/23493 ## What is the purpose of the change & Brief change log Add description for missing options in the all jobmanager/taskmanager options section in document: 1. taskmanager.bind-host

Re: [PR] [FLINK-33205][config] Replace Akka with Pekko in the description of "pekko.ssl.enabled" [flink]

2023-10-07 Thread via GitHub
flinkbot commented on PR #23492: URL: https://github.com/apache/flink/pull/23492#issuecomment-1751927693 ## CI report: * 94af2a81881c2c9202d9dd52a0efd0042135a821 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33205) Replace Akka with Pekko in the description of "pekko.ssl.enabled"

2023-10-07 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772927#comment-17772927 ] Zhanghao Chen commented on FLINK-33205: --- [~chesnay] I've prepared a quick fix on it, could you

[jira] [Updated] (FLINK-33205) Replace Akka with Pekko in the description of "pekko.ssl.enabled"

2023-10-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33205: --- Labels: pull-request-available (was: ) > Replace Akka with Pekko in the description of

[PR] [FLINK-33205][config] Replace Akka with Pekko in the description of "pekko.ssl.enabled" [flink]

2023-10-07 Thread via GitHub
X-czh opened a new pull request, #23492: URL: https://github.com/apache/flink/pull/23492 ## What is the purpose of the change & Brief change log Replace Akka with Pekko in the description of "pekko.ssl.enabled" ## Verifying this change This change is a trivial

[jira] [Updated] (FLINK-33205) Replace Akka with Pekko in the description of "pekko.ssl.enabled"

2023-10-07 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-33205: -- Description: Current description: "Turns on SSL for Akka’s remote communication. This is

[jira] [Created] (FLINK-33205) Replace Akka with Pekko in the description of "pekko.ssl.enabled"

2023-10-07 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-33205: - Summary: Replace Akka with Pekko in the description of "pekko.ssl.enabled" Key: FLINK-33205 URL: https://issues.apache.org/jira/browse/FLINK-33205 Project: Flink

[jira] [Comment Edited] (FLINK-33109) Watermark alignment not applied after recovery from checkpoint

2023-10-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772920#comment-17772920 ] Rui Fan edited comment on FLINK-33109 at 10/8/23 4:50 AM: -- Hi [~YordanPavlov] ,

[jira] [Created] (FLINK-33204) Add description for missing options in the all jobmanager/taskmanager options section in document

2023-10-07 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-33204: - Summary: Add description for missing options in the all jobmanager/taskmanager options section in document Key: FLINK-33204 URL:

Re: [PR] [FLINK-15959][flink-runtime] Add min number of slots configuration to limit total number of slots [flink]

2023-10-07 Thread via GitHub
xiangyuf commented on PR #23201: URL: https://github.com/apache/flink/pull/23201#issuecomment-1751917326 > Thanks for the update, @xiangyuf , I left one comment, please take a look hi @huwh , I changed the variable name to `resourcesAvailable` and `resourcesInTotal` to represent

[jira] [Commented] (FLINK-33109) Watermark alignment not applied after recovery from checkpoint

2023-10-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772920#comment-17772920 ] Rui Fan commented on FLINK-33109: - Hi [~YordanPavlov] , I guess the bug has been fixed in 1.17.2 and

Re: [PR] [FLINK-33161] Java17 profile for benchmarking [flink-benchmarks]

2023-10-07 Thread via GitHub
Zakelly commented on code in PR #80: URL: https://github.com/apache/flink-benchmarks/pull/80#discussion_r1349620289 ## README.md: ## @@ -39,6 +39,12 @@ There're mainly three ways: ``` java -jar target/benchmarks.jar -rf csv "" ``` + +When using uber jar

Re: [PR] [FLINK-33161] Java17 profile for benchmarking [flink-benchmarks]

2023-10-07 Thread via GitHub
Zakelly commented on code in PR #80: URL: https://github.com/apache/flink-benchmarks/pull/80#discussion_r1349620289 ## README.md: ## @@ -39,6 +39,12 @@ There're mainly three ways: ``` java -jar target/benchmarks.jar -rf csv "" ``` + +When using uber jar

[jira] [Commented] (FLINK-33160) Log the remote address when an exception occurs in the PartitionRequestQueue

2023-10-07 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772916#comment-17772916 ] Weihua Hu commented on FLINK-33160: --- [~lsdy] makes sense to me, would you like prepare a PR for it? >

Re: [PR] [FLINK-33161] Java17 profile for benchmarking [flink-benchmarks]

2023-10-07 Thread via GitHub
fredia commented on code in PR #80: URL: https://github.com/apache/flink-benchmarks/pull/80#discussion_r1349611595 ## README.md: ## @@ -39,6 +39,12 @@ There're mainly three ways: ``` java -jar target/benchmarks.jar -rf csv "" ``` + +When using uber jar

Re: [PR] [FLINK-33033][olap][haservice] Add haservice micro benchmark for olap [flink-benchmarks]

2023-10-07 Thread via GitHub
KarmaGYZ commented on PR #78: URL: https://github.com/apache/flink-benchmarks/pull/78#issuecomment-1751898838 @XComp Would you like to give it a look? I believe this benchmark can provide some basis for FLINK-32667. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-28303] Support LatestOffsetsInitializer to avoid latest-offset strategy lose data [flink-connector-kafka]

2023-10-07 Thread via GitHub
Tan-JiaLiang commented on PR #52: URL: https://github.com/apache/flink-connector-kafka/pull/52#issuecomment-1751898387 @tzulitai Maybe this will lead to a new bug. Assume topic has 3 partitions, A/B/C tp=0: Write a record to each partitions. All of partitions get a new record. The

[PR] [FLINK-30768] flink-web version cleanup [flink-web]

2023-10-07 Thread via GitHub
victor9309 opened a new pull request, #683: URL: https://github.com/apache/flink-web/pull/683 ## What is the purpose of the change *update versions (through variables) and adding references that these variables have to be updated to the corresponding versions that

Re: [PR] [FLINK-15959][flink-runtime] Add min number of slots configuration to limit total number of slots [flink]

2023-10-07 Thread via GitHub
huwh commented on code in PR #23201: URL: https://github.com/apache/flink/pull/23201#discussion_r1349610727 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java: ## @@ -347,10 +367,26 @@ &&

[jira] [Commented] (FLINK-33174) enabling tablesample bernoulli in flink

2023-10-07 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772912#comment-17772912 ] Benchao Li commented on FLINK-33174: [~zhoujira86] Since this is a new feature, which can be seen as

[jira] [Commented] (FLINK-33171) Table SQL support Not Equal for TimePoint type and TimeString

2023-10-07 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772909#comment-17772909 ] Benchao Li commented on FLINK-33171: [~qingyue] Yes, CALCITE-5907 is not going to fix this, but will

[jira] [Comment Edited] (FLINK-33171) Table SQL support Not Equal for TimePoint type and TimeString

2023-10-07 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772907#comment-17772907 ] Jane Chan edited comment on FLINK-33171 at 10/8/23 1:57 AM: [~libenchao]

[jira] [Commented] (FLINK-33171) Table SQL support Not Equal for TimePoint type and TimeString

2023-10-07 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772907#comment-17772907 ] Jane Chan commented on FLINK-33171: --- [~libenchao] Correct me if I'm wrong, but I think this issue

Re: [PR] [FLINK-30768] flink-web version cleanup [flink-web]

2023-10-07 Thread via GitHub
victor9309 closed pull request #681: [FLINK-30768] flink-web version cleanup URL: https://github.com/apache/flink-web/pull/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-9631) use Files.createDirectories instead of directory.mkdirs

2023-10-07 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-9631: -- Labels: auto-deprioritized-minor auto-unassigned stale-assigned (was:

Re: [PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArhitectureTests [flink]

2023-10-07 Thread via GitHub
flinkbot commented on PR #23491: URL: https://github.com/apache/flink/pull/23491#issuecomment-1751843154 ## CI report: * ccd6ac5e2b5d3cb1b46fad260b183408d8e7d5d4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33199) ArchitectureTests should test for fully qualified class names instead of Class objects

2023-10-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33199: --- Labels: pull-request-available (was: ) > ArchitectureTests should test for fully qualified

[PR] [FLINK-33199][tests] Use fully qualified class names instead of Class objects in ArhitectureTests [flink]

2023-10-07 Thread via GitHub
afedulov opened a new pull request, #23491: URL: https://github.com/apache/flink/pull/23491 ## What is the purpose of the change Currently architecture tests rely on importing such classes as `MiniClusterExtension`. This introduces a production scope dependency on `flink-test-utils`

[jira] [Comment Edited] (FLINK-25823) Remove Mesos from Flink Landing page

2023-10-07 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772873#comment-17772873 ] Samrat Deb edited comment on FLINK-25823 at 10/7/23 8:05 PM: - Here's a brief

[jira] [Commented] (FLINK-25823) Remove Mesos from Flink Landing page

2023-10-07 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772873#comment-17772873 ] Samrat Deb commented on FLINK-25823: Here's a brief example of the importance of documentation: I

[jira] [Updated] (FLINK-25823) Remove Mesos from Flink Landing page

2023-10-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25823: --- Labels: pull-request-available (was: ) > Remove Mesos from Flink Landing page >

[PR] [FLINK-25823] Remove Mesos from flink Architecture documentation. [flink-web]

2023-10-07 Thread via GitHub
Samrat002 opened a new pull request, #682: URL: https://github.com/apache/flink-web/pull/682 Mesos support in Flink is removed as part of [FLINK-23118](https://issues.apache.org/jira/browse/FLINK-23118). But currently in Flink Architecture page

[jira] [Commented] (FLINK-31278) exit code 137 (i.e. OutOfMemoryError) in core module

2023-10-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772852#comment-17772852 ] Alexander Fedulov commented on FLINK-31278: ---

[jira] [Commented] (FLINK-31278) exit code 137 (i.e. OutOfMemoryError) in core module

2023-10-07 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772849#comment-17772849 ] Alexander Fedulov commented on FLINK-31278: ---

Re: [PR] [FLINK-32650][protobuf]Added the ability to split flink-protobuf code… [flink]

2023-10-07 Thread via GitHub
maosuhan commented on code in PR #23162: URL: https://github.com/apache/flink/pull/23162#discussion_r1349534268 ## flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/BigProtoBufCodeSpiltterTest.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-33174) enabling tablesample bernoulli in flink

2023-10-07 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772820#comment-17772820 ] xiaogang zhou commented on FLINK-33174: --- [~libenchao] Hi Benchao, Would you please assign the

[jira] [Commented] (FLINK-33171) Table SQL support Not Equal for TimePoint type and TimeString

2023-10-07 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772803#comment-17772803 ] Benchao Li commented on FLINK-33171: Since Flink does not support implicit casting yet, I would

[jira] [Commented] (FLINK-33174) enabling tablesample bernoulli in flink

2023-10-07 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772801#comment-17772801 ] Benchao Li commented on FLINK-33174: It sounds good to me. Since Calcite has supported this syntax

Re: [PR] [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler [flink]

2023-10-07 Thread via GitHub
1996fanrui commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1349504826 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -67,13 +77,33 @@ class Executing extends StateWithExecutionGraph

Re: [PR] [FLINK-20886] Support printing the thread dump when checkpoint expired [flink]

2023-10-07 Thread via GitHub
Myasuka commented on code in PR #23347: URL: https://github.com/apache/flink/pull/23347#discussion_r1349497297 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointExpiredThreadDumper.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software

[PR] FLINK-30768 flink-web version cleanup [flink-web]

2023-10-07 Thread via GitHub
victor9309 opened a new pull request, #681: URL: https://github.com/apache/flink-web/pull/681 ## What is the purpose of the change *update versions (through variables) and adding references that these variables have to be updated to the corresponding versions that used in

[jira] [Updated] (FLINK-30768) flink-web version cleanup

2023-10-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30768: --- Labels: auto-deprioritized-major pull-request-available starter (was:

Re: [PR] FLINK-30768 flink-web version cleanup [flink-web]

2023-10-07 Thread via GitHub
victor9309 closed pull request #675: FLINK-30768 flink-web version cleanup URL: https://github.com/apache/flink-web/pull/675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (FLINK-33171) Table SQL support Not Equal for TimePoint type and TimeString

2023-10-07 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772771#comment-17772771 ] Jane Chan commented on FLINK-33171: --- Thanks for reporting this issue. I can help to review. > Table

[jira] [Closed] (FLINK-32985) Support setting env.java.opts.sql-gateway to specify the jvm opts for sql gateway

2023-10-07 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo closed FLINK-32985. -- Resolution: Duplicate > Support setting env.java.opts.sql-gateway to specify the jvm opts for sql >

[jira] [Updated] (FLINK-33203) FLIP-374: Adding a separate configuration for specifying Java Options of the SQL Gateway

2023-10-07 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo updated FLINK-33203: --- Parent: FLINK-32898 Issue Type: Sub-task (was: Improvement) > FLIP-374: Adding a separate

[jira] [Updated] (FLINK-20886) Add the option to get a threaddump on checkpoint timeouts

2023-10-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-20886: --- Labels: auto-deprioritized-major auto-deprioritized-minor pull-request-available

Re: [PR] [FLINK-20886] Support printing the thread dump when checkpoint expired [flink]

2023-10-07 Thread via GitHub
Zakelly commented on PR #23347: URL: https://github.com/apache/flink/pull/23347#issuecomment-1751636305 @Myasuka Could you please review this implementation? Alternatively, I am open to exploring another approach. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (FLINK-33203) FLIP-374: Adding a separate configuration for specifying Java Options of the SQL Gateway

2023-10-07 Thread Yangze Guo (Jira)
Yangze Guo created FLINK-33203: -- Summary: FLIP-374: Adding a separate configuration for specifying Java Options of the SQL Gateway Key: FLINK-33203 URL: https://issues.apache.org/jira/browse/FLINK-33203

[jira] [Commented] (FLINK-32006) AsyncWaitOperatorTest.testProcessingTimeWithTimeoutFunctionOrderedWithRetry times out on Azure

2023-10-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772761#comment-17772761 ] Sergey Nuyanzin commented on FLINK-32006: - set to critical since it is reproduced again >

[jira] [Updated] (FLINK-32006) AsyncWaitOperatorTest.testProcessingTimeWithTimeoutFunctionOrderedWithRetry times out on Azure

2023-10-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-32006: Priority: Critical (was: Major) >

Re: [PR] [FLINK-32006] Harden and speed up AsyncWaitOperatorTest#testProcessingTimeAlwaysTimeoutFunctionWithRetry [flink]

2023-10-07 Thread via GitHub
snuyanzin commented on PR #22523: URL: https://github.com/apache/flink/pull/22523#issuecomment-1751629057 @dmvk could you please take a look here? I'm asking since it is reproduced for the latest nightly 1.18 and potentially could be a blocker as it was introduced in 1.18 -- This is

[jira] [Commented] (FLINK-32006) AsyncWaitOperatorTest.testProcessingTimeWithTimeoutFunctionOrderedWithRetry times out on Azure

2023-10-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772759#comment-17772759 ] Sergey Nuyanzin commented on FLINK-32006: -

Re: [PR] [FLINK-33161] Java17 profile for benchmarking [flink-benchmarks]

2023-10-07 Thread via GitHub
Zakelly commented on PR #80: URL: https://github.com/apache/flink-benchmarks/pull/80#issuecomment-1751624381 I'm not sure if I have the right person, @pnowojski , but would you please review this one? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-33060] Fix the javadoc of ListState interfaces about not allowing null value [flink]

2023-10-07 Thread via GitHub
Zakelly commented on code in PR #23441: URL: https://github.com/apache/flink/pull/23441#discussion_r1349473352 ## flink-core/src/main/java/org/apache/flink/api/common/state/AppendingState.java: ## @@ -60,8 +60,11 @@ public interface AppendingState extends State { *

[jira] [Created] (FLINK-33202) FLIP-327: Support switching from batch to stream mode to improve throughput when processing backlog data

2023-10-07 Thread Xuannan Su (Jira)
Xuannan Su created FLINK-33202: -- Summary: FLIP-327: Support switching from batch to stream mode to improve throughput when processing backlog data Key: FLINK-33202 URL: