Re: [PR] [FLINK-33592]Modified the return type of the method, make it more convenient to use. [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23750: URL: https://github.com/apache/flink/pull/23750#issuecomment-1817420288 ## CI report: * 4d1c18402ded7421609ac8dad28f5978082d067b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33592) The return type of the function is void,not convenient to use

2023-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33592: --- Labels: pull-request-available (was: ) > The return type of the function is void,not

[PR] [FLINK-33592]Modified the return type of the method, make it more convenient to use. [flink]

2023-11-17 Thread via GitHub
Tao-Zhang9876 opened a new pull request, #23750: URL: https://github.com/apache/flink/pull/23750 ## What is the purpose of the change Modify the method return type from void to StreamExecutionEnvironment. ## Brief change log - Modify the return type.

[jira] [Created] (FLINK-33592) The return type of the function is void,not convenient to use

2023-11-17 Thread ZhangTao (Jira)
ZhangTao created FLINK-33592: Summary: The return type of the function is void,not convenient to use Key: FLINK-33592 URL: https://issues.apache.org/jira/browse/FLINK-33592 Project: Flink Issue

Re: [PR] [FLINK-33588][Flink-Runtime] Fix NullArgumentException in DescriptiveStatisticsHistogramStatistics [flink]

2023-11-17 Thread via GitHub
qinping416 commented on PR #23749: URL: https://github.com/apache/flink/pull/23749#issuecomment-1817400787 This change improves the robustness of the system -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33588][Flink-Runtime] Fix NullArgumentException in DescriptiveStatisticsHistogramStatistics [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23749: URL: https://github.com/apache/flink/pull/23749#issuecomment-1817372850 ## CI report: * 7a77058fb34170e82ffa9ee3463c22a04cc9e702 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-11-17 Thread Tongtong Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787450#comment-17787450 ] Tongtong Zhu commented on FLINK-33588: -- This submission greatly contributes to the stability of

[jira] [Updated] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-11-17 Thread Tongtong Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tongtong Zhu updated FLINK-33588: - Priority: Critical (was: Major) > Fix Flink Checkpointing Statistics Bug >

[jira] [Updated] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-11-17 Thread Tongtong Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tongtong Zhu updated FLINK-33588: - Attachment: FLINK-33588.patch > Fix Flink Checkpointing Statistics Bug >

[jira] [Updated] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33588: --- Labels: pull-request-available (was: ) > Fix Flink Checkpointing Statistics Bug >

[PR] [FLINK-33588][Flink-Runtime] Fix NullArgumentException in DescriptiveStatisticsHistogramStatistics [flink]

2023-11-17 Thread via GitHub
zhutong6688 opened a new pull request, #23749: URL: https://github.com/apache/flink/pull/23749 ## What is the purpose of the change Fix NullArgumentException of getQuantile method in DescriptiveStatisticsHistogramStatistics ## Brief change log This

[jira] [Updated] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-11-17 Thread Tongtong Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tongtong Zhu updated FLINK-33588: - Flags: Patch,Important Language: java Description: When the Flink task is

[jira] [Updated] (FLINK-33591) Cleanup usage of deprecated TableTestBase#addFunction

2023-11-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33591: Description: I would say it is a subtask of cleaning up for

Re: [PR] [FLINK-33597][table] Cleanup usage of deprecated TableTestBase#addFunction [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23748: URL: https://github.com/apache/flink/pull/23748#issuecomment-1817330805 ## CI report: * 6b5bca01a28f370b0048200eb8204b51279a67b1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33597][table] Cleanup usage of deprecated TableTestBase#addFunction [flink]

2023-11-17 Thread via GitHub
snuyanzin opened a new pull request, #23748: URL: https://github.com/apache/flink/pull/23748 ## What is the purpose of the change Removes the usage of the deprecated method `TableTestBase#addFunction` ## Brief change log Replace the usage of

[jira] [Updated] (FLINK-33591) Cleanup usage of deprecated TableTestBase#addFunction

2023-11-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33591: Summary: Cleanup usage of deprecated TableTestBase#addFunction (was: Cleanup ysage of

[jira] [Created] (FLINK-33591) Cleanup ysage of deprecated TableTestBase#addFunction

2023-11-17 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33591: --- Summary: Cleanup ysage of deprecated TableTestBase#addFunction Key: FLINK-33591 URL: https://issues.apache.org/jira/browse/FLINK-33591 Project: Flink

Re: [PR] [FLINK-33587][docs] Tidy up docs around JDBC [flink]

2023-11-17 Thread via GitHub
snuyanzin commented on PR #23743: URL: https://github.com/apache/flink/pull/23743#issuecomment-1817267362 thanks for the contribution i would have several questions > Put SQLLine first since Beeline is perhaps less likely to be used outside of a Hive context. there is a

[jira] [Assigned] (FLINK-30064) Move existing Hive connector code from Flink repo to dedicated Hive repo

2023-11-17 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-30064: --- Assignee: Sergey Nuyanzin > Move existing Hive connector code from Flink repo to

Re: [PR] [FLINK-33587][docs] Tidy up docs around JDBC [flink]

2023-11-17 Thread via GitHub
snuyanzin commented on code in PR #23743: URL: https://github.com/apache/flink/pull/23743#discussion_r1397996410 ## docs/content/docs/dev/table/jdbcDriver.md: ## @@ -51,16 +55,79 @@ You can also add dependency of Flink JDBC driver in your maven or gradle project ```

Re: [PR] [FLINK-33587][docs] Tidy up docs around JDBC [flink]

2023-11-17 Thread via GitHub
snuyanzin commented on code in PR #23743: URL: https://github.com/apache/flink/pull/23743#discussion_r1397996410 ## docs/content/docs/dev/table/jdbcDriver.md: ## @@ -51,16 +55,79 @@ You can also add dependency of Flink JDBC driver in your maven or gradle project ```

[PR] [hotfix][docs] Fix identifier collision causing coflict when switching between tabs in kinesis connector docs [flink-connector-aws]

2023-11-17 Thread via GitHub
z3d1k opened a new pull request, #117: URL: https://github.com/apache/flink-connector-aws/pull/117 ## Purpose of the change Resolve uid collision between 2 tab containers in Kinesis connector doc to fix behavior when switching between tabs: currently top container

[PR] [hotfix][docs] Fix identifier collision causing coflict when switching between tabs in kinesis connector docs [flink-connector-aws]

2023-11-17 Thread via GitHub
z3d1k opened a new pull request, #116: URL: https://github.com/apache/flink-connector-aws/pull/116 ## Purpose of the change Resolve uid collision between 2 tab containers in Kinesis connector doc to fix behavior when switching between tabs: currently top container

[jira] [Updated] (FLINK-33504) Supported maximum parallel jobs

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33504: -- Description: {quote}Up to 10 free Microsoft-hosted parallel jobs that can run for up to 360

[jira] [Updated] (FLINK-33589) Fix broken documentation page for Kinesis connector

2023-11-17 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-33589: -- Description: Recent change in connector version declaration in docs (FLINK-33567) resulted

[jira] [Commented] (FLINK-33589) Fix broken documentation page for Kinesis connector

2023-11-17 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787413#comment-17787413 ] Danny Cranmer commented on FLINK-33589: --- Merged commit

[jira] [Commented] (FLINK-33589) Fix broken documentation page for Kinesis connector

2023-11-17 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787414#comment-17787414 ] Danny Cranmer commented on FLINK-33589: --- Triggered docs build > Fix broken documentation page for

Re: [PR] [FLINK-33589][docs] Fix connector_artifact to prevent generation of broken layout [flink]

2023-11-17 Thread via GitHub
dannycranmer merged PR #23747: URL: https://github.com/apache/flink/pull/23747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33589][docs] Fix connector_artifact to prevent generation of broken layout [flink]

2023-11-17 Thread via GitHub
dannycranmer merged PR #23746: URL: https://github.com/apache/flink/pull/23746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33589][docs] Fix connector_artifact to prevent generation of broken layout [flink]

2023-11-17 Thread via GitHub
dannycranmer merged PR #23745: URL: https://github.com/apache/flink/pull/23745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-33589) Fix broken documentation page for Kinesis connector

2023-11-17 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-33589: - Assignee: Aleksandr Pilipenko > Fix broken documentation page for Kinesis connector >

Re: [PR] [FLINK-33589][docs] Fix connector_artifact to prevent generation of broken layout [flink]

2023-11-17 Thread via GitHub
dannycranmer merged PR #23744: URL: https://github.com/apache/flink/pull/23744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-33590) CheckpointStatsTracker.totalNumberOfSubTasks not updated

2023-11-17 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-33590: -- Component/s: (was: Runtime / Checkpointing) (was: Runtime /

[jira] [Updated] (FLINK-33590) CheckpointStatsTracker.totalNumberOfSubTasks not updated

2023-11-17 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-33590: -- Affects Version/s: (was: 1.18.0) (was: 1.19.0) >

[jira] [Closed] (FLINK-33590) CheckpointStatsTracker.totalNumberOfSubTasks not updated

2023-11-17 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan closed FLINK-33590. - Fix Version/s: (was: 1.19.0) (was: 1.18.1) Assignee:

[jira] [Updated] (FLINK-33590) CheckpointStatsTracker.totalNumberOfSubTasks not updated

2023-11-17 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-33590: -- Affects Version/s: 1.19.0 > CheckpointStatsTracker.totalNumberOfSubTasks not updated

[jira] [Updated] (FLINK-33590) CheckpointStatsTracker.totalNumberOfSubTasks not updated

2023-11-17 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-33590: -- Fix Version/s: 1.19.0 > CheckpointStatsTracker.totalNumberOfSubTasks not updated >

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-17 Thread via GitHub
eskabetxe commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397897431 ## pom.xml: ## @@ -315,6 +322,20 @@ under the License. 1.12.10 + + +

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-17 Thread via GitHub
maver1ck commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397884392 ## pom.xml: ## @@ -315,6 +322,20 @@ under the License. 1.12.10 + + +

[jira] [Commented] (FLINK-33567) Flink documentation should only display connector downloads links when a connector is available

2023-11-17 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787367#comment-17787367 ] Mason Chen commented on FLINK-33567: [~martijnvisser] thanks for fixing this! > Flink documentation

[jira] [Created] (FLINK-33590) CheckpointStatsTracker.totalNumberOfSubTasks not updated

2023-11-17 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-33590: - Summary: CheckpointStatsTracker.totalNumberOfSubTasks not updated Key: FLINK-33590 URL: https://issues.apache.org/jira/browse/FLINK-33590 Project: Flink

Re: [PR] [FLINK-33589][docs] Fix connector_artifact to prevent generation of broken layout [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23747: URL: https://github.com/apache/flink/pull/23747#issuecomment-1816932217 ## CI report: * 9e7b00ce80f7d02b45cff5231bc6b34a6a40742e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33589][docs] Fix connector_artifact to prevent generation of broken layout [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23746: URL: https://github.com/apache/flink/pull/23746#issuecomment-1816932029 ## CI report: * 9a32cc99b8c7ad8ebad88dfc9acbf20965aacaea UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33589][docs] Fix connector_artifact to prevent generation of broken layout [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23745: URL: https://github.com/apache/flink/pull/23745#issuecomment-1816931901 ## CI report: * 6cd5b5220ec298263a6ab8cd04b58ec5cb5288a5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33589) Fix broken documentation page for Kinesis connector

2023-11-17 Thread Aleksandr Pilipenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787353#comment-17787353 ] Aleksandr Pilipenko commented on FLINK-33589: - cc [~martijnvisser] > Fix broken

[PR] [FLINK-33589][docs] Fix connector_artifact to prevent generation of broken layout [flink]

2023-11-17 Thread via GitHub
z3d1k opened a new pull request, #23747: URL: https://github.com/apache/flink/pull/23747 ## What is the purpose of the change Fix issue in `connector_artifact` shortcode causing generation of corrupted layout when used in combination with `tabs`. ## Brief change

Re: [PR] [FLINK-33589][docs] Fix connector_artifact to prevent generation of broken layout [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23744: URL: https://github.com/apache/flink/pull/23744#issuecomment-1816925442 ## CI report: * 6c76616eb0cd915c71eb01633a2f766b0bee2752 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33589][docs] Fix connector_artifact to prevent generation of broken layout [flink]

2023-11-17 Thread via GitHub
z3d1k opened a new pull request, #23746: URL: https://github.com/apache/flink/pull/23746 ## What is the purpose of the change Fix issue in `connector_artifact` shortcode causing generation of corrupted layout when used in combination with `tabs`. ## Brief change

[PR] [FLINK-33589][docs] Fix connector_artifact to prevent generation of broken layout [flink]

2023-11-17 Thread via GitHub
z3d1k opened a new pull request, #23745: URL: https://github.com/apache/flink/pull/23745 ## What is the purpose of the change Fix issue in `connector_artifact` shortcode causing generation of corrupted layout when used in combination with `tabs`. ## Brief change

[jira] [Updated] (FLINK-33589) Fix broken documentation page for Kinesis connector

2023-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33589: --- Labels: pull-request-available (was: ) > Fix broken documentation page for Kinesis

[PR] [FLINK-33589] Fix connector_artifact to prevent generation of broken layout [flink]

2023-11-17 Thread via GitHub
z3d1k opened a new pull request, #23744: URL: https://github.com/apache/flink/pull/23744 ## What is the purpose of the change Fix issue in `connector_artifact` shortcode causing generation of corrupted layout when used in combination with `tabs`. ## Brief change

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-11-17 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1397712701 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,200 @@ +/* +

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-11-17 Thread via GitHub
afedulov commented on code in PR #23553: URL: https://github.com/apache/flink/pull/23553#discussion_r1397712701 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/functions/FromElementsGeneratorFunction.java: ## @@ -0,0 +1,200 @@ +/* +

[jira] [Created] (FLINK-33589) Fix broken documentation page for Kinesis connector

2023-11-17 Thread Aleksandr Pilipenko (Jira)
Aleksandr Pilipenko created FLINK-33589: --- Summary: Fix broken documentation page for Kinesis connector Key: FLINK-33589 URL: https://issues.apache.org/jira/browse/FLINK-33589 Project: Flink

[jira] [Created] (FLINK-33588) Fix Flink Checkpointing Statistics Bug

2023-11-17 Thread Tongtong Zhu (Jira)
Tongtong Zhu created FLINK-33588: Summary: Fix Flink Checkpointing Statistics Bug Key: FLINK-33588 URL: https://issues.apache.org/jira/browse/FLINK-33588 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2023-11-17 Thread via GitHub
eskabetxe commented on code in PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1397647438 ## flink-connector-jdbc/pom.xml: ## @@ -38,10 +38,12 @@ under the License. 2.12 2.12.7 3.23.1 +

Re: [PR] [FLINK-33587][docs] Tidy up docs around JDBC [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23743: URL: https://github.com/apache/flink/pull/23743#issuecomment-1816772920 ## CI report: * 940465d9294f4cbc4e64b06610bfe7d47a6a1ee7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33587) Tidy up docs around JDBC

2023-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33587: --- Labels: pull-request-available (was: ) > Tidy up docs around JDBC >

[PR] [FLINK-33587][docs] Tidy up docs around JDBC [flink]

2023-11-17 Thread via GitHub
rmoff opened a new pull request, #23743: URL: https://github.com/apache/flink/pull/23743 ## What is the purpose of the change In writing a [recent blog](https://rmoff.net/2023/11/16/learning-apache-flink-s01e06-the-flink-jdbc-driver/) I struggled with the docs somewhat. This is a PR

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1816718098 @snuyanzin I have this test working locally. Actually the plan test would not have shown this error - as it does not have the filter in it. The way the pushdown predicate

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1816695021 > well from my point of view lack of such test in `JdbcTablePlanTest` was one of the root causes of this issue i would vote for having this, may be even different joins

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-11-17 Thread via GitHub
snuyanzin commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1816663486 well from my point of view lack of such test in `JdbcTablePlanTest` was a root cause of this issue i would vote for having this, may be even different joins (inner, outer,

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-11-17 Thread via GitHub
afedulov commented on PR #23553: URL: https://github.com/apache/flink/pull/23553#issuecomment-1816655632 @zentol some thoughts: - I like the idea of exposing `fromData`. There is no good reason for both `fromElements` and and `fromCollection` methods to exist - they do the same thing

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1816649638 > can we also add a test to `org.apache.flink.connector.jdbc.table.JdbcTablePlanTest` to be sure that the execution plan is expected? I will have a look there are

[jira] [Commented] (FLINK-33462) Sort out the document page about the new Jdbc source.

2023-11-17 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787258#comment-17787258 ] david radley commented on FLINK-33462: -- I am curious what we intend to document here. the main

Re: [PR] [FLINK-30960] Fix a corner case oom error [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #77: URL: https://github.com/apache/flink-connector-jdbc/pull/77#discussion_r1397462056 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcOutputFormat.java: ## @@ -153,6 +153,16 @@ public void open(int

[jira] [Commented] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787253#comment-17787253 ] Matthias Pohl commented on FLINK-33502: --- You have to download the build artifacts for the

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1397421543 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-33550) "DataSet allround end-to-end test" failed due to certificate error

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787237#comment-17787237 ] Matthias Pohl commented on FLINK-33550: --- https://www.misterpki.com/java-keystore-pkcs12-legacy/ >

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1397421543 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/source/JdbcSource.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software

[jira] [Assigned] (FLINK-33587) Tidy up docs around JDBC

2023-11-17 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-33587: -- Assignee: Robin Moffatt > Tidy up docs around JDBC > > >

Re: [PR] [FLINK-29420][Build] Upgrade Zookeeper to 3.7.2 [flink]

2023-11-17 Thread via GitHub
Shreya11 commented on PR #23741: URL: https://github.com/apache/flink/pull/23741#issuecomment-1816524692 @MartijnVisser want to work on this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-17 Thread via GitHub
RocMarshal commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1397395729 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcInputFormat.java: ## @@ -99,7 +99,11 @@ * @see JdbcParameterValuesProvider *

Re: [PR] [FLINK-33340] Upgrade jackson from 2.14.3 to 2.15.3 [flink]

2023-11-17 Thread via GitHub
Shreya11 commented on PR #23742: URL: https://github.com/apache/flink/pull/23742#issuecomment-1816521711 @snuyanzin I want to work on this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (FLINK-33587) Tidy up docs around JDBC

2023-11-17 Thread Robin Moffatt (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Moffatt updated FLINK-33587: -- Description: The documentation around using JDBC with Flink is, IMHO, a bit disjointed and

[jira] [Created] (FLINK-33587) Tidy up docs around JDBC

2023-11-17 Thread Robin Moffatt (Jira)
Robin Moffatt created FLINK-33587: - Summary: Tidy up docs around JDBC Key: FLINK-33587 URL: https://issues.apache.org/jira/browse/FLINK-33587 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-11-17 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787224#comment-17787224 ] Wencong Liu commented on FLINK-33502: - Thank you for your reminder [~mapohl] . I would like to ask

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-17 Thread via GitHub
eskabetxe commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397338085 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: exactly, as this should be the

[jira] [Created] (FLINK-33586) Add GHA support in release-1.17 branch

2023-11-17 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33586: - Summary: Add GHA support in release-1.17 branch Key: FLINK-33586 URL: https://issues.apache.org/jira/browse/FLINK-33586 Project: Flink Issue Type:

Re: [PR] [FLINK-33340] Upgrade jackson from 2.14.3 to 2.15.3 [flink]

2023-11-17 Thread via GitHub
flinkbot commented on PR #23742: URL: https://github.com/apache/flink/pull/23742#issuecomment-1816445044 ## CI report: * c004ce1848a0623f3fbd12d63734e89c386db01e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33340] Upgrade jackson from 2.14.3 to 2.15.3 [flink]

2023-11-17 Thread via GitHub
snuyanzin opened a new pull request, #23742: URL: https://github.com/apache/flink/pull/23742 ## What is the purpose of the change The PR is to bump jackson to 2.15.3 ## Brief change log pom and NOTICE files ## Verifying this change This change is a

[jira] [Assigned] (FLINK-33006) Add e2e test for Kubernetes Operator HA

2023-11-17 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-33006: -- Assignee: Zhenqiu Huang > Add e2e test for Kubernetes Operator HA >

[jira] [Assigned] (FLINK-30529) Use simple cancel for savepoint upgrades on failing jobs

2023-11-17 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30529: -- Assignee: Zhenqiu Huang > Use simple cancel for savepoint upgrades on failing jobs >

[jira] (FLINK-28383) HDFS source: Trying to access closed classloader

2023-11-17 Thread gabrywu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28383 ] gabrywu deleted comment on FLINK-28383: - was (Author: gabry.wu): No, actually, it's caused by Configuration.CACHE_CLASSES > HDFS source: Trying to access closed classloader >

Re: [PR] [FLINK-33501][ci] Makes use of Maven wrapper [flink]

2023-11-17 Thread via GitHub
XComp commented on PR #23689: URL: https://github.com/apache/flink/pull/23689#issuecomment-1816379461 @zentol do you have any objections to that change? That would also enable us to remove Maven from the Docker ci image. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (FLINK-28383) HDFS source: Trying to access closed classloader

2023-11-17 Thread gabrywu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787186#comment-17787186 ] gabrywu commented on FLINK-28383: - No, actually, it's caused by Configuration.CACHE_CLASSES > HDFS

[jira] [Commented] (FLINK-33546) Implement type inference for order(asc/desc) function

2023-11-17 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787181#comment-17787181 ] Dawid Wysakowicz commented on FLINK-33546: -- [~jackylau] We can not cover it 100% in the API.

Re: [PR] [FLINK-33459][Connector/JDBC] Support the new source that keeps the same functionality as the original JDBC input format [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #78: URL: https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1397218900 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcInputFormat.java: ## @@ -99,7 +99,11 @@ * @see JdbcParameterValuesProvider *

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-17 Thread via GitHub
snuyanzin commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397216656 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: the minimum supported version

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397207308 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: I am wondering why the Flink

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397207308 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: I am wondering why the Flink

Re: [PR] [FLINK-33378] Prepare actions for flink version 1.18 [flink-connector-jdbc]

2023-11-17 Thread via GitHub
davidradl commented on code in PR #76: URL: https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1397207308 ## pom.xml: ## @@ -47,14 +47,14 @@ under the License. -1.17.0 +1.16.2 Review Comment: I am wondering why the Flink

Re: [PR] [FLINK-33568] Fix NullpointerException in SinkV2MetricsITCase [flink]

2023-11-17 Thread via GitHub
XComp commented on code in PR #23737: URL: https://github.com/apache/flink/pull/23737#discussion_r1397153112 ## flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SinkV2MetricsITCase.java: ## @@ -217,43 +215,41 @@ private void assertSinkMetrics(

[jira] [Commented] (FLINK-33578) Remove scala-2.12 system variable

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787166#comment-17787166 ] Matthias Pohl commented on FLINK-33578: --- No backport is necessary because omitting the system

[jira] [Resolved] (FLINK-33578) Remove scala-2.12 system variable

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-33578. --- Fix Version/s: 1.19.0 Resolution: Fixed master:

Re: [PR] [FLINK-33578][ci] Removes scala-2.12 system property [flink]

2023-11-17 Thread via GitHub
XComp merged PR #23738: URL: https://github.com/apache/flink/pull/23738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33568) SinkV2MetricsITCase.testCommitterMetrics fails with NullPointerException

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787160#comment-17787160 ] Matthias Pohl commented on FLINK-33568: ---

Re: [PR] [FLINK-33582] Upgrade to flink-shaded 16.2 [flink]

2023-11-17 Thread via GitHub
TanYuxin-tyx commented on PR #23739: URL: https://github.com/apache/flink/pull/23739#issuecomment-1816274599 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-33531) Nightly Python fails with NPE at metadataHandlerProvider on AZP (StreamDependencyTests.test_add_python_archive)

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787161#comment-17787161 ] Matthias Pohl commented on FLINK-33531: ---

[jira] [Commented] (FLINK-30703) PulsarOrderedPartitionSplitReaderTest>PulsarPartitionSplitReaderTestBase.consumeMessageCreatedBeforeHandleSplitsChangesAndResetToEarliestPosition fails

2023-11-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787157#comment-17787157 ] Matthias Pohl commented on FLINK-30703: --- 1.16:

  1   2   >