Re: [PR] [FLINK-32563] Allow to execute archunit tests only with Flink version that connectors were built against [flink-connector-shared-utils]

2023-11-20 Thread via GitHub
zentol commented on code in PR #23: URL: https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1400151224 ## pom.xml: ## @@ -48,7 +52,41 @@ under the License. flink-test-utils-junit ${flink.version}

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-20 Thread via GitHub
1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1400131195 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategy.java: ## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33598][k8s] Watch HA configmap via name instead of lables to reduce pressure on APIserver [flink]

2023-11-20 Thread via GitHub
gyfora commented on PR #23764: URL: https://github.com/apache/flink/pull/23764#issuecomment-1820384018 @Myasuka , I am a bit confused, you mention https://issues.apache.org/jira/browse/FLINK-24038 but I still see 2 `high-availability` configmaps for Flink 1.18 jobs -- This is an

Re: [PR] [FLINK-32997][table-planner][JUnit5 Migration] Module: flink-table-planner (StreamingTestBase) [flink]

2023-11-20 Thread via GitHub
leonardBang commented on code in PR #23330: URL: https://github.com/apache/flink/pull/23330#discussion_r1400089893 ## flink-table/flink-table-planner/src/test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension: ## @@ -0,0 +1,34 @@ +# +# Licensed to the Apache

Re: [PR] [FLINK-33581][core] Deprecate configuration getters/setters that return/set complex Java objects. [flink]

2023-11-20 Thread via GitHub
JunRuiLee commented on PR #23758: URL: https://github.com/apache/flink/pull/23758#issuecomment-1820325905 Hi @JingGe, Thanks for your feedback. I've updated the PR based on your comments. Looking forward to your thoughts on the changes. -- This is an automated message from the Apache

Re: [PR] [FLINK-33581][core] Deprecate configuration getters/setters that return/set complex Java objects. [flink]

2023-11-20 Thread via GitHub
JunRuiLee commented on code in PR #23758: URL: https://github.com/apache/flink/pull/23758#discussion_r1400089782 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java: ## @@ -759,9 +765,15 @@ public void

[jira] [Commented] (FLINK-33121) Failed precondition in JobExceptionsHandler due to concurrent global failures

2023-11-20 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788272#comment-17788272 ] Rui Fan commented on FLINK-33121: - Hey [~pgaref] , thanks for reporing this Jira and fixing it. :) I

Re: [PR] [FLINK-33581][core] Deprecate configuration getters/setters that return/set complex Java objects. [flink]

2023-11-20 Thread via GitHub
JunRuiLee commented on code in PR #23758: URL: https://github.com/apache/flink/pull/23758#discussion_r1400088967 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java: ## @@ -663,10 +663,16 @@ public CheckpointingMode

Re: [PR] [FLINK-33581][core] Deprecate configuration getters/setters that return/set complex Java objects. [flink]

2023-11-20 Thread via GitHub
JunRuiLee commented on code in PR #23758: URL: https://github.com/apache/flink/pull/23758#discussion_r1400088360 ## flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java: ## @@ -111,7 +118,17 @@ public static

[jira] [Commented] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-20 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788266#comment-17788266 ] xuyang commented on FLINK-33541: Maybe we should add the logic back in IfCallGen#generate. If we agree

Re: [PR] [hotfix][docs] Delete kafka connector docs [flink]

2023-11-20 Thread via GitHub
ruanhang1993 commented on PR #23628: URL: https://github.com/apache/flink/pull/23628#issuecomment-1820299986 > Hi @ruanhang1993, just out of curiosity, how will users find the kafka connector doc while they are reading docs on https://flink.apache.org/? Connector docs will be copied

[jira] [Comment Edited] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-20 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788263#comment-17788263 ] xuyang edited comment on FLINK-33541 at 11/21/23 6:07 AM: -- The root cause is

[jira] [Comment Edited] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-20 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788263#comment-17788263 ] xuyang edited comment on FLINK-33541 at 11/21/23 6:06 AM: -- The root cause is

[jira] [Comment Edited] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-20 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788263#comment-17788263 ] xuyang edited comment on FLINK-33541 at 11/21/23 6:05 AM: -- The root cause is

[jira] [Commented] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-20 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788263#comment-17788263 ] xuyang commented on FLINK-33541: The root cause is that in 1.14, the cast rule allow to cast from 'int'

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-11-20 Thread via GitHub
xiangforever2014 commented on PR #23253: URL: https://github.com/apache/flink/pull/23253#issuecomment-1820273335 @masteryhx Many thanks for your suggestion, and I have followed your advice to simplify the code. I have tested in my local machine, when triggering a detached savepoint, the

[jira] [Commented] (FLINK-33565) The concurrentExceptions doesn't work

2023-11-20 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788255#comment-17788255 ] Rui Fan commented on FLINK-33565: - Hi [~mapohl] , thanks for providing these background.:)

[jira] [Comment Edited] (FLINK-33490) Validate the name conflicts when creating view

2023-11-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788253#comment-17788253 ] Benchao Li edited comment on FLINK-33490 at 11/21/23 5:12 AM: -- I'm

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788253#comment-17788253 ] Benchao Li commented on FLINK-33490: I'm wondering what the expected behavior for ``` SELECT * FROM

Re: [PR] [FLINK-15571][connector][WIP] Redis Stream connector for Flink [flink-connector-redis-streams]

2023-11-20 Thread via GitHub
sazzad16 commented on PR #2: URL: https://github.com/apache/flink-connector-redis-streams/pull/2#issuecomment-1820248466 @Amitgb14 Well, that was the initial plan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (FLINK-33600) Print cost time for batch queries in SQL Client

2023-11-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788252#comment-17788252 ] Benchao Li commented on FLINK-33600: +1 > Print cost time for batch queries in SQL Client >

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788250#comment-17788250 ] Benchao Li commented on FLINK-33365: [~davidradl] Is the PR ready to review now? Since we've reached

Re: [PR] [FLINK-33485][table] Optimize exists subqueries by looking at metadata rowcount [flink]

2023-11-20 Thread via GitHub
libenchao commented on code in PR #23685: URL: https://github.com/apache/flink/pull/23685#discussion_r1400021264 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/FlinkSubQueryRemoveRule.scala: ## @@ -216,6 +216,18 @@ class

Re: [PR] [FLINK-32622][table-planner] Optimize mini-batch assignment [flink]

2023-11-20 Thread via GitHub
xuyangzhong commented on code in PR #23470: URL: https://github.com/apache/flink/pull/23470#discussion_r148054 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/StreamCommonSubGraphBasedOptimizer.scala: ## @@ -50,14 +51,23 @@

Re: [PR] [FLINK-33598][k8s] Watch HA configmap via name instead of lables to reduce pressure on APIserver [flink]

2023-11-20 Thread via GitHub
flinkbot commented on PR #23764: URL: https://github.com/apache/flink/pull/23764#issuecomment-1820212100 ## CI report: * 1b5c0d16c60d1470ef2874238035f5cc2c39e1d6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33598][k8s] Watch HA configmap via name instead of lables to reduce pressure on APIserver [flink]

2023-11-20 Thread via GitHub
Myasuka commented on PR #23764: URL: https://github.com/apache/flink/pull/23764#issuecomment-1820210514 @wangyang0918 @dmvk @gyfora could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-33598) Watch HA configmap via name instead of lables to reduce pressure on APIserver

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33598: --- Labels: pull-request-available (was: ) > Watch HA configmap via name instead of lables to

[PR] [FLINK-33598][k8s] Watch HA configmap via name instead of lables to reduce pressure on APIserver [flink]

2023-11-20 Thread via GitHub
Myasuka opened a new pull request, #23764: URL: https://github.com/apache/flink/pull/23764 ## What is the purpose of the change As [FLINK-24819](https://issues.apache.org/jira/browse/FLINK-24819) described, the k8s API server would receive more pressure when HA is enabled, due to

[jira] [Comment Edited] (FLINK-33519) standalone mode could not create keytab secret

2023-11-20 Thread chaoran.su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788241#comment-17788241 ] chaoran.su edited comment on FLINK-33519 at 11/21/23 3:51 AM: -- actually,

[jira] [Commented] (FLINK-33519) standalone mode could not create keytab secret

2023-11-20 Thread chaoran.su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788241#comment-17788241 ] chaoran.su commented on FLINK-33519: actually, this is because of flink-kubernetes lib's logic,

Re: [PR] [FLINK-31631][FileSystems] shade guava in gs-fs filesystem [flink]

2023-11-20 Thread via GitHub
jayadeep-jayaraman commented on PR #23489: URL: https://github.com/apache/flink/pull/23489#issuecomment-1820164156 Created [FLINK-33603](https://issues.apache.org/jira/browse/FLINK-33603) for this issue. @singhravidutt - can you please update the JIRA request number -- This is an

Re: [PR] [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction [flink]

2023-11-20 Thread via GitHub
LadyForest commented on code in PR #23751: URL: https://github.com/apache/flink/pull/23751#discussion_r1399931555 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/OverAggregateITCase.scala: ## @@ -22,14 +22,16 @@ import

[jira] [Created] (FLINK-33603) Fix guava shading for GCS connector

2023-11-20 Thread Jayadeep Jayaraman (Jira)
Jayadeep Jayaraman created FLINK-33603: -- Summary: Fix guava shading for GCS connector Key: FLINK-33603 URL: https://issues.apache.org/jira/browse/FLINK-33603 Project: Flink Issue Type:

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-11-20 Thread via GitHub
xiangforever2014 commented on PR #23253: URL: https://github.com/apache/flink/pull/23253#issuecomment-1820158718 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-29420][Build] Upgrade Zookeeper to 3.7.2 [flink]

2023-11-20 Thread via GitHub
TanYuxin-tyx commented on PR #23741: URL: https://github.com/apache/flink/pull/23741#issuecomment-1820119109 @MartijnVisser I took a look. It seems that the failed reason is that version 3.7.2 of flink-shaded-zookeeper-3 has not been

[jira] [Commented] (FLINK-33582) Update flink-shaded version

2023-11-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788226#comment-17788226 ] Weijie Guo commented on FLINK-33582: release-1.16 via cef22667ae65fb6fda78f22a05a8ca91540af687. >

[jira] [Updated] (FLINK-33582) Update flink-shaded version

2023-11-20 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-33582: -- Affects Version/s: 1.17.3 (was: 1.17.2) > Update flink-shaded version >

[jira] [Closed] (FLINK-33582) Update flink-shaded version

2023-11-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-33582. -- Resolution: Fixed > Update flink-shaded version > --- > >

[jira] [Updated] (FLINK-33582) Update flink-shaded version

2023-11-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33582: --- Fix Version/s: 1.17.3 > Update flink-shaded version > --- > >

Re: [PR] [FLINK-33582] Upgrade to flink-shaded 16.2 [flink]

2023-11-20 Thread via GitHub
reswqa merged PR #23739: URL: https://github.com/apache/flink/pull/23739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33582] Upgrade to flink-shaded 16.2 [flink]

2023-11-20 Thread via GitHub
TanYuxin-tyx commented on PR #23739: URL: https://github.com/apache/flink/pull/23739#issuecomment-1820100146 @JingGe Thanks for taking a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33340] Upgrade jackson from 2.14.3 to 2.15.3 [flink]

2023-11-20 Thread via GitHub
TanYuxin-tyx commented on PR #23742: URL: https://github.com/apache/flink/pull/23742#issuecomment-1820092696 OK. Thanks for the explanation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Closed] (FLINK-33593) Left title bar of the official documentation for the master branch is misaligned

2023-11-20 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu closed FLINK-33593. - Resolution: Duplicate > Left title bar of the official documentation for the master branch is >

[jira] [Commented] (FLINK-33600) Print cost time for batch queries in SQL Client

2023-11-20 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788217#comment-17788217 ] dalongliu commented on FLINK-33600: --- +1, it seems very userful. > Print cost time for batch queries

[jira] [Created] (FLINK-33602) Pulsar connector should be compatible with Flink 1.18

2023-11-20 Thread Zili Chen (Jira)
Zili Chen created FLINK-33602: - Summary: Pulsar connector should be compatible with Flink 1.18 Key: FLINK-33602 URL: https://issues.apache.org/jira/browse/FLINK-33602 Project: Flink Issue Type:

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-11-20 Thread via GitHub
afedulov commented on PR #23553: URL: https://github.com/apache/flink/pull/23553#issuecomment-1820017623 @zentol CI is green again after the discussed API changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Closed] (FLINK-27882) [JUnit5 Migration] Module: flink-scala

2023-11-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-27882. --- > [JUnit5 Migration] Module: flink-scala > -- > >

[jira] [Resolved] (FLINK-27882) [JUnit5 Migration] Module: flink-scala

2023-11-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-27882. - Fix Version/s: 1.19.0 Resolution: Fixed > [JUnit5 Migration] Module: flink-scala

[jira] [Commented] (FLINK-27882) [JUnit5 Migration] Module: flink-scala

2023-11-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788182#comment-17788182 ] Sergey Nuyanzin commented on FLINK-27882: - Merged as

Re: [PR] [FLINK-27882][tests][table] Migrate flink-scala to JUnit5 [flink]

2023-11-20 Thread via GitHub
snuyanzin merged PR #19870: URL: https://github.com/apache/flink/pull/19870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-27882][tests][table] Migrate flink-scala to JUnit5 [flink]

2023-11-20 Thread via GitHub
snuyanzin commented on PR #19870: URL: https://github.com/apache/flink/pull/19870#issuecomment-1819959684 thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33601] Implement restore tests for Expand node [flink]

2023-11-20 Thread via GitHub
flinkbot commented on PR #23763: URL: https://github.com/apache/flink/pull/23763#issuecomment-1819953555 ## CI report: * 766035eb44ecd06a512f03fc25ca71fc122d821a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33601] Implement restore tests for Expand node [flink]

2023-11-20 Thread via GitHub
jnh5y opened a new pull request, #23763: URL: https://github.com/apache/flink/pull/23763 ## What is the purpose of the change Implement restore tests for Expand node ## Verifying this change This change added tests and can be verified as follows: * Added restore

[jira] [Updated] (FLINK-33601) Implement restore tests for Expand node

2023-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33601: --- Labels: pull-request-available (was: ) > Implement restore tests for Expand node >

[jira] [Created] (FLINK-33601) Implement restore tests for Expand node

2023-11-20 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33601: -- Summary: Implement restore tests for Expand node Key: FLINK-33601 URL: https://issues.apache.org/jira/browse/FLINK-33601 Project: Flink Issue Type: Sub-task

[jira] [Assigned] (FLINK-33601) Implement restore tests for Expand node

2023-11-20 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Hughes reassigned FLINK-33601: -- Assignee: Jim Hughes > Implement restore tests for Expand node >

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-20 Thread via GitHub
bvarghese1 commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1399839325 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java: ## @@ -222,7 +249,15 @@ void

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-20 Thread via GitHub
bvarghese1 commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1399843416 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/GroupWindowAggregateTestPrograms.java: ## @@ -0,0 +1,256 @@

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-20 Thread via GitHub
bvarghese1 commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1399839325 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java: ## @@ -222,7 +249,15 @@ void

Re: [PR] [FLINK-15571][connector][WIP] Redis Stream connector for Flink [flink-connector-redis-streams]

2023-11-20 Thread via GitHub
Amitgb14 commented on PR #2: URL: https://github.com/apache/flink-connector-redis-streams/pull/2#issuecomment-1819926173 Hi @sazzad16 , is there this going to support Redis Cluster? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-11-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788171#comment-17788171 ] Sergey Nuyanzin commented on FLINK-33502: -

Re: [PR] [FLINK-32622][table-planner] Optimize mini-batch assignment [flink]

2023-11-20 Thread via GitHub
JingGe commented on code in PR #23470: URL: https://github.com/apache/flink/pull/23470#discussion_r1399813069 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/StreamCommonSubGraphBasedOptimizer.scala: ## @@ -50,14 +51,23 @@ class

[jira] [Resolved] (FLINK-33456) Upgrade maven-shade-plugin to 3.5.1

2023-11-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33456. - Fix Version/s: 1.19.0 Resolution: Fixed > Upgrade maven-shade-plugin to 3.5.1 >

[jira] [Commented] (FLINK-33456) Upgrade maven-shade-plugin to 3.5.1

2023-11-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788164#comment-17788164 ] Sergey Nuyanzin commented on FLINK-33456: - Merged as

[jira] [Closed] (FLINK-33456) Upgrade maven-shade-plugin to 3.5.1

2023-11-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33456. --- > Upgrade maven-shade-plugin to 3.5.1 > --- > >

Re: [PR] [FLINK-33456] Upgrade maven-shade-plugin to 3.5.1 to support jdk20+ [flink]

2023-11-20 Thread via GitHub
snuyanzin merged PR #23661: URL: https://github.com/apache/flink/pull/23661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-32918][release] Generate reference data for state migration tests based on release-1.18.0 [flink]

2023-11-20 Thread via GitHub
snuyanzin commented on PR #23710: URL: https://github.com/apache/flink/pull/23710#issuecomment-1819865844 Thanks for the feedback @JingGe agree, changed commit message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-33210] Introduce lineage graph relevant interfaces [flink]

2023-11-20 Thread via GitHub
JingGe commented on code in PR #23626: URL: https://github.com/apache/flink/pull/23626#discussion_r1399694431 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageGraph.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-32918][tests] Upgraded migration test data [flink]

2023-11-20 Thread via GitHub
JingGe commented on PR #23710: URL: https://github.com/apache/flink/pull/23710#issuecomment-1819697096 @snuyanzin should we follow the description in https://issues.apache.org/jira/browse/FLINK-32918 to commit with the suggest message format? -- This is an automated message from the

Re: [PR] [hotfix][docs] fix typo in checkpoint_monitoring.md [flink]

2023-11-20 Thread via GitHub
JingGe merged PR #23762: URL: https://github.com/apache/flink/pull/23762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33456] Upgrade maven-shade-plugin to 3.5.1 to support jdk20+ [flink]

2023-11-20 Thread via GitHub
JingGe commented on PR #23661: URL: https://github.com/apache/flink/pull/23661#issuecomment-1819689561 Thanks for sharing the info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-20 Thread via GitHub
bvarghese1 commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1399638216 ##

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-20 Thread via GitHub
afedulov commented on PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#issuecomment-1819644904 @mxm @gyfora I added the proposed `MAX_RESTART_TIME` option with the default value of 30minutes:

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-20 Thread via GitHub
bvarghese1 commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1399621861 ##

Re: [PR] [FLINK-33508] [HistoryServer] Support for wildcard paths in Flink History Server for multi cluster environment [flink]

2023-11-20 Thread via GitHub
anikakelhanka commented on PR #23714: URL: https://github.com/apache/flink/pull/23714#issuecomment-1819635637 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (FLINK-33568) SinkV2MetricsITCase.testCommitterMetrics fails with NullPointerException

2023-11-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-33568. --- Fix Version/s: 1.19.0 Assignee: Peter Vary Resolution: Fixed master:

Re: [PR] [FLINK-33568] Fix NullpointerException in SinkV2MetricsITCase [flink]

2023-11-20 Thread via GitHub
XComp merged PR #23737: URL: https://github.com/apache/flink/pull/23737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-11-20 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1399544889 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,21 +96,54 @@ public

[jira] [Updated] (FLINK-33340) Bump Jackson to 2.15.3

2023-11-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-33340: Fix Version/s: 1.19.0 > Bump Jackson to 2.15.3 > -- > >

[jira] [Commented] (FLINK-33340) Bump Jackson to 2.15.3

2023-11-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788106#comment-17788106 ] Sergey Nuyanzin commented on FLINK-33340: - flink main repo master

[jira] [Resolved] (FLINK-33340) Bump Jackson to 2.15.3

2023-11-20 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33340. - Resolution: Fixed > Bump Jackson to 2.15.3 > -- > >

Re: [PR] [FLINK-33340] Upgrade jackson from 2.14.3 to 2.15.3 [flink]

2023-11-20 Thread via GitHub
snuyanzin commented on PR #23742: URL: https://github.com/apache/flink/pull/23742#issuecomment-1819524757 Thanks for taking a look >I think it is always recommended to use one lower version, since the most up-to-date version might not be stable enough, especially with the first new

Re: [PR] [FLINK-33340] Upgrade jackson from 2.14.3 to 2.15.3 [flink]

2023-11-20 Thread via GitHub
snuyanzin merged PR #23742: URL: https://github.com/apache/flink/pull/23742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][docs] Delete kafka connector docs [flink]

2023-11-20 Thread via GitHub
JingGe commented on PR #23628: URL: https://github.com/apache/flink/pull/23628#issuecomment-1819491720 Hi @ruanhang1993 How will users find the kafka connector doc while they are reading docs on https://flink.apache.org/? -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-33456] Upgrade maven-shade-plugin to 3.5.1 to support jdk20+ [flink]

2023-11-20 Thread via GitHub
snuyanzin commented on PR #23661: URL: https://github.com/apache/flink/pull/23661#issuecomment-1819479163 @JingGe it is a subtask of FLINK-33163 to support java 21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [hotfix] [docs] Fix typo [flink]

2023-11-20 Thread via GitHub
JingGe merged PR #23647: URL: https://github.com/apache/flink/pull/23647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33456] Upgrade maven-shade-plugin to 3.5.1 to support jdk20+ [flink]

2023-11-20 Thread via GitHub
JingGe commented on PR #23661: URL: https://github.com/apache/flink/pull/23661#issuecomment-1819474455 Hi @snuyanzin, just out of curiosity, is there any requirement to support JDK20+? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Support Flink 1.17.1 [flink-statefun]

2023-11-20 Thread via GitHub
dannyporrello commented on PR #332: URL: https://github.com/apache/flink-statefun/pull/332#issuecomment-1819467599 Hey, any update on this? @MartijnVisser @gfmio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [hotfix][docs] fix typo in checkpoint_monitoring.md [flink]

2023-11-20 Thread via GitHub
flinkbot commented on PR #23762: URL: https://github.com/apache/flink/pull/23762#issuecomment-1819450366 ## CI report: * 8815ab35d20f2f56f95b6880847603ad2929c01d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][docs] fix typo in checkpoint_monitoring.md [flink]

2023-11-20 Thread via GitHub
JingGe opened a new pull request, #23762: URL: https://github.com/apache/flink/pull/23762 ## What is the purpose of the change fix typo in the docs ## Verifying this change This change is a trivial typo fix without any test coverage. ## Does this pull

Re: [PR] [hotfix] [docs] modify the Chinese translation content [flink]

2023-11-20 Thread via GitHub
JingGe commented on PR #23672: URL: https://github.com/apache/flink/pull/23672#issuecomment-1819403285 Please use the PR template as a template in stead of using it as the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [docs] Fix typo [flink]

2023-11-20 Thread via GitHub
JingGe merged PR #23670: URL: https://github.com/apache/flink/pull/23670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33501][ci] Makes use of Maven wrapper [flink]

2023-11-20 Thread via GitHub
JingGe commented on code in PR #23689: URL: https://github.com/apache/flink/pull/23689#discussion_r1399450618 ## docs/content.zh/docs/dev/configuration/maven.md: ## @@ -28,7 +28,7 @@ under the License. ## 要求 -- Maven 3.0.4 (or higher) +- Maven 3.8.6 (recommended or higher)

Re: [PR] [FLINK-33340] Upgrade jackson from 2.14.3 to 2.15.3 [flink]

2023-11-20 Thread via GitHub
JingGe commented on PR #23742: URL: https://github.com/apache/flink/pull/23742#issuecomment-1819348252 @TanYuxin-tyx I think it is always recommended to use one lower version, since the most up-to-date version might not be stable enough, especially with the first new minor version x.x.0

Re: [PR] [FLINK-33490][table-planner] Validate the name conflicts when creating view [flink]

2023-11-20 Thread via GitHub
JingGe commented on code in PR #23760: URL: https://github.com/apache/flink/pull/23760#discussion_r1399405605 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConvertUtils.java: ## @@ -63,6 +69,32 @@ static CatalogView

Re: [PR] [FLINK-33581][core] Deprecate configuration getters/setters that return/set complex Java objects. [flink]

2023-11-20 Thread via GitHub
JingGe commented on code in PR #23758: URL: https://github.com/apache/flink/pull/23758#discussion_r1399351523 ## flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java: ## @@ -111,7 +118,17 @@ public static

[jira] [Created] (FLINK-33600) Print cost time for batch queries in SQL Client

2023-11-20 Thread Jark Wu (Jira)
Jark Wu created FLINK-33600: --- Summary: Print cost time for batch queries in SQL Client Key: FLINK-33600 URL: https://issues.apache.org/jira/browse/FLINK-33600 Project: Flink Issue Type: New

Re: [PR] [FLINK-33564] Implement restore tests for GroupWindowAggregate node [flink]

2023-11-20 Thread via GitHub
dawidwys commented on code in PR #23728: URL: https://github.com/apache/flink/pull/23728#discussion_r1399341044 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/GroupWindowAggregateTestPrograms.java: ## @@ -0,0 +1,256 @@ +/*

[jira] [Created] (FLINK-33599) Run restore tests with RocksDB state backend

2023-11-20 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-33599: Summary: Run restore tests with RocksDB state backend Key: FLINK-33599 URL: https://issues.apache.org/jira/browse/FLINK-33599 Project: Flink Issue

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-20 Thread via GitHub
mxm commented on PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#issuecomment-1819233149 What you describe is already the case. Any deployment which currently takes longer than the configured rescale time, will not scale accurately. By adding the feature in its

  1   2   3   >