[PR] [hotfix] Using commons-lang3 for exception checking [flink-kubernetes-operator]

2024-04-21 Thread via GitHub
haoxins opened a new pull request, #818: URL: https://github.com/apache/flink-kubernetes-operator/pull/818 ## What is the purpose of the change *(For example: This pull request adds a new feature to periodically create and maintain savepoints through the `FlinkDeployment`

[jira] [Commented] (FLINK-34380) Strange RowKind and records about intermediate output when using minibatch join

2024-04-21 Thread Roman Boyko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839474#comment-17839474 ] Roman Boyko commented on FLINK-34380: - Hi [~xuyangzhong] , [~xu_shuai_] ! 1) The RowKind can't be

Re: [PR] [FLINK-34980] Translate overview document into Chinese [flink-kubernetes-operator]

2024-04-21 Thread via GitHub
caicancai commented on code in PR #810: URL: https://github.com/apache/flink-kubernetes-operator/pull/810#discussion_r1574122219 ## docs/content.zh/docs/concepts/overview.md: ## @@ -24,86 +24,93 @@ specific language governing permissions and limitations under the License.

Re: [PR] [BP-1.18][FLINK-35169][runtime] Recycle buffers to freeSegments before releasing data buffer for sort accumulator [flink]

2024-04-21 Thread via GitHub
flinkbot commented on PR #24696: URL: https://github.com/apache/flink/pull/24696#issuecomment-2068485490 ## CI report: * 51874ab3e4d2d2b8b84c22bc1e3e6326dba6839a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-1.18][FLINK-35169][runtime] Recycle buffers to freeSegments before releasing data buffer for sort accumulator [flink]

2024-04-21 Thread via GitHub
TanYuxin-tyx opened a new pull request, #24696: URL: https://github.com/apache/flink/pull/24696 ## What is the purpose of the change Backport to Flink 1.18 for https://github.com/apache/flink/pull/24688#event-12553480360 *When using sortBufferAccumulator, we should

Re: [PR] [BP][FLINK-35169][runtime] Recycle buffers to freeSegments before releasing data buffer for sort accumulator [flink]

2024-04-21 Thread via GitHub
flinkbot commented on PR #24695: URL: https://github.com/apache/flink/pull/24695#issuecomment-2068471232 ## CI report: * 4923275887fdcdfe189f070894fd779dc8fe0f46 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP][FLINK-35169][runtime] Recycle buffers to freeSegments before releasing data buffer for sort accumulator [flink]

2024-04-21 Thread via GitHub
TanYuxin-tyx opened a new pull request, #24695: URL: https://github.com/apache/flink/pull/24695 ## What is the purpose of the change Backport to Flink 1.19 for https://github.com/apache/flink/pull/24688#event-12553480360 *When using sortBufferAccumulator, we should

Re: [PR] [FLINK-35120][doris] Add Doris integration test cases [flink-cdc]

2024-04-21 Thread via GitHub
JNSimba commented on PR #3227: URL: https://github.com/apache/flink-cdc/pull/3227#issuecomment-2068453899 It seems that some codes are duplicated with pr #3222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-34970] Translate architecture documents into Chinese [flink-kubernetes-operator]

2024-04-21 Thread via GitHub
caicancai commented on code in PR #809: URL: https://github.com/apache/flink-kubernetes-operator/pull/809#discussion_r1574098275 ## docs/content.zh/docs/concepts/architecture.md: ## @@ -24,57 +24,66 @@ specific language governing permissions and limitations under the License.

Re: [PR] [FLINK-35092][cdc][starrocks] Add starrocks integration test cases [flink-cdc]

2024-04-21 Thread via GitHub
banmoy commented on PR #3231: URL: https://github.com/apache/flink-cdc/pull/3231#issuecomment-2068440105 @yuxiqian Thanks for the work. Left some comments. Also cc @lvyanquan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-35092][cdc][starrocks] Add starrocks integration test cases [flink-cdc]

2024-04-21 Thread via GitHub
banmoy commented on code in PR #3231: URL: https://github.com/apache/flink-cdc/pull/3231#discussion_r1574081602 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/resources/log4j2-test.properties: ## @@ -15,7 +15,7 @@ # Set

Re: [PR] [FLINK-34970] Translate architecture documents into Chinese [flink-kubernetes-operator]

2024-04-21 Thread via GitHub
caicancai commented on code in PR #809: URL: https://github.com/apache/flink-kubernetes-operator/pull/809#discussion_r1574091929 ## docs/content.zh/docs/concepts/architecture.md: ## @@ -24,57 +24,66 @@ specific language governing permissions and limitations under the License.

Re: [PR] [FLINK-33460][Connector/JDBC] Support property authentication connection. [flink-connector-jdbc]

2024-04-21 Thread via GitHub
RocMarshal commented on PR #115: URL: https://github.com/apache/flink-connector-jdbc/pull/115#issuecomment-2068437230 hi, @Jiabao-Sun master, Could you help to have a review if you had the free time ? Thank you~  -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (FLINK-35184) Hash collision inside MiniBatchStreamingJoin operator

2024-04-21 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839464#comment-17839464 ] Shuai Xu commented on FLINK-35184: -- Hi [~rovboyko] , thx for reporting this bug which is caused by the

[jira] [Updated] (FLINK-35169) Recycle buffers to freeSegments before releasing data buffer for sort accumulator

2024-04-21 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35169: --- Fix Version/s: 1.20.0 > Recycle buffers to freeSegments before releasing data buffer for sort >

[jira] [Closed] (FLINK-35169) Recycle buffers to freeSegments before releasing data buffer for sort accumulator

2024-04-21 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-35169. -- Resolution: Fixed master via 68a84fd02fb8e288ff7605073f55834468dcf53a. > Recycle buffers to

Re: [PR] [FLINK-35169][runtime] Recycle buffers to freeSegments before releasing data buffer for sort accumulator [flink]

2024-04-21 Thread via GitHub
reswqa merged PR #24688: URL: https://github.com/apache/flink/pull/24688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35162][state] Implement WriteBatchOperation and general MultiGetOperation for ForSt [flink]

2024-04-21 Thread via GitHub
ljz2051 commented on code in PR #24681: URL: https://github.com/apache/flink/pull/24681#discussion_r1574080412 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStWriteBatchOperation.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the

Re: [PR] [FLINK-34970] Translate architecture documents into Chinese [flink-kubernetes-operator]

2024-04-21 Thread via GitHub
1996fanrui commented on code in PR #809: URL: https://github.com/apache/flink-kubernetes-operator/pull/809#discussion_r1574071090 ## docs/content.zh/docs/concepts/architecture.md: ## @@ -24,57 +24,66 @@ specific language governing permissions and limitations under the

Re: [PR] [FLINK-35168][State] Basic State Iterator for async processing [flink]

2024-04-21 Thread via GitHub
Zakelly commented on PR #24690: URL: https://github.com/apache/flink/pull/24690#issuecomment-2068416578 Rebased master to resolve conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Assigned] (FLINK-35158) Error handling in StateFuture's callback

2024-04-21 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei reassigned FLINK-35158: -- Assignee: Yanfei Lei > Error handling in StateFuture's callback >

Re: [PR] [FLINK-35162][state] Implement WriteBatchOperation and general MultiGetOperation for ForSt [flink]

2024-04-21 Thread via GitHub
ljz2051 commented on code in PR #24681: URL: https://github.com/apache/flink/pull/24681#discussion_r1574076315 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStGeneralMultiGetOperation.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed

Re: [PR] [FLINK-35156][Runtime] Make operators of DataStream V2 integrate with async state processing framework [flink]

2024-04-21 Thread via GitHub
fredia commented on code in PR #24678: URL: https://github.com/apache/flink/pull/24678#discussion_r1574075445 ## flink-datastream/src/main/java/org/apache/flink/datastream/impl/operators/ProcessOperator.java: ## @@ -46,6 +46,12 @@ public

[jira] [Closed] (FLINK-35058) Encountered change event for table db.table whose schema isn't known to this connector

2024-04-21 Thread MOBIN (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] MOBIN closed FLINK-35058. - Resolution: Not A Bug > Encountered change event for table db.table whose schema isn't known to this >

[jira] [Commented] (FLINK-35178) Checkpoint CLAIM mode does not fully control snapshot ownership

2024-04-21 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839458#comment-17839458 ] Jinzhong Li commented on FLINK-35178: - [~elon]  Thanks for reporting this. For case 1: Let me

[jira] [Resolved] (FLINK-35027) Implement checkpoint drain in AsyncExecutionController

2024-04-21 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei resolved FLINK-35027. Resolution: Resolved > Implement checkpoint drain in AsyncExecutionController >

Re: [PR] [FLINK-35027][runtime/checkpoint] Implement checkpoint drain in AsyncExecutionController [flink]

2024-04-21 Thread via GitHub
fredia merged PR #24676: URL: https://github.com/apache/flink/pull/24676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35028][runtime] Timer firing under async execution model [flink]

2024-04-21 Thread via GitHub
fredia commented on code in PR #24672: URL: https://github.com/apache/flink/pull/24672#discussion_r1574062845 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceAsyncImpl.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-34980] Translate overview document into Chinese [flink-kubernetes-operator]

2024-04-21 Thread via GitHub
RocMarshal commented on code in PR #810: URL: https://github.com/apache/flink-kubernetes-operator/pull/810#discussion_r1574054494 ## docs/content.zh/docs/concepts/overview.md: ## @@ -24,86 +24,93 @@ specific language governing permissions and limitations under the License.

Re: [PR] [FLINK-35156][Runtime] Make operators of DataStream V2 integrate with async state processing framework [flink]

2024-04-21 Thread via GitHub
Zakelly commented on code in PR #24678: URL: https://github.com/apache/flink/pull/24678#discussion_r1574052485 ## flink-datastream/src/main/java/org/apache/flink/datastream/impl/operators/ProcessOperator.java: ## @@ -23,15 +23,15 @@ import

Re: [PR] [FLINK-33681] Reuse input/output metrics of SourceOperator/SinkWriterOperator for task [flink]

2024-04-21 Thread via GitHub
X-czh commented on PR #23998: URL: https://github.com/apache/flink/pull/23998#issuecomment-2068376358 @affo Thanks! @huwh Could you help take a look at the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Hotfix] Improve the Readme flink source code compilation document [flink]

2024-04-21 Thread via GitHub
flinkbot commented on PR #24694: URL: https://github.com/apache/flink/pull/24694#issuecomment-2068368531 ## CI report: * b5857ed21eeda0a1338a5df27caa1743ea5cf150 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [Hotfix] Building Apache Flink from Source [flink]

2024-04-21 Thread via GitHub
caicancai opened a new pull request, #24694: URL: https://github.com/apache/flink/pull/24694 ## What is the purpose of the change ①mvn clean package compilation, using IDEA to run unit tests may fail to build ②

Re: [PR] [hotfix][ci] Polish ci concurrency group [flink-cdc]

2024-04-21 Thread via GitHub
GOODBOY008 commented on PR #3241: URL: https://github.com/apache/flink-cdc/pull/3241#issuecomment-2068366576 And bump maven-setup action version to avoid warning. https://github.com/apache/flink-cdc/assets/13617900/91047893-f711-4b7c-beac-054ecaee0332;> -- This is an automated

Re: [PR] [FLINK-33584][Filesystems] Update Hadoop Filesystem dependencies to 3.3.6 [flink]

2024-04-21 Thread via GitHub
masteryhx commented on PR #23844: URL: https://github.com/apache/flink/pull/23844#issuecomment-2068360164 Hi, just kindly ping. Could we resolve this by the solution metioned by @MartijnVisser ? We tried to use positionable read with ByteBuffer on hadoop to imporve the performance but

[jira] [Updated] (FLINK-35185) Resuming Externalized Checkpoint(rocks, incremental, no parallelism change) end-to-end test failed

2024-04-21 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35185: --- Description: {code:java} pr 21 00:52:11 Running externalized checkpoints test, with

[jira] [Created] (FLINK-35185) Resuming Externalized Checkpoint(rocks, incremental, no parallelism change) end-to-end test failed

2024-04-21 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-35185: -- Summary: Resuming Externalized Checkpoint(rocks, incremental, no parallelism change) end-to-end test failed Key: FLINK-35185 URL: https://issues.apache.org/jira/browse/FLINK-35185

[jira] [Resolved] (FLINK-35175) HadoopDataInputStream can't compile with Hadoop 3.2.3

2024-04-21 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-35175. -- Fix Version/s: 1.20.0 Assignee: Hangxiang Yu Resolution: Fixed merged

[jira] [Commented] (FLINK-35175) HadoopDataInputStream can't compile with Hadoop 3.2.3

2024-04-21 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839447#comment-17839447 ] Weijie Guo commented on FLINK-35175: hadoop313:

Re: [PR] [FLINK-35175][filesystem] Avoid reading with ByteBuffer on hadoop version below 3.3.0 [flink]

2024-04-21 Thread via GitHub
masteryhx closed pull request #24691: [FLINK-35175][filesystem] Avoid reading with ByteBuffer on hadoop version below 3.3.0 URL: https://github.com/apache/flink/pull/24691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-35041) IncrementalRemoteKeyedStateHandleTest.testSharedStateReRegistration failed

2024-04-21 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839445#comment-17839445 ] Weijie Guo commented on FLINK-35041: test_cron_jdk21 core

[jira] [Commented] (FLINK-35175) HadoopDataInputStream can't compile with Hadoop 3.2.3

2024-04-21 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839444#comment-17839444 ] Weijie Guo commented on FLINK-35175: 1.20 compile_cron_hadoop313

[jira] [Assigned] (FLINK-35166) Improve the performance of Hybrid Shuffle when enable memory decoupling

2024-04-21 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan reassigned FLINK-35166: - Assignee: Jiang Xin > Improve the performance of Hybrid Shuffle when enable memory decoupling

Re: [PR] [FLINK-35162][state] Implement WriteBatchOperation and general MultiGetOperation for ForSt [flink]

2024-04-21 Thread via GitHub
jectpro7 commented on code in PR #24681: URL: https://github.com/apache/flink/pull/24681#discussion_r1573855255 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStGeneralMultiGetOperation.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed

Re: [PR] [FLINK-34980] Translate overview document into Chinese [flink-kubernetes-operator]

2024-04-21 Thread via GitHub
caicancai commented on code in PR #810: URL: https://github.com/apache/flink-kubernetes-operator/pull/810#discussion_r1573750686 ## docs/content.zh/docs/concepts/overview.md: ## @@ -24,86 +24,93 @@ specific language governing permissions and limitations under the License.

Re: [PR] [FLINK-34970] Translate architecture documents into Chinese [flink-kubernetes-operator]

2024-04-21 Thread via GitHub
caicancai commented on code in PR #809: URL: https://github.com/apache/flink-kubernetes-operator/pull/809#discussion_r1573750776 ## docs/content.zh/docs/concepts/architecture.md: ## @@ -24,57 +24,66 @@ specific language governing permissions and limitations under the License.

[jira] [Commented] (FLINK-35184) Hash collision inside MiniBatchStreamingJoin operator

2024-04-21 Thread Roman Boyko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839382#comment-17839382 ] Roman Boyko commented on FLINK-35184: - please assign this bug on me, I'm working on it. > Hash

[jira] [Created] (FLINK-35184) Hash collision inside MiniBatchStreamingJoin operator

2024-04-21 Thread Roman Boyko (Jira)
Roman Boyko created FLINK-35184: --- Summary: Hash collision inside MiniBatchStreamingJoin operator Key: FLINK-35184 URL: https://issues.apache.org/jira/browse/FLINK-35184 Project: Flink Issue