Re: [PR] [FLINK-35400][checkpoint] Release FileMergingSnapshotManager if all tasks finished [flink]

2024-05-20 Thread via GitHub
flinkbot commented on PR #24817: URL: https://github.com/apache/flink/pull/24817#issuecomment-2121766002 ## CI report: * 99713100d9b0ca11356ae2628edebc7429bedb46 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35400) Rebuild FileMergingSnapshotManager in failover

2024-05-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35400: --- Labels: pull-request-available (was: ) > Rebuild FileMergingSnapshotManager in failover >

[PR] [FLINK-35400][checkpoint] Release FileMergingSnapshotManager if all tasks finished [flink]

2024-05-20 Thread via GitHub
Zakelly opened a new pull request, #24817: URL: https://github.com/apache/flink/pull/24817 ## What is the purpose of the change Currently, the `FileMergingSnapshotManager` is created for each job, only when the corresponding job released, the manager is released and disposed. For

[jira] [Updated] (FLINK-35395) Fix KeyedStateStore class annotation error

2024-05-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35395: --- Priority: Minor (was: Major) > Fix KeyedStateStore class annotation error >

[jira] [Resolved] (FLINK-35395) Fix KeyedStateStore class annotation error

2024-05-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-35395. Resolution: Fixed master(1.20) via 5f5722fe916bafc00ec05539d6c19ac28ac1c5c4. > Fix

[jira] [Updated] (FLINK-35395) Fix KeyedStateStore class annotation error

2024-05-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35395: --- Issue Type: Bug (was: Improvement) > Fix KeyedStateStore class annotation error >

[jira] [Closed] (FLINK-35395) Fix KeyedStateStore class annotation error

2024-05-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-35395. -- > Fix KeyedStateStore class annotation error > -- > >

[jira] [Assigned] (FLINK-35395) Fix KeyedStateStore class annotation error

2024-05-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-35395: -- Assignee: bradley > Fix KeyedStateStore class annotation error >

Re: [PR] [FLINK-35395][core] Fix KeyedStateStore class annotation error [flink]

2024-05-20 Thread via GitHub
reswqa commented on PR #24808: URL: https://github.com/apache/flink/pull/24808#issuecomment-2121760418 Thanks @usberkeley  , merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-35395) Fix KeyedStateStore class annotation error

2024-05-20 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35395: --- Fix Version/s: 1.20.0 > Fix KeyedStateStore class annotation error >

Re: [PR] [FLINK-35395][core] Fix KeyedStateStore class annotation error [flink]

2024-05-20 Thread via GitHub
reswqa merged PR #24808: URL: https://github.com/apache/flink/pull/24808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34944] Use Incremental Source Framework in Flink CDC OceanBase Source Connector [flink-cdc]

2024-05-20 Thread via GitHub
whhe commented on PR #3211: URL: https://github.com/apache/flink-cdc/pull/3211#issuecomment-2121749049 > hello,When can this feature be merged into version 3.2? I will add test cases for this PR in the next two days, and after that we can ask the committers to review it. -- This

[jira] [Created] (FLINK-35405) Add buffer size/in-flight records metrics for AsyncExecutionController

2024-05-20 Thread Yanfei Lei (Jira)
Yanfei Lei created FLINK-35405: -- Summary: Add buffer size/in-flight records metrics for AsyncExecutionController Key: FLINK-35405 URL: https://issues.apache.org/jira/browse/FLINK-35405 Project: Flink

[jira] [Resolved] (FLINK-35030) Introduce Epoch Manager for async execution

2024-05-20 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei resolved FLINK-35030. Resolution: Resolved > Introduce Epoch Manager for async execution >

[jira] [Commented] (FLINK-35030) Introduce Epoch Manager for async execution

2024-05-20 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848041#comment-17848041 ] Yanfei Lei commented on FLINK-35030: Merged into master via f1ecb9e > Introduce Epoch Manager for

Re: [PR] [hotfix][ForStStateBackend] Create new copy for each SerializedCompositeKeyBuilder in ForStStateBackend [flink]

2024-05-20 Thread via GitHub
flinkbot commented on PR #24816: URL: https://github.com/apache/flink/pull/24816#issuecomment-2121707146 ## CI report: * 6a92726158cb6a53b1fb0960a242d66973d9d447 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32706][table] Add built-in SPLIT_STRING function [flink]

2024-05-20 Thread via GitHub
mohitjain2504 commented on code in PR #24365: URL: https://github.com/apache/flink/pull/24365#discussion_r1607603000 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/SplitFunction.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the

Re: [PR] [FLINK-32706][table] Add built-in SPLIT_STRING function [flink]

2024-05-20 Thread via GitHub
mohitjain2504 commented on code in PR #24365: URL: https://github.com/apache/flink/pull/24365#discussion_r1607597612 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/SplitFunction.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the

Re: [PR] [FLINK-32706][table] Add built-in SPLIT_STRING function [flink]

2024-05-20 Thread via GitHub
mohitjain2504 commented on code in PR #24365: URL: https://github.com/apache/flink/pull/24365#discussion_r1607592570 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/SplitFunction.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the

Re: [PR] [FLINK-35037][table-planner]Optimize uniqueKeys and upsertKeys inference of windows with ROW_NUMBER. [flink]

2024-05-20 Thread via GitHub
libenchao commented on code in PR #24638: URL: https://github.com/apache/flink/pull/24638#discussion_r1607579249 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdUpsertKeysTest.scala: ## @@ -188,7 +188,7 @@ class

Re: [PR] [hotfix][ForStStateBackend] Create new copy for each SerializedCompositeKeyBuilder in ForStStateBackend [flink]

2024-05-20 Thread via GitHub
zoltar9264 commented on PR #24816: URL: https://github.com/apache/flink/pull/24816#issuecomment-2121678039 Please have a check @masteryhx . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [hotfix][ForStStateBackend] Create new copy for each SerializedCompositeKeyBuilder in ForStStateBackend [flink]

2024-05-20 Thread via GitHub
zoltar9264 opened a new pull request, #24816: URL: https://github.com/apache/flink/pull/24816 ## What is the purpose of the change This is a internal hotfix within development of ForStStateBackend (see: FLIP-427). ## Brief change log - As title, create new copy for

[jira] [Commented] (FLINK-35296) Flink mysql-cdc connector stops reading data

2024-05-20 Thread Gang Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848037#comment-17848037 ] Gang Yang commented on FLINK-35296: --- Hi,[~ruanhang1993] ,Below is a screenshot of the thread dump

Re: [PR] [FLINK-35167][cdc-connector] Introduce MaxCompute pipeline DataSink [flink-cdc]

2024-05-20 Thread via GitHub
dingxin-tech commented on PR #3254: URL: https://github.com/apache/flink-cdc/pull/3254#issuecomment-2121641714 > I am wondering how a commercial database sink like MaxCompute to do e2e test? I will soon be working on creating a Docker image for a `MaxCompute Emulator` that launches

[jira] [Updated] (FLINK-35296) Flink mysql-cdc connector stops reading data

2024-05-20 Thread Gang Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gang Yang updated FLINK-35296: -- Attachment: image-2024-05-21-11-17-13-441.png > Flink mysql-cdc connector stops reading data >

[jira] [Updated] (FLINK-35296) Flink mysql-cdc connector stops reading data

2024-05-20 Thread Gang Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gang Yang updated FLINK-35296: -- Attachment: image-2024-05-21-11-16-01-719.png > Flink mysql-cdc connector stops reading data >

[jira] [Commented] (FLINK-35296) Flink mysql-cdc connector stops reading data

2024-05-20 Thread Gang Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848033#comment-17848033 ] Gang Yang commented on FLINK-35296: --- Hi,[~ruanhang1993] ,The following is a screenshot of my

[jira] [Updated] (FLINK-35296) Flink mysql-cdc connector stops reading data

2024-05-20 Thread Gang Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gang Yang updated FLINK-35296: -- Attachment: image-2024-05-21-10-53-54-946.png > Flink mysql-cdc connector stops reading data >

[jira] [Updated] (FLINK-35296) Flink mysql-cdc connector stops reading data

2024-05-20 Thread Gang Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gang Yang updated FLINK-35296: -- Attachment: image-2024-05-21-10-53-05-634.png > Flink mysql-cdc connector stops reading data >

[jira] [Updated] (FLINK-35296) Flink mysql-cdc connector stops reading data

2024-05-20 Thread Gang Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gang Yang updated FLINK-35296: -- Attachment: image-2024-05-21-10-52-52-827.png > Flink mysql-cdc connector stops reading data >

[jira] [Updated] (FLINK-35296) Flink mysql-cdc connector stops reading data

2024-05-20 Thread Gang Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gang Yang updated FLINK-35296: -- Attachment: image-2024-05-21-10-52-02-530.png > Flink mysql-cdc connector stops reading data >

[jira] [Updated] (FLINK-35296) Flink mysql-cdc connector stops reading data

2024-05-20 Thread Gang Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gang Yang updated FLINK-35296: -- Attachment: image-2024-05-21-10-51-17-196.png > Flink mysql-cdc connector stops reading data >

[jira] [Updated] (FLINK-35296) Flink mysql-cdc connector stops reading data

2024-05-20 Thread Gang Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gang Yang updated FLINK-35296: -- Attachment: image-2024-05-21-10-51-08-452.png > Flink mysql-cdc connector stops reading data >

[jira] [Comment Edited] (FLINK-35382) ChangelogCompatibilityITCase.testRestore fails with an NPE

2024-05-20 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848030#comment-17848030 ] Yanfei Lei edited comment on FLINK-35382 at 5/21/24 2:35 AM: - Merged into

[jira] [Resolved] (FLINK-35382) ChangelogCompatibilityITCase.testRestore fails with an NPE

2024-05-20 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei resolved FLINK-35382. Assignee: Jinzhong Li Resolution: Fixed > ChangelogCompatibilityITCase.testRestore fails

Re: [PR] [FLINK-31109][yarn] Support Hadoop proxy user when delegation token f… [flink]

2024-05-20 Thread via GitHub
wForget commented on PR #22009: URL: https://github.com/apache/flink/pull/22009#issuecomment-2121596615 I've tried specifying proxyUser using `HADOOP_PROXY_USER` and maintaining the delegation tokens with an external service and sending them into jobmanager, but I can't seem to update

[jira] [Commented] (FLINK-35382) ChangelogCompatibilityITCase.testRestore fails with an NPE

2024-05-20 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848030#comment-17848030 ] Yanfei Lei commented on FLINK-35382: Merged into master via 26b149a. >

Re: [PR] [FLINK-35382][test] Disable snapshot-file-merging in ChangelogCompabilityITCase [flink]

2024-05-20 Thread via GitHub
fredia merged PR #24813: URL: https://github.com/apache/flink/pull/24813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35277][cdc-connector][db2] Fix the error in the `asncdcaddremove.sql` script for the DB2 test container. [flink-cdc]

2024-05-20 Thread via GitHub
gong commented on PR #3286: URL: https://github.com/apache/flink-cdc/pull/3286#issuecomment-2121589464 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Comment Edited] (FLINK-35296) Flink mysql-cdc connector stops reading data

2024-05-20 Thread Gang Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848028#comment-17848028 ] Gang Yang edited comment on FLINK-35296 at 5/21/24 2:19 AM:

[jira] [Comment Edited] (FLINK-35296) Flink mysql-cdc connector stops reading data

2024-05-20 Thread Gang Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848028#comment-17848028 ] Gang Yang edited comment on FLINK-35296 at 5/21/24 2:18 AM:   At present, I

[jira] [Commented] (FLINK-35296) Flink mysql-cdc connector stops reading data

2024-05-20 Thread Gang Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848028#comment-17848028 ] Gang Yang commented on FLINK-35296: ---

[PR] [hotfix][cdc][docs] Supplementary answer to the Mysql CDC Q15 question [flink-cdc]

2024-05-20 Thread via GitHub
PONYLEE opened a new pull request, #3337: URL: https://github.com/apache/flink-cdc/pull/3337 Supplementary answer to the [Mysql CDC Q15] question -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-35379][Checkpoint] Fix incorrect checkpoint notification handling in file merging [flink]

2024-05-20 Thread via GitHub
Zakelly merged PR #24806: URL: https://github.com/apache/flink/pull/24806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34456][configuration]Move all checkpoint-related options into CheckpointingOptions [flink]

2024-05-20 Thread via GitHub
spoon-lz commented on PR #24374: URL: https://github.com/apache/flink/pull/24374#issuecomment-2121565086 @Zakelly New code has been submitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-33212][runtime] add job status changed listener for lineage [flink]

2024-05-20 Thread via GitHub
HuangZhenQiu commented on PR #24754: URL: https://github.com/apache/flink/pull/24754#issuecomment-2121563878 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35047][state] Shutdown StateExecutors when ForStKeyedStateBackend is closed [flink]

2024-05-20 Thread via GitHub
masteryhx commented on code in PR #24768: URL: https://github.com/apache/flink/pull/24768#discussion_r1607490839 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackend.java: ## @@ -147,15 +160,30 @@ public S

[PR] [FLINK-35354] Support host mapping in Flink tikv cdc [flink-cdc]

2024-05-20 Thread via GitHub
Mrart opened a new pull request, #3336: URL: https://github.com/apache/flink-cdc/pull/3336 In tidb production environment deployment, there are usually two kinds of network: internal network and public network. When we use pd mode in tikv, we need to do network mapping, such as

[jira] [Updated] (FLINK-35354) Support host mapping in Flink tikv cdc

2024-05-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35354: --- Labels: pull-request-available (was: ) > Support host mapping in Flink tikv cdc >

[jira] [Comment Edited] (FLINK-25537) [JUnit5 Migration] Module: flink-core

2024-05-20 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845561#comment-17845561 ] Rui Fan edited comment on FLINK-25537 at 5/21/24 1:29 AM: -- Merged to

Re: [PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: types [flink]

2024-05-20 Thread via GitHub
1996fanrui merged PR #24613: URL: https://github.com/apache/flink/pull/24613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35359][config] General Improvement to Configuration for Flink 2.0 [flink]

2024-05-20 Thread via GitHub
flinkbot commented on PR #24815: URL: https://github.com/apache/flink/pull/24815#issuecomment-2121526672 ## CI report: * 3fc215385500d8eb69d85c860e6e936ab103eae4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35359) General Improvement to Configuration for Flink 2.0

2024-05-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35359: --- Labels: pull-request-available (was: ) > General Improvement to Configuration for Flink

Re: [PR] [FLINK-25537][JUnit5 Migration] Module: flink-core with,Package: types [flink]

2024-05-20 Thread via GitHub
1996fanrui commented on code in PR #24613: URL: https://github.com/apache/flink/pull/24613#discussion_r1598105369 ## flink-core/src/test/java/org/apache/flink/types/BasicTypeInfoTest.java: ## @@ -51,24 +49,24 @@ public class BasicTypeInfoTest extends TestLogger { };

[PR] [FLINK-35359][config] General Improvement to Configuration for Flink 2.0 [flink]

2024-05-20 Thread via GitHub
Sxnan opened a new pull request, #24815: URL: https://github.com/apache/flink/pull/24815 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

Re: [PR] [FLINK-35403] Allow Skipping Invocation of Function Calls While Constant-folding [flink]

2024-05-20 Thread via GitHub
flinkbot commented on PR #24814: URL: https://github.com/apache/flink/pull/24814#issuecomment-2121448911 ## CI report: * 78c4501b833f0860ce931ef91c1efaae71d90e09 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35403) FLIP-452: Allow Skipping Invocation of Function Calls While Constant-folding

2024-05-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35403: --- Labels: pull-request-available (was: ) > FLIP-452: Allow Skipping Invocation of Function

[PR] [FLINK-35403] Allow Skipping Invocation of Function Calls While Constant-folding [flink]

2024-05-20 Thread via GitHub
AlanConfluent opened a new pull request, #24814: URL: https://github.com/apache/flink/pull/24814 ## What is the purpose of the change This PR adds a new method to `FunctionDefinition`, `supportsConstantFolding` which indicates of a function call should have constant

Re: [PR] [FLINK-35404] Report all metrics of KafkaConsumer in new Kafka source [flink-connector-kafka]

2024-05-20 Thread via GitHub
boring-cyborg[bot] commented on PR #103: URL: https://github.com/apache/flink-connector-kafka/pull/103#issuecomment-2121252403 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This

[PR] [FLINK-35404] Report all metrics of KafkaConsumer in new Kafka source [flink-connector-kafka]

2024-05-20 Thread via GitHub
hmit opened a new pull request, #103: URL: https://github.com/apache/flink-connector-kafka/pull/103 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Comment Edited] (FLINK-35404) Report metrics of KafkaConsumer in new Kafka source

2024-05-20 Thread Harshit Mittal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847993#comment-17847993 ] Harshit Mittal edited comment on FLINK-35404 at 5/20/24 8:55 PM: - A

[jira] [Updated] (FLINK-35404) Report metrics of KafkaConsumer in new Kafka source

2024-05-20 Thread Harshit Mittal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harshit Mittal updated FLINK-35404: --- Description: Currently new Kafka source only registers metrics that are available on

[jira] [Commented] (FLINK-35404) Report metrics of KafkaConsumer in new Kafka source

2024-05-20 Thread Harshit Mittal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847993#comment-17847993 ] Harshit Mittal commented on FLINK-35404: A better way to solve this problem is to implement

[jira] [Updated] (FLINK-35404) Report metrics of KafkaConsumer in new Kafka source

2024-05-20 Thread Harshit Mittal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harshit Mittal updated FLINK-35404: --- Fix Version/s: (was: 1.14.0) (was: 1.13.2) > Report metrics of

[jira] [Created] (FLINK-35404) Report metrics of KafkaConsumer in new Kafka source

2024-05-20 Thread Harshit Mittal (Jira)
Harshit Mittal created FLINK-35404: -- Summary: Report metrics of KafkaConsumer in new Kafka source Key: FLINK-35404 URL: https://issues.apache.org/jira/browse/FLINK-35404 Project: Flink

[jira] [Created] (FLINK-35403) FLIP-452: Allow Skipping Invocation of Function Calls While Constant-folding

2024-05-20 Thread Alan Sheinberg (Jira)
Alan Sheinberg created FLINK-35403: -- Summary: FLIP-452: Allow Skipping Invocation of Function Calls While Constant-folding Key: FLINK-35403 URL: https://issues.apache.org/jira/browse/FLINK-35403

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
ldadima commented on PR #24784: URL: https://github.com/apache/flink/pull/24784#issuecomment-2120974575 Sorry to bother you again, but I made a separate one [Pull request with hotfix](https://github.com/apache/flink/pull/24811) -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1607065866 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1607065866 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1607065866 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1607061596 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointCustomRescaleITCase.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

[jira] [Updated] (FLINK-35402) [flink-operator][Deployment] add labels to metadata

2024-05-20 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-35402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luís Costa updated FLINK-35402: --- Description: Greetings dear team, I would like to add labels to flink-operator Deployment metadata

[PR] FLINK-35402 [flink-operator][Deployment] add labels to metadata [flink-kubernetes-operator]

2024-05-20 Thread via GitHub
luismacosta opened a new pull request, #829: URL: https://github.com/apache/flink-kubernetes-operator/pull/829 FLINK-35402 [flink-operator][Deployment] add labels to metadata - https://issues.apache.org/jira/browse/FLINK-35402 -- This is an automated message from the Apache Git Service.

[jira] [Updated] (FLINK-35402) [flink-operator][Deployment] add labels to metadata

2024-05-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35402: --- Labels: pull-request-available (was: ) > [flink-operator][Deployment] add labels to

[jira] [Created] (FLINK-35402) [flink-operator][Deployment] add labels to metadata

2024-05-20 Thread Jira
Luís Costa created FLINK-35402: -- Summary: [flink-operator][Deployment] add labels to metadata Key: FLINK-35402 URL: https://issues.apache.org/jira/browse/FLINK-35402 Project: Flink Issue Type:

Re: [PR] [FLINK-32706][table] Add built-in SPLIT_STRING function [flink]

2024-05-20 Thread via GitHub
hanyuzheng7 commented on code in PR #24365: URL: https://github.com/apache/flink/pull/24365#discussion_r1606922419 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/SplitFunction.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the

Re: [PR] [FLINK-32706][table] Add built-in SPLIT_STRING function [flink]

2024-05-20 Thread via GitHub
hanyuzheng7 commented on PR #24365: URL: https://github.com/apache/flink/pull/24365#issuecomment-2120677719 > > When the delimiter is empty, do we need to handle this situation specially?/ > > Yes, we do. Do you mind updating the PR? I have already updated the PR. --

Re: [PR] [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to [flink]

2024-05-20 Thread via GitHub
reswqa commented on PR #24741: URL: https://github.com/apache/flink/pull/24741#issuecomment-2120663487 We should include it as flink has nightly ci that check jdk17 build also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
pnowojski commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1606882746 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointCustomRescaleITCase.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

[jira] [Updated] (FLINK-35401) Add SQS Table API support

2024-05-20 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy updated FLINK-35401: Fix Version/s: aws-connector-4.4.0 > Add SQS Table API support > - > >

[jira] [Updated] (FLINK-35401) Add SQS Table API support

2024-05-20 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy updated FLINK-35401: Description: Add Table API support for Amazon SQS (was: This is an umbrella task for FLIP-438.

[jira] [Updated] (FLINK-35401) Add SQS Table API support

2024-05-20 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy updated FLINK-35401: Labels: (was: pull-request-available) > Add SQS Table API support > - >

[jira] [Updated] (FLINK-35401) Add SQS Table API support

2024-05-20 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy updated FLINK-35401: Description: # Add Table API support for Amazon SQS sink as per

[jira] [Updated] (FLINK-35401) Add SQS Table API support

2024-05-20 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy updated FLINK-35401: Description: # Add Table API support for Amazon SQS sink as per

[jira] [Updated] (FLINK-35401) Add SQS Table API support

2024-05-20 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy updated FLINK-35401: Description: Add Table API support for Amazon SQS sink as per FLIP-481 (was: Add Table API

[jira] [Created] (FLINK-35401) Add SQS Table API support

2024-05-20 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35401: --- Summary: Add SQS Table API support Key: FLINK-35401 URL: https://issues.apache.org/jira/browse/FLINK-35401 Project: Flink Issue Type: New Feature

Re: [PR] [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to [flink]

2024-05-20 Thread via GitHub
davidradl commented on PR #24741: URL: https://github.com/apache/flink/pull/24741#issuecomment-2120541110 @reswqa If you have strong views I can include it in this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-35395][core] Fix KeyedStateStore class annotation error [flink]

2024-05-20 Thread via GitHub
usberkeley commented on PR #24808: URL: https://github.com/apache/flink/pull/24808#issuecomment-2120534284 > Oh, `/doc` means flink documentation, while java doc means the doc/comments on java class/interface/method/field. > > But It doesn't matter, this fix is good enough. Would you

Re: [PR] [FLINK-35395][core] Fix KeyedStateStore class annotation error [flink]

2024-05-20 Thread via GitHub
usberkeley commented on PR #24808: URL: https://github.com/apache/flink/pull/24808#issuecomment-2120526422 > Oh, `/doc` means flink documentation, while java doc means the doc/comments on java class/interface/method/field. > > But It doesn't matter, this fix is good enough. Would you

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
pnowojski commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1606820986 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
pnowojski commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1606820986 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606797248 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606797248 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to

[PR] Fix ingress example in docs [flink-kubernetes-operator]

2024-05-20 Thread via GitHub
yardenshoham opened a new pull request, #828: URL: https://github.com/apache/flink-kubernetes-operator/pull/828 In the "Simple domain based routing" example, there's no `/` so the ingress doesn't work by default -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606797248 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606797248 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606797248 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
superdiaodiao commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606776660 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlEncodeFunction.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
davidradl commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606752091 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlEncodeFunction.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the

Re: [PR] [FLINK-34108][table] Add built-in URL_ENCODE and URL_DECODE function. [flink]

2024-05-20 Thread via GitHub
davidradl commented on code in PR #24773: URL: https://github.com/apache/flink/pull/24773#discussion_r1606749183 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/UrlDecodeFunction.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the

  1   2   >