lsyldliu merged PR #24799:
URL: https://github.com/apache/flink/pull/24799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-34840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849623#comment-17849623
]
Peter Vary commented on FLINK-34840:
If you need help with Iceberg reviews, feel free to ping me.
>
X-czh closed pull request #24216: [BP-1.18][FLINK-34052][examples] Install the
shaded streaming example jars in the maven repo
URL: https://github.com/apache/flink/pull/24216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/FLINK-35295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonard Xu resolved FLINK-35295.
Resolution: Fixed
master: 18b0627e343ddd218adcbccef8fb5f5f65813479
> Improve jdbc connection
[
https://issues.apache.org/jira/browse/FLINK-35295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonard Xu reassigned FLINK-35295:
--
Assignee: Xiao Huang
> Improve jdbc connection pool initialization failure message
>
[
https://issues.apache.org/jira/browse/FLINK-35295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonard Xu updated FLINK-35295:
---
Fix Version/s: cdc-3.2.0
> Improve jdbc connection pool initialization failure message
>
[
https://issues.apache.org/jira/browse/FLINK-35295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonard Xu updated FLINK-35295:
---
Affects Version/s: cdc-3.1.0
> Improve jdbc connection pool initialization failure message
>
leonardBang merged PR #3293:
URL: https://github.com/apache/flink-cdc/pull/3293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-35294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonard Xu closed FLINK-35294.
--
Resolution: Implemented
Implemented master via : bddcaae7846671c0447b2aa6c7d8e96638988f99
> Use
[
https://issues.apache.org/jira/browse/FLINK-35294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonard Xu reassigned FLINK-35294:
--
Assignee: Xiao Huang
> Use source config to check if the filter should be applied in
leonardBang merged PR #3291:
URL: https://github.com/apache/flink-cdc/pull/3291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-35426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhu Zhu closed FLINK-35426.
---
Resolution: Done
master: 4b342da6d149113dde821b370a136beef3430fff
> Change the distribution of
zhuzhurk merged PR #24830:
URL: https://github.com/apache/flink/pull/24830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-35456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849612#comment-17849612
]
Weijie Guo edited comment on FLINK-35456 at 5/27/24 4:04 AM:
-
[
https://issues.apache.org/jira/browse/FLINK-35456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849612#comment-17849612
]
Weijie Guo edited comment on FLINK-35456 at 5/27/24 4:03 AM:
-
[
https://issues.apache.org/jira/browse/FLINK-35456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849612#comment-17849612
]
Weijie Guo commented on FLINK-35456:
1996fanrui commented on code in PR #108:
URL:
https://github.com/apache/flink-connector-jdbc/pull/108#discussion_r1615444568
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/AbstractPostgresCompatibleDialect.java:
##
@@ -50,12 +50,14 @@ public
1996fanrui commented on PR #108:
URL:
https://github.com/apache/flink-connector-jdbc/pull/108#issuecomment-2132593834
Hi @Mrart , the CI is failed, could you rebase the main branch and check the
CI?
--
This is an automated message from the Apache Git Service.
To respond to the message,
1996fanrui commented on code in PR #108:
URL:
https://github.com/apache/flink-connector-jdbc/pull/108#discussion_r1615442044
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/AbstractPostgresCompatibleDialect.java:
##
@@ -50,12 +50,14 @@ public
Xuannan Su created FLINK-35461:
--
Summary: Improve Runtime Configuration for Flink 2.0
Key: FLINK-35461
URL: https://issues.apache.org/jira/browse/FLINK-35461
Project: Flink
Issue Type:
flinkbot commented on PR #24846:
URL: https://github.com/apache/flink/pull/24846#issuecomment-2132573107
## CI report:
* 411168066e0918d38167fc9e33861fc1945baa27 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-35457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-35457:
---
Labels: pull-request-available (was: )
> EventTimeWindowCheckpointingITCase fails on AZP
fredia opened a new pull request, #24846:
URL: https://github.com/apache/flink/pull/24846
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way we avoid re-transferring them on
Hangxiang Yu created FLINK-35460:
Summary: Check file size when position read for ForSt
Key: FLINK-35460
URL: https://issues.apache.org/jira/browse/FLINK-35460
Project: Flink
Issue Type: Bug
SamBarker commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1615426480
##
benchmark.sh:
##
@@ -0,0 +1,54 @@
+#!/usr/bin/env bash
Review Comment:
One final call out. This is not currently checked in with the executable bit
set
SamBarker commented on PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2132564249
I think the `benchmark-java17` profile could potentially be simplified to
specify a property with just the additional JVM_ARGS (possibly changing `-j` to
be single arg inline with
liuyongvs commented on PR #24650:
URL: https://github.com/apache/flink/pull/24650#issuecomment-2132559247
rebase to fix conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
SamBarker commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1615419310
##
pom.xml:
##
@@ -290,25 +291,31 @@ under the License.
ouyangwulin created FLINK-35459:
---
Summary: Use Incremental Source Framework in Flink CDC TiKV Source
Connector
Key: FLINK-35459
URL: https://issues.apache.org/jira/browse/FLINK-35459
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-35342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849607#comment-17849607
]
Weijie Guo commented on FLINK-35342:
1.20 test_cron_adaptive_scheduler table
[
https://issues.apache.org/jira/browse/FLINK-34239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849606#comment-17849606
]
Zhanghao Chen commented on FLINK-34239:
---
[~mallikarjuna] Hi could you help rebase the code on the
[
https://issues.apache.org/jira/browse/FLINK-35456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weijie Guo updated FLINK-35456:
---
Priority: Blocker (was: Major)
> Many tests fails on AZP as NPE related to FileMerging
>
[
https://issues.apache.org/jira/browse/FLINK-35456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849605#comment-17849605
]
Weijie Guo commented on FLINK-35456:
SplitAggregateITCase.testMultipleDistinctAggOnSameColumn
[
https://issues.apache.org/jira/browse/FLINK-35456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849604#comment-17849604
]
Weijie Guo commented on FLINK-35456:
testTop1WithGroupByCount:535->testTopNthWithGroupByCountBase
Zhanghao Chen created FLINK-35458:
-
Summary: Add serializer upgrade test for set serializer
Key: FLINK-35458
URL: https://issues.apache.org/jira/browse/FLINK-35458
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-35456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weijie Guo updated FLINK-35456:
---
Summary: Many tests fails on AZP as NPE related to FileMerging (was:
flinkbot commented on PR #24845:
URL: https://github.com/apache/flink/pull/24845#issuecomment-2132544519
## CI report:
* 00aff8482b13a036e64212cc985843cf50a13a69 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-35342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849602#comment-17849602
]
Weijie Guo commented on FLINK-35342:
1.20 test_cron_adaptive_scheduler
[
https://issues.apache.org/jira/browse/FLINK-35456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849601#comment-17849601
]
Weijie Guo commented on FLINK-35456:
WindowJoinITCase.testInnerJoinOnWTFWithOffset also has same
X-czh opened a new pull request, #24845:
URL: https://github.com/apache/flink/pull/24845
## What is the purpose of the change
Introduce built-in serialization support for sets, which falls back to Kyro
previously.
## Brief change log
Introduce dedicated
[
https://issues.apache.org/jira/browse/FLINK-35068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-35068:
---
Labels: pull-request-available (was: )
> Introduce built-in serialization support for Set
[
https://issues.apache.org/jira/browse/FLINK-35457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weijie Guo updated FLINK-35457:
---
Description:
{code:java}
Caused by: java.lang.NullPointerException
at
Weijie Guo created FLINK-35457:
--
Summary: EventTimeWindowCheckpointingITCase fails on AZP as NPE
Key: FLINK-35457
URL: https://issues.apache.org/jira/browse/FLINK-35457
Project: Flink
Issue
[
https://issues.apache.org/jira/browse/FLINK-35456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weijie Guo updated FLINK-35456:
---
Description:
{code:java}
May 25 02:12:16 Caused by: java.lang.NullPointerException
May 25 02:12:16
Weijie Guo created FLINK-35456:
--
Summary: WindowAggregateITCase.testEventTimeHopWindow fails on AZP
as NPE
Key: FLINK-35456
URL: https://issues.apache.org/jira/browse/FLINK-35456
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-35068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849599#comment-17849599
]
Weijie Guo commented on FLINK-35068:
Thanks [~Zhanghao Chen], you are assigned.
> Introduce
[
https://issues.apache.org/jira/browse/FLINK-35068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weijie Guo reassigned FLINK-35068:
--
Assignee: Zhanghao Chen
> Introduce built-in serialization support for Set
>
[
https://issues.apache.org/jira/browse/FLINK-34123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weijie Guo closed FLINK-34123.
--
Resolution: Done
master(1.20) via f860631c523c1d446c0d01046f0fbe6055174dc6.
> Introduce built-in
reswqa merged PR #24634:
URL: https://github.com/apache/flink/pull/24634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-35324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849596#comment-17849596
]
Weijie Guo commented on FLINK-35324:
Does 1.20 has the same problem?
> Avro format can not perform
loserwang1024 commented on code in PR #3349:
URL: https://github.com/apache/flink-cdc/pull/3349#discussion_r1615396296
##
[
https://issues.apache.org/jira/browse/FLINK-35423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weijie Guo updated FLINK-35423:
---
Affects Version/s: 1.20.0
> ARRAY_EXCEPT should support set semantics
>
liuyongvs commented on code in PR #24526:
URL: https://github.com/apache/flink/pull/24526#discussion_r1615393266
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayIntersectFunction.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed
reswqa commented on PR #24741:
URL: https://github.com/apache/flink/pull/24741#issuecomment-2132504566
> I suggest we leave the fix as is, with the method you added, and not do a
large amount of 1.19 -1.18 back ports. WDYT?
It looks like we can't avoid a change to the public api, and
[
https://issues.apache.org/jira/browse/FLINK-35429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848927#comment-17848927
]
Weijie Guo edited comment on FLINK-35429 at 5/27/24 1:42 AM:
-
master(1.20)
[
https://issues.apache.org/jira/browse/FLINK-35429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weijie Guo updated FLINK-35429:
---
Fix Version/s: 1.20.0
1.19.1
> We don't need introduce
reswqa merged PR #24838:
URL: https://github.com/apache/flink/pull/24838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reswqa commented on PR #24838:
URL: https://github.com/apache/flink/pull/24838#issuecomment-2132499806
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
hackergin commented on PR #24844:
URL: https://github.com/apache/flink/pull/24844#issuecomment-2132497948
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
SamBarker commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1615355106
##
pom.xml:
##
@@ -345,6 +346,8 @@ under the License.
-classpath
SamBarker opened a new pull request, #90:
URL: https://github.com/apache/flink-benchmarks/pull/90
In exploring
[FLINK-35215](https://issues.apache.org/jira/browse/FLINK-35215) being able to
generate flame graphs from each benchmark run makes comparing results a lot
easier.
--
This is
[
https://issues.apache.org/jira/browse/FLINK-35446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zakelly Lan resolved FLINK-35446.
-
Fix Version/s: 1.20.0
Assignee: Zakelly Lan
Resolution: Fixed
>
[
https://issues.apache.org/jira/browse/FLINK-35446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849563#comment-17849563
]
Zakelly Lan commented on FLINK-35446:
-
Merged into master via
Zakelly closed pull request #24840: [FLINK-35446] Fix NPE when disabling
checkpoint file merging but restore from merged files
URL: https://github.com/apache/flink/pull/24840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Kaiyao Ke created FLINK-35455:
-
Summary: Non-idempotent unit tests
Key: FLINK-35455
URL: https://issues.apache.org/jira/browse/FLINK-35455
Project: Flink
Issue Type: Bug
Reporter:
snuyanzin commented on PR #27:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/27#issuecomment-2132266341
it seems dependency convergence issue should be resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
snuyanzin commented on code in PR #27:
URL:
https://github.com/apache/flink-connector-gcp-pubsub/pull/27#discussion_r1615240064
##
flink-connector-gcp-pubsub/src/main/java/org/apache/flink/connector/gcp/pubsub/common/PubSubConstants.java:
##
@@ -0,0 +1,11 @@
+package
[
https://issues.apache.org/jira/browse/FLINK-35424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849556#comment-17849556
]
Sergey Nuyanzin commented on FLINK-35424:
-
Merged as
[
https://issues.apache.org/jira/browse/FLINK-35424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Nuyanzin resolved FLINK-35424.
-
Fix Version/s: elasticsearch-3.2.0
Resolution: Fixed
> Elasticsearch connector 8
snuyanzin merged PR #104:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
snuyanzin commented on PR #104:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/104#issuecomment-2132254635
Thanks for the valuable improvement @liuml07
thanks for the review @reta
--
This is an automated message from the Apache Git Service.
To respond to the
vahmed-hamdy commented on PR #24839:
URL: https://github.com/apache/flink/pull/24839#issuecomment-2132249502
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
flinkbot commented on PR #24844:
URL: https://github.com/apache/flink/pull/24844#issuecomment-2132246140
## CI report:
* b9b0aad8794f5fe34bdb3a5c0d3a75826468 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-35348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-35348:
---
Labels: pull-request-available (was: )
> Implement materialized table refresh rest api
>
hackergin opened a new pull request, #24844:
URL: https://github.com/apache/flink/pull/24844
## What is the purpose of the change
*Introduce refresh materialized table rest api*
## Brief change log
- *test-filesystem support partition.fields option*
- *Introduce
Mrart commented on PR #3336:
URL: https://github.com/apache/flink-cdc/pull/3336#issuecomment-2132210507
> > I think we can specific a config prefix pass config to tikv client like
cdc source connector pass config to debezium by `debezium.*`. This way will be
flexible. @leonardBang @Mrart
GOODBOY008 commented on PR #3336:
URL: https://github.com/apache/flink-cdc/pull/3336#issuecomment-2132201295
As discuss offline with @Mrart , due to ``tikvclient` config `hostMapping`
different from others. So the solution in this PR, I think ok.
--
This is an automated message from the
xuzifu666 commented on PR #24842:
URL: https://github.com/apache/flink/pull/24842#issuecomment-2132165935
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
flinkbot commented on PR #24843:
URL: https://github.com/apache/flink/pull/24843#issuecomment-2132147690
## CI report:
* 7dd3dc90fcb9c37fd0beccba69cf19586efe59f6 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
vahmed-hamdy commented on PR #24839:
URL: https://github.com/apache/flink/pull/24839#issuecomment-2132141416
@dannycranmer thanks for the review, Could you have another pass?
The CI is failing due to a bug in Architecture tests FLINK-35454,
Could you take a look at this
[
https://issues.apache.org/jira/browse/FLINK-35454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-35454:
---
Labels: pull-request-available (was: )
> Connector ArchTests fails due to dependency on
vahmed-hamdy opened a new pull request, #24843:
URL: https://github.com/apache/flink/pull/24843
…
## What is the purpose of the change
Allow connector classes to depend on internal Flink util classes in ArchUnit
tests.
## Brief change log
*(for
[
https://issues.apache.org/jira/browse/FLINK-35454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849505#comment-17849505
]
Ahmed Hamdy commented on FLINK-35454:
-
Ahmed Hamdy created FLINK-35454:
---
Summary: Connector ArchTests fails due to dependency on
fink.util.Preconditions
Key: FLINK-35454
URL: https://issues.apache.org/jira/browse/FLINK-35454
Project: Flink
84 matches
Mail list logo
