Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6388
LGTM, except the one remaining indentation problem mentioned by @zentol .
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6351#discussion_r204345031
--- Diff:
flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/SequenceGeneratorSource.java
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6351
Had one question. Otherwise LGTM ð
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6351#discussion_r204336316
--- Diff:
flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/SequenceGeneratorSource.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6351#discussion_r204336026
--- Diff:
flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/SequenceGeneratorSource.java
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6376
Thanks for the fast review @aljoscha . Addressed the comment about the
`while`-loop and will merge now.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6376#discussion_r203982061
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/FailingSource.java
---
@@ -0,0 +1,155 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6376#discussion_r203981882
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/ValidatingSink.java
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6376#discussion_r203978845
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/WindowCheckpointingITCase.java
---
@@ -92,19 +89,21 @@ private static
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6376#discussion_r203978691
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/FailingSource.java
---
@@ -0,0 +1,155 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6376#discussion_r203978368
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeAllWindowCheckpointingITCase.java
---
@@ -88,20 +80,17 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6376#discussion_r203978136
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeAllWindowCheckpointingITCase.java
---
@@ -133,9 +122,12 @@ public
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6376#discussion_r203978068
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java
---
@@ -299,12 +288,17 @@ public
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6361
Very good work, LGTM ð Merging.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6351#discussion_r203382388
--- Diff:
flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/SemanticsCheckMapper.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6351#discussion_r203380952
--- Diff:
flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/DataStreamAllroundTestJobFactory.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6361#discussion_r203377098
--- Diff: flink-end-to-end-tests/test-scripts/common.sh ---
@@ -240,6 +240,15 @@ function start_cluster {
done
}
+function
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6361#discussion_r203372004
--- Diff:
flink-end-to-end-tests/flink-stream-state-ttl-test/src/main/java/org/apache/flink/streaming/tests/verify/TtlUpdateContext.java
---
@@ -0,0
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6361#discussion_r203363708
--- Diff:
flink-end-to-end-tests/flink-stream-state-ttl-test/src/main/java/org/apache/flink/streaming/tests/DataStreamStateTTLTestProgram.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6361#discussion_r203362731
--- Diff:
flink-end-to-end-tests/flink-stream-state-ttl-test/src/main/java/org/apache/flink/streaming/tests/DataStreamStateTTLTestProgram.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6361#discussion_r203361200
--- Diff:
flink-end-to-end-tests/flink-stream-state-ttl-test/src/main/java/org/apache/flink/streaming/tests/verify/AbstractTtlStateVerifier.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6361#discussion_r203355448
--- Diff:
flink-end-to-end-tests/flink-stream-state-ttl-test/src/main/java/org/apache/flink/streaming/tests/verify/AbstractTtlStateVerifier.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6361#discussion_r203353112
--- Diff:
flink-end-to-end-tests/flink-stream-state-ttl-test/src/main/java/org/apache/flink/streaming/tests/verify/AbstractTtlStateVerifier.java
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6302
@indrc I think there is no contradiction between Stephan's comment and my
suggestion about 1. I stand by my point that this is a very common task and
there is no very special requirement
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202556109
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CachingInternalPriorityQueueSet.java
---
@@ -80,13 +82,57 @@ public E peek
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6333#discussion_r202556091
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -446,8 +485,10 @@ public String toString
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6333
CC @tillrohrmann
---
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/6333
[FLINK-9489] Checkpoint timers as part of managed keyed state instead of
raw keyed state
## What is the purpose of the change
This PR integrates priority queue state (timers
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6325#discussion_r202295131
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6325#discussion_r202285840
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerConfigSnapshot.java
---
@@ -99,7 +99,8
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6325#discussion_r202293686
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6325#discussion_r202293217
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6325#discussion_r202293477
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6325#discussion_r202289229
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6313
LGTM, nice work! ð Besides one comment about closing the backends after
tests, the PR is ready. This is no big thing so I will just fix it myself
before merging now.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6313#discussion_r202130806
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/StateBackendTestContext.java
---
@@ -0,0 +1,120 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6313#discussion_r202103083
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -240,7 +243,7 @@ private boolean
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6313#discussion_r202058484
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java
---
@@ -240,7 +243,7 @@ private boolean
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6313#discussion_r202057089
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackend.java
---
@@ -93,7 +94,7 @@
private static
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6313#discussion_r202056626
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackend.java
---
@@ -93,7 +94,7 @@
private static
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6308#discussion_r202047581
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedBackendSerializationProxy.java
---
@@ -98,8 +103,7 @@ public int
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6308#discussion_r202047403
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/SerializationProxiesTest.java
---
@@ -126,11 +131,11 @@ public void
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6313#discussion_r202042548
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlMapState.java
---
@@ -84,52 +86,89 @@ public boolean contains(UK key
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6308
@sihuazhou @azagrebin thanks guys for the fast reviews! Will address the
comments and merge.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6308#discussion_r202041046
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/metainfo/StateMetaInfoSnapshotReadersWriters.java
---
@@ -0,0 +1,412
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6313#discussion_r202036711
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlMapState.java
---
@@ -84,52 +86,89 @@ public boolean contains(UK key
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6313#discussion_r202032512
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/state/StateDescriptor.java
---
@@ -92,6 +93,10 @@
@Nullable
private
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6277
LGTM ð merging.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6308
CC @azagrebin
---
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/6308
[FLINK-9799] Generalize and unify state meta info snapshot
## What is the purpose of the change
This PR generalizes and unifies the de/serialization of state meta
information
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6276
@tillrohrmann Thanks for the fast review. Merging.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6276#discussion_r201013659
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupedInternalPriorityQueue.java
---
@@ -0,0 +1,31
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6275
LGTM ð
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6275#discussion_r200911028
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -1563,7 +1573,7 @@ public void run
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6275#discussion_r200737014
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -1563,7 +1573,7 @@ public void run
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6276
CC @tillrohrmann
---
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/6276
[FLINK-9486] Introduce TimerState in keyed state backend
## What is the purpose of the change
This PR integrates `InternalTimerQueue` with keyed state backends (Heap and
RocksDB
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6251
LGTM ð
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6196
I found there is still a small issue with the equals/hashCode but will just
fix it before merging.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6196
LGTM ð merging.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199894398
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -272,4 +254,60 @@ public int getVersion
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199894217
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -272,4 +254,60 @@ public int getVersion
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6228
@sihuazhou @azagrebin thanks for the reviews! I will merge this once my
travis is green.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199841799
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199817513
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199817285
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199817158
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199816750
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199816552
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199816139
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/KeyGroupPartitionedPriorityQueue.java
---
@@ -0,0 +1,280
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199816118
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOrderedSetStore.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199815863
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/KeyGroupPartitionedPriorityQueue.java
---
@@ -0,0 +1,280
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199814790
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueueSet.java
---
@@ -0,0 +1,186 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199814578
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueue.java
---
@@ -0,0 +1,341 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199813559
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueue.java
---
@@ -0,0 +1,341 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199813529
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueue.java
---
@@ -0,0 +1,341 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199812541
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyExtractorFunction.java
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199812074
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/InternalPriorityQueue.java
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6196
Had a few more comments, but they all are basically optimizations. I leave
it up to you if you still want to address all or some of them. Please let me
know. Otherwise, we can merge this. ð
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199783587
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,275 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199782860
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,275 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199782303
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,275 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199485075
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,258 @@
+/*
+ * Licensed
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6196
I had a few more comments, in particular some improvements for the new
serializer. I think when those are addressed this is good to merge.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199477483
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
---
@@ -0,0 +1,210 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199476870
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlStateFactory.java
---
@@ -0,0 +1,210 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199474873
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,258 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199474421
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,258 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199474494
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,258 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199474258
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,258 @@
+/*
+ * Licensed
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199474152
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,258 @@
+/*
+ * Licensed
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6228
@sihuazhou thanks for the fast review. I addressed all your comments.
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199442186
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOrderedStore.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199427083
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOrderedStore.java
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199426052
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOrderedStore.java
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/5799
LGTM ð Merging.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6186
Merging this.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6186
Had one more minor comment. Besides, this looks good ð Nice job!
---
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6186#discussion_r199109435
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlMapState.java
---
@@ -0,0 +1,134 @@
+/*
+ * Licensed
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6228
CC @azagrebin @sihuazhou
---
1 - 100 of 1452 matches
Mail list logo
