[GitHub] flink pull request #3688: [FLINK-6273] [core] don't convert hostname to lowe...

2017-10-13 Thread barcahead
Github user barcahead closed the pull request at: https://github.com/apache/flink/pull/3688 ---

[GitHub] flink issue #3391: [FLINK-5758] [yarn] support port range for web monitor

2017-04-21 Thread barcahead
Github user barcahead commented on the issue: https://github.com/apache/flink/pull/3391 @StephanEwen I will update the PR later --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #3688: [FLINK-6273] [core] don't convert hostname to lowe...

2017-04-06 Thread barcahead
GitHub user barcahead opened a pull request: https://github.com/apache/flink/pull/3688 [FLINK-6273] [core] don't convert hostname to lower cases to prevent akka connection failure For akka `Address`, the host part is case sensitive, So if we build remote jobmanager url with

[GitHub] flink pull request #3654: [FLINK-6152] [yarn] don't throw exception if clien...

2017-03-30 Thread barcahead
GitHub user barcahead opened a pull request: https://github.com/apache/flink/pull/3654 [FLINK-6152] [yarn] don't throw exception if client can't receive cluster status Currently if client can't get jobmanager status, it will throw exception and trigger shutdo

[GitHub] flink issue #3640: [FLINK-6213] [yarn] terminate resource manager itself whe...

2017-03-29 Thread barcahead
Github user barcahead commented on the issue: https://github.com/apache/flink/pull/3640 @StephanEwen Thanks for the review, I tested in my environment and `ProcessReaper` receives msg `Terminated` successfully. Because msg `PosionPill` is not a instance of `RequiredLeaderSessionID

[GitHub] flink pull request #3640: [FLINK-6213] [yarn] terminate resource manager its...

2017-03-29 Thread barcahead
GitHub user barcahead opened a pull request: https://github.com/apache/flink/pull/3640 [FLINK-6213] [yarn] terminate resource manager itself when shutting down application When number of failed containers exceeds maximum failed containers, `YarnFlinkResourceManager` will receive

[GitHub] flink issue #3416: [FLINK-5918] [runtime] port range support for config task...

2017-03-06 Thread barcahead
Github user barcahead commented on the issue: https://github.com/apache/flink/pull/3416 @zentol @tillrohrmann Thanks for your review, I have addressed your comments and updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request #3416: [FLINK-5918] [runtime] port range support for conf...

2017-03-06 Thread barcahead
Github user barcahead commented on a diff in the pull request: https://github.com/apache/flink/pull/3416#discussion_r104584562 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala --- @@ -720,5 +722,55 @@ object AkkaUtils { if (sslEnabled

[GitHub] flink pull request #3416: [FLINK-5918] [runtime] port range support for conf...

2017-03-02 Thread barcahead
Github user barcahead commented on a diff in the pull request: https://github.com/apache/flink/pull/3416#discussion_r104065323 --- Diff: flink-core/pom.xml --- @@ -165,6 +165,7 @@ under the License

[GitHub] flink issue #3391: [FLINK-5758] [yarn] support port range for web monitor

2017-02-26 Thread barcahead
Github user barcahead commented on the issue: https://github.com/apache/flink/pull/3391 @StephanEwen could you help review this pr please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #3416: [FLINK-5918] [runtime] port range support for conf...

2017-02-25 Thread barcahead
GitHub user barcahead opened a pull request: https://github.com/apache/flink/pull/3416 [FLINK-5918] [runtime] port range support for config taskmanager.rpc.port add port range support for config `taskmanager.rpc.port` using existing helper functions. The port range format follows

[GitHub] flink pull request #3391: [FLINK-5758] [yarn] support port range for web mon...

2017-02-22 Thread barcahead
GitHub user barcahead opened a pull request: https://github.com/apache/flink/pull/3391 [FLINK-5758] [yarn] support port range for web monitor 1. `jobmanager.web.port` now supports port range and has a string type default value - "8081" 2. a helper method `createServe

[GitHub] flink pull request #3267: [FLINK-5712] [config] update several deprecated co...

2017-02-12 Thread barcahead
Github user barcahead commented on a diff in the pull request: https://github.com/apache/flink/pull/3267#discussion_r100710125 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/services/MesosServicesUtils.java --- @@ -40,9 +41,11 @@ public static

[GitHub] flink pull request #3267: [FLINK-5712] [config] update several deprecated co...

2017-02-10 Thread barcahead
Github user barcahead commented on a diff in the pull request: https://github.com/apache/flink/pull/3267#discussion_r100660350 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/services/MesosServicesUtils.java --- @@ -40,9 +41,11 @@ public static

[GitHub] flink pull request #3267: [FLINK-5712] [config] update several deprecated co...

2017-02-04 Thread barcahead
GitHub user barcahead opened a pull request: https://github.com/apache/flink/pull/3267 [FLINK-5712] [config] update several deprecated configuration options 1. We should use 'containerized.heap-cutoff-ratio' and 'containerized.heap-cutoff-min' instead of depr

[GitHub] flink pull request #3261: [FLINK-5708] [doc] remove duplicated configuration...

2017-02-03 Thread barcahead
GitHub user barcahead opened a pull request: https://github.com/apache/flink/pull/3261 [FLINK-5708] [doc] remove duplicated configuration option remove duplicated configuration option in config.md You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink pull request #3173: Each time application is submitted to yarn, applic...

2017-01-19 Thread barcahead
GitHub user barcahead opened a pull request: https://github.com/apache/flink/pull/3173 Each time application is submitted to yarn, application id increases by two In method `deployInternal` in class `AbstractYarnClusterDescriptor`, a new application is created just to get yarn

[GitHub] flink pull request #3082: [FLINK-5427][docs]replace element with lastElement

2017-01-09 Thread barcahead
GitHub user barcahead opened a pull request: https://github.com/apache/flink/pull/3082 [FLINK-5427][docs]replace element with lastElement typo in event_timestamps_watermarks doc You can merge this pull request into a Git repository by running: $ git pull https://github.com