[GitHub] flink pull request #3253: [FLINK-5606] Remove magic number in key and namesp...

2017-02-07 Thread dawidwys
Github user dawidwys closed the pull request at: https://github.com/apache/flink/pull/3253 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3255: [FLINK-5509] Replace QueryableStateClient keyHashC...

2017-02-02 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/3255 [FLINK-5509] Replace QueryableStateClient keyHashCode argument Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink pull request #3253: [FLINK-5606] Remove magic number in key and namesp...

2017-02-02 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/3253 [FLINK-5606] Remove magic number in key and namespace serialization Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink pull request #1963: [FLINK-3870][docs] Added IntelliJ code style

2016-12-02 Thread dawidwys
Github user dawidwys closed the pull request at: https://github.com/apache/flink/pull/1963 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3870][docs] Added IntelliJ code style

2016-05-30 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1963#issuecomment-222518190 What version are you using @danielblazevski? I checked just now on 2016.1 and the instructions where valid. --- If your project is set up for it, you can reply to

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-27 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1981#issuecomment-222138623 Really sorry for those mistakes :( Thanks for fixing them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-26 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1981#issuecomment-221901395 I am not sure if you've seen my comment(due it was to some previous commit version). Let me paste my doubts about CNF one more time: > I am not sur

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-26 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/1981#discussion_r64763844 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -342,21 +368,29 @@ case class Join

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-26 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1981#issuecomment-221875998 I applied your changes @fhueske . If you have any comments regarding the equi-join validation I will address/apply them in the evening. --- If your project is set up

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-26 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1981#issuecomment-221846252 Thanks @fhueske for your comments. I uploaded another version with my resolutions to issues you've raised. Still happy to discuss. --- If your project is set u

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-26 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/1981#discussion_r64728794 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -298,11 +333,34 @@ case class Join

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-26 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/1981#discussion_r64714427 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -269,22 +269,57 @@ case class Join

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-24 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1981#issuecomment-221307901 @fhueske I have uploaded the updated PR. Unfortunately there are some strange VM crashes, that I think are not related to the changes. --- If your project is set up

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-24 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1981#issuecomment-221187695 Hi @fhueske. Yes I will update this PR today. Sorry I haven't done it earlier but I was away for the past week. --- If your project is set up for it, you can rep

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-10 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/1981 [Flink-2971][table] Add outer joins to the Table API Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If

[GitHub] flink pull request: [FLINK-3842] [table] Fix handling null record/...

2016-05-10 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1974#issuecomment-218221293 I think those failing tests are unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [docs] Added IntelliJ code style

2016-05-04 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/1963 [docs] Added IntelliJ code style Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all

[GitHub] flink pull request: [FLINK-2946] Add orderBy() to Table API

2016-04-26 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1926#issuecomment-214862766 I tried to address all your comments. Unfortunately I didn't notice lines longer than 100 yesterday, sorry for that. I started working on outer joins

[GitHub] flink pull request: [FLINK-2946] Add orderBy() to Table API

2016-04-25 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/1926#discussion_r60936652 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/SortITCase.scala --- @@ -0,0 +1,121 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-2946] Add orderBy() to Table API

2016-04-22 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1926#issuecomment-213575798 Always glad to help! In fact I would be happy for any suggestions what can I work on further. I changed the tests. --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2946] Add orderBy() to Table API

2016-04-22 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/1926 [FLINK-2946] Add orderBy() to Table API Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes

[GitHub] flink pull request: [FLINK-3665] Implemented sort orders support i...

2016-04-20 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1848#issuecomment-212581664 I think I applied all changes. Unfortunately the travis build fails but I don't know why. The test it fails has nothing in common with my changes. It

[GitHub] flink pull request: [FLINK-3665] Implemented sort orders support i...

2016-04-20 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/1848#discussion_r60410346 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java --- @@ -546,43 +549,274 @@ public void

[GitHub] flink pull request: [FLINK-3665] Implemented sort orders support i...

2016-04-20 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1848#issuecomment-212432502 Unfortunately I agree that it can be confusing but could not find an easier way to properly test it. I will fix the issue with the smaller equal -> smal

[GitHub] flink pull request: [FLINK-3665] Implemented sort orders support i...

2016-04-20 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/1848#discussion_r60409121 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java --- @@ -546,43 +549,274 @@ public void

[GitHub] flink pull request: [FLINK-3665] Implemented sort orders support i...

2016-04-20 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/1848#discussion_r60409063 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java --- @@ -546,43 +549,264 @@ public void

[GitHub] flink pull request: [FLINK-3665] Implemented sort orders support i...

2016-04-20 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/1848#discussion_r60392270 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java --- @@ -546,43 +549,264 @@ public void

[GitHub] flink pull request: [FLINK-3665] Implemented sort orders support i...

2016-04-20 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/1848#discussion_r60391643 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/PartitionITCase.java --- @@ -546,43 +549,264 @@ public void

[GitHub] flink pull request: [FLINK-3665] Implemented sort orders support i...

2016-04-15 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1848#issuecomment-210485959 Hi @fhueske, I hope I applied all your comments, so it would be nice if you could have a look at it once again. --- If your project is set up for it, you can reply to

[GitHub] flink pull request: [FLINK-3665] Implemented sort orders support i...

2016-04-10 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/1848#discussion_r59137767 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java --- @@ -98,6 +101,14 @@ public PartitionOperator(DataSet

[GitHub] flink pull request: [FLINK-3665] Implemented sort orders support i...

2016-04-02 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/1848 [FLINK-3665] Implemented sort orders support in range partitioning You can merge this pull request into a Git repository by running: $ git pull https://github.com/dawidwys/flink withOrders

[GitHub] flink pull request: [FLINK-3574] Implement math functions for Tabl...

2016-03-14 Thread dawidwys
Github user dawidwys closed the pull request at: https://github.com/apache/flink/pull/1775 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3574] Implement math functions for Tabl...

2016-03-14 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1775#issuecomment-196249782 Great. I will gladly take over. Will you assign it to me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-3574] Implement math functions for Tabl...

2016-03-14 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1775#issuecomment-196227330 @twalthr The Table API operators sounds interesting. I will also gladly work on the Code generation. Frankly, the least fun would be tests for me. --- If your project

[GitHub] flink pull request: [FLINK-3574] Implement math functions for Tabl...

2016-03-12 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1775#issuecomment-195784404 Glad I could help. I would also happily take on another issue regarding table API and SQL support if you could advise me some. --- If your project is set up for it

[GitHub] flink pull request: [FLINK-3574] Implement math functions for Tabl...

2016-03-08 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/1775 [FLINK-3574] Implement math functions for Table API You can merge this pull request into a Git repository by running: $ git pull https://github.com/dawidwys/flink mathFunctions

[GitHub] flink pull request: [FLINK-2156] Scala modules cannot create loggi...

2015-10-06 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/1234 [FLINK-2156] Scala modules cannot create logging file You can merge this pull request into a Git repository by running: $ git pull https://github.com/dawidwys/flink master Alternatively you

<    2   3   4   5   6   7