Github user etiennecarriere commented on the issue:
https://github.com/apache/flink/pull/6149
Hi @pnowojski,
Unfortunately, this patch is not working because :
* The implementation of FileSystem is using a temporary file to store it
** s3 : it is mandatory to know
Github user etiennecarriere commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195687859
--- Diff:
flink-core/src/test/java/org/apache/flink/core/fs/LimitedConnectionsFileSystemTest.java
---
@@ -122,6 +122,42 @@ public void
Github user etiennecarriere commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195682592
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/LimitedConnectionsFileSystem.java
---
@@ -940,7 +932,9 @@ public int read() throws
Github user etiennecarriere commented on a diff in the pull request:
https://github.com/apache/flink/pull/6149#discussion_r195682578
--- Diff:
flink-core/src/test/java/org/apache/flink/core/fs/LimitedConnectionsFileSystemTest.java
---
@@ -122,6 +122,42 @@ public void
Github user etiennecarriere commented on the issue:
https://github.com/apache/flink/pull/6149
@pnowojski , I add a unit test which validate the rate limiting feature but
:
* It add 20s to the unit test . Would it be better to move to Integration
Test (even
Github user etiennecarriere commented on the issue:
https://github.com/apache/flink/pull/6149
@pnowojski , I already addressed the small remarks but not the test part.
I will try to propose a first test versions in the next days.
---
GitHub user etiennecarriere opened a pull request:
https://github.com/apache/flink/pull/6149
[FLINK-9560] Add RateLimiting for FileSystem
## Contribution Checklist
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can set up
Github user etiennecarriere commented on the issue:
https://github.com/apache/flink/pull/5296
We tested this PR with flink 1.4 and the swift offered by French Hoster
OVH.
I was fine for checkpoint .
---
