Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/6407
Maybe @twalthr you can have a look at this?
---
GitHub user florianschmidt1994 opened a pull request:
https://github.com/apache/flink/pull/6407
[FLINK-8478][docs] Add documentation page for different datastream joins
## What is the purpose of the change
Add a documentation page under Application Development / Streaming
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/6216
> (Did you start a review, but wrote your comment separately? Then your
review would still be in progress!)
Yes :D I submitted it now
>The issues you iden
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6216#discussion_r199719951
--- Diff:
flink-end-to-end-tests/test-scripts/test_queryable_state_restart_tm.sh ---
@@ -85,20 +90,23 @@ function run_test() {
exit
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/6216
Thanks @zentol, I have one remark (see above), besides that looks good to
me!
Additionally I had some ideas that came to mind that I think we could
discuss:
- We have
GitHub user florianschmidt1994 opened a pull request:
https://github.com/apache/flink/pull/6197
[FLINK-9638][E2E Tests] Add helper script to run single test
## What is the purpose of the change
Usage: ./run-single-test.sh [ ...]
This PR adds a helper script `run-single
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5807
@kl0u can you have a look at this?
---
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/6172
Thanks for proof-reading! I addressed your comments and squashed the PR
---
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/6172
@tzulitai or @zentol Can you skim over this if you have some time?
---
GitHub user florianschmidt1994 opened a pull request:
https://github.com/apache/flink/pull/6172
[FLINK-9594][E2E tests] Improve docs for new test runner]
## What is the purpose of the change
Improve documentation for end-to-end tests with the new test runner pattern
introduced
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/6053
@zentol Looks like travis likes it ð
---
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6053#discussion_r195081885
--- Diff: flink-end-to-end-tests/test-scripts/test-runner-common.sh ---
@@ -0,0 +1,76 @@
+#!/usr/bin/env bash
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6053#discussion_r195080229
--- Diff: flink-end-to-end-tests/test-scripts/test-runner-common.sh ---
@@ -0,0 +1,76 @@
+#!/usr/bin/env bash
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6053#discussion_r195076092
--- Diff:
flink-end-to-end-tests/test-scripts/test_local_recovery_and_scheduling.sh ---
@@ -71,8 +69,14 @@ function run_local_recovery_test
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5342
@kl0u I made some changes on how I handle events on either side of the
stream. By introducing some generic methods we can now reuse large parts of the
code for either input stream
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5762
@twalthr How are we planning to proceed on this PR?
---
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/6053
Thanks @zentol and @tzulitai for the review. I addressed your concerns in
the lastest couple of commits
---
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6053#discussion_r195036305
--- Diff:
flink-end-to-end-tests/test-scripts/test_local_recovery_and_scheduling.sh ---
@@ -53,8 +53,6 @@ function cleanup_after_test
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6053#discussion_r192139268
--- Diff: flink-end-to-end-tests/test-scripts/test-runner-common.sh ---
@@ -0,0 +1,76 @@
+#!/usr/bin/env bash
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/6053
@zentol Maybe you could have a look at this?
---
GitHub user florianschmidt1994 opened a pull request:
https://github.com/apache/flink/pull/6053
[FLINK-9257][E2E Tests] Fix wrong "All tests pass" message
## What is the purpose of the change
Fix a wrongly printed "All tests PASS" message when
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6028#discussion_r189815546
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5482#discussion_r183727245
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/JoinedStreams.java
---
@@ -137,6 +158,151 @@ public
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5482
Thanks for your comments @bowenli86 and sorry for the delay! I added some
comments and some stuff I'll be addressing right away
---
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5482#discussion_r183712409
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java
---
@@ -0,0 +1,480
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5482#discussion_r183706512
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java
---
@@ -0,0 +1,480
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5482#discussion_r183705882
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/JoinedStreams.java
---
@@ -137,6 +158,151 @@ public
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5482#discussion_r183704705
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/JoinedStreams.java
---
@@ -137,6 +158,151 @@ public
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5482#discussion_r183703916
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/JoinedStreams.java
---
@@ -137,6 +158,151 @@ public
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5807
Thanks! I addressed the changes in the last two commits
---
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5762#discussion_r178828282
--- Diff:
flink-end-to-end-tests/flink-avro-classloading-test/src/main/avro/user.avsc ---
@@ -0,0 +1,9 @@
+{
+ "type"
GitHub user florianschmidt1994 opened a pull request:
https://github.com/apache/flink/pull/5807
[FLINK-8982][E2E Tests] Add test for known failure of queryable state
## What is the purpose of the change
Add an end-to-end test to verify that the changes that @kl0u introduced
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5762#discussion_r178758895
--- Diff:
flink-end-to-end-tests/flink-avro-classloading-test/src/main/avro/user.avsc ---
@@ -0,0 +1,9 @@
+{
+ "type"
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5762
@aljoscha @patricklucas Could you maybe have a look at this?
---
GitHub user florianschmidt1994 opened a pull request:
https://github.com/apache/flink/pull/5762
[FLINK-9078][E2ETests] Add test that verifies correct avro behaviour
## What is the purpose of the change
There was a specific kind of classloading issue where a flink job would
fail
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5717
Thanks @zentol! I addressed your comments and will squash if approved
---
GitHub user florianschmidt1994 opened a pull request:
https://github.com/apache/flink/pull/5717
[FLINK-9020][E2E Tests] Use separate modules per testcase
## Use separate maven modules per test case in end-to-end tests
This change sets up the end-to-end project dir in a way
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5717
@kl0u Could you have a look at this?
---
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5692
@zentol I found this browsing through the docs
---
GitHub user florianschmidt1994 opened a pull request:
https://github.com/apache/flink/pull/5692
[docs] Fix typo in Python API docs
Rename `Tockenizer` to `Tokenizer` in python docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user florianschmidt1994 opened a pull request:
https://github.com/apache/flink/pull/5482
[Flink-8480][DataStream] Add Java API for timebounded stream join
## What is the purpose of the change
* Add a JavaAPI to the DataStream API to join two streams based on
user
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5342#discussion_r164747531
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java
---
@@ -0,0 +1,398
Github user florianschmidt1994 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5342#discussion_r164708594
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/TimeBoundedStreamJoinOperator.java
---
@@ -0,0 +1,398
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5342
@hequn8128 Thank you for the review. Regarding your concern about delaying
the watermark I added some sketches and description about my thought process to
the design document.
---
GitHub user florianschmidt1994 opened a pull request:
https://github.com/apache/flink/pull/5382
[FLINK-8524][JavaDoc] Fix JavaDoc for TypeExtractor.getBinaryReturnType
## What is the purpose of the change
Fix JavaDoc for TypeExtractor.getBinaryReturnType
## Brief change
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5342
@bowenli86 the document should now be be public for everyone to comment on.
Yes, it caches data on either side, and for each incoming element it looks
up eligible records from
Github user florianschmidt1994 commented on the issue:
https://github.com/apache/flink/pull/5342
Yeah seems like I made a typo there. It's actually
https://issues.apache.org/jira/browse/FLINK-8479, I just fixed the title.
---
GitHub user florianschmidt1994 opened a pull request:
https://github.com/apache/flink/pull/5342
[FLINK-8470] Timebounded stream join
## What is the purpose of the change
Add a time-bounded inner join implementation of two streams as a
TwoInputStreamOperator, as discussed
48 matches
Mail list logo
