Github user fmthoma commented on the issue:
https://github.com/apache/flink/pull/6221
@tillrohrmann @tzulitai Thank you!
---
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6221#discussion_r199462901
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/AWSConfigConstants.java
---
@@ -45,29
GitHub user fmthoma opened a pull request:
https://github.com/apache/flink/pull/6221
[FLINK-9686] [kinesis] Enable Kinesis authentication via AssumeRole
## What is the purpose of the change
Enable `FlinkKinesisProducer` to authenticate via assuming a role
Github user fmthoma commented on the issue:
https://github.com/apache/flink/pull/6021
Merged manually by squashing: 7d034d4
---
Github user fmthoma closed the pull request at:
https://github.com/apache/flink/pull/6021
---
Github user fmthoma commented on the issue:
https://github.com/apache/flink/pull/6021
@tzulitai Thanks for your last review comments! I addressed them, and
rebased the branch against master.
---
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r197143428
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -326,6
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r197143312
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/TimeoutLatch.java
---
@@ -0,0 +1,41
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r197143254
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -326,6
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r197142648
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -144,6
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r197141591
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -55,6
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r197137205
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducerTest.java
---
@@ -267,6
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r192861304
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -180,9
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r192861127
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/TimeoutLatch.java
---
@@ -0,0 +1,41
Github user fmthoma commented on the issue:
https://github.com/apache/flink/pull/6021
@tzulitai @bowenli86 I've made some more changes while investigating
awslabs/amazon-kinesis-producer#183:
* I've followed your suggestion and used `wait()` instead of
`Thread.sleep()`, see
Github user fmthoma commented on the issue:
https://github.com/apache/flink/pull/6021
@tzulitai I added some docs.
As for the `flush()` vs. just waiting: As I see it, the
[`RecordMaxBufferedTime`](https://github.com/awslabs/amazon-kinesis-producer/blob
Github user fmthoma commented on the issue:
https://github.com/apache/flink/pull/6021
@tzulitai I believe the right location is `docs/dev/connectors/kinesis.md`?
I'll add some docs there.
---
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r190154347
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -326,6
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r189432802
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -326,6
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r189432920
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -326,6
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r189433306
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -326,6
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r189432726
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -326,6
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r189432794
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -326,6
Github user fmthoma commented on a diff in the pull request:
https://github.com/apache/flink/pull/6021#discussion_r189432840
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -218,6
Github user fmthoma commented on the issue:
https://github.com/apache/flink/pull/6021
@tzulitai I agree on adding additional docs, where do you suggest I should
put them? In the Javadoc on `setQueueLimit()`?
My current suggestion is to look at the size of your individual
GitHub user fmthoma opened a pull request:
https://github.com/apache/flink/pull/6021
[FLINK-9374] [kinesis] Enable FlinkKinesisProducer Backpressuring
## What is the purpose of the change
The `FlinkKinesisProducer` just accepts records and forwards it to a
`KinesisProducer
26 matches
Mail list logo
