Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90929487
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90924411
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90924109
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90923574
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteEdge.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90937167
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90921530
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteEdge.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90926220
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90938901
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java
---
@@ -480,7 +480,8 @@ protected static
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90937740
--- Diff:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/BipartiteEdgeTest.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90926409
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90921785
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteEdge.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90937555
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/Projection.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90923609
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90931164
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90930301
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90933026
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90935587
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90926642
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90929479
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java
---
@@ -0,0 +1,364 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90922934
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteEdge.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2564#discussion_r90938279
--- Diff:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/ProjectionTest.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2901
@fhueske, please review the additional commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2898
Unless a PR is urgent we typically allow a few days to see if any
additional comments come in from the community. This looks good so I'm merging
it now. Thanks for the contribution!
---
If your
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2617
@StephanEwen, no worries about deferring this. Performance is nice but
scaling and stability certainly takes precedence. Just wanted to make sure
there was ample time between review and release
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2467
Merging this ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2457
Merging this ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2617
Hi @StephanEwen, should we endeavor to get this into 1.2 or defer to the
next release?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2809#discussion_r90306654
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -957,4 +969,65 @@ public void run
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2809#discussion_r90303696
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -40,15 +43,21 @@
import org.slf4j.Logger
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2809#discussion_r90305721
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/stats/PendingCheckpointStats.java
---
@@ -0,0 +1,187 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2809#discussion_r90312273
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -957,4 +969,65 @@ public void run
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2809#discussion_r90308555
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -214,6 +224,8 @@ public CheckpointCoordinator
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2809#discussion_r90306783
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/stats/PendingCheckpointStats.java
---
@@ -0,0 +1,187 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2902#discussion_r90274186
--- Diff:
flink-runtime-web/web-dashboard/app/partials/taskmanager/taskmanager.metrics.jade
---
@@ -75,18 +75,18 @@ div(ng-if="metrics.id")
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2902#discussion_r90273043
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagersHandler.java
---
@@ -124,13 +124,21 @@ public String
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2902#discussion_r90272935
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagersHandler.java
---
@@ -124,13 +124,21 @@ public String
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2902
[FLINK-5209] [webfrontend] Fix TaskManager metrics
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2898
The builds are run with five different configurations each split into two
sets of tests. Looking at the details 9/10 passed which is a success.
---
If your project is set up for it, you can reply
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2901
[FLINK-3921] StringParser encoding
This further modifies #2060:
- save charset as String which is serializable
- remove unused methods
- annotate new CsvReader methods
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2898
Looks good to merge after the tests finish.
One more thought: if your IDE is set to fix trailing whitespace, it's fine
in this PR since only a few lines changed but for larger PRs you'll
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2892
Hi @Hapcy, thanks for submitting this PR.
It's best to create a feature branch for each ticket rather than committing
to master. You can fix this by creating a branch (git checkout master
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2664
@StephanEwen @rmetzger, why would a user copy an optional fat jar rather
than having it included in their uber jar?
By creating fat jars, do we not have the potential for duplicate
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2060
I am working on merging this ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2664
@rmetzger, I have not been able to improve on the current configuration.
`useTransitiveFiltering` seems to work as the inverse from the plugin
documentation (true prevents transitive dependencies
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2842
@vasia should `Graph` be using the function specific
`TypeExtractor.getMapReturnTypes` (not sure why this is plural) and similar
where core Functions are used?
For `Gelly` functions, I
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2664
@rmetzger it appears that project artifacts are not included as transitive
dependencies and I had overlooked 0.9 as a dependency for the 0.10 connector.
After correcting this the provided
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2850
Does Flink build against Hadoop 3.0.0-alpha1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2842
I count nine uses of `TypeExtractor.createTypeInfo` in `Graph` and one each
in `ScatterGatherIteration`, `VertexCentricIteration`, and
`GatherSumApplyIteration`. The latter still need to allow
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2842#discussion_r88920404
--- Diff:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/TypeExtractorTest.java
---
@@ -0,0 +1,106
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2842#discussion_r88919069
--- Diff:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/TypeExtractorTest.java
---
@@ -0,0 +1,106
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2842#discussion_r88914659
--- Diff:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/TypeExtractorTest.java
---
@@ -0,0 +1,106
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2842#discussion_r88919762
--- Diff:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/TypeExtractorTest.java
---
@@ -0,0 +1,106
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2842#discussion_r88921327
--- Diff:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/TypeExtractorTest.java
---
@@ -0,0 +1,106
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2832
[FLINK-4936] [gelly] Operator names for Gelly inputs
Provide descriptive operator names for Graph and GraphCsvReader.
Condense multiple type conversion maps into a single mapper.
Reuse
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2060
@rekhajoshm have you had a chance to look again at this PR? The 1.2 feature
freeze will be in a few weeks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2066
The `Dockerfile` has been fully rewritten since this PR. @techmaniack is
there additional functionality still needed or can this PR be closed?
---
If your project is set up for it, you can reply
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/1033
Is this PR's functionality still requested or can it be closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2814
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2740
`zipWithIndex` preserves the order between partitions
(DataSetUtils.java:121). @tfournier314, I don't think it's a problem pushing
your current code since we're still discussing the PR
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2802
Line 110 is closed by `` on line 85.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2457
1) `JsonPlanGenerator.java:55` should be reverted to use `NOT_SET`.
2) `index.js` is changing jobServer from the empty string to
'http://localhost:8081/'.
3) `vendor.js` is upgrading
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2740#discussion_r87860878
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StringIndexer.scala
---
@@ -0,0 +1,108 @@
+package
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2740#discussion_r87863825
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StringIndexer.scala
---
@@ -0,0 +1,108 @@
+package
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2800
Hi @bitchelov, I don't think we want to advertise the Travis CI status.
Builds consistently fail, both due to Flink test instability and issues running
on the Travis CI architecture. We test each
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2802#discussion_r87820837
--- Diff: docs/_includes/sidenav.html ---
@@ -147,3 +147,4 @@
+
--- End diff --
The div is closed on line 85
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2457#discussion_r87440964
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/jsonplan/JsonPlanGenerator.java
---
@@ -52,10 +52,10 @@ public static String
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2782
1) This needs a Jira ticket.
2) There are more cases in `FlumeSink` where `client` accessed without
checking for `null`.
---
If your project is set up for it, you can reply to this email
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2564
Try switching to `ExecutionEnvironment.createCollectionsEnvironment()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2708
@mxm I pushed a new commit that is working in YARN with recursive
directories. The issue looks to have been that YARN was copying files
recursively but the Java classpath can only contain simple
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2708
@uce @mxm after adding the recursive wildcard the nested jar files are
copied to the application directory within HDFS. This is my first time testing
Flink on YARN and I am getting
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2730
@vasia docs are updated. I also noted the dependence of the algorithm on
implementation of `equals()`. What are your thoughts on requiring vertex types
to implement `Comparable` instead
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2731
@vasia the graphs have been removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2764
I haven't yet looked at this PR in detail but it looks to have some much
needed cleanup for the documentation.
Are we certain we need to abandon Eclipse as a viable IDE for Flink
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2731
The RMat graph is used across many tests and the intent was to verify the
larger tests against secondary frameworks. I have no problem leaving out the
files as the command is documented
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2724
I have no issue with removing the properties tab. @iampeter the new UI
features look very nice!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r86554520
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade ---
@@ -50,19 +50,15 @@
nav.navbar.navbar-default.navbar-fixed-top.navbar-main(ng
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2724#discussion_r86530365
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade ---
@@ -50,19 +50,15 @@
nav.navbar.navbar-default.navbar-fixed-top.navbar-main(ng
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2740#discussion_r86392126
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StringIndexer.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2740#discussion_r86391230
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StringIndexer.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2740#discussion_r86391698
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StringIndexer.scala
---
@@ -0,0 +1,163 @@
+/*
+ * Licensed
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2737
Why not keep the color image for the favicons? The smaller size looks like
a black blob to my eyes. The current color icon is distinctive and will look
even better at 32x32. If we wanted to use B
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2743
[FLINK-4996] [core] Make CrossHint @Public
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 4996_make_crosshint_public
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2737
The Travis CI tests have never been stable. There are five parallel builds
each split into two jobs and 9 of 10 passed for the latest commit on this PR.
The tests are significantly more stable
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2664
@StephanEwen the latest commit uses a separate module to prevent the
optional packages and dependencies from being included in the `flink-dist` uber
jar. `flink-dist-opt` assembles
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2737
Could we enhance the favicon itself? I tried
`http://realfavicongenerator.net/` and there are many other 'favicon
generators'.
I used this image:
https://github.com/apache/flink-web/blob
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2664
I need to rework this since additional classes are being pulled into the
uber jar.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2733
[FLINK-4896] [gelly] PageRank algorithm for directed graphs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2731
[FLINK-4934] [gelly] Triadic Census
A triad is any three vertices in a graph. The triadic census produces
counts for each of the 4 undirected and 16 directed triad types.
You can merge this pull
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2730
[FLINK-4970] [gelly] Parameterize vertex value for SSSP
The input vertex values for SingleSourceShortestPaths and
GSASingleSourceShortestPaths are unused and replaced with a parameterized type
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2725
[FLINK-4963] [gelly] Tabulate edge direction for directed VertexMetrics
The current implementation simply counts edges. We can do one better and
tabulate unidirectional (u:v but no v:u
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2708
[FLINK-4946] [scripts] Load jar files from subdirectories of lib
The Flink classpath is a concatenation of jar files in lib/. This commit
includes files from subdirectories of lib
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2664
@StephanEwen latest commit assembles connectors into separate directories.
I'll create a ticket for loading jar files from subdirectories of`lib`.
---
If your project is set up
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2704
I keep an `_minutiae` branch and push that every few months, typically
after a release. There are fixed costs at each level of Flink's ticketing /
pull request / verify / commit process
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2704
I'd recommend collecting typographical and grammatical errors within
comments into a larger ticket and pull request.
---
If your project is set up for it, you can reply to this email and have
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2664
The mailing list conversation only included an indirect reference to
including connectors in this `opt` directory. I was just trying to verify that
we did in fact wish to include
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2670
I pushed a commit to remove the `GraphMetrics` example.
I think providing drivers for all library methods is both desirable and
ambitious. If we like the form and functionality
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2670
[FLINK-4204] [gelly] Clean up gelly-examples
Moves drivers into separate package. Adds default main class to print usage
listing included classes. Includes documentation for running Gelly
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2662
@mxm thanks for the review. I added a second commit which I think satisfies
your request. When no job is executed then the message is printed to stderr
without a stacktrace.
---
If your project
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2628
Thanks @ggevay for reviewing. I added a commit with additional comments.
I transcribed `Quicksort` so as to remove considerations of Java
performance and inlining. It was not clear to me
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2606
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
701 - 800 of 1173 matches
Mail list logo
