Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/492#issuecomment-83655940
+1 SHIP IT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/499#discussion_r26686143
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1274,9 +1274,10 @@ object TaskManager
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/501#discussion_r26704861
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/GroupCombineITCase.java
---
@@ -276,7 +276,7 @@ public void
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/501#discussion_r26704856
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/GroupCombineITCase.java
---
@@ -58,7 +58,7 @@
*/
public class
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/499#issuecomment-83150196
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/482#issuecomment-82605275
This is merged by @StephanEwen with
http://git-wip-us.apache.org/repos/asf/flink/commit/72ca014e.
Thanks Stephan.
---
If your project is set up for it, you can
Github user hsaputra closed the pull request at:
https://github.com/apache/flink/pull/482
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/494
Add final modifier to PollingThread#lock object
Add final modifier to PollingThread#lock object to make sure immutability
as lock object.
You can merge this pull request into a Git repository
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/466#issuecomment-81777035
HI @mxm, appreciate the ACK. Just trying to keep up all informed with more
code coming in.
It is harder to read other people code and flow so was just trying to ease
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/479#discussion_r26526474
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/common/FlinkTools.scala
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/466#issuecomment-79188765
Thanks @mxm ! I add couple more comments about documentation. I am trying
to promote habit of adding JavaDoc comment for new classes to help indicate why
it has
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/466#discussion_r26407753
--- Diff:
flink-compiler/src/main/java/org/apache/flink/compiler/operators/GroupCombineProperties.java
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/482#issuecomment-78991357
The issue is that those params are not in command line doc. Or maybe I
misread ?
Removing unnecessary param will make it easier to read.
On Friday, March
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/482#issuecomment-79140904
Thanks for the input @fhueske. I am trying to make all the example
consistent and removing the parameters seem to be consistent with examples in
the command line page
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/479#issuecomment-78541637
@tillrohrmann, could you fire JIRA for this one? Should help when we want
to manage releases or merge between branches.
---
If your project is set up for it, you can
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/454#issuecomment-78560058
How much time does this new shading add to the total compile? It used to be
around 16-18mins for me using mvn clean install -DskipTests.
I just did merge today
GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/482
Remove -j and -a parameters which seemed no longer valid in the doc example
for YARN
From:
./bin/flink run -j
./examples/flink-java-examples-{{site.FLINK_VERSION_SHORT }}-WordCount.jar
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/466#discussion_r26064533
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/operators/base/GroupReducePartialOperatorBase.java
---
@@ -0,0 +1,150
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/461#issuecomment-77796550
Thx @StephanEwen, will merge this tomorrow unless someone beats me to it =)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/460#issuecomment-77796609
Thx @StephanEwen, will merge this tomorrow unless someone else beats me to
it.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/461
Fix checking null for ternary operator check on Exception#getMessage calls
Add parentheses on Exception#getMessage calls from pattern of:
Initializing the input processing failed
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/457#issuecomment-77469917
Thx @tillrohrmann, @uce for the review!
Will merge once it passes the build
---
If your project is set up for it, you can reply to this email and have your
reply
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/453#discussion_r25801300
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/Path.java ---
@@ -217,7 +211,17 @@ public Path(String pathString) {
*the path
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/443#issuecomment-76667900
Thx for the review, will merge this soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/443
Fix typos in iterations.md file
-) Remove extra solution word.
-) Change propagete to propagate.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/434#discussion_r25399885
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/utils/MinSpanningTreeData.java
---
@@ -0,0 +1,91
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/434#discussion_r25399853
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/MinSpanningTreeExample.java
---
@@ -0,0 +1,132 @@
+/*
+ * Licensed
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/437#issuecomment-75822423
+1 LGTM
How can Java compiler miss this I am confused =(
My IntelliJ IDEA has a red wiggly line indicating mismatch package name.
---
If your project is set
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/436#issuecomment-75861629
W000t!
+1 @uce =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/431#issuecomment-75414784
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/421#issuecomment-75091767
You are the man, Robert!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/416
Remove extra space after open parenthesis in InstanceConnectionInfo#toString
Small update to remove extra space after open parenthesis in
InstanceConnectionInfo#toString to be consistent with other
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/417#discussion_r24931138
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/IOManager.java
---
@@ -52,26 +57,88 @@
/**
* Constructs
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/417#issuecomment-74930615
Since the IOManager add shutdown hook to clean up the files, should
IOManagerAsync#isProperlyShutDown need to call super.isProperlyShutDown ?
---
If your project is set
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/396#issuecomment-74558015
Thanks for the review Ufuk and Stephan.
Also thx for Stephan for merging it.
---
If your project is set up for it, you can reply to this email and have your
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/394#issuecomment-74388302
No worries, thanks for replying to my concern =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/394#discussion_r24689710
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -517,67 +521,83 @@ protected int list(String[] args
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/394#discussion_r24690375
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerTest.java
---
@@ -486,7 +489,8 @@ protected void run
GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/396
[FLINK-1542] Test case at BlobUtilsTest should not assume user could not
create new item in root directory
[FLINK-1542] Test case at BlobUtilsTest should not assume user could not
create new item
GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/373
Remove unused enum values from Aggregations enum.
SImple cleanup to remove unused enum values from Aggregations enum.
You can merge this pull request into a Git repository by running:
$ git
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/368#discussion_r24220454
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -125,6 +126,10 @@ Actor with ActorLogMessages
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/344#discussion_r24097257
--- Diff:
flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingMemoryArchivist.scala
---
@@ -31,10 +31,11 @@ trait
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/202#discussion_r23973573
--- Diff:
flink-addons/flink-language-binding/src/main/python/org/apache/flink/languagebinding/api/python/dill/__diff.py
---
@@ -0,0 +1,247
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/349#issuecomment-72262547
@aalexandrov, could you file JIRA to associate this PR with? I need it for
tracking purposes and releases.
Thanks!
---
If your project is set up for it, you can
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/349#issuecomment-72291369
@aalexandrov, cool! Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/346#issuecomment-72111491
@coderxiang, ah that the tests do comparison in the after method so it is
hard to figure out which method fail. But seemed like other builds passed and I
am sure
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/346#issuecomment-72109489
HI @aljoscha, thanks.
If you could merge it before later tonight please do. Otherwise I could do
it later tonight if you did not have time to get to this one
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/351#issuecomment-72162452
To reduce code duplication and tracing, we could just throw the exception
inside createInput(InputFormatX, ? inputFormat, TypeInformationX
producedType) by wrapping
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/346#issuecomment-71948299
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/328#discussion_r23485615
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -175,62 +175,79 @@ import
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/328#discussion_r23485570
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -175,62 +175,79 @@ import
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/324#issuecomment-71119613
Cool, thanks @StephanEwen, if no one beats me merging I will do this EOD
today
---
If your project is set up for it, you can reply to this email and have your
reply
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/328#issuecomment-71148024
Thanks for the explation @tillrohrmann
+1 for exponential backoff approach. We can have max retries and max delay
for each try as configurable configuration
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/324#issuecomment-71134892
As per recommendation from @StephanEwen, will not merge this to 0.8 until
we need to cherry-pick fixes related to these files.
---
If your project is set up for it, you
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/324#issuecomment-71079720
Can I get +1 for this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/324#issuecomment-70715529
I rename the file from coGroupDataSet.scala to CoGroupDataSet.scala and
crossDataSet.scala to CrossDataSet.scala to follow convention Scala file naming.
And move
GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/324
Rename coGroupDataSet.scala to CoGroupDataSet.scala, and crossDataSet.scala
to CrossDataSet.scala
This PR contains changes to follow Scala style:
-) Rename coGroupDataSet.scala
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/313#issuecomment-70284303
Thanks @rmetzger, will merge this today. Not a blocker for 0.8 so I will
not merge it to 0.8 branch.
---
If your project is set up for it, you can reply to this email
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/306#issuecomment-69967270
Ah ok, thanks for the info Stephen, good to know it was intentional.
Do you want to keep this pattern?
---
If your project is set up for it, you can reply
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/296#issuecomment-69971212
+1 gentler and informative =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/306#issuecomment-69992202
I don't remember if there any best practice about this, so If we think it
is useful we could keep this style and maybe document it?
But I don't think it is good
201 - 261 of 261 matches
Mail list logo
