Github user mbode commented on the issue:
https://github.com/apache/flink/pull/4586
I mean in general it is probably not the best thing to just rely on the
port not being available as a consensus algorithm of who should claim which
port. Then again, I could not think
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/4586
Also there should have been the warning "Could not start PrometheusReporter
HTTP server on any configured port. Ports: ...", wasn't this logged?
---
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/4586
Did you configure a port range with sufficient (i.e.) three ports? By
default, it uses only one port. I added a sentence about this to the readme but
maybe we can make this more explicit?
---
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/4586
[Green Travis](https://travis-ci.org/mbode/flink/builds/290468452)
---
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/4586
I implemented your comments and assembled a [small
setup](https://github.com/mbode/flink-prometheus-example) to test the reporter
again.
It currently clones *master* and build the reporter
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/4586
@zentol *ping*
---
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/4586
@zentol It would be great if you could have another look on occasion, I
added better handling for metrics that are registered e.g. by different
subtasks.
[green travis](https://travis-ci.org
Github user mbode commented on a diff in the pull request:
https://github.com/apache/flink/pull/4586#discussion_r136503621
--- Diff:
flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTest.java
---
@@ -160,6 +151,43
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/4586
[Green Travis](https://travis-ci.org/mbode/flink/builds/268258386)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user mbode opened a pull request:
https://github.com/apache/flink/pull/4586
[FLINK-7502] [metrics] Improve PrometheusReporter
## What is the purpose of the change
*This pull request addresses several issues that came up when testing
PrometheusReporter in a YARN
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/3833
I see, makes sense. Finally got around to fixing the dependency and getting
a [Green Travis](https://travis-ci.org/mbode/flink/builds/240926382).
---
If your project is set up for it, you can reply
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/3833
Oh, I broke the stricter checkstyle. To me, it feels a bit weird to have to
put javadoc on tests, is that intended?
---
If your project is set up for it, you can reply to this email and have your
Github user mbode commented on a diff in the pull request:
https://github.com/apache/flink/pull/3833#discussion_r119661118
--- Diff: flink-metrics/flink-metrics-prometheus/pom.xml ---
@@ -0,0 +1,129 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://w
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/4036
[Green Travis](https://travis-ci.org/mbode/flink/builds/238207585)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mbode commented on a diff in the pull request:
https://github.com/apache/flink/pull/4036#discussion_r119528882
--- Diff:
flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormatTest.java
---
@@ -101,6 +105,33 @@ public void
GitHub user mbode opened a pull request:
https://github.com/apache/flink/pull/4036
[FLINK-6781] Make statement fetch size configurable in JDBCInputFormat
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbode/flink
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/3833
@zentol Would you mind checking that I got the shading right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/3833
Okay, guava is not used anymore. I am not sure about the shading part.
Would you expect either prometheus clients or nanohttpd to be used in Flink
user code? Or are there other advantages to shading
Github user mbode commented on a diff in the pull request:
https://github.com/apache/flink/pull/3833#discussion_r116376242
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusReporter.java
---
@@ -0,0 +1,256
Github user mbode commented on a diff in the pull request:
https://github.com/apache/flink/pull/3833#discussion_r116375209
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusReporter.java
---
@@ -0,0 +1,256
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/3833
@hadronzoo I tried to keep it as general as possible by exporting all
variables available to the metric group as labels. I am not sure if this might
lead to [label
overuse](https://prometheus.io/docs
Github user mbode commented on the issue:
https://github.com/apache/flink/pull/3833
Thanks for looking at it so quickly! I somewhat had the same instinct as
far as your first point is concerned and thought about pulling out a
`DropwizardReporter` without Scheduling but decided
GitHub user mbode opened a pull request:
https://github.com/apache/flink/pull/3833
[FLINK-6221] Add PrometheusReporter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbode/flink PrometheusReporter
Alternatively you can review
Github user mbode commented on the pull request:
https://github.com/apache/flink/pull/1966#issuecomment-222155560
Sorry guys, botched the PR :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mbode closed the pull request at:
https://github.com/apache/flink/pull/1966
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mbode commented on the pull request:
https://github.com/apache/flink/pull/1966#issuecomment-220277425
Hi Stephan, sounds good.
1. I wanted to avoid too much duplication, but I see your point.
2. Ok, throwing a new exception breaks the API. So should I just mark
GitHub user mbode reopened a pull request:
https://github.com/apache/flink/pull/1966
[FLINK-3836] Add LongHistogram accumulator
New accumulator `LongHistogram`; the `Histogram` accumulator now throws an
`IllegalArgumentException` instead of letting the int overflow.
- [x
Github user mbode closed the pull request at:
https://github.com/apache/flink/pull/1966
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user mbode opened a pull request:
https://github.com/apache/flink/pull/1966
[Flink-3836] Add LongHistogram accumulator
New accumulator `LongHistogram`; the `Histogram` accumulator now throws an
`IllegalArgumentException` instead of letting the int overflow.
- [x
29 matches
Mail list logo
