[GitHub] flink pull request #:

2017-01-25 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/flink/commit/6342d6db1de5f38a921732e35abd83e6c5b9305a#commitcomment-20615018 In flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java: In flink-streaming

[GitHub] flink pull request #:

2017-01-24 Thread mindprince
Github user mindprince commented on the pull request: https://github.com/apache/flink/commit/6342d6db1de5f38a921732e35abd83e6c5b9305a#commitcomment-20600038 In flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java: In flink-streaming

[GitHub] flink issue #2929: [FLINK-5247] Fix incorrect check in allowedLateness() met...

2017-01-24 Thread mindprince
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2929 Merged in https://github.com/apache/flink/commit/87af84194911eb1e0c3b3a894bb3f04b628fbf11 and https://github.com/apache/flink/commit/4697b97a0101cf04b43c4a6e4887adba10b4a69a --- If your

[GitHub] flink pull request #2929: [FLINK-5247] Fix incorrect check in allowedLatenes...

2017-01-24 Thread mindprince
Github user mindprince closed the pull request at: https://github.com/apache/flink/pull/2929 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2929: [FLINK-5247] Fix incorrect check in allowedLateness() met...

2017-01-05 Thread mindprince
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2929 Thanks for the review @kl0u I didn't do it because there was no logger defined in the file. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #2929: [FLINK-5247] Fix incorrect check in allowedLateness() met...

2017-01-03 Thread mindprince
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2929 Ping @aljoscha --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2981: [docker] improve Dockerfile host configuration

2016-12-24 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/flink/pull/2981#discussion_r93824021 --- Diff: flink-contrib/docker-flink/docker-entrypoint.sh --- @@ -40,3 +39,6 @@ elif [ "$1" = "taskmanager" ]; then else

[GitHub] flink issue #2940: [FLINK-5258] [docs] reorganize the docs to improve naviga...

2016-12-17 Thread mindprince
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2940 We seem to have lost changes from https://github.com/apache/flink/commit/c024b0b6cae16a0b668d864c77e923820c262087 and https://github.com/apache/flink/commit

[GitHub] flink issue #2951: [docs] clarify default restart behavior when checkpointin...

2016-12-07 Thread mindprince
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2951 Also, this PR is open but the change is already there in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...

2016-12-07 Thread mindprince
Github user mindprince closed the pull request at: https://github.com/apache/flink/pull/2954 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2954: [docs] Note that numberOfExecutionRetries and executionRe...

2016-12-07 Thread mindprince
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2954 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...

2016-12-06 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/flink/pull/2954#discussion_r91163739 --- Diff: docs/setup/fault_tolerance.md --- @@ -45,9 +45,6 @@ To enable checkpointing, call `enableCheckpointing(n)` on the `StreamExecutionEn

[GitHub] flink issue #2954: [docs] Note that numberOfExecutionRetries and executionRe...

2016-12-06 Thread mindprince
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2954 cc - @mxm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...

2016-12-06 Thread mindprince
Github user mindprince commented on a diff in the pull request: https://github.com/apache/flink/pull/2954#discussion_r91163826 --- Diff: docs/setup/fault_tolerance.md --- @@ -345,20 +342,6 @@ env.setRestartStrategy(RestartStrategies.fixedDelayRestart

[GitHub] flink pull request #2954: [docs] Note that numberOfExecutionRetries and exec...

2016-12-06 Thread mindprince
GitHub user mindprince opened a pull request: https://github.com/apache/flink/pull/2954 [docs] Note that numberOfExecutionRetries and executionRetryDelay are deprecated And some other minor fixes and deduplication. You can merge this pull request into a Git repository by running

[GitHub] flink issue #2929: [FLINK-5247] Fix check to make sure that we throw error w...

2016-12-03 Thread mindprince
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2929 cc - @kl0u, @aljoscha for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request #2929: [FLINK-5247] Fix check to make sure that we throw ...

2016-12-03 Thread mindprince
GitHub user mindprince opened a pull request: https://github.com/apache/flink/pull/2929 [FLINK-5247] Fix check to make sure that we throw error when allowed lateness is set for non event-time windows. Also, fix outdated documentation. You can merge this pull request into a Git

[GitHub] flink issue #2927: [docs] Replace broken link.

2016-12-02 Thread mindprince
Github user mindprince commented on the issue: https://github.com/apache/flink/pull/2927 Added another unrelated doc fix to this PR instead of creating a new PR. Let me know if that's not fine and I will create another PR. --- If your project is set up for it, you can reply

[GitHub] flink pull request #2927: [docs] Replace broken link.

2016-12-02 Thread mindprince
GitHub user mindprince opened a pull request: https://github.com/apache/flink/pull/2927 [docs] Replace broken link. This variable was removed in dc5062557a55 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mindprince/flink docs

[GitHub] flink pull request #2834: [docs] Fix broken links and incorrect examples

2016-11-19 Thread mindprince
GitHub user mindprince opened a pull request: https://github.com/apache/flink/pull/2834 [docs] Fix broken links and incorrect examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/mindprince/flink docs-fix Alternatively you

[GitHub] flink pull request #2821: [MINOR][DOC] Fix incorrect URL

2016-11-16 Thread mindprince
GitHub user mindprince opened a pull request: https://github.com/apache/flink/pull/2821 [MINOR][DOC] Fix incorrect URL You can merge this pull request into a Git repository by running: $ git pull https://github.com/mindprince/flink patch-1 Alternatively you can review