Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2317
Rebased and ready to go. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2317#discussion_r75126672
--- Diff: flink-dist/src/main/flink-bin/yarn-bin/yarn-session.sh ---
@@ -52,5 +52,5 @@ log_setting="-Dlog.file="$log"
-Dlog4j.configuration=file:&
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2317
Woops. Didn't end up merging #2320 so this got overlooked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75123576
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -118,27 +138,168 @@ public static JobExecutionResult submitJobAndWait
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2340
Thanks for addressing my comments! Looks very good. I'm sorry I asked
whether you have tested the changes. It may seem natural to you but trust me
that is not always the case :)
Merging
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r75123833
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,31 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r75122721
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -118,27 +138,168 @@ public static JobExecutionResult submitJobAndWait
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2347
Merging this after a Checkstyle fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2313
CC @rmetzger @tillrohrmann Could you please take a look? I would like to
merge this. Tests are passing: https://travis-ci.org/mxm/flink/builds/151653198
---
If your project is set up for it, you can
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2340
Thanks! Looks good. Did you run the changes with Docker?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74445659
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74445485
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2275
>HDFS and Yarn are handled through the @BeforeClass and @AfterClass style
and they do not use custom JRunner implementation. As you have suggested, I
could keep just one or two tests for e
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2340
Thanks for the PR! It would be nice to have the install path configurable.
Also, we should use ASF's load balancing script for downloading the binaries.
---
If your project is set up for it, you can
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74229989
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2340#discussion_r74229920
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,25 +22,30 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2347
[FLINK-4236] fix error handling for jar files with no main method
This change shows only entry classes with a valid main method. It
ignores classes which contain no main method.
You can merge
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2327
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2109
Just had a brief look. Looks nice. Actually, I like how you moved the file
filter to the `FileInputFormat` instead of having it as a special case of the
file monitoring source.
I think you
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r73162978
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java
---
@@ -257,41 +257,22 @@ public void testFileInputSplit
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r73162125
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -274,7 +272,7
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r73162167
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r73162004
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -274,7 +272,7
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2109#discussion_r73161791
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -995,8 +993,7 @@ public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73160331
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaShortRetentionTestBase.java
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73159602
--- Diff:
flink-streaming-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/RollingSinkSecuredITCase.java
---
@@ -0,0
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73159441
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73159333
--- Diff: docs/internals/flink_security.md ---
@@ -0,0 +1,87 @@
+---
+title: "Flink Security"
+# Top navigation
+top-nav-group:
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73159225
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -1016,6 +1016,23 @@
/** The environment variable name which
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73159038
--- Diff: flink-core/src/main/java/org/apache/flink/util/Preconditions.java
---
@@ -293,6 +293,16 @@ private static String format(@Nullable String
template
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r73158919
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/JaasConfiguration.java
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2275
> Yes, it is not essential to run the secure test case all the time as it
consumes more cycles. Do you have any suggestion on controlling this through
some mvn/surefire plugin configuration?
Github user mxm closed the pull request at:
https://github.com/apache/flink/pull/2326
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2326
Looks like the integration works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2326
Sure, no problem. The empty commit is just for testing the integration.
Can't break anything with an empty commit :)
---
If your project is set up for it, you can reply to this email and have your
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2326
[FLINK-4305] test Jenkins GitHub integration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink jenkins-github
Alternatively you can review
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2325
[cleanup] remove unused code
Removes some unused code an tests the GitHub integration with Jenkins :)
- remove unused utility testing function
- remove leftover FLINK_CONF_DIR jvm property
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2317
Thanks @nielsbasjes. Will merge with #2320.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2320
Should be good to go now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2320
Thanks for trying it out @uce! There was an unrelated quoting issue in
`yarn-session.sh`. I pushed another fix.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2321
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2322
@uce Is this has you had in mind?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2322
[FLINK-4299] show loss of job manager in Client
This prints a message when the leading JobManager changes after first
connecting to a JobManager. Further, it prints a message when a connection
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2320
[FLINK-4297][yarn] decode URL encoded fat jar path
This solves problems with spaces and special characters in the
automatically determined fat jar path which is returned URL encoded.
You can merge
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2309
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2313#discussion_r72887224
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobInfo.scala
---
@@ -37,8 +37,10 @@ import
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2313
[FLINK-4273] Modify JobClient to attach to running jobs
These changes are required for FLINK-4272 (introduce a JobClient class
for job control). Essentially, we want to be able to re-attach
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2310
Thanks for the PR @zentol.
The test didn't fail because the exception is swallowed in a catch block:
```java
} catch (Exception e
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2310#discussion_r72780980
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerConfigurationTest.java
---
@@ -110,7 +110,7 @@ public void
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2275
I've passed through your changes. Great work! Thanks a lot for the
documentation, it was very helpful. Please don't be scared by all the comments,
most of them are minor. The most important points
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72456165
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java
---
@@ -125,29 +124,35 @@ protected int run(String[] args
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72450591
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/SecureTestEnvironment.java
---
@@ -0,0 +1,207
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72448326
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
---
@@ -123,6
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72449798
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/SecureTestEnvironment.java
---
@@ -0,0 +1,207
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72449664
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/SecureTestEnvironment.java
---
@@ -0,0 +1,207
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72448057
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaShortRetentionTestBase.java
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72449205
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/RunTypeSelectionRunner.java
---
@@ -0,0 +1,54
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72448259
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
---
@@ -81,13
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2275#discussion_r72439360
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityContext.java
---
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2123#discussion_r72078054
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/GlobalConfiguration.java
---
@@ -44,159 +35,62 @@
@Internal
public final class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2123#discussion_r72076345
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
@@ -84,12 +84,11 @@
*/
private static int
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2123#discussion_r72076940
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/GlobalConfiguration.java
---
@@ -44,159 +35,62 @@
@Internal
public final class
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2123#discussion_r72074912
--- Diff: flink-core/src/test/resources/log4j-test.properties ---
@@ -18,7 +18,7 @@
# Set root logger level to OFF to not flood build logs
# set
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2257
Thanks for investigating! Let me see if I can further debug the problem and
find out why Maven doesn't use the installed `flink-runtime` artifact instead
of the snapshot artifact.
---
If your project
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2123
Brief summary of changes:
- fail if config couldn't be loaded
- make globalconfiguration non-global and remove static SINGLETON
- remove duplicate api methods
- remove undocumented
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2123
That's odd. I was working on exactly these changes and have just pushed
them (without seeing your comment before).
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71664833
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -405,36 +405,23 @@ class JobManager
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71664748
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/FlinkResourceManager.java
---
@@ -113,7 +111,8 @@
/** The service
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71523881
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -405,36 +405,23 @@ class JobManager
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2257
Thank you for taking the time to revise some parts of the PR! I like the
changes. The eventual resource registration has been re-introduced but
simplified to only acknowledge the registration
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71522922
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/FlinkResourceManager.java
---
@@ -113,7 +111,8 @@
/** The service
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71517956
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -405,36 +405,23 @@ class JobManager
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r71355731
--- Diff: flink-dist/src/main/flink-bin/bin/flink ---
@@ -17,21 +17,39 @@
# limitations under the License
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2257
+1 Let's get it out of the way for the 1.1 release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r71354413
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendMainTest.java ---
@@ -0,0 +1,39 @@
+package org.apache.flink.client
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r71354777
--- Diff: flink-dist/src/main/flink-bin/bin/flink ---
@@ -17,21 +17,39 @@
# limitations under the License.
--- End diff --
You change the mode
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r71354529
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java ---
@@ -110,6 +110,8 @@ public void testRun
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r71354329
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/ProgramOptions.java ---
@@ -148,4 +148,5 @@ public boolean getDetachedMode() {
public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r71354132
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -451,4 +479,25 @@ public static InfoOptions parseInfoCommand
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r71354207
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -451,4 +479,25 @@ public static InfoOptions parseInfoCommand
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r71353752
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -451,4 +479,25 @@ public static InfoOptions parseInfoCommand
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71350758
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java ---
@@ -78,6 +79,9 @@
/** The containers where a TaskManager
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r71332501
--- Diff: docs/apis/cli.md ---
@@ -187,6 +187,8 @@ Action "run" compiles and runs
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2249
Travis cache seems to be corrupted. Have you run `mvn verify` from the
command-line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2257
I don't feel particularly great about breaking the contract between
JobManager and ResourceManager but it is a path we can go until we expand the
ResourceManager capabilities. The figures here would
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2249
Thank you! Merging after tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71325247
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java ---
@@ -78,6 +79,9 @@
/** The containers where a TaskManager
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71325133
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -405,36 +374,13 @@ class JobManager
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2249#discussion_r71311352
--- Diff: docs/setup/config.md ---
@@ -272,7 +272,9 @@ For example when running Flink on YARN on an
environment with a restrictive fire
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2249
Thanks for the update. Could you rebase to the latest master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2109
I'll try to review this as soon as possible. Maybe @kl0u or @zentol also
want to have another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2249
The changes look good to me. Just had some comments about the default
namespace name and an idea to generate a default namespace value in standalone
mode.
---
If your project is set up for it, you can
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2249#discussion_r71178603
--- Diff: docs/setup/config.md ---
@@ -272,7 +272,9 @@ For example when running Flink on YARN on an
environment with a restrictive fire
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2249#discussion_r71176801
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -969,6 +971,8 @@
public static final String
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71173613
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java ---
@@ -78,6 +79,9 @@
/** The containers where a TaskManager
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2257
It was just a surprise to me that we're breaking the original
ResourceManager role. If the ResourceManager doesn't get eventually notified
about new TaskManagers, then it is not guaranteed anymore
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71174483
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -405,36 +374,13 @@ class JobManager
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2264
[FLINK-4199] Fix misleading CLI messages and return execution result for
interactive blocking execution
**OLD**
```
Cluster retrieved: Standalone cluster with JobManager at
localhost/127.0.0.1
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2257
Thank you for the pull request! Looking at the changes, it looks like it
could have been broken up into two pull requests and jira issues. 1) Avoiding
duplicate RegisterTaskManager messages 2) Changing
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71122579
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -405,36 +374,13 @@ class JobManager
601 - 700 of 1762 matches
Mail list logo
