GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2665
[FLINK-4659]: Potential resource leak due to unclosed InputStream in
SecurityContext#populateSystemSecurityProperties()
Thanks for contributing to Apache Flink. Before you open your pull request
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2642
Thanks @uce, agreed, it would be a community effort indeed. I will try to
help as much as possible.
@ggevay, it's alright. I'll close the PR.
---
If your project is set up for it, you can
Github user nssalian closed the pull request at:
https://github.com/apache/flink/pull/2642
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2642
@StephanEwen ,thanks for that, that makes sense. But it is hard for someone
new to understand the problem you mention. If someone familiar with the
product, could review new JIRAs for clear benefit
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2642
@ggevay they are not related.. I think it caught from me old branch on to
this one. The 3 in the middle2ef4401,46d91b0,1433a5d are
relevant here. Apologies for the mix up
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2642
[FLINK-3999]: Rename the `running` flag in the drivers to `canceled`
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2641
[FLINK-4792] [Docs] Update documentation - FlinkML/QuickStart Guide
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user nssalian commented on a diff in the pull request:
https://github.com/apache/flink/pull/2618#discussion_r82871252
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
---
@@ -107,10 +113,10
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2442
Seems good to me. @zentol do you have time to add some extra review on
this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2493
Thanks @StephanEwen . Closing this one as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nssalian closed the pull request at:
https://github.com/apache/flink/pull/2493
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nssalian closed the pull request at:
https://github.com/apache/flink/pull/2494
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2494
That helps clarify. Thanks @StephanEwen. Closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2493
@uce, @zentol do you have some time to help review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2494
@uce, @zentol do you have some time to help review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2494
[FLINK-4614][Docs]: Changed the version from 1.2-SNAPSHOT to 1.2 in
docs/_config.yml
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2493
[FLINK-4513] [Docs]: Kafka connector documentation refers to Flink
1.1-SNAPSHOT
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2465
Hi @greghogan thanks for the PR. Took a look at it and seems good to go.
The test failure doesn't seem related. Since I'm new to the community, I would
probably ask someone else to have a look
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2442
Hi @xhumanoid , thanks for the PR. Could you please check the Failure
messages and fix the build? Can help review once the PR is cleanly mergable.
---
If your project is set up for it, you can
Github user nssalian closed the pull request at:
https://github.com/apache/flink/pull/2403
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2403
@StephanEwen, let me close this and open a new one after some testing. Will
post an new PR this week.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2403
Thanks @StephanEwen. Let me check again with the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2403
Hi @rmetzger, @tedyu do you have some time to help review this?
I am not sure if the failures are related.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2403
[FLINK-4278]: Unclosed FSDataOutputStream in multiple files in the project
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2382
Thank you @rmetzger and @zentol
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2382
FLINK-4402: Wrong metrics parameter names in documentation
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2307
Hi @aditivin , welcome to the community. Thank you for the PR as well.
A few suggestions:
1) Upon opening a PR, it is best to add more information regarding testing
or even checks that you
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2299
Thanks @mbalassi and @zentol for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2299
Hi @mbalassi and @zentol, I ran the builds twice and both instances the
PythonBinderTest passed.
The 2nd build ran with a failure on 2 with:
MVN exited with EXIT CODE: 1
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2299
[FLINK-4259]: Unclosed FSDataOutputStream in FileCache#copy(): Added a â¦
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2291
Thanks @gallenvara. I'll close in favor of #2261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nssalian closed the pull request at:
https://github.com/apache/flink/pull/2291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nssalian commented on the issue:
https://github.com/apache/flink/pull/2274
LGTM after the nits. But I would request someone else have a pass over it
before moving forward since I am new to the code.
---
If your project is set up for it, you can reply to this email
Github user nssalian commented on a diff in the pull request:
https://github.com/apache/flink/pull/2274#discussion_r71998373
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/examples/scala/StreamTableExample.scala
---
@@ -0,0 +1,56 @@
+/*
+ * Licensed
Github user nssalian commented on a diff in the pull request:
https://github.com/apache/flink/pull/2274#discussion_r71998370
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/examples/scala/StreamSQLExample.scala
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed
Github user nssalian commented on a diff in the pull request:
https://github.com/apache/flink/pull/2274#discussion_r71998367
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/examples/java/JavaSQLExample.java
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2291
FLINK-4226: Define Keys using Field Expressions example should use wiâ¦
Description:
val wordCounts = words.keyBy("word").reduce(/*window specification*/)
Should be:
val
37 matches
Mail list logo
