Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4380
@fhueske
I have updated the PR.
Based on the previous discussions i have:
1) integrated the support for offset and fetch when time is ascending as
you suggested (having a counter within
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4380
@fhueske
Thanks for the remarks/clarification.
I am fine with taking an approach to tackle both scenarios (also the simple
addons you suggest but also having the actual useful
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4380
@fhueske
Hi, I saw your remark for "If a query specifies ORDER BY ... FETCH x ROWS
ONLY, then the query must emit exactly x rows (given that the result has at
least x rows) and not x
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4380
@fhueske ,@wuchong
I updated the PR. Please have a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4380
@fhueske
Also - i do not understand why you would need to keep the counters for
offset/fetch as states?
Assuming we have in the buffer state with events for proctime T values (1,
2, 3
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4380
@fhueske
I did not understood initially that this is your suggestion. What you
propose has the advantage that it is easy to maintain (as we consolidate the
whole functionality) and a slight
Github user rtudoran closed the pull request at:
https://github.com/apache/flink/pull/4263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4263
@fhueske ,@wuchong I am closing this PR as i opened a new one for
offset/fetch without retraction
Check #4380
---
If your project is set up for it, you can reply to this email and have your
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4380
@fhueske ,@wuchong
As mentioned in PR #4263 I re-implemented the offset/fetch support for
*time without retraction. You can find things in this PR. In principle things
should be easy to follow
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/4380
Time sort with offset/fetch without retraction
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4263
@wuchong sounds good to me. Please ping me when you have the PR if you want
me to take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4263
@fhueske ,@wuchong thanks for the feedback. I will modify all these today
- tomorrow and ping you when they are pushed.
@wuchong - TopN for each group should not be hard to implement
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4263
@fhueske @wuchong
Thanks for the feedback. Fine for me to eliminate the retraction for the
*time ASC cases. I will modify the PR (to support *time ASC cases) over the
next days and re-submit
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4263
@fhueske You were the one that argue that retraction support is needed for
offset and fetch. When we were discussing this i was not into having the
retraction. I think finally it depends on what
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4263
@wuchong @fhueske
I closed that old PR (i forgot about it).
Thanks for looking into this.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rtudoran closed the pull request at:
https://github.com/apache/flink/pull/3714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4263
@fhueske
I have implemented the support for offset and fetch for both rowtime and
proctime.
This PR will close the JIRA issue. Please have a look
---
If your project is set up for it, you
Github user rtudoran closed the pull request at:
https://github.com/apache/flink/pull/4003
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4003
I have updated these contributions against the master branch and based on
the latest modifications after the merge of the basis for orderby. I opened a
new PR for this #4263.
I will close
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/4263
[FLINK-6075] - Support Limit/Top(Sort) for Stream SQL
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3889
@fhueske Thanks for the review and for handling the the fixes (sorry for
still kipping some :( ). I will create this week the PR for the rest of the
functions.
---
If your project is set up
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4003
@fhueske I will re-factor these contributions (hopefully by the end of the
week) based on the things that are already merged from order by. I will ping
you soon
---
If your project is set up
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3889
@fhueske I have addressed the remarks you have done (with 1-2 minor
exceptions for which you can see my comments). Please have a look. I think it
could be ready to be merged and than I can start
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124576040
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/aggregate/TimeSortProcessFunctionTest.scala
---
@@ -0,0 +1,256
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124575119
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/aggregate/TimeSortProcessFunctionTest.scala
---
@@ -0,0 +1,256
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124574652
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/aggregate/TimeSortProcessFunctionTest.scala
---
@@ -0,0 +1,256
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124573957
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SortTest.scala
---
@@ -0,0 +1,87
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124563186
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala
---
@@ -0,0 +1,247
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124556692
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala
---
@@ -0,0 +1,247
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124527971
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala
---
@@ -0,0 +1,206
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124492156
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonSort.scala
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124491949
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonSort.scala
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124491150
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonSort.scala
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124489316
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SortITCase.scala
---
@@ -0,0 +1,127
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3609#discussion_r120007611
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala
---
@@ -0,0 +1,241
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r119358128
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamRowStreamJoin.scala
---
@@ -0,0 +1,184
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r119357940
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamRowStreamJoin.scala
---
@@ -0,0 +1,184
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4003
@fhueske - Fine for me! I just wanted to finish this as well :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4003
@shijinkui @hongyuhong @stefanobortoli
I add you to the issue to track the progress
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/4003
@fhueske
I have implemented meanwhile also the support for offset and fetch for both
rowtime and proctime. This PR includes all the modifications and reviews you
made for #3889.
You can
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/4003
[FLINK-6075] - Support Limit/Top(Sort) for Stream SQL
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3889
@fhueske @stefanobortoli @shijinkui @hongyuhong
I have updated the PR. In principle all remarks were addressed. This should
be ready to merge (i hope)
---
If your project is set up
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r118475890
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SortTest.scala
---
@@ -0,0 +1,89
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r118468562
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SortITCase.scala
---
@@ -0,0 +1,133
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r118466310
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SortITCase.scala
---
@@ -0,0 +1,133
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r118465274
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/aggregate/ProcTimeSortProcessFunctionTest.scala
---
@@ -0,0 +1,165
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r118459358
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/RowTimeSortProcessFunction.scala
---
@@ -0,0 +1,169
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r118423723
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala
---
@@ -0,0 +1,345
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r118241119
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala
---
@@ -0,0 +1,345
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r118239983
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala
---
@@ -0,0 +1,345
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r118237512
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala
---
@@ -0,0 +1,225
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r117651897
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala
---
@@ -0,0 +1,323
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r117146377
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/RowTimeSortProcessFunction.scala
---
@@ -0,0 +1,169
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3889
@hongyuhong @stefanobortoli @shijinkui i forgot to add you to the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r116397679
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/FilterRunner.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r116397441
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala
---
@@ -199,31 +157,38 @@ object JoinUtil
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r116397057
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala
---
@@ -0,0 +1,180
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r116396723
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala
---
@@ -0,0 +1,323
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3714
@fhueske
Please refer to #3889 which contains the same code updated to the new
interfaces
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3889
@fhueske I updated the code to work with 1.3 (CRow, FlinkLogicalSort)
and all the implied changes.
We can close #3714 after we merge this i guess
..that one is the same logical code only
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/3889
[FLINK-6075] - Support Limit/Top(Sort) for Stream SQL
Order by time and optionally other fields is supported
Thanks for contributing to Apache Flink. Before you open your pull request
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3714
@fhueske As at some point there were some other issues open on this i just
wanted to ping you on the right :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3849
@fhueske
I resubmitted it - please have a look. I hope it is fine now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3849
@fhueske thanks for the review. I will have make another pass and resubmit
it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3849
@fhueske
Please have a look. I inserted tests in scala and java to check the
registration of the stream.
For scala - it seemed to work directly if the implicit value is set (i did
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/3849
[FLINK-6476] - Table environment register row data stream
Added tests for registering row streams in java and scala
Thanks for contributing to Apache Flink. Before you open your pull
Github user rtudoran closed the pull request at:
https://github.com/apache/flink/pull/3847
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3847
@fhueske
Please have a look. I inserted tests in scala and java to check the
registration of the stream.
For scala - it seemed to work directly if the implicit value is set (i did
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/3847
[FLINK-6476] - Table environment register row data stream
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user rtudoran closed the pull request at:
https://github.com/apache/flink/pull/3846
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/3846
[FLINK-6476] - Table environment register row data stream
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3845
i will close this PR to push one with only one commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rtudoran closed the pull request at:
https://github.com/apache/flink/pull/3845
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3845
@fhueske
Please have a look. I inserted tests in scala and java to check the
registration of the stream.
For scala - it seemed to work directly if the implicit value is set (i did
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/3845
[FLINK-6476] - Table environment register row data stream
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3783
@fhueske thanks for the clarification. I think it is good also to have the
solution for the over windows :)
I also wanted to ask you about the calcite and DISTINCT/DIST syntax. What
do
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3714
@fhueske I have committed also the support for rowtime order.
Now the PR contains the complete implementation for the things discussed in
the JIRA issue.
offset and fetch support
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3783
@fhueske @stefanobortoli
Regarding the options for solving the distinct. From my point of view the
previous approach worked:
- we keep in the processFunctions a state for each field
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3783
@fhueske @stefanobortoli
I recently fixed in Calcite the problem of porting distinct flag to the the
over. This was merged in the master. Hence it is a matter of when flink will
get the new
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3714
@fhueske
I have implemented all the suggestions you made. The only thing remaining
for this is:
- decide if keyBy is needed or not for the case when sorting happens only
on proc time
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3714#discussion_r113214399
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala
---
@@ -0,0 +1,353
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3714#discussion_r113143239
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala
---
@@ -0,0 +1,169
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3732
@fhueske @stefanobortoli I suggest we merge this temporary solution into
flink (with using a special marker for distinct) until the flink module will be
upgraded to the next calcite release. I
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3714#discussion_r112623715
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala
---
@@ -0,0 +1,353
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3714#discussion_r112623603
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala
---
@@ -0,0 +1,353
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3714#discussion_r112623175
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala
---
@@ -0,0 +1,169
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3714#discussion_r112623029
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala
---
@@ -0,0 +1,169
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3714#discussion_r112622475
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala
---
@@ -0,0 +1,169
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3714#discussion_r112622144
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamSortRule.scala
---
@@ -0,0 +1,67
Github user rtudoran closed the pull request at:
https://github.com/apache/flink/pull/3700
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3700
@fhueske I will close the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3700
@fhueske This PR can be closed. I have addressed all remarks and
reimplemented everything in #3714
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rtudoran commented on the issue:
https://github.com/apache/flink/pull/3714
@fhueske @shijinkui @hongyuhong @stefanobortoli @sunjincheng121 @twalthr
I have re-implemented the Sort based on the specifications in the #3700
Please have a look
---
If your project
GitHub user rtudoran opened a pull request:
https://github.com/apache/flink/pull/3714
[FLINK-6075] - Support Limit/Top(Sort) for Stream SQL
Implement the sort based on process function
Thanks for contributing to Apache Flink. Before you open your pull request,
please take
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3700#discussion_r111073880
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeUnboundedSortProcessFunction.scala
---
@@ -0,0
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3700#discussion_r110902190
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeUnboundedSortProcessFunction.scala
---
@@ -0,0
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3700#discussion_r110901541
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala
---
@@ -0,0 +1,167
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3700#discussion_r110900961
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SortAggFunction.scala
---
@@ -0,0 +1,166
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3700#discussion_r110900641
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/SortAggFunction.scala
---
@@ -0,0 +1,166
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3700#discussion_r110900086
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala
---
@@ -0,0 +1,367
1 - 100 of 221 matches
Mail list logo
