Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3783#discussion_r125677038
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -296,6 +299,39 @@ class CodeGenerator
Github user stefanobortoli commented on the issue:
https://github.com/apache/flink/pull/3783
@fhueske thanks for the comments. Did we include the latest calcite already?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3783#discussion_r125291954
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala
---
@@ -20,16 +20,22
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3783#discussion_r125291702
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -296,6 +299,39 @@ class CodeGenerator
Github user stefanobortoli closed the pull request at:
https://github.com/apache/flink/pull/3771
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user stefanobortoli commented on the issue:
https://github.com/apache/flink/pull/3732
@fhueske @sunjincheng121 @shijinkui @hongyuhong I have created a PR with
the latest master with the code generated distinct, #3771 please have a look.
If we it is fine, we can basically
Github user stefanobortoli commented on the issue:
https://github.com/apache/flink/pull/3771
@fhueske @rtudoran @shijinkui @sunjincheng121 I have create a new PR for
distinct in the code generator. Please have a look and let me know. I have
implemented and tested only
GitHub user stefanobortoli opened a pull request:
https://github.com/apache/flink/pull/3771
[FLINK-6250] Distinct procTime with Rows boundaries
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user stefanobortoli commented on the issue:
https://github.com/apache/flink/pull/3732
@fhueske I have just pushed a version working with code generation (without
modifying the code generation) There will be the need for some refactoring in
the AggregateUtil function
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112725482
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/UnsupportedOperatorsIndicatorFunctions.scala
---
@@ -0,0 +1,46
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112725820
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -91,6 +93,22
Github user stefanobortoli commented on the issue:
https://github.com/apache/flink/pull/3732
@fhueske, I agree with you about the risk of temporary DIST() ingestion.
Perhaps we could meanwhile just work on the "ProcessFunction + Code
generation" keeping the DIST functio
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112713096
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala
---
@@ -0,0
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112712717
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedDistinctRowsOver.scala
---
@@ -0,0
Github user stefanobortoli commented on the issue:
https://github.com/apache/flink/pull/3574
@fhueske @sunjincheng121 the latest merge caused a conflict, however I have
already pushed a new branch and created a new PR. This can be closed.
---
If your project is set up for it, you
Github user stefanobortoli commented on the issue:
https://github.com/apache/flink/pull/3653
@fhueske @sunjincheng121 I have merged with the most recent branch, using
the function freshly merged. I think the PR is good to merge now.
---
If your project is set up for it, you can
GitHub user stefanobortoli opened a pull request:
https://github.com/apache/flink/pull/3653
[FLINK-5653] Add processing time OVER ROWS BETWEEN x PRECEDING aggregation
to SQL
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check
Github user stefanobortoli commented on the issue:
https://github.com/apache/flink/pull/3574
@fhueske @sunjincheng121 @rtudoran sorry for the extra commit, I saw some
comments too little too late. Now the code should comply with the requested
changes.
---
If your project is set up
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r108703268
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRowProcessFunction.scala
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r108626444
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -350,4 +350,59
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r108625887
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRowProcessFunction.scala
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r108611315
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -195,6
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r108611259
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -696,6 +696,181 @@ class
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r108610311
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -350,4 +350,59
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r108610149
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRowProcessFunction.scala
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r108610034
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRowProcessFunction.scala
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r108609894
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRowProcessFunction.scala
Github user stefanobortoli commented on the issue:
https://github.com/apache/flink/pull/3574
@fhueske @sunjincheng121 @rtudoran I have just completed the implementation
with the MapState, please have a look.
---
If your project is set up for it, you can reply to this email and have
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r108398986
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -239,4 +239,61
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r108372957
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala
---
@@ -239,4 +239,61
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r108369391
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/IncrementalAggregateOverWindowFunction.scala
Github user stefanobortoli commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-216521677
@tillrohrmann, I see the conflicts. How should I deal with this? rebase?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/1915#discussion_r61855824
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/util/StartupUtils.java ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/1915#discussion_r61037816
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerStartupTest.java
---
@@ -53,41 +59,55 @@ public void
Github user stefanobortoli commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-212305774
We had a look at the Flink test dependency hierarchies and the thing is
feasible but I it should be done in a separate PR. In fact, it requires a
clerical review
Github user stefanobortoli commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-212293101
We mainly wanted to simplify the build skipping tests. However, if you
think it makes sense, we can give it a try.
---
If your project is set up for it, you
GitHub user stefanobortoli opened a pull request:
https://github.com/apache/flink/pull/1915
Flink 1827 and small fixes in some tests
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your
37 matches
Mail list logo
