[GitHub] flink issue #5367: [FLINK-7923][Table API & SQL] Support field access of com...

2018-02-01 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/5367 @hequn8128 , thanks for the review. Where do you think we can add it in sql.md? ---

[GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...

2018-02-01 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/5367#discussion_r165515039 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala --- @@ -469,6 +473,148 @@ class SqlITCase

[GitHub] flink issue #5306: [FLINK-8390][security]remove unused integration test code

2018-01-30 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/5306 @tillrohrmann you are right, I just checked. The test is not functioning as it should be. I'll fix it. Can you take a look at https://github.com/apache/flink/pull/5172 if you have time? ---

[GitHub] flink issue #5367: [FLINK-7923][Table API & SQL] Support field access of com...

2018-01-26 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/5367 @twalthr rebased, could you please take another look? Thanks a lot. ---

[GitHub] flink issue #5355: [FLINK-7934][Table & SQL API] Upgrade Flink to use Calcit...

2018-01-25 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/5355 @bowenli86 The following two features are related to this PR. [CALCITE-2016] Make item + dot operators work for array (e.g. SELECT orders[5].color FROM t (Shuyi Chen) [CALCITE-1867] Allow

[GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...

2018-01-25 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/5367 [FLINK-7923][Table API & SQL] Support field access of composite array element in SQL Note: This is based on FLINK-7934, will rebase once FLINK-7934 is resolved. ## What is the purpos

[GitHub] flink pull request #5355: [FLINK-7934][Table & SQL API] Upgrade Flink to use...

2018-01-24 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/5355 [FLINK-7934][Table & SQL API] Upgrade Flink to use Calcite 1.15 ## Brief change log - Update flink-table dependency to use Calcite 1.15 - Add new codegen from EXTRACT since Calcite

[GitHub] flink issue #5172: [FLINK-8275] [Security] fix keytab local path in YarnTask...

2018-01-17 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/5172 Thanks a lot for the review, @EronWright. Could you please take another look? ---

[GitHub] flink pull request #5172: [FLINK-8275] [Security] fix keytab local path in Y...

2018-01-17 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/5172#discussion_r162239390 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskManagerRunner.java --- @@ -126,12 +124,6 @@ public static void runYarnTaskManager(String

[GitHub] flink pull request #5306: [FLINK-8390][security]remove unused integration te...

2018-01-17 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/5306 [FLINK-8390][security]remove unused integration test code ## What is the purpose of the change Remove unused integration test code from the main code. ## Brief change log

[GitHub] flink pull request #5172: [FLINK-8275] [Security] fix keytab local path in Y...

2018-01-17 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/5172#discussion_r162204277 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskManagerRunner.java --- @@ -142,19 +134,22 @@ public static void runYarnTaskManager(String

[GitHub] flink pull request #5172: [FLINK-8275] [Security] fix keytab local path in Y...

2018-01-17 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/5172#discussion_r162190016 --- Diff: flink-yarn/src/test/resources/flink-conf.yaml --- @@ -0,0 +1,23

[GitHub] flink issue #5274: [FLINK-8401][Cassandra Connector]Refactor CassandraOutput...

2018-01-15 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/5274 Thanks a lot, @tillrohrmann . Added javadoc. Please take another look. ---

[GitHub] flink pull request #5274: [FLINK-8401][Cassandra Connector]Refactor Cassandr...

2018-01-15 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/5274#discussion_r161672700 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java --- @@ -66,6

[GitHub] flink pull request #5274: [FLINK-8401][Cassandra Connector]Refactor Cassandr...

2018-01-15 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/5274#discussion_r161672687 --- Diff: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/batch/connectors/cassandra/CassandraOutputFormat.java --- @@ -66,6

[GitHub] flink pull request #5274: [FLINK-8401][Cassandra Connector]Refactor Cassandr...

2018-01-10 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/5274 [FLINK-8401][Cassandra Connector]Refactor CassandraOutputFormat to allow subclass to customize the fai… ## What is the purpose of the change Refactor CassandraOutputFormat to allow

[GitHub] flink pull request #5272: [Flink-8397][Connectors]Support Row type for Cassa...

2018-01-10 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/5272 [Flink-8397][Connectors]Support Row type for Cassandra OutputFormat ## Brief change log - Add CassandraOutputFormatBase - Add CassandraRowOutputFormat - Add

[GitHub] flink pull request #5172: [FLINK-8275] [Security] fix keytab local path in Y...

2017-12-17 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/5172 [FLINK-8275] [Security] fix keytab local path in YarnTaskManagerRunner ## Brief change log - Set the local keytab path in YarnTaskManagerRunner to the correct local path

[GitHub] flink pull request #5150: upgrade Calcite dependency to 1.15

2017-12-12 Thread suez1224
Github user suez1224 closed the pull request at: https://github.com/apache/flink/pull/5150 ---

[GitHub] flink pull request #5150: upgrade Calcite dependency to 1.15

2017-12-11 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/5150 upgrade Calcite dependency to 1.15 *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in

[GitHub] flink pull request #4989: [Flink 7003] [Table API & SQL] use PEEK_FIELDS_NO_...

2017-11-09 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/4989 [Flink 7003] [Table API & SQL] use PEEK_FIELDS_NO_EXPAND for CompositeRelDataType ## What is the purpose of the change This pull request change CompositeRelDataType to use the newly a

[GitHub] flink issue #4729: [FLINK-7076] [ResourceManager] implement YARN stopWorker ...

2017-11-07 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/4729 @tillrohrmann Updated the PR that addresses your comments. Could you please take another look when you have time? ---

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-11-07 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r149540088 --- Diff: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java --- @@ -0,0 +1,354 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-11-07 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r149304158 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnWorkerNode.java --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software

[GitHub] flink issue #4729: [FLINK-7076] [ResourceManager] implement YARN stopWorker ...

2017-10-24 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/4729 @tillrohrmann can you take another look? I've updated the code as well as the test. Thanks. ---

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-17 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145325673 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-17 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145067180 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-17 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145054746 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnWorkerNode.java --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-17 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145054599 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-17 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r145053774 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-11 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r143934625 --- Diff: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the Apache Software

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-11 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r143934519 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -227,13 +241,19 @@ public void startNewWorker(ResourceProfile

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-05 Thread suez1224
GitHub user suez1224 reopened a pull request: https://github.com/apache/flink/pull/4729 [FLINK-7076] [ResourceManager] implement YARN stopWorker logic ## What is the purpose of the change *Implement stopWorker logic for YarnResourceManager* ## Brief change log

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-10-05 Thread suez1224
Github user suez1224 closed the pull request at: https://github.com/apache/flink/pull/4729 ---

[GitHub] flink issue #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInfo; add ...

2017-10-05 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/4585 @fhueske Addressed your comments. PTAL. Much appreciated. ---

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-09-29 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r141822004 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -228,7 +234,14 @@ public void startNewWorker(ResourceProfile

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-09-29 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r141820967 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -228,7 +234,14 @@ public void startNewWorker(ResourceProfile

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-28 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141576017 --- Diff: docs/dev/table/sql.md --- @@ -746,6 +746,7 @@ The SQL runtime is built on top of Flink's DataSet and DataStream APIs. Int

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-28 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141576005 --- Diff: docs/dev/table/sql.md --- @@ -2107,6 +2108,17 @@ VAR_SAMP(value) Returns the sample variance (square of the sample standard

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-27 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141507401 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CollectAggFunction.scala --- @@ -0,0 +1,158

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-27 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141507197 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/MultisetTypeInfo.java --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-27 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141507177 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/MultisetTypeInfo.java --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-27 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141494189 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CollectAggFunction.scala --- @@ -0,0 +1,158

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-27 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141494139 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CollectAggFunction.scala --- @@ -0,0 +1,158

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-27 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141485942 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1414,8 +1414,29 @@ object

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-27 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141485981 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1414,8 +1414,29 @@ object

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-27 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141449807 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CollectAggFunction.scala --- @@ -0,0 +1,158

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-27 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141260762 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/MultisetTypeInfo.java --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-27 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141260601 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/MultisetTypeInfo.java --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-26 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141256073 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/MultisetTypeInfo.java --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-26 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141256026 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/MultisetTypeInfo.java --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-26 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141255931 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/MultisetTypeInfo.java --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-26 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r141255917 --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/MultisetTypeInfo.java --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-09-26 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/4729 [FLINK-7076] [ResourceManager] implement YARN stopWorker logic ## What is the purpose of the change *Implement stopWorker logic for YarnResourceManager* ## Brief change log

[GitHub] flink pull request #4724: [FLINK-7690] [Cluster Management] Do not call acto...

2017-09-26 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/4724 [FLINK-7690] [Cluster Management] Do not call actorSystem.awaitTermination from akka's main message han… ## What is the purpose of the change *During shutdown, do not wait fo

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-21 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r140176626 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CollectAggFunction.scala --- @@ -0,0 +1,121

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-20 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r140159387 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CollectAggFunction.scala --- @@ -0,0 +1,121

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-20 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r140159053 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CollectAggFunction.scala --- @@ -0,0 +1,121

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-20 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r140089533 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/MultisetRelDataType.scala --- @@ -0,0 +1,50

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-20 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r140089018 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/AggregateITCase.scala --- @@ -329,6 +329,35 @@ class

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-20 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r140083074 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CollectAggFunction.scala --- @@ -0,0 +1,121

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-15 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r139237307 --- Diff: flink-core/pom.xml --- @@ -80,6 +80,13 @@ under the License

[GitHub] flink pull request #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInf...

2017-09-15 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4585#discussion_r139237144 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala --- @@ -211,6 +218,14 @@ class FlinkTypeFactory

[GitHub] flink issue #4585: [FLINK-7491] [Table API & SQL] add MultiSetTypeInfo; add ...

2017-09-01 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/4585 Hi @fhueske , I've filled out the PR template. Please take a look. Thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] flink pull request #4585: [FLINK-7491] add MultiSetTypeInfo; add built-in Co...

2017-08-24 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/4585 [FLINK-7491] add MultiSetTypeInfo; add built-in Collect Aggregate Function for Flink SQL. *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve

[GitHub] flink issue #3793: flink-6033 Support UNNEST query in the stream SQL API

2017-05-05 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/3793 @twalthr , can you take a look when you have time? I have added the LogicalUnnestRule and unitest for batch as well. Thanks a lot. --- If your project is set up for it, you can reply to this

[GitHub] flink issue #3793: flink-6033 Support UNNEST query in the stream SQL API

2017-05-04 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/3793 Thanks a lot for reviewing the PR, @twalthr. It turns out the change in basic type arrays is not needed. Regarding introducing the LogicalUnnestRule, I think it's a good idea. I

[GitHub] flink pull request #3793: flink-6033 Support UNNEST query in the stream SQL ...

2017-04-27 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/3793 flink-6033 Support UNNEST query in the stream SQL API …y is supported, and WITH ORDINALITY is not yet supported. Thanks for contributing to Apache Flink. Before you open your pull

[GitHub] flink pull request #3787: flink-6033 Support UNNEST query in the stream SQL ...

2017-04-27 Thread suez1224
Github user suez1224 closed the pull request at: https://github.com/apache/flink/pull/3787 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3787: flink-6033 Support UNNEST query in the stream SQL ...

2017-04-27 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/3787 flink-6033 Support UNNEST query in the stream SQL API …y is supported, and WITH ORDINALITY is not yet supported. Thanks for contributing to Apache Flink. Before you open your pull

<    1   2