[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-27 Thread uybhatti
Github user uybhatti commented on a diff in the pull request: https://github.com/apache/flink/pull/4670#discussion_r141356723 --- Diff: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcUtils.java --- @@ -0,0 +1,2229 @@ +/* + * Licensed to the Apache

[GitHub] flink issue #4660: [FLINK-7050][table] Add support of RFC compliant CSV pars...

2017-09-27 Thread uybhatti
Github user uybhatti commented on the issue: https://github.com/apache/flink/pull/4660 Hi @fhueske , thanks for your feedback. I have addressed your feedback. Please take a look on changes. Thanks, Usman ---

[GitHub] flink pull request #4660: [FLINK-7050][table] Add support of RFC compliant C...

2017-09-27 Thread uybhatti
Github user uybhatti commented on a diff in the pull request: https://github.com/apache/flink/pull/4660#discussion_r141336157 --- Diff: flink-libraries/flink-table/pom.xml --- @@ -114,6 +114,12 @@ under the License. joda-time joda

[GitHub] flink pull request #4660: [FLINK-7050][table] Add support of RFC compliant C...

2017-09-20 Thread uybhatti
Github user uybhatti commented on a diff in the pull request: https://github.com/apache/flink/pull/4660#discussion_r139923268 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/runtime/batch/io/RFCCsvInputFormat.java --- @@ -0,0 +1,449

[GitHub] flink pull request #4638: [FLINK-6563] [table] Add time indicator support to...

2017-09-19 Thread uybhatti
Github user uybhatti commented on a diff in the pull request: https://github.com/apache/flink/pull/4638#discussion_r139692943 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -62,10

[GitHub] flink pull request #4638: [FLINK-6563] [table] Add time indicator support to...

2017-09-19 Thread uybhatti
Github user uybhatti commented on a diff in the pull request: https://github.com/apache/flink/pull/4638#discussion_r139665963 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -106,8

[GitHub] flink pull request #4635: [FLINK-7571] [table] Fix translation of TableSourc...

2017-09-19 Thread uybhatti
Github user uybhatti commented on a diff in the pull request: https://github.com/apache/flink/pull/4635#discussion_r139661930 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/StreamTableSourceTable.scala --- @@ -28,48 +29,113 @@ import

[GitHub] flink pull request #4635: [FLINK-7571] [table] Fix translation of TableSourc...

2017-09-19 Thread uybhatti
Github user uybhatti commented on a diff in the pull request: https://github.com/apache/flink/pull/4635#discussion_r139630218 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/StreamTableSourceTable.scala --- @@ -28,48 +29,113 @@ import

[GitHub] flink pull request #4670: [FLINK-2170] [connectors] Add ORC connector for Ta...

2017-09-14 Thread uybhatti
GitHub user uybhatti opened a pull request: https://github.com/apache/flink/pull/4670 [FLINK-2170] [connectors] Add ORC connector for TableSource ## What is the purpose of the change Currently, we can't read data from ORC files. In this PR, we added the support to load data

[GitHub] flink pull request #4660: [FLINK-7050][table] Add support of RFC compliant C...

2017-09-08 Thread uybhatti
GitHub user uybhatti opened a pull request: https://github.com/apache/flink/pull/4660 [FLINK-7050][table] Add support of RFC compliant CSV parser for Table Source ## What is the purpose of the change Currently CsvInputFormat is not compliant with RFC 4180 standards and we

[GitHub] flink pull request #4608: [FLINK-7227][Table API & SQL]Fix the the TableSour...

2017-08-28 Thread uybhatti
GitHub user uybhatti opened a pull request: https://github.com/apache/flink/pull/4608 [FLINK-7227][Table API & SQL]Fix the the TableSource predicate push… … down issue for OR and AND expression with more than 2 predicates *Thank you very much for contribu