liyubin117 commented on code in PR #24932:
URL: https://github.com/apache/flink/pull/24932#discussion_r1639333418
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterCatalogComment.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache
liyubin117 commented on code in PR #24932:
URL: https://github.com/apache/flink/pull/24932#discussion_r1639332192
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogDescriptor.java:
##
@@ -48,18 +51,29 @@ public Configuration
anupamaggarwal commented on PR #839:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/839#issuecomment-2167310593
> +1 to merge. I don't think the `[Kubernetes Operator]` tag in the commit
message is needed, since this is the operator repo.
ack @rmetzger I was following
fredia commented on PR #24917:
URL: https://github.com/apache/flink/pull/24917#issuecomment-2167284732
@kartikeypant Thanks for the PR, overall LGTM, would you like to add a test
about this in `WindowOperatorTest`?
--
This is an automated message from the Apache Git Service.
To respond
dingxin-tech commented on code in PR #3414:
URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1639313828
##
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunctionProvider.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software
dingxin-tech commented on code in PR #3414:
URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1639312924
##
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunction.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation
rmetzger commented on PR #839:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/839#issuecomment-2167276203
+1 to merge.
I don't think the `[Kubernetes Operator]` tag in the commit message is
needed, since this is the operator repo.
--
This is an automated message from
dingxin-tech commented on code in PR #3254:
URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1639307538
##
docs/content.zh/docs/connectors/maxcompute.md:
##
@@ -0,0 +1,342 @@
+---
+title: "MaxCompute"
+weight: 7
+type: docs
+aliases:
+ - /connectors/maxcompute
yuxiqian commented on code in PR #2944:
URL: https://github.com/apache/flink-cdc/pull/2944#discussion_r1639295066
##
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/schema/PhysicalColumnSerializer.java:
##
Review Comment:
Seems this is a breaking
dingxin-tech commented on code in PR #3254:
URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1639306007
##
XComp commented on code in PR #24426:
URL: https://github.com/apache/flink/pull/24426#discussion_r1639305664
##
.github/workflows/nightly.yml:
##
@@ -28,69 +28,131 @@ jobs:
name: "Pre-compile Checks"
uses: ./.github/workflows/template.pre-compile-checks.yml
-
dingxin-tech commented on code in PR #3254:
URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1639304610
##
yuxiqian commented on code in PR #2944:
URL: https://github.com/apache/flink-cdc/pull/2944#discussion_r1639295066
##
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/schema/PhysicalColumnSerializer.java:
##
Review Comment:
Seems this is a breaking
1996fanrui commented on PR #24936:
URL: https://github.com/apache/flink/pull/24936#issuecomment-2167246199
> @1996fanrui @GOODBOY008 Thanks for your attention, I found that CI e2e
tests have stucked for hours, As the code is about to be frozen, could you help
cancel some tasks? For
liyubin117 commented on PR #24936:
URL: https://github.com/apache/flink/pull/24936#issuecomment-2167237003
@1996fanrui @GOODBOY008 Thanks for your attention, I found that CI e2e tests
have stucked for hours, As the code is about to be frozen, could you help
cancel some tasks? For example,
anupamaggarwal opened a new pull request, #839:
URL: https://github.com/apache/flink-kubernetes-operator/pull/839
## What is the purpose of the change
Adds Apache 2 LICENSE to Apache Kubernetes Operator Docker image
## Brief change log
- Adds LICENSE file to docker stage image
liyubin117 commented on code in PR #24934:
URL: https://github.com/apache/flink/pull/24934#discussion_r1639245472
##
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/CatalogManagerTest.java:
##
@@ -367,14 +368,28 @@ void testCatalogStore() throws
liyubin117 commented on code in PR #24934:
URL: https://github.com/apache/flink/pull/24934#discussion_r1639245307
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##
@@ -295,31 +295,42 @@ public DataTypeFactory
liyubin117 commented on code in PR #24934:
URL: https://github.com/apache/flink/pull/24934#discussion_r1639244971
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlCreateCatalogConverter.java:
##
@@ -41,6 +43,10 @@ public
liyubin117 commented on code in PR #24934:
URL: https://github.com/apache/flink/pull/24934#discussion_r1639244453
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/CreateCatalogOperation.java:
##
@@ -39,10 +41,18 @@
public class
liyubin117 commented on code in PR #24934:
URL: https://github.com/apache/flink/pull/24934#discussion_r1639243865
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogDescriptor.java:
##
@@ -48,18 +55,34 @@ public Configuration
liyubin117 commented on code in PR #24934:
URL: https://github.com/apache/flink/pull/24934#discussion_r1639240721
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateCatalog.java:
##
@@ -45,11 +48,18 @@ public class SqlCreateCatalog extends
Jiabao-Sun closed pull request #3318: Out of use
URL: https://github.com/apache/flink-cdc/pull/3318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Jiabao-Sun commented on PR #3412:
URL: https://github.com/apache/flink-cdc/pull/3412#issuecomment-2167182112
Closed by #3382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Jiabao-Sun closed pull request #3412:
[FLINK-35121][pipeline-connector][cdc-base] CDC pipeline connector provide
ability to verify requiredOptions and optionalOptions
URL: https://github.com/apache/flink-cdc/pull/3412
--
This is an automated message from the Apache Git Service.
To respond
Jiabao-Sun merged PR #3382:
URL: https://github.com/apache/flink-cdc/pull/3382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
wzx140 commented on PR #24937:
URL: https://github.com/apache/flink/pull/24937#issuecomment-2167176948
@1996fanrui Could you please review it? Really thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
flinkbot commented on PR #24937:
URL: https://github.com/apache/flink/pull/24937#issuecomment-2167173883
## CI report:
* 0438cd927e430131c07b0555265696e34e1606a0 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
lvyanquan commented on code in PR #3414:
URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1639192510
##
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunction.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
pan3793 commented on PR #24905:
URL: https://github.com/apache/flink/pull/24905#issuecomment-2167155520
thank you, @1996fanrui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
fredia commented on PR #24922:
URL: https://github.com/apache/flink/pull/24922#issuecomment-2167153534
> Thanks for the PR! Overall LGTM. How about adding some docs under
`docs/ops/metrics#checkpointing`?
@Zakelly Thanks for the review, added into `docs/ops/metrics#checkpointing`
1996fanrui merged PR #24905:
URL: https://github.com/apache/flink/pull/24905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lvyanquan commented on code in PR #3414:
URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1639176999
##
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunction.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lvyanquan commented on code in PR #3414:
URL: https://github.com/apache/flink-cdc/pull/3414#discussion_r1639176999
##
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/HashFunction.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
LadyForest commented on code in PR #24934:
URL: https://github.com/apache/flink/pull/24934#discussion_r1639160703
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/CreateCatalogOperation.java:
##
@@ -39,10 +41,18 @@
public class
caicancai commented on PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#issuecomment-2167139959
@1996fanrui @RocMarshal Thank you for your review and patient reply
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dingxin-tech commented on code in PR #3254:
URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1639174241
##
1996fanrui merged PR #830:
URL: https://github.com/apache/flink-kubernetes-operator/pull/830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dingxin-tech commented on code in PR #3254:
URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1639171927
##
yuanoOo commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1639167796
##
docs/content/docs/connectors/pipeline-connectors/oceanbase.md:
##
@@ -0,0 +1,343 @@
+---
+title: "OceanBase"
+weight: 7
+type: docs
+aliases:
+-
GOODBOY008 commented on PR #24936:
URL: https://github.com/apache/flink/pull/24936#issuecomment-2167128712
@1996fanrui It's indeed my mistake. @liyubin117 Great catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
RocMarshal commented on PR #119:
URL:
https://github.com/apache/flink-connector-jdbc/pull/119#issuecomment-2167128684
Thank you @1996fanrui @eskabetxe very much for your review and attention
for the feature !
--
This is an automated message from the Apache Git Service.
To respond
caicancai commented on PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#issuecomment-2167127192
@1996fanrui cli fail, but it doesn't seem to be caused by my pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
caicancai commented on code in PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1639121989
##
docs/content/docs/custom-resource/pod-template.md:
##
@@ -125,4 +124,4 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}]
merged: [{name: a, p1:
whhe commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1639119977
##
docs/content/docs/connectors/pipeline-connectors/oceanbase.md:
##
@@ -0,0 +1,343 @@
+---
+title: "OceanBase"
+weight: 7
+type: docs
+aliases:
+-
flinkbot commented on PR #24936:
URL: https://github.com/apache/flink/pull/24936#issuecomment-2167073330
## CI report:
* 971edbe445dc16987a149bda399cf235f2ed5554 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
HuangXingBo commented on code in PR #24426:
URL: https://github.com/apache/flink/pull/24426#discussion_r1639115041
##
.github/workflows/nightly.yml:
##
@@ -28,69 +28,131 @@ jobs:
name: "Pre-compile Checks"
uses: ./.github/workflows/template.pre-compile-checks.yml
-
1996fanrui merged PR #119:
URL: https://github.com/apache/flink-connector-jdbc/pull/119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
HuangXingBo commented on PR #24426:
URL: https://github.com/apache/flink/pull/24426#issuecomment-2167064115
Thanks @morazow for the update.
I downloaded the wheel package and found that the wheel package after repair
is manylinux_2_5. It may be related to not using
liyubin117 opened a new pull request, #24936:
URL: https://github.com/apache/flink/pull/24936
## Brief change log
* it should be ia.getNumberOfLocalAssignments() as before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Jiabao-Sun commented on code in PR #3382:
URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1639108698
##
flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/definition/PipelineValidationTest.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache
1996fanrui commented on code in PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1639108031
##
docs/content/docs/custom-resource/pod-template.md:
##
@@ -125,4 +124,4 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}]
merged: [{name: a, p1:
1996fanrui commented on code in PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1639106337
##
docs/content/docs/custom-resource/pod-template.md:
##
@@ -93,16 +90,18 @@ spec:
```
{{< hint info >}}
-When using the operator with Flink
1996fanrui commented on code in PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1639106337
##
docs/content/docs/custom-resource/pod-template.md:
##
@@ -93,16 +90,18 @@ spec:
```
{{< hint info >}}
-When using the operator with Flink
1996fanrui merged PR #24757:
URL: https://github.com/apache/flink/pull/24757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
flinkbot commented on PR #24935:
URL: https://github.com/apache/flink/pull/24935#issuecomment-2167007574
## CI report:
* 8c396c54eeda5bc8f8f656847a372b3421c25a7f UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
venkata91 commented on PR #24935:
URL: https://github.com/apache/flink/pull/24935#issuecomment-2167003430
cc @becketqin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
venkata91 opened a new pull request, #24935:
URL: https://github.com/apache/flink/pull/24935
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way we avoid re-transferring them
mattayes commented on PR #838:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/838#issuecomment-2166971750
@gyfora Here's a rework of #837.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mattayes opened a new pull request, #838:
URL: https://github.com/apache/flink-kubernetes-operator/pull/838
## What is the purpose of the change
Add missing documentation for `FlinkSessionJob` CRD.
## Brief change log
Add docs for `FlinkSessionJob` CRD.
venkata91 commented on code in PR #24736:
URL: https://github.com/apache/flink/pull/24736#discussion_r1638672737
##
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerTest.java:
##
Review Comment:
Addressed it.
--
This is
venkata91 commented on PR #24736:
URL: https://github.com/apache/flink/pull/24736#issuecomment-2166456519
> > > Thanks, @venkata91, for your contribution! After reviewing this PR,
I'm concerned that it entirely removes limit that source parallelism should
lower than source jobVertex's max
liyubin117 opened a new pull request, #24934:
URL: https://github.com/apache/flink/pull/24934
## What is the purpose of the change
Introduce comment for CatalogStore and Support enhanced `CREATE CATALOG`
syntax
## Brief change log
* add comment instance in
jnh5y commented on code in PR #24929:
URL: https://github.com/apache/flink/pull/24929#discussion_r1638447342
##
docs/content/docs/dev/table/sql/create.md:
##
@@ -406,6 +413,14 @@ Flink will assume correctness of the primary key by
assuming that the columns nu
Partition the
jnh5y commented on code in PR #24929:
URL: https://github.com/apache/flink/pull/24929#discussion_r1638444015
##
docs/content/docs/dev/table/sql/create.md:
##
@@ -465,6 +480,7 @@ You can control the merging behavior of:
* GENERATED - computed columns
* METADATA - metadata
LadyForest commented on code in PR #24932:
URL: https://github.com/apache/flink/pull/24932#discussion_r1638477886
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##
@@ -327,11 +328,15 @@ public void createCatalog(String
flinkbot commented on PR #24934:
URL: https://github.com/apache/flink/pull/24934#issuecomment-2166393201
## CI report:
* d31c5b45069430fcdd04727df1aebde7dd111d97 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
lvyanquan commented on code in PR #3254:
URL: https://github.com/apache/flink-cdc/pull/3254#discussion_r1635846252
##
docs/content.zh/docs/connectors/maxcompute.md:
##
@@ -0,0 +1,342 @@
+---
+title: "MaxCompute"
+weight: 7
+type: docs
+aliases:
+ - /connectors/maxcompute
+---
vahmed-hamdy commented on PR #136:
URL:
https://github.com/apache/flink-connector-aws/pull/136#issuecomment-2165938144
@hlteoh37 Thanks, for the feedback, the reason we took this approach is that
We are trying to couple it as much as possible with Flink's TypeInfo Class,
Using
vahmed-hamdy commented on code in PR #136:
URL:
https://github.com/apache/flink-connector-aws/pull/136#discussion_r1638374818
##
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbTypeInformedElementConverter.java:
##
@@
caicancai commented on code in PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1638395305
##
docs/content/docs/custom-resource/pod-template.md:
##
@@ -93,16 +90,18 @@ spec:
```
{{< hint info >}}
-When using the operator with Flink
twalthr commented on code in PR #24929:
URL: https://github.com/apache/flink/pull/24929#discussion_r1638286027
##
docs/content/docs/dev/table/sql/create.md:
##
@@ -181,10 +182,16 @@ CREATE TABLE [IF NOT EXISTS]
[catalog_name.][db_name.]table_name
:
{
- { INCLUDING |
twalthr merged PR #24886:
URL: https://github.com/apache/flink/pull/24886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
PatrickRen merged PR #3380:
URL: https://github.com/apache/flink-cdc/pull/3380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xbthink commented on PR #23454:
URL: https://github.com/apache/flink/pull/23454#issuecomment-2165733120
@littleeleventhwolf Can you post your code? I'll use your code to check it
again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
LadyForest commented on code in PR #24932:
URL: https://github.com/apache/flink/pull/24932#discussion_r1638176317
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterCatalogComment.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache
affo commented on PR #24471:
URL: https://github.com/apache/flink/pull/24471#issuecomment-2165511898
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
anupamaggarwal commented on PR #24482:
URL: https://github.com/apache/flink/pull/24482#issuecomment-2165510538
Hi @klam-shop, apologies, I missed your comment earlier. I am sorry for
leaving this PR hanging in the middle, I had to context switch to focus on some
other priorities. I might
pan3793 commented on PR #24905:
URL: https://github.com/apache/flink/pull/24905#issuecomment-2165447683
ping @1996fanrui can we include this in 1.20?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
LadyForest merged PR #24763:
URL: https://github.com/apache/flink/pull/24763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
flinkbot commented on PR #24933:
URL: https://github.com/apache/flink/pull/24933#issuecomment-2165343946
## CI report:
* 4e54756da848b4b6febc23f70175a563c8a95795 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
zoltar9264 opened a new pull request, #24933:
URL: https://github.com/apache/flink/pull/24933
## What is the purpose of the change
Clean up useless file-merging managed directory (which never be include in
any checkpoint) on exit of TM.
## Brief change log
1. Normalize
loserwang1024 commented on PR #3412:
URL: https://github.com/apache/flink-cdc/pull/3412#issuecomment-2165162601
> @loserwang1024 mind if I cherry pick your commit?
Just do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
flinkbot commented on PR #24932:
URL: https://github.com/apache/flink/pull/24932#issuecomment-2165051805
## CI report:
* 9e10cf9d38d624b4982a20ab863098df408358cf UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
MartijnVisser merged PR #24805:
URL: https://github.com/apache/flink/pull/24805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
liyubin117 opened a new pull request, #24932:
URL: https://github.com/apache/flink/pull/24932
## What is the purpose of the change
Provide the ability to set comment for the catalog.
## Brief change log
* add comment instance in `CatalogDescriptor` and expose
yuxiqian commented on PR #3083:
URL: https://github.com/apache/flink-cdc/pull/3083#issuecomment-2164936973
Seems there's some conflicts between `master` branch, could @loserwang1024
please rebase it when you're available?
--
This is an automated message from the Apache Git Service.
To
JingGe commented on code in PR #24471:
URL: https://github.com/apache/flink/pull/24471#discussion_r1637750136
##
flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software
gaborgsomogyi commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2164843469
I'm fine with merging it on 14th of June EOB. Let's wait on other voices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
boring-cyborg[bot] commented on PR #94:
URL:
https://github.com/apache/flink-connector-pulsar/pull/94#issuecomment-2164765271
Thanks for opening this pull request! Please check out our contributing
guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is
thinker0 opened a new pull request, #94:
URL: https://github.com/apache/flink-connector-pulsar/pull/94
## Purpose of the change
*For example: Add dynamic sink topic support for Pulsar connector.*
## Brief change log
- *Change the internal design of
liyubin117 commented on code in PR #24763:
URL: https://github.com/apache/flink/pull/24763#discussion_r1637667029
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java:
##
@@ -124,6 +127,26 @@ public void
liyubin117 commented on code in PR #24763:
URL: https://github.com/apache/flink/pull/24763#discussion_r1637666706
##
flink-table/flink-sql-client/src/test/resources/sql/catalog_database.q:
##
@@ -769,3 +769,28 @@ desc catalog extended cat2;
liyubin117 commented on code in PR #24763:
URL: https://github.com/apache/flink/pull/24763#discussion_r1637655816
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##
@@ -342,6 +342,15 @@ public void alterCatalog(String
1996fanrui merged PR #24881:
URL: https://github.com/apache/flink/pull/24881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1996fanrui commented on PR #24757:
URL: https://github.com/apache/flink/pull/24757#issuecomment-2164660806
@elon-X The CI fails, could you rebase the master branch first? We can
follow the CI after rebaseing.
--
This is an automated message from the Apache Git Service.
To respond to the
LadyForest commented on code in PR #24763:
URL: https://github.com/apache/flink/pull/24763#discussion_r1636497861
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlDdlToOperationConverterTest.java:
##
@@ -124,6 +127,26 @@ public void
rkhachatryan commented on PR #24926:
URL: https://github.com/apache/flink/pull/24926#issuecomment-2164612236
LGTM
(please regenerate the documentation as CI suggests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
snuyanzin commented on code in PR #24921:
URL: https://github.com/apache/flink/pull/24921#discussion_r1637604401
##
docs/setup_docs.sh:
##
@@ -59,7 +59,7 @@ if [ "$SKIP_INTEGRATE_CONNECTOR_DOCS" = false ]; then
integrate_connector_docs rabbitmq v3.0
flinkbot commented on PR #24931:
URL: https://github.com/apache/flink/pull/24931#issuecomment-2164497999
## CI report:
* af743054861262cb5362528ff0e867717df16916 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
301 - 400 of 36569 matches
Mail list logo
