[GitHub] flink pull request #1121: [FLINK-2591] Add configuration parameter for defau...

2017-05-12 Thread willmiao
Github user willmiao closed the pull request at: https://github.com/apache/flink/pull/1121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-10-26 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-151092573 hi @rmetzger , I believe I find the reason why my test failed. A test will fail if we don’t specify “-t” argument(_which is an optional argument_

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-10-25 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-150919886 Hi rmetzger, I have updated this PR. I generated a flink-conf.yaml in a directory, which I then used as the configuration directory for the test. --- If your

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-10-25 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-150928188 Sorry for the failed tests, I'll fix them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-10-07 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-146371570 @rmetzger : I'm sorry for the late reply, I have been on vacation last three weeks. I failed to find a nice way to "generate a flink-conf.yaml just for the

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-11 Thread willmiao
Github user willmiao closed the pull request at: https://github.com/apache/flink/pull/1107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-11 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-139531959 I'm sorry that something went wrong with my original repository. So, I open a new PR, and this one will be closed. --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-09-11 Thread willmiao
GitHub user willmiao opened a pull request: https://github.com/apache/flink/pull/1121 [FLINK-2591] Add configuration parameter for default number of yarn containers You can merge this pull request into a Git repository by running: $ git pull https://github.com/willmiao/flink

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-08 Thread willmiao
GitHub user willmiao opened a pull request: https://github.com/apache/flink/pull/1107 [FLINK-2591]Add configuration parameter for default number of yarn containers https://issues.apache.org/jira/browse/FLINK-2591 Add configuration parameter for default number of yarn containers

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-08 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-138772421 Hi rmetzger, I've got a question: what if yarn.defaultNumberOfTaskManagers is set to a invalid value, say -2? Should user have to supply the -n argument? --- If your

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-08 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-138774833 Hi rmetzger, I've got a question: what if yarn.defaultNumberOfTaskManagers is set to a invalid value, say -2? Should users have to supply the -n argument? I

[GitHub] flink pull request: [FLINK-2591]Add configuration parameter for de...

2015-09-08 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1107#issuecomment-138603922 Thanks for your advices, I'll fix it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project