Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3039#discussion_r93758640
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTable.scala
---
@@ -44,14 +44,14 @@ abstract class FlinkTable[T
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3039#discussion_r93755631
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -535,4 +509,74 @@ object TableEnvironment
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3038#discussion_r93594267
--- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java ---
@@ -113,4 +113,30 @@ public boolean equals(Object o) {
public int hashCode
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/3038
[FLINK-5385] [core] Add a help function to create Row
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3020
Thank you @fhueske , I think your points are very good. And I changed my
code according to your suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3020#discussion_r93566506
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java
---
@@ -54,6 +76,152 @@ public RowTypeInfo(TypeInformation... types
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3020#discussion_r93566058
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java
---
@@ -54,6 +76,152 @@ public RowTypeInfo(TypeInformation... types
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3027#discussion_r93159119
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/TypeExtractorTest.java
---
@@ -345,8 +346,22 @@ public CustomType cross(CustomType
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3027#discussion_r93159264
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/TypeExtractorTest.java
---
@@ -345,8 +346,22 @@ public CustomType cross(CustomType
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3020
Hi @tonycox , the field names of RowTypeInfo are guaranteed to be unique.
So I think `getFieldIndex ` is fine with it. Do you have special case which
`getFieldIndex` give a wrong result ?
---
If
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/3020
[FLINK-5348] [core] Support custom field names for RowTypeInfo
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2968
Hi @fhueske , thanks for reviewing. I have addressed the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2968#discussion_r91953233
--- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2968
Hi @tonycox , I agree we should move `RowCsvInputFormat` also. But I think
it would be better to do that in another JIRA like FLINK-5188. Let's keep this
PR simple so that it can be in befor
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2968#discussion_r91902644
--- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java ---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2978
[FLINK-5304] [table] Change method name from crossApply to join in Table API
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2968#discussion_r91690748
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java
---
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2968
Hi @tonycox , thanks for your reviewing. I addressed some of your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2968#discussion_r91652189
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowComparator.java
---
@@ -0,0 +1,698 @@
+/*
+ * Licensed to the
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2968#discussion_r91652223
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/RowComparator.java
---
@@ -0,0 +1,698 @@
+/*
+ * Licensed to the
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2968#discussion_r91652178
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/RowTypeInfo.java
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2968
[FLINK-5187] [core] Create analog of Row and RowTypeInfo and RowCompator in
core
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2956
[FLINK-5223] [doc] Add documentation of UDTF in Table API & SQL
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into considera
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2653
Thanks @twalthr , I will add the documentation ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2653
Hi @fhueske @twalthr , I have updated the PR, please review it again when
you are available.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2938
[FLINK-4692] [tableApi] Add tumbling group-windows for batch tables
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r90583213
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/TableFunctionCall.scala
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2921#discussion_r90582677
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableSourceScan.scala
---
@@ -32,18 +31,20 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r90582259
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/TableFunction.scala
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2921#discussion_r90576889
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableSourceScan.scala
---
@@ -32,18 +31,20 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r90478025
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -334,18 +337,33 @@ class CodeGenerator
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2653
Hi @fhueske @twalthr , could you have a look at this PR again ? I have fix
the conflicts again and squashed the commits.
---
If your project is set up for it, you can reply to this email and have
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2810
Hi @tonycox , thanks for the update. I'm thinking of an idea that
`StreamProjectableTableSourceScan` seems duplicate with
`StreamTableSourceScan`, why not reuse the `StreamTableSourceScan` wi
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2653
Hi @fhueske @twalthr , I have addressed all the comments and made the
following changes:
1. Forbid TableFunction implemented by Scala object, since the `collect` is
called on a singleton
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89670370
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/BatchProjectableTableSourceScanRule.scala
---
@@ -0,0
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89671607
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/datastream/StreamProjectableTableSourceScanRule.scala
---
@@ -0,0
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89671603
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/BatchProjectableTableSourceScanRule.scala
---
@@ -0,0
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89246478
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sources/ProjectableTableSource.scala
---
@@ -0,0 +1,32
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89671537
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/StreamProjectableTableSourceScan.scala
---
@@ -0,0
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89671731
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/datastream/StreamProjectableTableSourceScanRule.scala
---
@@ -0,0
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89671523
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchProjectableTableSourceScan.scala
---
@@ -0,0 +1,74
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89671437
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/BatchProjectableTableSourceScanRule.scala
---
@@ -0,0
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89671462
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchProjectableTableSourceScan.scala
---
@@ -0,0 +1,74
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89671175
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/BatchProjectableTableSourceScanRule.scala
---
@@ -0,0
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89670435
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/BatchProjectableTableSourceScanRule.scala
---
@@ -0,0
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89246193
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/StreamProjectableTableSourceScan.scala
---
@@ -0,0
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89671556
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchProjectableTableSourceScan.scala
---
@@ -0,0 +1,74
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89671180
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/datastream/StreamProjectableTableSourceScanRule.scala
---
@@ -0,0
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89671736
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/TableSourceITCase.scala
---
@@ -131,6 +101,33 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89670471
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/datastream/StreamProjectableTableSourceScanRule.scala
---
@@ -0,0
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89671544
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/StreamProjectableTableSourceScan.scala
---
@@ -0,0
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89246096
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/StreamProjectableTableSourceScan.scala
---
@@ -0,0
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89671128
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sources/CsvTableSource.scala
---
@@ -102,11 +107,43 @@ class CsvTableSource
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2810
Hi @tonycox , the overall change looks good to me. I will do more thorough
review in this weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2653
Regarding to the mixing parser Expression and Logical Node, how about to
create a `LogicalParser` which is used to parse string to LogicalNode ? This
can separate expressions and logical nodes, and
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r89124951
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -162,24 +191,107
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r89124491
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -162,24 +191,107
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2810
Hi @tonycox , the
[`RowCsvInputFormat`](https://github.com/apache/flink/blob/master/flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/io/RowCsvInputFormat.scala#L100
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89090976
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableProject.scala
---
@@ -0,0 +1,67
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r89091052
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sources/ProjectableTableSource.scala
---
@@ -0,0 +1,32
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88869401
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableProject.scala
---
@@ -0,0 +1,67
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88844164
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableProject.scala
---
@@ -0,0 +1,67
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2758
Great ! The PR looks good to me now, thank you for your contribution !
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2758
The Travis CI has failed because of `BuiltInMethods` line length, could
you fix this ?
```
[INFO] --- scalastyle-maven-plugin:0.8.0:check (default) @ flink-table_2.10
---
error
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2758
It would be great if you can rebase your branch and resolve the conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r88796985
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala
---
@@ -0,0 +1,69
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r88778110
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/IncrementalAggregateReduceFunction.scala
---
@@ -0,0 +1,69
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88622767
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/TableFunction.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88617248
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/validate/FunctionCatalog.scala
---
@@ -47,13 +52,50 @@ class FunctionCatalog
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88617192
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -611,6 +612,130 @@ class Table
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88617047
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/schema/FlinkTableFunctionImpl.scala
---
@@ -0,0 +1,77
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88615712
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCorrelate.scala
---
@@ -0,0 +1,136
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88614416
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/call.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88614200
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -162,24 +191,107
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88591860
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/StreamTableProject.scala
---
@@ -0,0 +1,67
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88592516
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableProject.scala
---
@@ -0,0 +1,67
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88609838
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sources/ProjectableTableSource.scala
---
@@ -0,0 +1,32
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88591928
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/BatchTableSourceProjectRule.scala
---
@@ -0,0 +1,81
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88591967
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/datastream/StreamTableSourceProjectRule.scala
---
@@ -0,0 +1,82
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2810#discussion_r88591760
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableProject.scala
---
@@ -0,0 +1,67
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88594602
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/BatchTableEnvironment.scala
---
@@ -162,4 +165,24 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88594496
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/TableSqlFunction.scala
---
@@ -0,0 +1,99
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88594489
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/utils/TableSqlFunction.scala
---
@@ -0,0 +1,99
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88594410
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/StreamTableEnvironment.scala
---
@@ -164,4 +167,24 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88594421
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -542,11 +563,14 @@ class CodeGenerator
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2653
Thank you @fhueske @twalthr for the review, I will update the PR in this
weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88593490
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -154,6 +154,10 @@ under the License.
maven-shade-plugin
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2653
Hi @fhueske , you mentioned two ways to reduce IT cases. One is comparing
the logical plans of two tables, this can reduce Java IT cases. Another is
using `TableTestBase` tool to write unit tests
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88406551
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/UserDefinedTableFunctionITCase.java
---
@@ -0,0 +1,201
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r88406527
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/functions/TableFunction.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2758#discussion_r87993759
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/sql/SqlITCase.java
---
@@ -118,4 +119,39 @@ public void testJoin
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87693820
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -103,19 +103,12
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87693902
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateUtil.scala
---
@@ -61,25 +61,108 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87693746
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/AggregationsITCase.scala
---
@@ -177,6 +177,58 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87693718
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/AggregationsITCase.scala
---
@@ -177,6 +177,58 @@ class
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87693848
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateUtil.scala
---
@@ -61,25 +61,108 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87706978
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -135,50 +130,124
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87708469
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateUtil.scala
---
@@ -61,25 +61,108 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87707411
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -194,9 +263,10
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2792#discussion_r87707098
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala
---
@@ -135,50 +130,124
401 - 500 of 647 matches
Mail list logo
