Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2282#discussion_r71898802
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala
---
@@ -150,6 +150,41 @@ case class Sort(order
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2282#discussion_r71898818
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala
---
@@ -150,6 +150,41 @@ case class Sort(order
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2280
[FLINK-4244] [docs] Field names for union operator do not have to be equal
We just merged FLINK-2985 , but not update the document.
You can merge this pull request into a Git repository by running
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2274
[FLINK-4180] [FLINK-4181] [table] add Batch SQL and Stream SQL and Stream
Table API examples
[FLINK-4180] [FLINK-4181] [table] add Batch SQL and Stream SQL and Stream
Table API examples
I
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2265
Yes, I see. That's great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2265
Yes, you are right. I'm just a little concerned about the class name of
`ScalarFunction`, haha..
In addition, Java Table API should be `table.select("hashCode(text)");`
which i
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2265
Do we have any google docs or FLIP talking about this design ?
I think the `ScalarFunction` has too many internal functions, and should
not be exposed to users. Maybe we can create a new
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2159
@twalthr Thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2120
Hi @twalthr , I find that `expr` in `expressionDsl.scala` has done what we
want. As we can do like this: `12.expr % 'f0` or `12 * 'f0.expr`.
So do we need this PR just rename `expr
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2078
Yes, you are right. Now this PR look good to me. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2078
Hi @gallenvara , I debug the `IndexOutOfBoundsException` exception of
`testJoinWithDisjunctivePred`, and find this line [L526 in
CodeGenerator](https://github.com/apache/flink/blob/master/flink
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2078#discussion_r69402729
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeutils/RowTypeInfo.scala
---
@@ -25,38 +25,25 @@ import
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2159
Thanks @fhueske for your review, I have addressed all the comments and
squashed the commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2182
Yah... the `isNull$17` is not declared if we do what I said above, and of
course will throw compile error.
The code looks good to me now, although it looks a little weird that
`$nullTerm
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2169#discussion_r69065352
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala
---
@@ -236,6 +236,32 @@ case class Aggregate
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2182#discussion_r68969793
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/CallGenerator.scala
---
@@ -43,11 +43,16 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2182#discussion_r68969768
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/CallGenerator.scala
---
@@ -43,11 +43,16 @@ object
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2169#discussion_r68706865
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala
---
@@ -236,6 +236,32 @@ case class Aggregate
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2173
[FLINK-4109] [tableAPI] Change the name of ternary condition operator
It's better to use "?" than "eval()" for ternary condition operator in
Table API since most people comming
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2169
Hi @mushketyk, I think we should remove duplicate records in CoGroup
instead of using `distinct`. Others looks good to me.
---
If your project is set up for it, you can reply to this email
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2169#discussion_r68689676
--- Diff: docs/apis/table.md ---
@@ -873,7 +920,7 @@ val result = tableEnv.sql(
Limitations
-The current version of streaming SQL
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2169#discussion_r68689427
--- Diff: docs/apis/table.md ---
@@ -695,6 +718,30 @@ val result = left.unionAll(right);
+ Minus
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2169#discussion_r68687942
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala
---
@@ -236,6 +236,32 @@ case class Aggregate
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2169#discussion_r68687402
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetMinus.scala
---
@@ -0,0 +1,106
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2159
Hi @fhueske, that's a good idea to use CoGroup instead of Join. I updated
the PR according to your advice. Meanwhile, I updated the document too (correct
me if I describe wrong).
NOTE
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2159
[FLINK-3942] [tableAPI] Add support for INTERSECT
Internally, I translate INTERSECT into a Join on all fields and then a
distinct for removing duplicate records.
As Calcite SQL Parser
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2102
@twalthr That sounds great ! Thank you .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2120
[FLINK-4070] [tableApi] Support literals on left side of binary expreâ¦
The Table API does not support literals on left side of expressions like
`+,_,*,/,%,>,< `. Because there is a
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2102
After introducing `RexExecutor` which make `ReduceExpressionRules` taking
effect , many errors occurred.
1. The `cannot translate call AS($t0, $t1)` is a Calcite bug I think, and I
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2102#discussion_r67276795
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/sql/SelectITCase.scala
---
@@ -146,4 +148,21 @@ class SelectITCase
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2102
[FLINK-4068] [tableAPI] Move constant computations out of code-generated
The `ReduceExpressionsRule` rule can reduce constant expressions and
replacing them with the corresponding constant. We
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/1763
[docs] fix the active tab caption is not displaying blue
and a very very minor typo fix
