Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191381531
--- Diff: pom.xml ---
@@ -300,15 +300,7 @@ under the License.
org.apache.flink
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191379687
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/runtime/NettyEpollITCase.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191376001
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191350958
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191348415
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191346124
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191345794
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191325180
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6073#discussion_r191207284
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -146,6 +147,12 @@ under the License.
flink-test-utils_${scala.binary.version
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6023
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191174704
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/AbstractPrometheusReporter.java
---
@@ -0,0 +1,283
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191174912
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/AbstractPrometheusReporter.java
---
@@ -0,0 +1,283
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191174014
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191173964
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
---
@@ -0,0 +1,79
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5857#discussion_r191175257
--- Diff:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusReporter.java
---
@@ -120,199 +83,4 @@ public
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5959
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5843
@StephanEwen The options are now sorted.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r191150025
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
@@ -247,7 +249,15 @@ public void shutdown(Time timeout
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6086
merged, @yanghua please close the PR. Thanks!
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6086
@alpinegizmo nice catch!
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6086
will fix things while merging...
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6044
@medcv yes we should test the scala quickstarts as well.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6073
I still don't know whether this is the way to go. The exclusion pattern can
be icky when dealing with a single dependency A that pulls in 2 different
versions of a dependency B. When excluding B you
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5857
I think it's fine to be in the same project.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5843
For `env.java.opts` we have a `ConfigOption` in the `CoreOptions` class.
They are documented like any other option (and technically they are also usable
like any other option).
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6071#discussion_r190705206
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
@@ -247,7 +249,15 @@ public void shutdown(Time timeout
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5843
they _should_ be sorted alphabetically based on the key, but i now see that
this isn't actually the case.
I'm not sure if I can easily add the kind of sorting you're asking for as
that would
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5869
that should do the trick imo.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5959
The methods have been identical since FLINK-7692, but I didn't catch it in
the review. Thus, `ComponentMetricGroup#getAllVariables()` should be removed,
along with `ComponentMetricGroup#putVariables
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5869
that shouldn't be possible, as all tasks are removed when a TM
disassociates from the JM which also implies removing all metrics related to a
specific task.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6053#discussion_r190156721
--- Diff: flink-end-to-end-tests/run-nightly-tests.sh ---
@@ -30,168 +30,50 @@ if [ -z "$FLINK_DIR" ] ; then
exit 1
fi
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5840#discussion_r190155472
--- Diff: flink-libraries/flink-ml/pom.xml ---
@@ -103,6 +103,9 @@
windows
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5840#discussion_r190155490
--- Diff: flink-libraries/flink-ml/pom.xml ---
@@ -116,6 +119,9 @@
default
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5964
That the example doesn't work isn't related to this PR so I'll merge it as
is.
But I'll take a look what the problem is, and either fix it or open a JIRA.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6058#discussion_r190139650
--- Diff: docs/dev/stream/testing.md ---
@@ -181,7 +181,7 @@ public class ExampleIntegrationTest extends
StreamingMultipleProgramsTestBase
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6053
I'll take a look tomorrow.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6051
ah right, my bad. merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6041#discussion_r189836110
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/LocalStreamEnvironment.java
---
@@ -103,9 +103,16 @@ public
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5970
@yanghua The PR has been merged, could you close it?
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6049#discussion_r189803747
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -394,29 +394,33 @@ protected void list(String[] args) throws
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6049#discussion_r189803645
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -436,11 +440,15 @@ protected void list(String[] args) throws
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6049#discussion_r189804643
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/ListOptions.java ---
@@ -30,11 +31,13 @@
private final boolean running
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6037#discussion_r189803238
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java ---
@@ -316,14 +317,18 @@ public CsvReader ignoreInvalidLines
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6048
merging,
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6047
Please explain how this solution allows the user of a
`AbstractStreamOperatorTestHarness to access the metrics registered by
contained operator.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6051
Can you also fix schema on this page:
https://ci.apache.org/projects/flink/flink-docs-master/dev/connectors/filesystem_sink.html?
(in this
[file](https://github.com/apache/flink/blob/master/docs/dev
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6052
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6052
+1
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6029#discussion_r188936871
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5964#discussion_r188722661
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSink.java
---
@@ -381,6 +393,9
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6023
[FLINK-9383][runtime] Test directories in DistributedCache E2E test
## What is the purpose of the change
With this PR the distributed cache end-to-end test
* also covers the distributed
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188604472
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AllowNonRestoredStateQueryParameter.java
---
@@ -42,4 +42,10
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188604063
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188603266
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188603310
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188603356
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188603410
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188604321
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188604517
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/EntryClassQueryParameter.java
---
@@ -28,4 +28,10 @@
public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188603431
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6008#discussion_r188550129
--- Diff: flink-end-to-end-tests/test-scripts/test_resume_savepoint.sh ---
@@ -33,8 +33,8 @@ else
NUM_SLOTS=$NEW_DOP
fi
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5928#discussion_r188548729
--- Diff: docs/_includes/generated/checkpointing_configuration.html ---
@@ -40,7 +40,7 @@
state.checkpoints.dir
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5928#discussion_r188549219
--- Diff: docs/ops/state/checkpoints.md ---
@@ -35,60 +35,62 @@ the same semantics as a failure-free execution.
See [Checkpointing]({{ site.baseurl
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5928#discussion_r188548955
--- Diff: docs/ops/state/checkpoints.md ---
@@ -35,60 +35,62 @@ the same semantics as a failure-free execution.
See [Checkpointing]({{ site.baseurl
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5946
merging.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5964#discussion_r188545721
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSink.java
---
@@ -258,6 +259,17
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5964#discussion_r188545817
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSink.java
---
@@ -410,6 +425,9
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5964#discussion_r188546432
--- Diff:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5964#discussion_r188545761
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSink.java
---
@@ -381,6 +393,9
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5964#discussion_r188546038
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSink.java
---
@@ -470,6 +488,9
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5964#discussion_r188545921
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSink.java
---
@@ -381,6 +393,9
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5989
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6010
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6005
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6013
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6022
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6009
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6008
nice catch @tzulitai, will rework this into a run_test method that takes a
description and command to execute.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6016
hmm, according to the
[javadocs](https://docs.oracle.com/javase/7/docs/api/java/lang/reflect/InvocationTargetException.html)
the wrapped exception is part of the exception chain and accessible via
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6016
and I look at the review threads as well, which apparently didn't address
the issue.
---
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6016#discussion_r188246102
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java
---
@@ -225,7 +225,7 @@ public T copy(T from
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6016#discussion_r188246084
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java
---
@@ -193,7 +193,7 @@ public T createInstance
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6016#discussion_r188246145
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/TupleSerializer.java
---
@@ -76,7 +76,7 @@ public T createInstance
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6016#discussion_r188246129
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/TupleSerializer.java
---
@@ -59,7 +59,7 @@ public TupleSerializer(Class
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6016#discussion_r188246156
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/TupleSerializer.java
---
@@ -150,7 +150,7 @@ public T deserialize(T reuse
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6014
The discussion on the JIRA clearly came tot he conclusion to do this change
in 2 commits. Please separate the PR.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6010
+1
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6009
[FLINK-9357][tests][yarn] Add margins to exception excerpts
## What is the purpose of the change
The yarn tests check the log files for exceptions to detect test failures.
If detected
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6008
[FLINK-9354][travis] Print execution times for nightly E2E tests
## What is the purpose of the change
With this PR we print the execution time for all end-to-end tests.
## Brief
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6006
You have to regenerate the config docs, instructions can be found
[here](https://github.com/apache/flink/blob/master/flink-docs/README.md).
---
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6005
[FLINK-9176][tests] Remove category annotations
Subsumes #5851.
## What is the purpose of the change
This PR removes the category annotations that were once used to selectively
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5834
Generally I would refrain from pinging specific committers. This can be
counter-productive as it discourages other committers, or even contributors,
from taking a look.
Similarly, pinging
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5997
merging.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5997
we can do it in this issue.
---
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5997
This does fix the issue, but I'd like to extend this a bit. The root issue
is that we're registering the handler for an arbitrary header, which is
ridiculously error-prone.
So i propose
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r187378661
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ProgramArgsQueryParameter.java
---
@@ -30,4 +30,8 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r187377384
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/MessageParametersTest.java
---
@@ -109,8 +114,13 @@ public JobID
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r187378407
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/SubtaskIndexPathParameter.java
---
@@ -44,4 +44,9 @@ protected String
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r187382132
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/TaskManagerIdPathParameter.java
---
@@ -41,4 +41,9 @@ protected
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r187381371
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/metrics/MetricsAggregationParameter.java
---
@@ -46,6 +46,13 @@ public
501 - 600 of 5225 matches
Mail list logo
