[GitHub] flink issue #4424: [FLINK-7302] [table] Fix failed to run CorrelateITCase cl...

2017-08-03 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4424 There is nothing wrong with the newest code and test passed. I will close this PR and the correspoding JIRA soon. Thanks to @fhueske the comments. --- If your project is set up for it, you

[GitHub] flink pull request #4328: [FLINK-6493] Fix ineffective null check in Registe...

2017-08-03 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4328#discussion_r131071909 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredOperatorBackendStateMetaInfo.java --- @@ -175,14 +175,19 @@ public

[GitHub] flink issue #4328: [FLINK-6493] Fix ineffective null check in RegisteredOper...

2017-08-02 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4328 This time, build pass. ![build](https://user-images.githubusercontent.com/6520673/28903370-11085ea4-7837-11e7-8805-ac4dcc6e9eda.png) --- If your project is set up

[GitHub] flink issue #4328: [FLINK-6493] Fix ineffective null check in RegisteredOper...

2017-08-02 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4328 Thanks @tzulitai. I updated the code, let us wait the build ending. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #4316: [FLINK-6105] Use InterruptedIOException instead of IOExce...

2017-08-02 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4316 @greghogan I saw Ted comment on the jira before. But I am not sure whether we will adopt Ted's comments. So, that is why I leave this PR until someone adopt it, I will keep working

[GitHub] flink issue #4424: [FLINK-7302] [table] Fix failed to run CorrelateITCase cl...

2017-08-02 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4424 Because build flink always cost me a lot of time, So, I wasnt did this build flink stuff often. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink issue #4424: [FLINK-7302] [table] Fix failed to run CorrelateITCase cl...

2017-08-02 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4424 Hey. @fhueske I checked my code again and found it build error i think. because it is really gives me the wrong error. You are right. I have decided that I have not build flink project

[GitHub] flink issue #4424: [FLINK-7302] [table] Fix failed to run CorrelateITCase cl...

2017-08-01 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4424 @fhueske Thank you for your reply. Yes, I am always on the newest master branch every time I write code. What you said about causes that issue reason, it is did defined

[GitHub] flink pull request #4424: [FLINK-7302] [table] Fix failed to run CorrelateIT...

2017-07-31 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4424 [FLINK-7302] [table] Fix failed to run CorrelateITCase class under wi… With an environment on Windows, Test run failed as reference to UserDefinedFunctionTestUtils is ambiguous

[GitHub] flink pull request #4423: [FLINK-7297] [table] Fix failed to run CorrelateIT...

2017-07-31 Thread zhangminglei
Github user zhangminglei closed the pull request at: https://github.com/apache/flink/pull/4423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #4423: [FLINK-7297] [table] Fix failed to run CorrelateIT...

2017-07-31 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4423 [FLINK-7297] [table] Fix failed to run CorrelateITCase class under wi… With a environment on Windows, Test run failed as reference to UserDefinedFunctionTestUtils is ambiguous

[GitHub] flink issue #4328: [FLINK-6493] Fix ineffective null check in RegisteredOper...

2017-07-30 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4328 Thanks to @tedyu . It is a good idea and code have been updated based on your suggestion. Please check it out again ~ --- If your project is set up for it, you can reply to this email

[GitHub] flink issue #4289: [FLINK-7092] [mesos] Shutdown ResourceManager components ...

2017-07-26 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4289 Thanks for your generous review @tillrohrmann. I am very appreciate it! PR updated again. Please helps to review. If I am wrong , please helps me out there ~ Peace! --- If your project is set

[GitHub] flink issue #4362: [FLINK-7134] Remove hadoop1.x code in mapreduce.utils.Had...

2017-07-19 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4362 Hey, Stephan. This time codes works well. Thanks ~ :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #4362: [FLINK-7134] Remove hadoop1.x code in mapreduce.ut...

2017-07-19 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4362#discussion_r128417549 --- Diff: flink-connectors/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatInputFormatBase.java --- @@ -271,7 +273,7 @@ public

[GitHub] flink issue #4315: [FLINK-5541] Missing null check for localJar in FlinkSubm...

2017-07-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4315 PR had been updated. Please helps to check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #4315: [FLINK-5541] Missing null check for localJar in FlinkSubm...

2017-07-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4315 Oh my gosh, The newest checkstyle is very awesome, it can detect this kinda message. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request #4362: [FLINK-7134] Remove hadoop1.x code in mapreduce.ut...

2017-07-18 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4362 [FLINK-7134] Remove hadoop1.x code in mapreduce.utils.HadoopUtils You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhangminglei/flink flink

[GitHub] flink issue #4311: [FLINK-7162] [test] Tests should not write outside 'targe...

2017-07-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4311 Thanks to zentol. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink pull request #4285: [FLINK-7118] [hadoop] Remove hadoop1.x code in Had...

2017-07-18 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4285#discussion_r128009928 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/hadoop/mapred/HadoopOutputFormatBase.java --- @@ -126,18 +128,18 @@ public void open(int

[GitHub] flink pull request #4356: [FLINK-5486] Fix lacking of synchronization in Buc...

2017-07-18 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4356 [FLINK-5486] Fix lacking of synchronization in BucketingSink#handleRe… You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhangminglei

[GitHub] flink issue #4285: [FLINK-7118] [hadoop] Remove hadoop1.x code in HadoopUtil...

2017-07-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4285 @StephanEwen PR have been updated. Please check it out again ~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #4328: [FLINK-6493] Fix ineffective null check in RegisteredOper...

2017-07-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4328 PR has been updated. Please helps to check again. Thanks ~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #4316: [FLINK-6105] Use InterruptedIOException instead of IOExce...

2017-07-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4316 Maybe @tedyu could share some light on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #4311: [FLINK-7162] [test] Tests should not write outside 'targe...

2017-07-17 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4311 Thanks @StephanEwen for generous review. All proposes have been addressed. PR updated again. Please helps to check :) --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #4319: [FLINK-5987] [build] Upgrade zookeeper dependency to 3.4....

2017-07-14 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4319 :) Thanks, Stephan! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #4166: [FLINK-6857] [types] Add global default Kryo serializer c...

2017-07-14 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4166 @tzulitai Sorry for delay. What you mean is that I should first implement or support ```Kryo.setDefaultSerializer(...)``` method in ```ExecutionConfig```, and that is the solution

[GitHub] flink pull request #4328: [FLINK-6493] Fix ineffective null check in Registe...

2017-07-13 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4328 [FLINK-6493] Fix ineffective null check in RegisteredOperatorBackendS… This PR is simlar to https://github.com/apache/flink/pull/1871/files. @tedyu What do you think of this Change ? You

[GitHub] flink issue #4311: [FLINK-7162] [test] Tests should not write outside 'targe...

2017-07-13 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4311 PR have been updated. Please check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #4217: [FLINK-6934] [util] remove unused LRUCache class

2017-07-13 Thread zhangminglei
Github user zhangminglei closed the pull request at: https://github.com/apache/flink/pull/4217 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #4217: [FLINK-6934] [util] remove unused LRUCache class

2017-07-13 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4217 Yep. I will close this PR. 咯咯~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #4311: [FLINK-7162] [test] Tests should not write outside 'targe...

2017-07-13 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4311 Thanks, zentol. I will fix it using ```TemporaryFolder``` soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #4319: [FLINK-5987] [build] Upgrade zookeeper dependency ...

2017-07-13 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4319 [FLINK-5987] [build] Upgrade zookeeper dependency to 3.4.10 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhangminglei/flink flink-5987

[GitHub] flink pull request #4317: [FLINK-5987] [build] Upgrade zookeeper dependency ...

2017-07-13 Thread zhangminglei
Github user zhangminglei closed the pull request at: https://github.com/apache/flink/pull/4317 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #4317: [FLINk-5987] [build] Upgrade zookeeper dependency ...

2017-07-13 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4317 [FLINk-5987] [build] Upgrade zookeeper dependency to 3.4.10 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhangminglei/flink flink-5987

[GitHub] flink pull request #4316: [FLINK-6105] Use InterruptedIOException instead of...

2017-07-13 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4316 [FLINK-6105] Use InterruptedIOException instead of IOException This is my first commit of this. It might be have other places also do this change, but I am not sure now. You can merge

[GitHub] flink issue #4315: [FLINK-5541] Missing null check for localJar in FlinkSubm...

2017-07-13 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4315 @tedyu What do you think of this change ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #4315: [FLINK-5541] Missing null check for localJar in Fl...

2017-07-13 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4315 [FLINK-5541] Missing null check for localJar in FlinkSubmitter#submit… You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhangminglei

[GitHub] flink pull request #4311: [FLINK-7162] [test] Tests should not write outside...

2017-07-12 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4311 [FLINK-7162] [test] Tests should not write outside 'target' directory A few tests use ```Files.createTempDir()``` from Guava package, but do not set java.io.tmpdir system property. Thus

[GitHub] flink issue #4217: [FLINK-6934] [util] remove unused LRUCache class

2017-07-12 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4217 Hello, @aljoscha PR had been updated. Please helps check it again, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink issue #4217: [FLINK-6934] [util] remove unused LRUCache class

2017-07-12 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4217 Sure, Thanks, I had seen those before. ```LRUCacheMap``` and ```LRUCacheMapTest``` will be removed in this PR soon. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #4305: [FLINK-7161] fix misusage of Float.MIN_VALUE and Double.M...

2017-07-12 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4305 Looks good, as ```Double.MIN_VALUE``` always return a positive number. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #4285: [FLINK-7118] [hadoop] Remove hadoop1.x code in HadoopUtil...

2017-07-11 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4285 Thanks, Stephan. I think it is a good idea. PR has been updated. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #4205: [FLINK-6407] [build] Upgrade AVRO to 1.8.2

2017-07-11 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4205 Thanks, Greg. You are very welcome. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #4289: [FLINK-7092] [mesos] Shutdown ResourceManager comp...

2017-07-08 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4289 [FLINK-7092] [mesos] Shutdown ResourceManager components properly (FL… The MesosResourceManager starts internally a TaskMonitor, LaunchCoordinator, ConnectionMonitor

[GitHub] flink pull request #4285: [FLINK-7118] [hadoop] Remove hadoop1.x code in Had...

2017-07-07 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4285 [FLINK-7118] [hadoop] Remove hadoop1.x code in HadoopUtils You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhangminglei/flink flink-7118

[GitHub] flink issue #4219: [FLINK-6842] [runtime] Uncomment and activate code in Had...

2017-07-06 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4219 Thanks, Greg. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #4219: [FLINK-6842] [runtime] Uncomment and activate code...

2017-07-06 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4219#discussion_r125926605 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopFileSystem.java --- @@ -459,17 +459,14 @@ public boolean isDistributedFS

[GitHub] flink pull request #4219: [FLINK-6842] [runtime] Uncomment and activate code...

2017-07-06 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4219#discussion_r125925167 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopFileSystem.java --- @@ -459,17 +459,14 @@ public boolean isDistributedFS

[GitHub] flink pull request #4219: [FLINK-6842] [runtime] Uncomment and activate code...

2017-07-06 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4219#discussion_r125896588 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopFileSystem.java --- @@ -459,17 +459,14 @@ public boolean isDistributedFS

[GitHub] flink issue #4219: [FLINK-6842] [runtime] Uncomment and activate code in Had...

2017-07-05 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4219 Thanks @greghogan, and PR have been updated, please check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #4202: [FLINK-6422] [core] Unreachable code in FileInputFormat#c...

2017-07-05 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4202 Thanks @tzulitai for review! And thanks @tedyu for reporting this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #4243: [FLINK-5851] [streaming API] Rename AsyncCollector...

2017-07-02 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4243 [FLINK-5851] [streaming API] Rename AsyncCollector into ResultFuture You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhangminglei/flink

[GitHub] flink issue #4202: [FLINK-6422] [core] Unreachable code in FileInputFormat#c...

2017-07-01 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4202 Seems I could not get any useful information from CI, except for this kinda stuff following and it seems not relevant to this issue. ``` Running

[GitHub] flink pull request #4229: [FLINK-7038] [docs] Correct misused term to KeyedS...

2017-07-01 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4229#discussion_r125158619 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/AppendingState.java --- @@ -29,7 +29,7 @@ * The state is accessed

[GitHub] flink pull request #4229: [FLINK-7038] [docs] Correct misused term to KeyedS...

2017-07-01 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4229#discussion_r125158516 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/state/AggregatingState.java --- @@ -33,7 +33,7 @@ * The state is accessed

[GitHub] flink issue #4229: [FLINK-7038] [docs] Correct misused term to KeyedStream

2017-07-01 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4229 Yep. I will update code again soon enough. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #4216: [FLINK-6789] [optimizer] Remove duplicated test utility r...

2017-06-30 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4216 Thanks for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #4229: [FLINK-7038] [docs] Correct misused term to KeyedStream

2017-06-30 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4229 Hi, @tzulitai I have updated the code. Please check whether it should add more ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request #4230: [FLINK-7045] [checkpoints] Reduce element count of...

2017-06-30 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4230 [FLINK-7045] [checkpoints] Reduce element count of UdfStreamOperatorC… With NUM_INPUT equals to 2,500,000. It costs 33s,556ms on my computer. But and I can get 10s, 915ms as I reduce

[GitHub] flink issue #4229: [FLINK-7038] [docs] Correct misused term to KeyedStream

2017-06-29 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4229 Exactly, Could we create another jira or just do a hotfix for ```WindowedDataStream``` under ```FLINK-7038``` ? --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink issue #4229: [FLINK-7038] [docs] Correct misused term to KeyedStream

2017-06-29 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4229 Okay. I really found many ```KeyedDataStream``` terms existing in flink project under master branch. But there is not a class called it. So, it is very strange. Also the same stuff refers

[GitHub] flink pull request #4229: [FLINK-7038] [docs] Correct misused term to KeyedS...

2017-06-29 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4229 [FLINK-7038] [docs] Correct misused term to KeyedStream Correct misused term to KeyedStream. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink pull request #4219: [FLINK-6842] [runtime] Uncomment and activate code...

2017-06-28 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4219 [FLINK-6842] [runtime] Uncomment and activate code in HadoopFileSystem Uncomment and activate ```getFileSystemClass``` method in HadoopFileSystem. You can merge this pull request into a Git

[GitHub] flink pull request #4218: [FLINK-5842] [runtime] Uncomment and activate code...

2017-06-28 Thread zhangminglei
Github user zhangminglei closed the pull request at: https://github.com/apache/flink/pull/4218 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #4218: [FLINK-5842] [runtime] Uncomment and activate code...

2017-06-28 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4218 [FLINK-5842] [runtime] Uncomment and activate code in HadoopFileSystem Uncomment and activate hadoop 2 ```getFileSystemClass``` method. You can merge this pull request into a Git repository

[GitHub] flink pull request #4217: [FLINK-6934] [util] remove unused LRUCache class

2017-06-28 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4217 [FLINK-6934] [util] remove unused LRUCache class Remove unused ```LRUCache``` class since it was created in 2014. You can merge this pull request into a Git repository by running: $ git

[GitHub] flink pull request #4216: [FLINK-6789] [optimizer] Remove duplicated test ut...

2017-06-28 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4216 [FLINK-6789] [optimizer] Remove duplicated test utility reducer in op… Removed ```DummyReducer``` class, keep ```SelectOneReducer``` instead. You can merge this pull request into a Git

[GitHub] flink pull request #4215: [FLINK-6789] [optimizer] Remove duplicated test ut...

2017-06-28 Thread zhangminglei
Github user zhangminglei closed the pull request at: https://github.com/apache/flink/pull/4215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #4215: [FLINK] [optimizer] Remove duplicated test utility...

2017-06-28 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4215 [FLINK] [optimizer] Remove duplicated test utility reducer in optimizer Removed ```DummyReducer``` class, keep ```SelectOneReducer``` instead. You can merge this pull request into a Git

[GitHub] flink issue #4205: [FLINK-6407] [build] Upgrade AVRO to 1.8.2

2017-06-28 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4205 Okay. I remember. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #4205: [FLINK-6407] [build] Upgrade AVRO to 1.8.2

2017-06-27 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4205 cc @zentol --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #4205: [FLINK-6407] [build] Upgrade AVRO to 1.8.2

2017-06-27 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4205 [FLINK-6407] [build] Upgrade AVRO to 1.8.2 Upgrade to the last maintenance releases of **AVRO** 1.8.2 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink issue #4202: [FLINK-6422] [core] Unreachable code in FileInputFormat#c...

2017-06-27 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4202 Thanks @tedyu for reporting this. cc @StephanEwen @tedyu Could both you take a look ? I checked the first version you designed. --- If your project is set up for it, you can reply

[GitHub] flink pull request #4202: [FLINK-6422] [core] Unreachable code in FileInputF...

2017-06-27 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4202 [FLINK-6422] [core] Unreachable code in FileInputFormat#createInputSp… Fix Unreachable code in FileInputFormat#createInputSplits. You can merge this pull request into a Git repository

[GitHub] flink pull request #4196: [FLINK-7017] Remove netty usages in flink-tests

2017-06-27 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4196#discussion_r124424384 --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebFrontendITCase.java --- @@ -83,16 +78,16 @@ public static void

[GitHub] flink issue #4156: [FLINK-6655] Add validateAndNormalizeUri method to Memory...

2017-06-27 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4156 BTW, What is your Program arguments ? start with --configDir ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink issue #4156: [FLINK-6655] Add validateAndNormalizeUri method to Memory...

2017-06-27 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4156 Okay, Let me try. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #4156: [FLINK-6655] Add validateAndNormalizeUri method to Memory...

2017-06-27 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4156 @zentol If you dont mind, you can give me your sample test code via my personal email ```18717838...@163.com```, next time, I can test it by myself. --- If your project is set up for it, you

[GitHub] flink issue #4156: [FLINK-6655] Add validateAndNormalizeUri method to Memory...

2017-06-27 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4156 Nice ~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #4156: [FLINK-6655] Add validateAndNormalizeUri method to...

2017-06-27 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4156#discussion_r124272868 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/MemoryArchivist.scala --- @@ -255,4 +255,47 @@ class MemoryArchivist

[GitHub] flink pull request #4156: [FLINK-6655] Add validateAndNormalizeUri method to...

2017-06-27 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4156#discussion_r124259876 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/MemoryArchivist.scala --- @@ -255,4 +255,75 @@ class MemoryArchivist

[GitHub] flink pull request #4156: [FLINK-6655] Add validateAndNormalizeUri method to...

2017-06-27 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4156#discussion_r124251147 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/MemoryArchivist.scala --- @@ -255,4 +255,75 @@ class MemoryArchivist

[GitHub] flink pull request #4168: [FLINK-6987] Fix erroneous when path containing sp...

2017-06-27 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4168#discussion_r124225059 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java --- @@ -461,8 +463,9 @@ public LocatableInputSplitAssigner

[GitHub] flink pull request #4156: [FLINK-6655] Add validateAndNormalizeUri method to...

2017-06-27 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4156#discussion_r124224512 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/MemoryArchivist.scala --- @@ -255,4 +255,75 @@ class MemoryArchivist

[GitHub] flink pull request #4156: [FLINK-6655] Add validateAndNormalizeUri method to...

2017-06-27 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4156#discussion_r124221227 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/MemoryArchivist.scala --- @@ -255,4 +255,75 @@ class MemoryArchivist

[GitHub] flink pull request #4168: [FLINK-6987] Fix erroneous when path containing sp...

2017-06-26 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4168#discussion_r124175328 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java --- @@ -461,8 +463,9 @@ public LocatableInputSplitAssigner

[GitHub] flink pull request #4168: [FLINK-6987] Fix erroneous when path containing sp...

2017-06-26 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4168#discussion_r124168503 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java --- @@ -461,8 +463,9 @@ public LocatableInputSplitAssigner

[GitHub] flink pull request #3724: [FLINK-6275] [yarn] Fix unprotected access to reso...

2017-06-25 Thread zhangminglei
Github user zhangminglei closed the pull request at: https://github.com/apache/flink/pull/3724 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #3724: [FLINK-6275] [yarn] Fix unprotected access to resourceMan...

2017-06-25 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3724 @zentol Sorry. I just forgot. I close it right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request #4168: [FLINK-6987] Fix erroneous when path containing sp...

2017-06-23 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4168#discussion_r123743180 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java --- @@ -461,8 +463,9 @@ public LocatableInputSplitAssigner

[GitHub] flink pull request #4168: [FLINK-6987] Fix erroneous when path containing sp...

2017-06-23 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4168#discussion_r123726433 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java --- @@ -461,8 +463,9 @@ public LocatableInputSplitAssigner

[GitHub] flink pull request #4168: [FLINK-6987] Fix erroneous when path containing sp...

2017-06-23 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/4168#discussion_r123689575 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java --- @@ -461,8 +463,9 @@ public LocatableInputSplitAssigner

[GitHub] flink issue #4168: [FLINK-6987] Fix erroneous when path containing spaces

2017-06-23 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4168 Thanks @twalthr for reporting this VERY good issue. And thanks @zentol for looking over it. PR has been updated. I misread the error from JIRA before , so literally used ```trim()``` to solve

[GitHub] flink issue #4168: [FLINK-6987] Fix erroneous when path containing spaces

2017-06-22 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4168 Oops. I might be wrong. I will check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #4168: [FLINK-6987] Fix erroneous when path containing spaces

2017-06-22 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4168 I dont think it has an underlying issue as below line of code throw an error, and it is not relavant to the ```TextInputFormat``` class . ```tmpDir``` has spaces and then trigger that problem

[GitHub] flink issue #4168: [FLINK-6987] Fix erroneous when path containing spaces

2017-06-22 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4168 Hi @twalthr , you can test it again. I think it works fine now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request #4168: [FLINK-6987] Fix erroneous when path containing sp...

2017-06-22 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4168 [FLINK-6987] Fix erroneous when path containing spaces Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration

[GitHub] flink pull request #4166: [FLINK-6857] [types] Add global default Kryo seria...

2017-06-22 Thread zhangminglei
GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4166 [FLINK-6857] [types] Add global default Kryo serializer configuration… … to StreamExecutionEnvironment Thanks for contributing to Apache Flink. Before you open your pull request

[GitHub] flink issue #4156: [FLINK-6655] Add validateAndNormalizeUri method to Memory...

2017-06-21 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4156 cc @twalthr @zentol Please helps to review, Thank you very much. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

<    1   2   3   4   5   6   >