Github user zhenzhongxu commented on the issue:
https://github.com/apache/flink/pull/4844
@tillrohrmann created https://issues.apache.org/jira/browse/FLINK-7894
---
Github user zhenzhongxu commented on the issue:
https://github.com/apache/flink/pull/4149
thanks @aljoscha for the suggestion. KeyedDeserializationSchema seems like
a better approach. I'll close this PR.
---
If your project is set up for it, you can reply to this email and have your
Github user zhenzhongxu closed the pull request at:
https://github.com/apache/flink/pull/4149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zhenzhongxu commented on the issue:
https://github.com/apache/flink/pull/4187
@tzulitai all tests passing now. let me know if this looks ok now, also let
me know if you want me to go ahead squash all commits.
---
If your project is set up for it, you can reply
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r128078950
--- Diff: docs/monitoring/metrics.md ---
@@ -896,6 +896,28 @@ Thus, in order to infer the metric identifier:
+ Connector
Github user zhenzhongxu commented on the issue:
https://github.com/apache/flink/pull/4149
Sounds fair. @aljoscha @tzulitai Any recommendations on what particular
test and where I should put the tests in? I'll also improve the documentation
as well.
---
If your project is set up
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127842765
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127838984
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127560857
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127560753
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaCommitCallback.java
Github user zhenzhongxu commented on the issue:
https://github.com/apache/flink/pull/4187
@tzulitai seems the last CI pipeline failed because of stability issues,
how can I trigger another build without making a commit?
---
If your project is set up for it, you can reply
Github user zhenzhongxu commented on the issue:
https://github.com/apache/flink/pull/4187
@tzulitai rebase done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zhenzhongxu commented on the issue:
https://github.com/apache/flink/pull/4187
How about just "commits-succeeded" and "commits-failed" as metric names.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user zhenzhongxu commented on the issue:
https://github.com/apache/flink/pull/4187
@tzulitai
**Regarding the metric naming:**
Any suggestions on naming conventions for these flink specific metrics? How
do you like 'kafkaconnector-commits-succeeded' (component
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r124413737
--- Diff: docs/monitoring/metrics.md ---
@@ -867,6 +867,28 @@ Thus, in order to infer the metric identifier:
+ Connector
Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r124413756
--- Diff: docs/monitoring/metrics.md ---
@@ -867,6 +867,28 @@ Thus, in order to infer the metric identifier:
+ Connector
GitHub user zhenzhongxu opened a pull request:
https://github.com/apache/flink/pull/4187
[FLINK-6998][Kafka Connector] Add kafka offset commit metrics in consâ¦
add "kafkaCommitsSucceeded" and "kafkaCommitsFailed" metrics in
KafkaConsumerThread class.
You
Github user zhenzhongxu commented on the issue:
https://github.com/apache/flink/pull/4149
Hi @tzulitai, in this particular case, we actually disabled Flink
checkpointing (because we do not want to rely on fixed interval barrier to
trigger sink flush/offset commit). As a workaround
Github user zhenzhongxu commented on the issue:
https://github.com/apache/flink/pull/4149
Hi @tzulitai. Yes, we do have a use case where we need to disable Flink
checkpointing because the time interval checkpointing model does not work with
our constraints. We had to trigger Kafka
GitHub user zhenzhongxu opened a pull request:
https://github.com/apache/flink/pull/4149
[FLINK-6923] [Kafka Connector] Expose in-processing/in-flight record â¦
This PR exposes current in-processing record partition and offset
information per Kafka consumer instance. This allows
GitHub user zhenzhongxu opened a pull request:
https://github.com/apache/flink/pull/2335
[FLINK-4308] Allow uploaded jar directory to be configurable
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration
21 matches
Mail list logo
