1996fanrui commented on PR #19499:
URL: https://github.com/apache/flink/pull/19499#issuecomment-116001
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1996fanrui commented on PR #19499:
URL: https://github.com/apache/flink/pull/19499#issuecomment-1160637227
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1996fanrui commented on PR #19499:
URL: https://github.com/apache/flink/pull/19499#issuecomment-1159334613
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1996fanrui commented on PR #19499:
URL: https://github.com/apache/flink/pull/19499#issuecomment-1159015244
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1996fanrui commented on PR #19499:
URL: https://github.com/apache/flink/pull/19499#issuecomment-1158533552
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1996fanrui commented on PR #19499:
URL: https://github.com/apache/flink/pull/19499#issuecomment-1158503414
Hi @akalash , thanks for your suggestion. Currently, the unit test is
simpler than before.
--
This is an automated message from the Apache Git Service.
To respond to the message,
1996fanrui commented on PR #19499:
URL: https://github.com/apache/flink/pull/19499#issuecomment-1152319736
> @1996fanrui , Thanks for these changes. I have left a couple of minor
comments but in general, it looks good. I want to take some time to think about
how good the current tests are
1996fanrui commented on PR #19499:
URL: https://github.com/apache/flink/pull/19499#issuecomment-1142154056
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1996fanrui commented on PR #19499:
URL: https://github.com/apache/flink/pull/19499#issuecomment-1141802853
Hi @akalash @pnowojski , I updated this pr based on the FLIP-227, and I
have addressed @akalash 's all comments. Please help to review in your free
time, thanks a lot.
--
This is
1996fanrui commented on PR #19499:
URL: https://github.com/apache/flink/pull/19499#issuecomment-1110642698
> @1996fanrui , thanks for these changes. In general, the idea of
implementation looks good but I have left several comments in PR and we still
need to discuss configuration later.
10 matches
Mail list logo